pgbus 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c45dd364f341b6819b7901f583e058dbe761b375210e4162f19faf75917e3043
-  data.tar.gz: ed5ee189a3ff3d7fe0610deada3b2daba3726a2647d7762c58735e0771c9e0eb
+  metadata.gz: b1a647a2e485cace147ca201861ff4613e9c14f72f8fd8be9060f64d6eccfff5
+  data.tar.gz: bf3ca37850d549c6e9ed86bedbad1d88f9a50462b86a2d8a09113de7c1227d0f
 SHA512:
-  metadata.gz: e28c032dc7b4f2cba37bd709c4a45030bcedd90274b86a1499d55dd4f4e255769e580983023602a42267b8728068a7eb11f7fdcbc8d12bd3efd83f35a50f241b
-  data.tar.gz: dc6d8d5d2e4feebbf7d940c173f53700549b5364c0e15df3f6afac1d72ecc6b1222127d85649016e9c6590e3c184eb9365da95c424a21a98be683862f4a24e67
+  metadata.gz: b32dac214071005fa5974478f2cb8bd4d8a270efc3e6bc94141b74c28cebfea0dfa84e41ad9bf1ec2a10c8ab0d09ae08d0df989f0894b8d5cbc6a461698ecf5b
+  data.tar.gz: ea55e1a29e53e491063c34aaea3a643498d1567968e64833d9a38deef2bcd7a48dfb35e377601d347fa8e05e55a5647a77dbe958d9584fcdc8669a362ff253a8

data/lib/pgbus/active_job/executor.rb

@@ -19,7 +19,11 @@ module Pgbus
 
       def execute(message, queue_name, source_queue: nil)
         execution_start = monotonic_now
+        tag = "msg_id=#{message.msg_id} queue=#{queue_name} read_ct=#{message.read_ct}"
+        Pgbus.logger.debug { "[Pgbus::Executor] start #{tag}" }
+
         payload = JSON.parse(message.message)
+        job_class = payload["job_class"]
         read_count = message.read_ct.to_i
 
         if read_count > config.max_retries
@@ -29,10 +33,9 @@ module Pgbus
           signal_batch_discarded(payload)
           Uniqueness.release_lock(Uniqueness.extract_key(payload))
           record_stat(payload, queue_name, "dead_lettered", execution_start, message: message)
+          Pgbus.logger.debug { "[Pgbus::Executor] dead_lettered #{tag} job_class=#{job_class}" }
           return :dead_lettered
         end
-
-        job_class = payload["job_class"]
         uniqueness_key = Uniqueness.extract_key(payload)
         uniqueness_strategy = Uniqueness.extract_strategy(payload)
 
@@ -53,28 +56,24 @@ module Pgbus
           end
         end
 
+        Pgbus.logger.debug { "[Pgbus::Executor] deserialized #{tag} job_class=#{job_class}" }
         job_succeeded = false
 
-        # Debug-level phase markers. Silent at INFO+, but invaluable when a
-        # fiber interrupt or connection issue loses control flow between phases
-        # (issue #126). Each line identifies msg_id + phase so the gap is
-        # visible in logs: "deserialized" without "archived" means the job
-        # ran but its message was never archived.
         msg_id = message.msg_id.to_i
         Instrumentation.instrument("pgbus.executor.execute", queue: queue_name, job_class: job_class) do
-          Pgbus.logger.debug { "[Pgbus] Executor phase=deserialize msg_id=#{msg_id} job=#{job_class}" }
           job = ::ActiveJob::Base.deserialize(payload)
-          Pgbus.logger.debug { "[Pgbus] Executor phase=perform msg_id=#{msg_id} job=#{job_class}" }
+          Pgbus.logger.debug { "[Pgbus::Executor] running #{tag} job_class=#{job_class}" }
           execute_job(job)
-          Pgbus.logger.debug { "[Pgbus] Executor phase=archive msg_id=#{msg_id} job=#{job_class}" }
+          Pgbus.logger.debug { "[Pgbus::Executor] perform_returned #{tag} job_class=#{job_class}" }
           archive_from(queue_name, msg_id, source_queue: source_queue)
+          Pgbus.logger.debug { "[Pgbus::Executor] archived #{tag} job_class=#{job_class}" }
           FailedEventRecorder.clear!(queue_name: queue_name, msg_id: msg_id)
           job_succeeded = true
-          Pgbus.logger.debug { "[Pgbus] Executor phase=succeeded msg_id=#{msg_id} job=#{job_class}" }
         end
 
         instrument("pgbus.job_completed", queue: queue_name, job_class: job_class)
         record_stat(payload, queue_name, "success", execution_start, message: message)
+        Pgbus.logger.debug { "[Pgbus::Executor] done #{tag} job_class=#{job_class}" }
         :success
       rescue *FATAL_EXCEPTIONS
         # Process-fatal: propagate so the supervisor/OS can react.
@@ -88,6 +87,7 @@ module Pgbus
         handle_failure(message, queue_name, e, payload: payload)
         instrument("pgbus.job_failed", queue: queue_name, job_class: payload&.dig("job_class"), error: e.class.name)
         record_stat(payload, queue_name, "failed", execution_start, message: message)
+        Pgbus.logger.debug { "[Pgbus::Executor] failed #{tag} job_class=#{payload&.dig("job_class")} error=#{e.class}" }
         # Don't signal concurrency on transient failure — the job will be retried.
         # Semaphore is released only on success or dead-lettering.
         :failed

data/lib/pgbus/configuration.rb

@@ -85,6 +85,10 @@ module Pgbus
     # Requires a matching entry in config/database.yml under the "pgbus" key.
     attr_accessor :connects_to
 
+    # Zombie message detection — logs a warning when a message is redelivered
+    # (read_ct > 1) without any prior failure recorded in pgbus_failed_events.
+    attr_accessor :zombie_detection
+
     # Job stats
     attr_accessor :stats_enabled
     attr_reader :stats_retention # rubocop:disable Style/AccessorGrouping
@@ -160,6 +164,8 @@ module Pgbus
       @skip_recurring = false
       @recurring_execution_retention = 7 * 24 * 3600 # 7 days
 
+      @zombie_detection = true
+
       @stats_enabled = true
       @stats_retention = 30 * 24 * 3600 # 30 days
 

data/lib/pgbus/failed_event_recorder.rb

@@ -35,6 +35,18 @@ module Pgbus
         ErrorReporter.report(e, { action: "record_failed_event", queue: queue_name, msg_id: msg_id })
       end
 
+      def exists?(queue_name:, msg_id:)
+        result = connection.select_value(
+          "SELECT 1 FROM pgbus_failed_events WHERE queue_name = $1 AND msg_id = $2 LIMIT 1",
+          "FailedEvent Exists",
+          [queue_name, msg_id.to_i]
+        )
+        !result.nil?
+      rescue StandardError => e
+        Pgbus.logger.debug { "[Pgbus] FailedEvent exists? check failed: #{e.class}: #{e.message}" }
+        false
+      end
+
       def clear!(queue_name:, msg_id:)
         connection.exec_delete(
           "DELETE FROM pgbus_failed_events WHERE queue_name = $1 AND msg_id = $2",

data/lib/pgbus/process/worker.rb

@@ -126,6 +126,7 @@ module Pgbus
 
         @rate_counter.increment(:dequeued, tagged_messages.size)
         tagged_messages.each do |queue_name, message, source_queue|
+          detect_zombie(queue_name, message)
           @in_flight.increment
           @pool.post { process_message(message, queue_name, source_queue: source_queue) }
         end
@@ -285,6 +286,21 @@ module Pgbus
         Pgbus.logger.error { "[Pgbus] Queue table missing: #{error.message}" }
       end
 
+      def detect_zombie(queue_name, message)
+        return unless config.zombie_detection
+        return unless message.read_ct.to_i > 1
+
+        return if FailedEventRecorder.exists?(queue_name: queue_name, msg_id: message.msg_id.to_i)
+
+        Pgbus.logger.warn do
+          "[Pgbus] Zombie message redelivered: queue=#{queue_name} msg_id=#{message.msg_id} " \
+            "read_ct=#{message.read_ct} — previous read did not record a failure. " \
+            "The worker may have crashed mid-execute or the executor silently dropped the job."
+        end
+      rescue StandardError => e
+        Pgbus.logger.debug { "[Pgbus] Zombie detection failed: #{e.class}: #{e.message}" }
+      end
+
       def check_recycle
         return unless @lifecycle.running? && recycle_needed?
 

data/lib/pgbus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pgbus
-  VERSION = "0.7.1"
+  VERSION = "0.7.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pgbus
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Mikael Henriksson