pg_rails 7.0.8.pre.alpha.57 → 7.0.8.pre.alpha.58

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49e6cb9913064fd946d0ed5100572a31e6e39b7b4c0c5efeb8ca8ca520d9e75b
-  data.tar.gz: 206b926af17474e1ce20b6d76724729b60a6ee10955b3b459191949d72bcd3ed
+  metadata.gz: 418b790d06e3fdd8000b1722d68c479728e29eca73c1181544cf9241aed5745a
+  data.tar.gz: ec5ae58ada69aacb782c37374051022747b41049bd8cdd4824dac3f278a92325
 SHA512:
-  metadata.gz: 66dd233f281b67cf4557acdcc839095b6cf4327972f2bde48544a025fadf8ad272b5e6b15aea8fc000e7a8d4cb2dec37af3512d5326d23cf774dfef172a38147
-  data.tar.gz: '091b62e7722d9bdabb8df428074ac5f4a796cb1c2a4b058a86c6fd235a88b11dc160b1b30a5b34bd3f807a533c0c7337d61b8d92327028843c2ec1a2f8fd313a'
+  metadata.gz: e2b01bcb36204063d7374404571501f387adeec187364b16b014e9d81f20ed892ffc576af1cb69e967bef31008a90f197e412e6760ce02f493610b0ae8fe5eac
+  data.tar.gz: edfa1fbf40e2846af7c980f1bcbac849af13fe22ba5e4632ae7473795527a3da4b606f7e722d0dfc921017b71409f22010a79612bbcc34b7c137aa0815e51176

data/pg_engine/app/controllers/admin/emails_controller.rb

@@ -10,14 +10,10 @@ module Admin
 
     before_action(only: :index) { authorize Email }
 
-    before_action :set_instancia_modelo, only: %i[new create show edit update destroy content_eml]
+    before_action :set_instancia_modelo, only: %i[new create show edit update destroy]
 
     add_breadcrumb Email.nombre_plural, :admin_emails_path
 
-    def content_eml
-      send_data @email.content_eml, filename: "email_#{@email.id}.txt", disposition: :inline
-    end
-
     private
 
     def atributos_permitidos
@@ -25,7 +21,7 @@ module Admin
     end
 
     def atributos_para_buscar
-      %i[accepted_at delivered_at opened_at from_address from_name reply_to to subject body_input tags content_eml
+      %i[accepted_at delivered_at opened_at from_address from_name reply_to to subject body_input tags
          message_id mailer status_detail status]
     end
 
@@ -35,7 +31,7 @@ module Admin
 
     def atributos_para_mostrar
       %i[message_id status status_detail accepted_at delivered_at opened_at from_address
-         from_name reply_to to subject body_input tags associated mailer content_eml_link]
+         from_name reply_to to subject body_input tags associated mailer encoded_eml_link]
     end
   end
 end

data/pg_engine/app/decorators/email_decorator.rb

@@ -14,7 +14,9 @@ class EmailDecorator < PgEngine::BaseDecorator
   #     end
   #   end
 
-  def content_eml_link
-    link_to 'Download', helpers.content_eml_admin_email_path(object), target: :_blank, rel: :noopener
+  def encoded_eml_link
+    return if object.encoded_eml.blank?
+
+    link_to 'Download', helpers.rails_blob_path(object.encoded_eml), target: :_blank, rel: :noopener
   end
 end

data/pg_engine/app/mailers/pg_engine/base_mailer.rb

@@ -11,13 +11,19 @@ module PgEngine
 
     layout 'pg_layout/mailer'
 
+    # default delivery_method: :smtp
+
+    # TODO: rescue from StandardError? from PgEngine::Error?
+
     rescue_from MailNotDelivered do |err|
       # FIXME: marcar el Email en la DB como fallido
       pg_err err
     end
 
-    def mail
-      super.tap do |message|
+    protected
+
+    def mail(*args)
+      super(*args).tap do |message|
         # message.mailgun_options = {
         #   'tag' => email.tags,
         #   'tracking-opens' => true

data/pg_engine/app/models/email.rb

@@ -8,14 +8,13 @@
 #  accepted_at        :datetime
 #  associated_type    :string           indexed => [associated_id]
 #  body_input         :string
-#  content_eml        :string
 #  delivered_at       :datetime
 #  from_address       :string           not null
 #  from_name          :string
 #  mailer             :string
 #  opened_at          :datetime
 #  reply_to           :string
-#  status             :integer          default(0), not null
+#  status             :integer          default("pending"), not null
 #  status_detail      :string
 #  subject            :string
 #  tags               :string           is an Array
@@ -32,11 +31,12 @@
 #  fk_rails_...  (actualizado_por_id => users.id)
 #  fk_rails_...  (creado_por_id => users.id)
 #
-# generado con pg_rails
 
 class Email < ApplicationRecord
   audited
 
+  has_one_attached :encoded_eml
+
   belongs_to :associated, polymorphic: true, optional: true
 
   belongs_to :creado_por, optional: true, class_name: 'User'
@@ -66,16 +66,6 @@ class Email < ApplicationRecord
   after_initialize do
     self.from_address = ENV.fetch('DEFAULT_MAIL_FROM') if from_address.blank?
   end
-  # validates_format_of :subject, with: /\A[[[:alpha:]]\(\)\w\s.,;!¡?¿-]+\z/
-  # def strip_all(input)
-  #   return if input.blank?
-
-  #   strip_tags(input.strip)
-  # end
 
-  # def convert_br(input)
-  #   return if input.blank?
-
-  #   input.gsub("\n", '<br>').html_safe
-  # end
+  # validates_format_of :subject, with: /\A[[[:alpha:]]\(\)\w\s.,;!¡?¿-]+\z/
 end

data/pg_engine/app/policies/email_policy.rb

@@ -28,8 +28,4 @@ class EmailPolicy < ApplicationPolicy
   # def acceso_total?
   #   user.developer?
   # end
-
-  def content_eml?
-    acceso_total?
-  end
 end

data/pg_engine/config/routes.rb

@@ -9,11 +9,7 @@ Rails.application.routes.draw do
     registrations: 'users/registrations'
   }
   namespace :admin, path: 'a' do
-    pg_resource(:emails) do
-      member do
-        get :content_eml
-      end
-    end
+    pg_resource(:emails)
     pg_resource(:users)
     pg_resource(:accounts)
     pg_resource(:user_accounts)
@@ -98,7 +94,6 @@ end
 #                                              POST   /users/unlock(.:format)                                                                           devise/unlocks#create
 #                     abrir_modal_admin_emails GET    /a/emails/abrir_modal(.:format)                                                                   admin/emails#abrir_modal
 #                          buscar_admin_emails POST   /a/emails/buscar(.:format)                                                                        admin/emails#buscar
-#                      content_eml_admin_email GET    /a/emails/:id/content_eml(.:format)                                                               admin/emails#content_eml
 #                                 admin_emails GET    /a/emails(.:format)                                                                               admin/emails#index
 #                                              POST   /a/emails(.:format)                                                                               admin/emails#create
 #                              new_admin_email GET    /a/emails/new(.:format)                                                                           admin/emails#new

data/pg_engine/db/migrate/20240506194106_create_emails.rb

@@ -14,7 +14,6 @@ class CreateEmails < ActiveRecord::Migration[7.1]
       t.string :body_input
       t.string :tags, array: true
       t.references :associated, polymorphic: true, index: true
-      t.string :content_eml
       t.string :message_id
       t.string :mailer
       t.string :status_detail

data/pg_engine/lib/pg_engine/email_observer.rb

@@ -12,13 +12,14 @@ module PgEngine
       message_id = message.message_id
       mailer = message.delivery_handler.to_s
       status = get_status(message)
-      content_eml = message.encoded
       return if message['email'].blank?
 
       # El objeto Email ya estaba creado. Agarro ese objeto y le actualizo las cosas
       email = message['email'].unparsed_value
 
-      email.update_columns(message_id:, mailer:, status:, content_eml:) # rubocop:disable Rails/SkipsModelValidations
+      email.encoded_eml.attach({ io: StringIO.new(message.encoded), filename: "email-#{email.id}.eml" })
+
+      email.update_columns(message_id:, mailer:, status:) # rubocop:disable Rails/SkipsModelValidations
       # else
       # TODO: crear email
       # pg_warn 'El mail no tenía objeto Email asociado, se creó uno on the fly.', :warn

data/pg_engine/spec/controllers/admin/emails_controller_spec.rb

@@ -55,19 +55,6 @@ RSpec.describe Admin::EmailsController do
     end
   end
 
-  describe 'GET #content_eml' do
-    subject do
-      get :content_eml, params: { id: email.id }
-    end
-
-    let(:email) { create :email }
-
-    it do
-      subject
-      expect(response).to have_http_status(:ok)
-    end
-  end
-
   describe 'GET #index' do
     subject do
       get :index, params: {}
@@ -104,6 +91,7 @@ RSpec.describe Admin::EmailsController do
   describe 'GET #show' do
     it 'returns a success response' do
       email = create(:email)
+      email.encoded_eml.attach({ io: StringIO.new(Faker::Lorem.sentence), filename: 'email.eml' })
       get :show, params: { id: email.to_param }
       expect(response).to be_successful
     end

data/pg_engine/spec/factories/emails.rb

@@ -15,7 +15,6 @@ FactoryBot.define do
     body_input { Faker::Lorem.sentence }
     # tags { Faker::Lorem.sentence }
     # associated
-    # content_eml { Faker::Lorem.sentence }
     # message_id { Faker::Lorem.sentence }
     # mailer { Faker::Lorem.sentence }
     # status_detail { Faker::Lorem.sentence }

data/pg_rails/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgRails
-  VERSION = '7.0.8-alpha.57'
+  VERSION = '7.0.8-alpha.58'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pg_rails
 version: !ruby/object:Gem::Version
-  version: 7.0.8.pre.alpha.57
+  version: 7.0.8.pre.alpha.58
 platform: ruby
 authors:
 - Martín Rosso