pg_online_schema_change 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c13a6a65723fdd06f0de41359026198f3ea60907b7bf839c1d61e9eb9bbceb42
-  data.tar.gz: 6259bbb428ffe9a824da3d68289502322db71a26c394c87d1fa37483cb142666
+  metadata.gz: 2900c279c3ecb38f1deb228d82cb9c476f9aac331d669fea97c10ddd6eb41a94
+  data.tar.gz: 84f9a35eed1d5cde22924297e83d9539a218a964b76901005cdd6f389ee3c423
 SHA512:
-  metadata.gz: 367222a59e33bac35dd4778658d23c5acfbb68585fceb439d986f7846123bec295c2d831441891d0e59b1d3ee2feb438f6fc694fe4f498b02696d39492227079
-  data.tar.gz: 13baa1524266424fba9f25db9b308af2c3cb2c24e21f55fec7fb601e2915382f703430130fe8338534a3ce7a20dfe19334e04465877b4db6c76c6386baa54124
+  metadata.gz: 1395602fbea53d0d0d768fefed3d94f5cab39fae007ccd0c008f8a5818bf9de3b9f179a61b6cb91dbae288fec6cbd99e5bb6b494f1b38c0affe8c5c57d351b15
+  data.tar.gz: 5c0c2a4b305e147932a4fe8a62c9897238914343c95a39114cb5b8b05154eebee35c1e7fa164b592c7938c253c6b9ca8c3f943063b4b6c4b30618f31fefd3ae4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pg_online_schema_change (0.9.1)
+    pg_online_schema_change (0.9.2)
       ougai (~> 2.0.0)
       pg (>= 1.3.2, < 1.6.0)
       pg_query (>= 2.1.3, < 4.3.0)
@@ -20,8 +20,9 @@ GEM
       thor
       tilt
     json (2.6.3)
+    language_server-protocol (3.17.0.3)
     method_source (1.0.0)
-    oj (3.14.3)
+    oj (3.15.0)
     ougai (2.0.0)
       oj (~> 3.10)
     parallel (1.23.0)
@@ -54,8 +55,9 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)
-    rubocop (1.52.1)
+    rubocop (1.54.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)

data/lib/pg_online_schema_change/functions.rb

@@ -45,7 +45,7 @@ FUNC_CREATE_TABLE_ALL = <<~SQL
         rec record;
     begin
     EXECUTE format(
-          'CREATE TABLE %s (LIKE %s including all)',
+          'CREATE TABLE %s (LIKE %s including all) WITH (autovacuum_enabled = false)',
           newsource_table, source_table);
     END
   $$;

data/lib/pg_online_schema_change/orchestrate.rb

@@ -37,6 +37,7 @@ module PgOnlineSchemaChange
         Store.set(:audit_table_pk, "at_#{pgosc_identifier}_id")
         Store.set(:audit_table_pk_sequence, "#{audit_table}_#{audit_table_pk}_seq")
         Store.set(:shadow_table, "pgosc_st_#{client.table.downcase}_#{pgosc_identifier}")
+        Store.set(:primary_table_storage_parameters, Query.storage_parameters_for(client, client.table_name, true) || "")
 
         Store.set(
           :referential_foreign_key_statements,
@@ -59,7 +60,6 @@ module PgOnlineSchemaChange
 
         setup_trigger!
         setup_shadow_table! # re-uses transaction with serializable
-        disable_vacuum! # re-uses transaction with serializable
         run_alter_statement! # re-uses transaction with serializable
         copy_data! # re-uses transaction with serializable
         run_analyze!
@@ -105,7 +105,7 @@ module PgOnlineSchemaChange
         logger.info("Setting up audit table", { audit_table: audit_table })
 
         sql = <<~SQL
-          CREATE TABLE #{audit_table} (#{audit_table_pk} SERIAL PRIMARY KEY, #{operation_type_column} text, #{trigger_time_column} timestamp, LIKE #{client.table_name});
+          CREATE TABLE #{audit_table} (#{audit_table_pk} SERIAL PRIMARY KEY, #{operation_type_column} text, #{trigger_time_column} timestamp, LIKE #{client.table_name}) WITH (autovacuum_enabled = false);
         SQL
 
         Query.run(client.connection, sql)
@@ -177,28 +177,6 @@ module PgOnlineSchemaChange
         )
       end
 
-      def disable_vacuum!
-        # re-uses transaction with serializable
-        # Disabling vacuum to avoid any issues during the process
-        result = Query.storage_parameters_for(client, client.table_name, true) || ""
-        Store.set(:primary_table_storage_parameters, result)
-
-        logger.debug(
-          "Disabling vacuum on shadow and audit table",
-          { shadow_table: shadow_table, audit_table: audit_table },
-        )
-        sql = <<~SQL
-          ALTER TABLE #{shadow_table} SET (
-            autovacuum_enabled = false, toast.autovacuum_enabled = false
-          );
-
-          ALTER TABLE #{audit_table} SET (
-            autovacuum_enabled = false, toast.autovacuum_enabled = false
-          );
-        SQL
-        Query.run(client.connection, sql, true)
-      end
-
       def run_alter_statement!
         # re-uses transaction with serializable
         statement = Query.alter_statement_for(client, shadow_table)

data/lib/pg_online_schema_change/query.rb

@@ -81,7 +81,6 @@ module PgOnlineSchemaChange
         connection.block
         logger.info("Exception raised, rolling back query", { rollback: true, query: query })
         connection.async_exec("ROLLBACK;")
-        connection.async_exec("COMMIT;")
         raise
       else
         connection.async_exec("COMMIT;") unless reuse_trasaction

data/lib/pg_online_schema_change/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgOnlineSchemaChange
-  VERSION = "0.9.1"
+  VERSION = "0.9.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_online_schema_change
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Shayon Mukherjee
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-24 00:00:00.000000000 Z
+date: 2023-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ougai