pg_online_schema_change 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b14af6aa2b98ab8f1b2aab5ae0a8555e017f92531ce1214e50f2ac62ff354224
-  data.tar.gz: 66ba81f4e90f4dc612d863d043838fec8676e468924eeb5c39d21094d002e48a
+  metadata.gz: 3bc78403dc036598371393d5be0914bd7150660eda9798fb827af2892d058396
+  data.tar.gz: 6dbfb6e41267accf02e0da8ba88d7ea5039aa368ddc497e40d81f8952bed811d
 SHA512:
-  metadata.gz: a272a3749f8f053a528d859cc35b97b5fde7d6353a3c0c710500e35d33df6b4bc8526b18e855fd154b742eef8189b661e8e710a6b25221df6e47d55a47381a2e
-  data.tar.gz: c0dd7f41e204840b54b768df1f1e8486f79038bede199021ef13684c4b1369e3de43be6fbfd8f03b7ca652251c59a8a580ecefb235e00e54858d77f88a7334de
+  metadata.gz: '0683dd33e681162a1b16b471fbefc52021b66ccbb3235994fd0654c6d97052a5482e22e29c1280cbc332eb8510b1b4a571075b4e36f9a2565c359ad086100d05'
+  data.tar.gz: 51e1fcd9d8d8d4f2a3f5760dee1e51fbde5a45f3bf7dd9c2d048390856b3b71bfb23333b053e0a0e43c026e90a9f704efbc903760cd37e95eb5ac5ea24b66512

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.5.0] - 2022-02-26
+* Share some preliminary load test figures in https://github.com/shayonj/pg-osc/pull/54
+* Reuse existing transaction open for reading table columns in https://github.com/shayonj/pg-osc/pull/53
+* Start to deprecate --password with PGPASSWORD in https://github.com/shayonj/pg-osc/pull/56
+* Introduce configurable PULL_BATCH_COUNT and DELTA_COUNT in https://github.com/shayonj/pg-osc/pull/57
+
 ## [0.4.0] - 2022-02-22
 * Lint sourcecode, setup Rubocop proper and Lint in CI by @shayonj in https://github.com/shayonj/pg-osc/pull/46
 * Uniquely identify operation_type column by @shayonj in https://github.com/shayonj/pg-osc/pull/50

data/CODE_OF_CONDUCT.md

@@ -39,7 +39,7 @@ This Code of Conduct applies within all community spaces, and also applies when
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at shayon@loom.com. All complaints will be reviewed and investigated promptly and fairly.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at shayonj@gmail.com. All complaints will be reviewed and investigated promptly and fairly.
 
 All community leaders are obligated to respect the privacy and security of the reporter of any incident.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pg_online_schema_change (0.4.0)
+    pg_online_schema_change (0.5.0)
       ougai (~> 2.0.0)
       pg (~> 1.3.2)
       pg_query (~> 2.1.3)

data/README.md

@@ -100,6 +100,7 @@ print the version
 - `pg-osc` acquires minimal locks throughout the process (read more below on the caveats).
 - Copies over indexes and Foreign keys.
 - Optionally drop or retain old tables in the end.
+- Tune how slow or fast should replays be from the audit/log table ([Replaying larger workloads](#replaying-larger-workloads)).
 - Backfill old/new columns as data is copied from primary table to shadow table, and then perform the swap. [Example](#backfill-data)
 - **TBD**: Ability to reverse the change with no data loss. [tracking issue](https://github.com/shayonj/pg-osc/issues/14)
 

data/lib/pg_online_schema_change/orchestrate.rb

@@ -37,6 +37,8 @@ module PgOnlineSchemaChange
         Store.set(:audit_table_pk, "at_#{pgosc_identifier}_id")
         Store.set(:audit_table_pk_sequence, "#{audit_table}_#{audit_table_pk}_seq")
         Store.set(:shadow_table, "pgosc_st_#{client.table}_#{pgosc_identifier}")
+
+        Store.set(:foreign_key_statements, Query.get_foreign_keys_to_refresh(client, client.table))
       end
 
       def run!(options)
@@ -221,7 +223,6 @@ module PgOnlineSchemaChange
       def swap!
         logger.info("Performing swap!")
 
-        foreign_key_statements = Query.get_foreign_keys_to_refresh(client, client.table)
         storage_params_reset = primary_table_storage_parameters.empty? ? "" : "ALTER TABLE #{client.table} SET (#{primary_table_storage_parameters});"
 
         # From here on, all statements are carried out in a single
@@ -244,7 +245,7 @@ module PgOnlineSchemaChange
           DROP TRIGGER IF EXISTS primary_to_audit_table_trigger ON #{client.table};
         SQL
 
-        Query.run(client.connection, sql)
+        Query.run(client.connection, sql, opened)
       ensure
         Query.run(client.connection, "COMMIT;")
         Query.run(client.connection, "SET statement_timeout = 0;")
@@ -270,6 +271,7 @@ module PgOnlineSchemaChange
         shadow_table_drop = shadow_table ? "DROP TABLE IF EXISTS #{shadow_table}" : ""
 
         sql = <<~SQL
+          DROP TRIGGER IF EXISTS primary_to_audit_table_trigger ON #{client.table};
           #{audit_table_drop};
           #{shadow_table_drop};
           #{primary_drop}

data/lib/pg_online_schema_change/replay.rb

@@ -87,7 +87,7 @@ module PgOnlineSchemaChange
             SQL
             to_be_replayed << sql
 
-            to_be_deleted_rows << "'#{row[primary_key]}'"
+            to_be_deleted_rows << "'#{row[audit_table_pk]}'"
           when "UPDATE"
             set_values = new_row.map do |column, value|
               "#{column} = '#{value}'"
@@ -100,14 +100,14 @@ module PgOnlineSchemaChange
             SQL
             to_be_replayed << sql
 
-            to_be_deleted_rows << "'#{row[primary_key]}'"
+            to_be_deleted_rows << "'#{row[audit_table_pk]}'"
           when "DELETE"
             sql = <<~SQL
               DELETE FROM #{shadow_table} WHERE #{primary_key}=\'#{row[primary_key]}\';
             SQL
             to_be_replayed << sql
 
-            to_be_deleted_rows << "'#{row[primary_key]}'"
+            to_be_deleted_rows << "'#{row[audit_table_pk]}'"
           end
         end
 
@@ -117,7 +117,7 @@ module PgOnlineSchemaChange
         return unless to_be_deleted_rows.count >= 1
 
         delete_query = <<~SQL
-          DELETE FROM #{audit_table} WHERE #{primary_key} IN (#{to_be_deleted_rows.join(",")})
+          DELETE FROM #{audit_table} WHERE #{audit_table_pk} IN (#{to_be_deleted_rows.join(",")})
         SQL
         Query.run(client.connection, delete_query, reuse_trasaction)
       end

data/lib/pg_online_schema_change/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgOnlineSchemaChange
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_online_schema_change
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Shayon Mukherjee
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-26 00:00:00.000000000 Z
+date: 2022-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ougai