pg_conn 0.36.0 → 0.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d6940809a3f62bfad5cd2a94566a76bcd1944ad5b6ded6df2be159a010b2169
-  data.tar.gz: 6f213cb288ba5a85205fd5054fb498e6200b0319eee8c2bbc8c60515705410f7
+  metadata.gz: 1edd50ec4e7e4f072a695cd044ab6d930dd14cdf763dd335ee0fbb65865e83c4
+  data.tar.gz: 3fe0cf2fe952999dceea4b6776155b7252d4e3f4aeeab7089348fc10ec9cfc5e
 SHA512:
-  metadata.gz: a90dab6c75eb2cfd7a99b39676a4aa0dc167462e37e9229d96ed30517b4ff0c691f6b4389ceb6d26c3f2562d7ce4e7dd2be17d054f1e61369989fb9f8c3db8e1
-  data.tar.gz: f91893227ef9697eb236051728d509727b2d20b5d9efd7c6f848cf2e887b1abc0e5c8a48da291914372049ab25aee6580b9b74fd422d269c3e7813928032dd23
+  metadata.gz: a84b206b8c7b19813a3acbc63350289e6b072fc1ef8edb65901c99fe6f76fffe3c9ad9ab54d44105652902a8486e5904071e8f6712e73b7b9752019646a8bb8b
+  data.tar.gz: 6725ac8c9ef737db41770df819fefa88cb716ff189d714b139079475ee3255a59ec996e9d9c1e138b971b2b4908d6a91f08b9d7bc3731a7e46c32bd684f28000

data/TODO

@@ -1,11 +1,12 @@
 TODO
+  o Drop existing SQL output interface and instead implement a SQL logger
+
   o Add support for hstore (a hash)
 
   o Add a <fetch>! method. Require v2
       value?    0 or 1
       value     1
       values    0 or n
-      values?   0 or n
       values!   1 or more
 
   o Instrumentation of connection object
@@ -43,10 +44,6 @@ TODO
 
       server.call :sp_nic_update_comtext, str_id, str_comtext, site.current_user.id
 
-  o Have a 'with' method that combines multiple brachet-methods:
-
-      conn.with(schema: public, transation: true) { ... }
-
   o Create aliases
       tuple   ->  array
       tuples      arrays
@@ -120,6 +117,9 @@ TODO
     composition of anonymous record types
 
   + Quote methods (value, identier, ... -> Postgres string)
+  + Have a 'with' method that combines multiple brachet-methods:
+      conn.with(schema: public, transation: true) { ... }
+
 
 REFACTOR
   #!/usr/bin/env ruby

data/lib/pg_conn/schema_methods.rb

@@ -48,7 +48,7 @@ module PgConn
 
     # Empty all tables in the given schema
     def clean!(schema, exclude: [])
-      conn.session.triggers(false) {
+      conn.without_triggers {
         self.list_tables(schema, exclude: exclude).each { |table|
           conn.exec "delete from #{schema}.#{table}"
         }

data/lib/pg_conn/session_methods.rb

@@ -84,38 +84,6 @@ module PgConn
       end
     end
 
-    # Return true if session triggers are enabled. Triggers are enabled by
-    # default by Postgres
-    def triggers?() conn.value "select current_setting('session_replication_role') <> 'replica'" end
-
-    # Enable session triggers
-    def enable_triggers()
-      conn.execute "set session session_replication_role = DEFAULT"
-    end
-
-    # Disable session triggers
-    def disable_triggers()
-      conn.execute "set session session_replication_role = replica"
-    end
-
-    # Execute block with session triggers on or off
-    def triggers(on_off, &block)
-      begin
-        active = triggers?
-        if on_off && !active
-          enable_triggers
-        elsif !on_off && active
-          disable_triggers
-        end
-        yield
-      ensure
-        case active
-          when true; enable_triggers if !triggers?
-          when false; disable_triggers if triggers?
-        end
-      end
-    end
-
   private
     # Like #list but returns the PIDs of the users
     def pids(database, users)

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.36.0"
+  VERSION = "0.37.0"
 end

data/lib/pg_conn.rb

@@ -133,7 +133,7 @@ module PgConn
 
     # Name of user
     def user() @pg_connection.user end
-    alias_method :username, :user # Obsolete FIXME Is it?
+    alias_method :username, :user # Obsolete FIXME Is it? No it is not!
 
     # Name of database
     def name() @pg_connection.db end
@@ -263,12 +263,13 @@ module PgConn
     # The possible keys of the connection hash are :host, :port, :dbname, :user,
     # and :password. The connection string can either be a space-separated list
     # of <key>=<value> pairs with the same keys as the hash, or a URI with the
-    # format 'postgres[ql]://[user[:password]@][host][:port][/name]
+    # format 'postgres[ql]://[user[:password]@][host][:port][/name]. TODO Also
+    # allow :database and :username
     #
     # If given an array argument, PgConn will not connect to the database and
     # instead write its commands to the array. In this case, methods extracting
     # values from the database (eg. #value) will return nil or raise an
-    # exception
+    # exception. TODO: Remove
     #
     # The last variant is used to establish a PgConn from an existing
     # connection. It doesn't change the connection settings and is not
@@ -430,7 +431,8 @@ module PgConn
       end
     end
 
-    # Mark string argument as already being quoted
+    # Mark string argument as already being quoted. This is done automatically
+    # by all quote_* methods
     def literal(arg) Literal.new(arg) end
 
     # Connection member method variations of the PgConn quote class methods
@@ -784,6 +786,8 @@ module PgConn
     # There is no variant that takes a single tuple because it would then be
     # impossible to have array or hash field values
     def insert(*args, upsert: nil, **opts)
+      # Normalize arguments
+
       # Add options to args except the special :upsert option
       args << opts if !opts.empty?
 
@@ -1091,6 +1095,43 @@ module PgConn
       end
     end
 
+    # Return true if session triggers are enabled. Triggers are enabled by
+    # default by Postgres
+    def triggers?() self.value "select current_setting('session_replication_role') <> 'replica'" end
+
+    # Enable session triggers
+    def enable_triggers()
+      self.execute "set session session_replication_role = DEFAULT"
+    end
+
+    # Disable session triggers
+    def disable_triggers()
+      self.execute "set session session_replication_role = replica"
+    end
+
+    # Executes block without triggers
+    def without_triggers(&block)
+      triggers(false) { yield }
+    end
+
+    # Execute block with session triggers on or off
+    def triggers(on_off, &block)
+      begin
+        active = triggers?
+        if on_off && !active
+          enable_triggers
+        elsif !on_off && active
+          disable_triggers
+        end
+        yield
+      ensure
+        case active
+          when true; enable_triggers if !triggers?
+          when false; disable_triggers if triggers?
+        end
+      end
+    end
+
     def dump(*query)
       records = self.records(*query)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.37.0
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-23 00:00:00.000000000 Z
+date: 2025-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg