pg 0.14.0 → 0.14.1.pre.363

data/ChangeLog

@@ -1,10 +1,47 @@
+2012-08-10  Michael Granger  <ged@FaerieMUD.org>
+
+	* ext/pg_result.c:
+	Use heap instead of stack for result array in #values, etc al. (refs
+	#135, #136, #138)
+	[4d5e457062e8] [tip]
+
+2012-08-04  Lars Kanis  <kanis@comcard.de>
+
+	* spec/pg/connection_spec.rb:
+	Add missing require for using the TCPServer in connection_spec. This
+	fixes #137 .
+	[72b45840d975]
+
+2012-07-03  Lars Kanis  <kanis@comcard.de>
+
+	* ext/pg_connection.c:
+	Add note about the usage scope of the result object received by the
+	#set_notice_receiver block.
+	[de900bfaff1a]
+
+2012-07-02  Lars Kanis  <kanis@comcard.de>
+
+	* ext/pg_result.c:
+	Add PGRES_COPY_BOTH to documentation of PG::Result#result_status
+	[5e0e06440b1a]
+
+2012-06-23  Michael Granger  <ged@FaerieMUD.org>
+
+	* .hgtags:
+	Added tag v0.14.0 for changeset 634e0a42a101
+	[35eecb26bd34]
+
+	* .hgsigs:
+	Added signature for changeset a45710f8db30
+	[634e0a42a101] [v0.14.0]
+
 2012-06-17  Lars Kanis  <kanis@comcard.de>
 
 	* Rakefile.cross, ext/extconf.rb,
 	misc/postgresql-9.1.4.mingw-w64-support.patch:
 	Update windows cross compilation tasks to the latest
 	Openssl+Postgresql versions and the latest mingw-w64 compiler
-	[a45710f8db30] [tip]
+	[a45710f8db30]
 
 	* Rakefile:
 	Use RbConfig instead of obsolete and deprecated Config.

data/History.rdoc

@@ -1,3 +1,22 @@
+== v0.14.1 [2012-08-12] Michael Granger <ged@FaerieMUD.org>
+
+Important bugfix:
+
+- Fix stack overflow bug in PG::Result#values and #column_values (#135). Thanks
+  to everyone who reported the bug, and Lars Kanis especially for figuring out
+  the problem.
+
+PostgreSQL 9.2 beta fixes:
+
+- Recognize PGRES_SINGLE_TUPLE as OK when checking PGresult (Jeremy Evans)
+
+Documentation fixes:
+
+- Add note about the usage scope of the result object received by the
+  #set_notice_receiver block. (Lars Kanis)
+- Add PGRES_COPY_BOTH to documentation of PG::Result#result_status. (Lars Kanis)
+
+
 == v0.14.0 [2012-06-17] Michael Granger <ged@FaerieMUD.org>
 
 Bugfixes:

data/ext/extconf.rb

@@ -70,6 +70,7 @@ have_func 'rb_encdb_alias'
 have_func 'rb_enc_alias'
 
 have_const 'PGRES_COPY_BOTH', 'libpq-fe.h'
+have_const 'PGRES_SINGLE_TUPLE', 'libpq-fe.h'
 
 $defs.push( "-DHAVE_ST_NOTIFY_EXTRA" ) if
 	have_struct_member 'struct pgNotify', 'extra', 'libpq-fe.h'

data/ext/pg_connection.c

@@ -1,6 +1,6 @@
 /*
  * pg_connection.c - PG::Connection class extension
- * $Id: pg_connection.c,v a3a3177b921c 2012/06/17 17:40:49 ged $
+ * $Id: pg_connection.c,v de900bfaff1a 2012/07/03 14:38:38 kanis $
  *
  */
 
@@ -2325,6 +2325,10 @@ notice_receiver_proxy(void *arg, const PGresult *result)
  * the Proc object previously set, or +nil+ if it was previously the default.
  *
  * If you pass no arguments, it will reset the handler to the default.
+ *
+ * *Note:* The +result+ passed to the block should not be used outside
+ * of the block, since the corresponding C object could be freed after the
+ * block finishes.
  */
 static VALUE
 pgconn_set_notice_receiver(VALUE self)

data/ext/pg_result.c

@@ -1,6 +1,6 @@
 /*
  * pg_result.c - PG::Result class extension
- * $Id: pg_result.c,v 237cc4f69f63 2012/06/17 17:20:28 ged $
+ * $Id: pg_result.c,v f92b6456c566 2012/08/08 23:22:21 code $
  *
  */
 
@@ -67,6 +67,9 @@ pg_result_check( VALUE self )
 		case PGRES_COPY_IN:
 #ifdef HAVE_CONST_PGRES_COPY_BOTH
 		case PGRES_COPY_BOTH:
+#endif
+#ifdef HAVE_CONST_PGRES_SINGLE_TUPLE
+		case PGRES_SINGLE_TUPLE:
 #endif
 		case PGRES_EMPTY_QUERY:
 		case PGRES_COMMAND_OK:
@@ -179,6 +182,7 @@ pgresult_get(VALUE self)
  * * +PGRES_BAD_RESPONSE+
  * * +PGRES_NONFATAL_ERROR+
  * * +PGRES_FATAL_ERROR+
+ * * +PGRES_COPY_BOTH+
  */
 static VALUE
 pgresult_result_status(VALUE self)
@@ -725,15 +729,15 @@ pgresult_values(VALUE self)
 	int field;
 	int num_rows = PQntuples(result);
 	int num_fields = PQnfields(result);
-	VALUE rows[ num_rows ];
+	VALUE ary = rb_ary_new2(num_rows);
 
 	for ( row = 0; row < num_rows; row++ ) {
-		VALUE new_row[ num_fields ];
+		VALUE new_row = rb_ary_new2(num_fields);
 
 		/* populate the row */
 		for ( field = 0; field < num_fields; field++ ) {
 			if ( PQgetisnull(result, row, field) ) {
-				new_row[ field ] = Qnil;
+				rb_ary_store( new_row, field, Qnil );
 			}
 			else {
 				VALUE val = rb_tainted_str_new( PQgetvalue(result, row, field), 
@@ -747,14 +751,14 @@ pgresult_values(VALUE self)
 					rb_enc_associate( val, rb_ascii8bit_encoding() );
 				}
 #endif
-				new_row[ field ] = val;
+				rb_ary_store( new_row, field, val );
 			}
 		}
 
-		rows[ row ] = rb_ary_new4( num_fields, new_row );
+		rb_ary_store( ary, row, new_row );
 	}
 
-	return rb_ary_new4( num_rows, rows );
+	return ary;
 }
 
 
@@ -769,7 +773,7 @@ make_column_result_array( VALUE self, int col )
 	int rows = PQntuples( result );
 	int i;
 	VALUE val = Qnil;
-	VALUE results[ rows ];
+	VALUE results = rb_ary_new2( rows );
 
 	if ( col >= PQnfields(result) )
 		rb_raise( rb_eIndexError, "no column %d in result", col );
@@ -787,10 +791,10 @@ make_column_result_array( VALUE self, int col )
 		}
 #endif
 
-		results[ i ] = val;
+		rb_ary_store( results, i, val );
 	}
 
-	return rb_ary_new4( rows, results );
+	return results;
 }
 
 
@@ -860,16 +864,16 @@ pgresult_fields(VALUE self)
 {
 	PGresult *result = pgresult_get( self );
 	int n = PQnfields( result );
-	VALUE fields[ n ];
+	VALUE fields = rb_ary_new2( n );
 	int i;
 
 	for ( i = 0; i < n; i++ ) {
 		VALUE val = rb_tainted_str_new2(PQfname(result, i));
 		ASSOCIATE_INDEX(val, self);
-		fields[ i ] = val;
+		rb_ary_store( fields, i, val );
 	}
 
-	return rb_ary_new4( n, fields );
+	return fields;
 }
 
 

data/lib/pg.rb

@@ -19,10 +19,10 @@ end
 module PG
 
 	# Library version
-	VERSION = '0.14.0'
+	VERSION = '0.14.1'
 
 	# VCS revision
-	REVISION = %q$Revision: a3a3177b921c $
+	REVISION = %q$Revision: ef533f731814 $
 
 
 	### Get the PG library version. If +include_buildnum+ is +true+, include the build ID.

data/spec/pg/connection_spec.rb

@@ -14,6 +14,7 @@ BEGIN {
 require 'rspec'
 require 'spec/lib/helpers'
 require 'timeout'
+require 'socket'
 require 'pg'
 
 describe PG::Connection do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pg
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.14.1.pre.363
   prerelease: 
 platform: ruby
 authors:
@@ -36,7 +36,7 @@ cert_chain:
   YUhDS0xaZFNLai9SSHVUT3QrZ2JsUmV4OEZBaDhOZUEKY21saFhlNDZwWk5K
   Z1dLYnhaYWg4NWpJang5NWhSOHZPSStOQU01aUg5a09xSzEzRHJ4YWNUS1Bo
   cWo1UGp3RgotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
-date: 2012-06-23 00:00:00.000000000 Z
+date: 2012-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hoe-mercurial

metadata.gz.sig

@@ -1,2 +1 @@
-�2�����uam7�	_��1��,���n͘6���	
-����)�ם~��b\���vFCN�6]�K���ߡ�����c�l���a�Vke��iD���@B%��b5yc -e:V/�f��#Qc:��IO�<{&��O���8��7�Sʘ����@�}�߉VX
18m����i��ǢR?�rk�
$���oF8�K%4��3��
!�L�M�/�-�8�dv����M!q�~���^��&�z��'6�j�5��rJ
+i��7
�鰐��ܱ�Q\��� �=Y��|�0��o�[N�p�;%k�[�#���Y�C�W?}C�}��'O����<v:�V�m��;�ii�����W/����=�`@5d����	j3��4��U:VL��k�M��n�x