persistent_settings 1.0.3 → 1.1.0

data/README.md

@@ -1,5 +1,7 @@
 # Persistent Settings
 
+[![Build Status](https://secure.travis-ci.org/dabit/persistent_settings.png)](http://travis-ci.org/dabit/persistent_settings)
+
 A simple key value store for ActiveRecord based applications.
 
 Best used to store global app settings.
@@ -35,6 +37,17 @@ Reload your app:
 
 It accepts all kinds of objects as the value
 
+## Known Issues
+
+Sometimes, settings are not loaded automatically at startup. If that's the case
+add an initializer to your Rails app.
+
+    #
+    # config/initializers/settings.rb
+    #
+
+    Settings.load_from_persistance
+
 # License
 
 MIT License. Copyright 2011, Crowd Interactive http://www.crowdint.com

data/lib/persistent_settings/version.rb

@@ -1,3 +1,3 @@
 module PersistentSettings
-  VERSION = "1.0.3"
+  VERSION = "1.1.0"
 end

data/lib/settings.rb

@@ -40,15 +40,19 @@ class Settings < ActiveRecord::Base
     end
   end
 
-  def self.load_from_persistance
+  def self.load_from_persistance!
     self.all.each do |setting|
       self.send("#{setting.var}=", setting.value)
     end
   end
 
+  def self.load_from_persistance
+    load_from_persistance! if connected? && table_exists?
+  end
+
   def self.keys
     Settings.select(:var).collect { |s| s.var.to_sym }
   end
 
-  load_from_persistance if connected? && table_exists?
+  load_from_persistance
 end

data/spec/lib/settings_spec.rb

@@ -1,8 +1,6 @@
 require 'spec_helper'
 
 describe Settings do
-  before do
-  end
   describe :assignation? do
     context "the method name ends with =" do
       it "returns true" do
@@ -68,7 +66,7 @@ describe Settings do
 
         it "pulls the value from the database and creates its setter and getter" do
           Settings.should_receive(:persisted_method=).with('some value')
-          Settings.load_from_persistance
+          Settings.load_from_persistance!
         end
       end
 
@@ -96,4 +94,52 @@ describe Settings do
     specify { should include(:a_key) }
     specify { should include(:another_key) }
   end
+
+  describe :load_from_persistance! do
+    it "loads all settings from persistance and sets it up" do
+      settings = [ Settings.new(:var => 'foo', :value => 'bar') ]
+      Settings.should_receive(:all).and_return(settings)
+      Settings.should_receive("foo=").with('bar')
+
+      Settings.load_from_persistance!
+    end
+  end
+
+  describe :load_from_persistance do
+    context "AR is connected and table is created" do
+      before do
+        Settings.stub(:connected?).and_return true
+        Settings.stub(:table_exists?).and_return true
+      end
+
+      it "calls load_from_persistance!" do
+        Settings.should_receive(:load_from_persistance!)
+        Settings.load_from_persistance
+      end
+    end
+
+    context "AR is not connected" do
+      before do
+        Settings.stub(:connected?).and_return false
+        Settings.stub(:table_exists?).and_return true
+      end
+
+      it "calls load_from_persistance!" do
+        Settings.should_not_receive(:load_from_persistance!)
+        Settings.load_from_persistance
+      end
+    end
+
+    context "table is not created" do
+      before do
+        Settings.stub(:connected?).and_return false
+        Settings.stub(:table_exists?).and_return false
+      end
+
+      it "calls load_from_persistance!" do
+        Settings.should_not_receive(:load_from_persistance!)
+        Settings.load_from_persistance
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -2,3 +2,9 @@ require 'persistent_settings'
 
 ::ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
 
+::ActiveRecord::Schema.define(:version => 1) do
+  create_table "settings", :force => true do |t|
+    t.string "var"
+    t.string "value"
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: persistent_settings
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-15 00:00:00.000000000 Z
+date: 2012-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
-  requirement: &70348682989280 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,15 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70348682989280
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70348682988780 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +37,15 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70348682988780
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &70348682988280 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +53,15 @@ dependencies:
         version: 1.1.4
   type: :development
   prerelease: false
-  version_requirements: *70348682988280
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.1.4
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70348682987800 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +69,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70348682987800
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70348682987200 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +85,15 @@ dependencies:
         version: 2.7.0
   type: :development
   prerelease: false
-  version_requirements: *70348682987200
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.7.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70348683003000 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,7 +101,12 @@ dependencies:
         version: '1.3'
   type: :development
   prerelease: false
-  version_requirements: *70348683003000
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
 description: Simple global Settings class for ActiveRecord based applications
 email:
 - david@crowdint.com
@@ -115,15 +145,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 3753706074841151251
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 3753706074841151251
 requirements: []
 rubyforge_project: persistent_settings
-rubygems_version: 1.8.10
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Simple global Settings class for ActiveRecord based applications