permissions 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e7f21c268e22561d9d90f305d416cb57e8537f63
-  data.tar.gz: 67a4cb0addefefbb84a65028a5f865be609c5035
+  metadata.gz: febaedd5aee44b64e40764b8044c1266e4413e62
+  data.tar.gz: 610a0827dbdeca1afb0f1fc716fe62161507924b
 SHA512:
-  metadata.gz: 92e41c206d988fcc52bb156f00e34220243558de1dc7e1f90c297502eaeafd7eaf09a0abda6eb64560cbb1dc6eafd8d6b6608f725e51365d33bbba8191a4aa34
-  data.tar.gz: 0fc6e54049790f0c792a9dc3254a3cd9cae8c7c5cbdd8c4fb6e654ac7123e3496dc3cf02c45b992f534887ad98b3b52ffe1793b2b98904787e9af23adc264d5d
+  metadata.gz: c56f43cf0c7d08925f7ede8af7991bdd84bb4dd202453d331424c1dee9d3c8501485fc9361d99da174fdec4b44c920d1ad86d76e785808f06b436d9f6e2f51c7
+  data.tar.gz: cac31aa13191afc57cf4e356a3d2e5479a3f8c8d699d5c0df07e0171b79a6b0026801cde56acadebb923d32f04b0d4f1c1dd949fbc5a81867a0c5020b121ef76

data/README.md

@@ -33,12 +33,6 @@ class User
   def initialize(permissions)
     @permissions = permissions
   end
-
-  # Authorizables must provide their own implementation of "permissions".
-  # An attr_reader would do.
-  def permissions
-    @permissions
-  end
 end
 
 class Command
@@ -47,13 +41,6 @@ class Command
   def initialize(user)
     @user = user
   end
-
-  # Not provided by the library. An advanced example
-  # on how to authorize things like: "Does an object
-  # belong to a particular user?"
-  def authorize?(other)
-    other.authorize_for?(self.class, self)
-  end
 end
 
 permissions = Permissions.new
@@ -62,9 +49,15 @@ permissions.for(Command) { |user, command| user == command.user }
 
 user = User.new(permissions)
 
-command = Command.new(user)
+foo = Command.new(user)
 
-command.authorize?(user) # true
-```
+bar = Command.new(nil)
 
-More examples can be found in the tests.
+user.authorize_for?(Command, foo) # true
+
+user.authorize_for?(Command, bar) # false
+
+permissions.authorize?(Command, user, foo) # true
+
+permissions.authorize?(Command, user, bar) # false
+```

data/lib/permissions.rb

@@ -1,5 +1,5 @@
 class Permissions
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 
   module Authorizable
     def permissions
@@ -32,6 +32,6 @@ class Permissions
   end
 
   def deep_dup(initial_permissions = {})
-    Permissions.new(initial_permissions.merge(permissions)) { default }
+    self.class.new(initial_permissions.merge(permissions)) { default }
   end
 end

data/test/permissions_test.rb

@@ -6,12 +6,6 @@ class User
   def initialize(permissions)
     @permissions = permissions
   end
-
-  # Authorizables must provide their own implementation of "permissions".
-  # An attr_reader would do.
-  def permissions
-    @permissions
-  end
 end
 
 class Command
@@ -20,13 +14,6 @@ class Command
   def initialize(user)
     @user = user
   end
-
-  # Not provided by the library. An advanced example
-  # on how to authorize things like: "Does an object
-  # belong to a particular user?"
-  def authorize?(other)
-    other.authorize_for?(self.class, self)
-  end
 end
 
 class Create < Command
@@ -55,14 +42,6 @@ def refute_authorize_for(user, subject)
   assert !user.authorize_for?(subject), "#{user} is authorized for #{subject}, it should not be"
 end
 
-def assert_authorize(subject, user)
-  assert subject.authorize?(user), "#{subject} does not authorize #{user}, it should"
-end
-
-def refute_authorize(subject, user)
-  assert !subject.authorize?(user), "#{subject} does authorize #{user}, it should not"
-end
-
 # Create a Permissions object.
 guest_permissions = Permissions.new
 
@@ -95,37 +74,21 @@ admin_update = Update.new(admin)
 
 admin_delete = Delete.new(admin)
 
-test '#authorize_for?' do
+test do
   # Guest
   assert_authorize_for guest, Create
+
   refute_authorize_for guest, Update
+
   refute_authorize_for guest, Delete
 
   # Member
   assert_authorize_for member, Create
+
   assert_authorize_for admin, Create
 
   # Admin
   assert_authorize_for admin, Update
-  assert_authorize_for admin, Delete
-end
-
-test '#authorize?' do
-  # Guest
-  refute_authorize member_update, guest
-  refute_authorize member_delete, guest
-  refute_authorize admin_update, guest
-  refute_authorize admin_delete, guest
 
-  # Member
-  assert_authorize member_update, member
-  assert_authorize member_delete, member
-  refute_authorize admin_update, member
-  refute_authorize admin_delete, member
-
-  # Admin
-  assert_authorize member_update, admin
-  assert_authorize member_delete, admin
-  assert_authorize admin_update, admin
-  assert_authorize admin_delete, admin
+  assert_authorize_for admin, Delete
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: permissions
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Steve Weiss
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-11 00:00:00.000000000 Z
+date: 2017-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cutest