permissioner 0.0.1.beta → 0.0.2.beta

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: cfc2e5ec9d5f94f5c6630cac9b25295e5d6c0730
+  data.tar.gz: 35ceaa2887957280d16025bf13da99d891d23685
+SHA512:
+  metadata.gz: 68a379955f1b30f03d356196495edc5bc3ba5a7f51cd6466e7723e453fcbcea5db11bad372a71fad1b6e2f9fab298af4adcc8a3cbd032bba50f8dcf6e147c01f
+  data.tar.gz: e2dd5c7b676575a23fe64207317e2af0ff00fbdc51df8f6442a2342bd8ffc4905989c11be269665a22e68f1732985704b15bbd85ae2fde09c283b685dfb36fa0

data/Guardfile

@@ -1,6 +1,8 @@
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
+notification :notifysend
+
 guard 'rspec' do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb"}

data/epl-v10.html

@@ -258,5 +258,4 @@ rights to a jury trial in any resulting litigation.</p>
 
 </body>
 
-</html>
-------------A8suzBvPzrflNqC2kT6WbM--
+</html>

data/lib/permissioner/controller_additions.rb

@@ -2,7 +2,7 @@ module Permissioner
   module ControllerAdditions
 
     def self.included(base)
-      base.helper_method :allow_action?, :allow_attribute?
+      base.helper_method :allow_action?, :allow_attribute?, :permission_service
       base.delegate :allow_action?, :allow_attribute?, to: :permission_service
     end
 
@@ -16,12 +16,11 @@ module Permissioner
     end
 
     def permission_service
-      @permission_service ||= PermissionService.create(current_user)
+      @permission_service ||= PermissionService.new(current_user)
     end
 
     def current_resource
       nil
     end
-
   end
 end

data/lib/permissioner/matchers.rb

@@ -9,8 +9,8 @@ RSpec::Matchers.define :allow_attribute do |*args|
     permission_service.allow_attribute?(*args)
   end
 end
-RSpec::Matchers.define :passed_filters do |*args|
+RSpec::Matchers.define :pass_filters do |controller, action, params={}|
   match do |permission_service|
-    permission_service.passed_filters?(*args)
+    permission_service.passed_filters?(controller, action, params)
   end
 end

data/lib/permissioner/permission_configurer.rb

@@ -26,28 +26,16 @@ module Permissioner
   #
   module PermissionConfigurer
 
-    attr_accessor :current_user, :permission_service
+    attr_reader :current_user, :permission_service
     delegate :allow_actions, :allow_attributes, :add_filter, to: :permission_service
 
-    module ClassMethods
 
-      # Calling this method is the only intended way for creating an instance of the including class. It ensures the
-      # correct initialization and configurations of the permissions.
-      #
-      # Expects the an instance of a class including module Permissioner::PermissionServiceAdditions acting as
-      # permission service and current signed in user.
-      #
-      def create permission_service, current_user
-        permission_configurer= self.new
-        permission_configurer.permission_service = permission_service
-        permission_configurer.current_user = current_user
-        permission_configurer.configure_permissions
-        permission_configurer
-      end
-    end
-
-    def self.included(base)
-      base.extend(ClassMethods)
+    # Expects an instance of a class including module Permissioner::PermissionServiceAdditions acting as
+    # permission service and current signed in user.
+    def initialize permission_service, current_user
+      @permission_service = permission_service
+      @current_user = current_user
+      configure_permissions
     end
 
     # Should be overwritten by the including class and is called during initialization in ::create.

data/lib/permissioner/permission_service_additions.rb

@@ -1,21 +1,13 @@
 module Permissioner
   module PermissionServiceAdditions
 
-    module ClassMethods
-
-      def create current_user
-        permission_service = self.new
-        permission_service.current_user = current_user
-        permission_service.configure_permissions
-        permission_service
-      end
-    end
+    attr_accessor :current_user
 
-    def self.included(base)
-      base.extend(ClassMethods)
+    def initialize current_user=nil
+      @current_user = current_user
+      configure_permissions
     end
 
-    attr_accessor :current_user
 
     def allow_action?(controller, action, resource = nil)
       allowed = @allow_all || (@allowed_actions && @allowed_actions[[controller.to_s, action.to_s]])
@@ -55,7 +47,7 @@ module Permissioner
     #You can allow a single action or multiple actions at once:
     #
     #   allow_actions :comments, :index
-    #   allow_acitons [:comments, :posts], [:index, :create, :update]
+    #   allow_actions [:comments, :posts], [:index, :create, :update]
     #
     #If a block is given it is stored for the given action and will be evaluated every time the authorization for the
     #action runs. If the block returns true the action is allowed otherwise not. The current_resource will be put
@@ -74,7 +66,11 @@ module Permissioner
       @allowed_attributes ||= {}
       Array(resources).each do |resource|
         @allowed_attributes[resource] ||= []
-        @allowed_attributes[resource] += Array(attributes)
+        if attributes.is_a?(Hash)
+          @allowed_attributes[resource] << attributes
+        else
+          @allowed_attributes[resource] += Array(attributes)
+        end
       end
     end
 
@@ -89,11 +85,11 @@ module Permissioner
       end
     end
 
-    # Configures permissions by calling the factory method ::create on the given class which is intended to include
+    # Configures permissions by instantiate a new object of the given class which is intended to include
     # the module Permissioner::PermissionConfigurer.
     #
     def configure configurer_class
-      configurer_class.create(self, current_user)
+      configurer_class.new(self, current_user)
     end
 
     # Should be overwritten by the including class and is called during initialization in ::create.

data/lib/permissioner/version.rb

@@ -1,3 +1,3 @@
 module Permissioner
-  VERSION = "0.0.1.beta"
+  VERSION = "0.0.2.beta"
 end

data/permissioner.gemspec

@@ -8,8 +8,10 @@ Gem::Specification.new do |gem|
   gem.version = Permissioner::VERSION
   gem.authors = ["Daniel Grawunder, Christian Mierich"]
   gem.email = ["gramie.sw@gmail.com"]
-  gem.description = %q{A Ruby on Rails authorization gem}
+  gem.homepage = "https://github.com/gramie-sw/permissioner"
+  gem.description = %q{A Ruby on  Rails authorization gem}
   gem.summary = %q{An easy to use authorization solution for Ruby on Rails.}
+  gem.license = "EPL 1.0"
 
   gem.files = `git ls-files`.split($/)
   gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
@@ -18,5 +20,5 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency "rspec", "~> 2.13"
   gem.add_development_dependency "activesupport", "~>3.2"
-  gem.add_development_dependency "guard-rspec", "~>2.6.0"
+  gem.add_development_dependency "guard-rspec", "~>3.0.1"
 end

data/spec/permissioner/controller_additions_spec.rb

@@ -16,8 +16,8 @@ describe Permissioner::ControllerAdditions do
       @clazz = Class.new
     end
 
-    it 'should delegate helper methods to permission service' do
-      @clazz.should_receive(:helper_method).with(:allow_action?, :allow_attribute?)
+    it 'should set view helpers' do
+      @clazz.should_receive(:helper_method).with(:allow_action?, :allow_attribute?, :permission_service)
       @clazz.send(:include, Permissioner::ControllerAdditions)
     end
 
@@ -85,14 +85,14 @@ describe Permissioner::ControllerAdditions do
       permission_service_1.should eq permission_service_2
     end
 
-    it 'should create PermissionService by calling PermissionService::create' do
-      PermissionService.should_receive(:create)
+    it 'should create PermissionService by calling PermissionService::new' do
+      PermissionService.should_receive(:new)
       @controller.permission_service
     end
 
-    it 'should pass current_user to PermissionService::create' do
+    it 'should pass current_user to PermissionService::initialize' do
       @controller.should_receive(:current_user).and_return('current_user')
-      PermissionService.should_receive(:create).with('current_user')
+      PermissionService.should_receive(:new).with('current_user')
       @controller.permission_service
     end
   end
@@ -103,5 +103,4 @@ describe Permissioner::ControllerAdditions do
       @controller.current_resource.should be_nil
     end
   end
-
 end

data/spec/permissioner/matchers_spec.rb

@@ -32,16 +32,21 @@ describe 'matchers' do
     end
   end
 
-  describe 'passed_filters' do
+  describe 'pass_filters' do
 
-    it 'should delegate call to PermissionService#allow_action?' do
-      @permission_service.should_receive(:passed_filters?).with(:comment, :user_id, :text).and_return(true)
-      @permission_service.should passed_filters :comment, :user_id, :text
+    it 'should delegate call to PermissionService#passed_filters?' do
+      @permission_service.should_receive(:passed_filters?).with(:comment, :user_id, :block).and_return(true)
+      @permission_service.should pass_filters :comment, :user_id, :block
     end
 
-    it 'should return false when PermissionService#allow_action? returns false' do
+    it 'should return false when PermissionService#passed_filters? returns false' do
       @permission_service.should_receive(:passed_filters?).and_return(false)
-      @permission_service.should_not passed_filters
+      @permission_service.should_not pass_filters
+    end
+
+    it 'should set empty Hash as default value for params argument' do
+      @permission_service.should_receive(:passed_filters?).with(:comment, :user_id, {}).and_return(true)
+      @permission_service.should pass_filters :comment, :user_id
     end
   end
 end

data/spec/permissioner/permission_configurer_spec.rb

@@ -2,59 +2,60 @@ require 'spec_helper'
 
 describe Permissioner::PermissionConfigurer do
 
-  before :each do
-    @permission_configurer_class = Class.new
-    @permission_configurer_class.send(:include, Permissioner::PermissionConfigurer)
-    @permissioin_configurer = @permission_configurer_class.new
+  let(:permission_configurer_class) do
+    permission_configurer_class = Class.new
+    permission_configurer_class.send(:include, Permissioner::PermissionConfigurer)
+    permission_configurer_class
   end
 
   context 'delegation' do
+    let(:permission_service) { double('PermissionService') }
+    let(:permission_configurer) { permission_configurer_class.new(permission_service, 'current_user') }
 
     it 'should delegate call to allow_actions to permission_service' do
-      @permissioin_configurer.should_receive(:allow_actions).with(:comments, :index)
-      @permissioin_configurer.allow_actions(:comments, :index)
+      permission_service.should_receive(:allow_actions).with(:comments, :index)
+      permission_configurer.allow_actions(:comments, :index)
     end
 
     it 'should delegate call to allow_attributes to permission_service' do
-      @permissioin_configurer.should_receive(:allow_attributes).with(:comment, [:user_id, :text])
-      @permissioin_configurer.allow_attributes(:comment, [:user_id, :text])
+      permission_service.should_receive(:allow_attributes).with(:comment, [:user_id, :text])
+      permission_configurer.allow_attributes(:comment, [:user_id, :text])
     end
 
     it 'should delegate call to add_filter to permission_service' do
-      @permissioin_configurer.should_receive(:add_filter).with(:comments, :create, Proc.new {})
-      @permissioin_configurer.add_filter(:comments, :create, Proc.new {})
+      block = Proc.new {}
+      permission_service.should_receive(:add_filter).with(:comments, :create, &block)
+      permission_configurer.add_filter(:comments, :create, &block)
     end
   end
 
-  describe '::included' do
+  context 'setters' do
+    subject(:permission_configurer){ permission_configurer_class.new(nil, nil) }
 
-    it 'should extend including class with module Permissioner::PermissionConfigurer::ClassMethods' do
-      clazz = Class.new
-      clazz.should_receive(:extend).with(Permissioner::PermissionConfigurer::ClassMethods)
-      clazz.send(:include, Permissioner::PermissionConfigurer)
+    it 'should respond_to permission_service' do
+      should respond_to(:permission_service)
     end
-  end
-  
-  describe '::create' do
 
-    it 'should return permission_service instance' do
-      permission_service = @permission_configurer_class.create(nil, nil)
-      permission_service.class.included_modules.should include(Permissioner::PermissionConfigurer)
+    it 'should respond_to current_user' do
+      should respond_to(:current_user)
     end
+  end
+
+  describe '#initialize' do
 
     it 'should set permission_service' do
-      @permission_configurer_class.any_instance.should_receive(:permission_service=).with('permission_service')
-      @permission_configurer_class.create('permission_service', nil)
+      permission_configurer = permission_configurer_class.new('permission_service', nil)
+      permission_configurer.permission_service.should eq 'permission_service'
     end
 
     it 'should set current_user' do
-      @permission_configurer_class.any_instance.should_receive(:current_user=).with('current_user')
-      @permission_configurer_class.create(nil, 'current_user')
+      permission_configurer = permission_configurer_class.new(nil, 'current_user')
+      permission_configurer.current_user.should eq 'current_user'
     end
 
     it 'should call configure_permissions current_user' do
-      @permission_configurer_class.any_instance.should_receive(:configure_permissions)
-      @permission_configurer_class.create(nil, nil)
+      permission_configurer_class.any_instance.should_receive(:configure_permissions)
+      permission_configurer_class.new(nil, nil)
     end
   end
 end

data/spec/permissioner/permission_service_additions_spec.rb

@@ -2,61 +2,45 @@ require 'spec_helper'
 
 describe Permissioner::PermissionServiceAdditions do
 
-  before :each do
-    @permission_service_class = Class.new
-    @permission_service_class.send(:include, Permissioner::PermissionServiceAdditions)
-    @permission_service = @permission_service_class.new
+  let(:permission_service_class) do
+    permission_service_class = Class.new
+    permission_service_class.send(:include, Permissioner::PermissionServiceAdditions)
+    permission_service_class
   end
 
-  describe '::included' do
+  let(:permission_service) { permission_service_class.new }
 
-    it 'should extend including class with module Permissioner::PermissionServiceAdditions::ClassMethods' do
-      clazz = Class.new
-      clazz.should_receive(:extend).with(Permissioner::PermissionServiceAdditions::ClassMethods)
-      clazz.send(:include, Permissioner::PermissionServiceAdditions)
-    end
-  end
-
-  describe '::create' do
+  describe '#initialize' do
 
-    before :each do
-      @permission_service_class.any_instance.stub(:configure_permissions)
-    end
-
-    it 'should return permission_service instance' do
-      permission_service = @permission_service_class.create(nil)
-      permission_service.class.included_modules.should include(Permissioner::PermissionServiceAdditions)
+    it 'should call configure_permissions' do
+      permission_service_class.any_instance.should_receive(:configure_permissions).once
+      permission_service_class.new
     end
 
     it 'should set current_user' do
-      @permission_service_class.any_instance.should_receive(:current_user=).with('current_user')
-      @permission_service_class.create('current_user')
-    end
-
-    it 'should call configure_permissions current_user' do
-      @permission_service_class.any_instance.should_receive(:configure_permissions)
-      @permission_service_class.create(nil)
+      permission_service = permission_service_class.new 'current_user'
+      permission_service.current_user.should eq 'current_user'
     end
   end
 
   describe '#allow_action?' do
 
     it 'should return true if @allow_all is true' do
-      @permission_service.allow_all
-      @permission_service.allow_action?(:comments, :index).should be_true
+      permission_service.allow_all
+      permission_service.allow_action?(:comments, :index).should be_true
     end
 
     context 'when no block given' do
 
       it 'should return true if given action allowed' do
-        @permission_service.allow_actions :comments, :index
-        @permission_service.allow_action?(:comments, :index).should be_true
+        permission_service.allow_actions :comments, :index
+        permission_service.allow_action?(:comments, :index).should be_true
       end
 
       it 'should return false if given action not allowed' do
-        @permission_service.allow_action?(:comments, :index).should be_false
-        @permission_service.allow_actions :comments, :create
-        @permission_service.allow_action?(:comments, :index).should be_false
+        permission_service.allow_action?(:comments, :index).should be_false
+        permission_service.allow_actions :comments, :create
+        permission_service.allow_action?(:comments, :index).should be_false
       end
     end
 
@@ -65,33 +49,33 @@ describe Permissioner::PermissionServiceAdditions do
       it 'should call block for given action when ressource is given' do
         block = Proc.new {}
         block.should_receive(:call)
-        @permission_service.allow_actions :comments, :index, &block
-        @permission_service.allow_action?(:comments, :index, 'resource')
+        permission_service.allow_actions :comments, :index, &block
+        permission_service.allow_action?(:comments, :index, 'resource')
       end
 
       it 'should not call block for given action but no ressource is given' do
         block = Proc.new {}
         block.should_receive(:call).never
-        @permission_service.allow_actions :comments, :index, &block
-        @permission_service.allow_action?(:comments, :index)
+        permission_service.allow_actions :comments, :index, &block
+        permission_service.allow_action?(:comments, :index)
       end
 
       it 'should return true when block returns true' do
         block = Proc.new { true }
-        @permission_service.allow_actions :comments, :index, &block
-        @permission_service.allow_action?(:comments, :index, 'resource').should be_true
+        permission_service.allow_actions :comments, :index, &block
+        permission_service.allow_action?(:comments, :index, 'resource').should be_true
       end
 
       it 'should return false when block returns false' do
         block = Proc.new { false }
-        @permission_service.allow_actions :comments, :index, &block
-        @permission_service.allow_action?(:comments, :index, 'resource').should be_false
+        permission_service.allow_actions :comments, :index, &block
+        permission_service.allow_action?(:comments, :index, 'resource').should be_false
       end
 
       it 'should return false when no ressource given' do
         block = Proc.new { true }
-        @permission_service.allow_actions :comments, :index, &block
-        @permission_service.allow_action?(:comments, :index).should be_false
+        permission_service.allow_actions :comments, :index, &block
+        permission_service.allow_action?(:comments, :index).should be_false
       end
     end
   end
@@ -99,47 +83,47 @@ describe Permissioner::PermissionServiceAdditions do
   describe '#passed_filters?' do
 
     it 'should return true when all blocks for given controller and action returns true' do
-      @permission_service.add_filter(:comments, :create, &Proc.new { true })
-      @permission_service.passed_filters?(:comments, :create, 'params').should be_true
+      permission_service.add_filter(:comments, :create, &Proc.new { true })
+      permission_service.passed_filters?(:comments, :create, 'params').should be_true
     end
 
     it 'should return true when no filters are added at all' do
-      @permission_service.passed_filters?(:comments, :create, 'params').should be_true
+      permission_service.passed_filters?(:comments, :create, 'params').should be_true
     end
 
     it 'should return true when for given controller and action no filters has been added' do
-      @permission_service.add_filter(:comments, :update, &Proc.new {})
-      @permission_service.passed_filters?(:comments, :create, 'params').should be_true
+      permission_service.add_filter(:comments, :update, &Proc.new {})
+      permission_service.passed_filters?(:comments, :create, 'params').should be_true
     end
 
     it 'should return false when at least one block for given controller and action returns false' do
-      @permission_service.add_filter(:comments, :create, &Proc.new { true })
-      @permission_service.add_filter(:comments, :create, &Proc.new { false })
-      @permission_service.add_filter(:comments, :create, &Proc.new { true })
-      @permission_service.passed_filters?(:comments, :create, 'params').should be_false
+      permission_service.add_filter(:comments, :create, &Proc.new { true })
+      permission_service.add_filter(:comments, :create, &Proc.new { false })
+      permission_service.add_filter(:comments, :create, &Proc.new { true })
+      permission_service.passed_filters?(:comments, :create, 'params').should be_false
     end
 
     it 'should pass params to the given block' do
       params = Object.new
-      @permission_service.add_filter(:comments, :create, &Proc.new { |p| p.object_id.should eq params.object_id })
-      @permission_service.passed_filters?(:comments, :create, params)
+      permission_service.add_filter(:comments, :create, &Proc.new { |p| p.object_id.should eq params.object_id })
+      permission_service.passed_filters?(:comments, :create, params)
     end
   end
 
   describe '#allow_attributes?' do
 
     it 'should return true when @allow_all is true' do
-      @permission_service.allow_all
-      @permission_service.allow_attribute?(:comment, :user_id).should be_true
+      permission_service.allow_all
+      permission_service.allow_attribute?(:comment, :user_id).should be_true
     end
 
     it 'should return true when param is allowed' do
-      @permission_service.allow_attributes(:comment, :user_id)
-      @permission_service.allow_attribute?(:comment, :user_id).should be_true
+      permission_service.allow_attributes(:comment, :user_id)
+      permission_service.allow_attribute?(:comment, :user_id).should be_true
     end
 
     it 'should return false when param not allowed' do
-      @permission_service.allow_attribute?(:comment, :user_id).should be_false
+      permission_service.allow_attribute?(:comment, :user_id).should be_false
     end
   end
 
@@ -148,41 +132,41 @@ describe Permissioner::PermissionServiceAdditions do
     it 'should call permit! on given params when @allow_all is true' do
       params = double('params')
       params.should_receive(:permit!)
-      @permission_service.allow_all
-      @permission_service.permit_params!(params)
+      permission_service.allow_all
+      permission_service.permit_params!(params)
     end
 
     it 'should call permit on allowed params' do
       params = {comment: {user_id: '12', text: 'text', date: 'date'}, post: {title: 'title', content: 'content'}}
-      @permission_service.allow_attributes(:comment, [:user_id, :text])
-      @permission_service.allow_attributes(:post, [:title, :content])
+      permission_service.allow_attributes(:comment, [:user_id, :text])
+      permission_service.allow_attributes(:post, [:title, :content])
       params[:comment].should_receive(:respond_to?).with(:permit).and_return(true)
       params[:comment].should_receive(:permit).with(:user_id, :text)
       params[:post].should_receive(:permit).with(:title, :content)
-      @permission_service.permit_params!(params)
+      permission_service.permit_params!(params)
     end
   end
 
   describe '#allow_all' do
 
     it 'should set @allow_all to true' do
-      @permission_service.allow_all
-      @permission_service.instance_variable_get(:@allow_all).should be_true
+      permission_service.allow_all
+      permission_service.instance_variable_get(:@allow_all).should be_true
     end
   end
 
   describe '#allow_actions' do
 
     it 'should add controller and action to @allowed_actions' do
-      @permission_service.allow_actions :comments, :index
-      allowed_actions = @permission_service.instance_variable_get(:@allowed_actions)
+      permission_service.allow_actions :comments, :index
+      allowed_actions = permission_service.instance_variable_get(:@allowed_actions)
       allowed_actions.count.should eq 1
       allowed_actions[['comments', 'index']].should be_true
     end
 
     it 'should add controllers and action to @allowed_actions when multiple given' do
-      @permission_service.allow_actions([:comments, :users], [:index, :create])
-      allowed_actions = @permission_service.instance_variable_get(:@allowed_actions)
+      permission_service.allow_actions([:comments, :users], [:index, :create])
+      allowed_actions = permission_service.instance_variable_get(:@allowed_actions)
       allowed_actions.count.should eq 4
       allowed_actions[['comments', 'index']].should be_true
       allowed_actions[['comments', 'create']].should be_true
@@ -192,8 +176,8 @@ describe Permissioner::PermissionServiceAdditions do
 
     it 'should add controllers and action to @allowed_actions and store block when given' do
       block = Proc.new {}
-      @permission_service.allow_actions(:comments, :edit, &block)
-      allowed_actions = @permission_service.instance_variable_get(:@allowed_actions)
+      permission_service.allow_actions(:comments, :edit, &block)
+      allowed_actions = permission_service.instance_variable_get(:@allowed_actions)
       allowed_actions[['comments', 'edit']].object_id.should eq block.object_id
     end
   end
@@ -201,63 +185,70 @@ describe Permissioner::PermissionServiceAdditions do
   describe '#allow_attributes' do
 
     it 'should add resource and attribute to @allowed_params' do
-      @permission_service.allow_attributes :comment, :text
-      allowed_params = @permission_service.instance_variable_get(:@allowed_attributes)
+      permission_service.allow_attributes :comment, :text
+      allowed_params = permission_service.instance_variable_get(:@allowed_attributes)
       allowed_params.count.should eq 1
       allowed_params[:comment].should eq [:text]
     end
 
-    it 'should add resource and attribute to @allowed_params if multiple given' do
-      @permission_service.allow_attributes [:comment, :post], [:user, :text]
-      allowed_params = @permission_service.instance_variable_get(:@allowed_attributes)
+    it 'should add resource and attributes to @allowed_params if multiple given' do
+      permission_service.allow_attributes [:comment, :post], [:user, :text]
+      allowed_params = permission_service.instance_variable_get(:@allowed_attributes)
       allowed_params.count.should eq 2
       allowed_params[:comment].should eq [:user, :text]
       allowed_params[:post].should eq [:user, :text]
     end
+
+    it 'should add resource and attributes to @allowed_params if attributes is a Hash' do
+      permission_service.allow_attributes :comment, {attributes: [:user, :text]}
+      allowed_params = permission_service.instance_variable_get(:@allowed_attributes)
+      allowed_params.count.should eq 1
+      allowed_params[:comment].should eq [{attributes: [:user, :text]}]
+    end
   end
 
   describe '#add_filter' do
 
     it 'should add given block to @filters addressed by controller and action' do
       block = Proc.new {}
-      @permission_service.add_filter(:comments, :create, &block)
-      filter_list = @permission_service.instance_variable_get(:@filters)[['comments', 'create']]
+      permission_service.add_filter(:comments, :create, &block)
+      filter_list = permission_service.instance_variable_get(:@filters)[['comments', 'create']]
       filter_list.count.should eq 1
       filter_list.should include block
     end
 
     it 'should add given block to @filters addressed by controller and action when multiple given' do
       block = Proc.new {}
-      @permission_service.add_filter([:comments, :posts], [:create, :update], &block)
-      @permission_service.instance_variable_get(:@filters)[['comments', 'create']].should include block
-      @permission_service.instance_variable_get(:@filters)[['comments', 'update']].should include block
-      @permission_service.instance_variable_get(:@filters)[['posts', 'create']].should include block
-      @permission_service.instance_variable_get(:@filters)[['posts', 'update']].should include block
+      permission_service.add_filter([:comments, :posts], [:create, :update], &block)
+      permission_service.instance_variable_get(:@filters)[['comments', 'create']].should include block
+      permission_service.instance_variable_get(:@filters)[['comments', 'update']].should include block
+      permission_service.instance_variable_get(:@filters)[['posts', 'create']].should include block
+      permission_service.instance_variable_get(:@filters)[['posts', 'update']].should include block
     end
 
     it 'should add multiple blocks to @filters addressed by controller and action' do
       block_1 = Proc.new { 'block 1' }
       block_2 = Proc.new { 'block 2' }
-      @permission_service.add_filter(:comments, :create, &block_1)
-      @permission_service.add_filter(:comments, :create, &block_2)
-      filter_list = @permission_service.instance_variable_get(:@filters)[['comments', 'create']]
+      permission_service.add_filter(:comments, :create, &block_1)
+      permission_service.add_filter(:comments, :create, &block_2)
+      filter_list = permission_service.instance_variable_get(:@filters)[['comments', 'create']]
       filter_list.count.should eq 2
       filter_list.should include block_1
       filter_list.should include block_2
     end
 
     it 'should rails exception when no block given' do
-      expect { @permission_service.add_filter(:comments, :index) }.to raise_error('no block given')
+      expect { permission_service.add_filter(:comments, :index) }.to raise_error('no block given')
     end
   end
 
   describe 'configure' do
 
-    it 'should call create on the given configurer class' do
-    @permission_service.stub(:current_user).and_return('current_user')
-    configurer_class = double('permission_configurer')
-    configurer_class.should_receive(:create).with(@permission_service, 'current_user')
-    @permission_service.configure(configurer_class)
+    it 'should create new instance of given configurer class' do
+      permission_service.stub(:current_user).and_return('current_user')
+      configurer_class = double('permission_configurer')
+      configurer_class.should_receive(:new).with(permission_service, 'current_user')
+      permission_service.configure(configurer_class)
+    end
   end
-end
 end

data/spec/spec_helper.rb

@@ -5,6 +5,5 @@ require 'permissioner/matchers'
 
 
 class PermissionService
-
   include Permissioner::PermissionServiceAdditions
 end

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: permissioner
 version: !ruby/object:Gem::Version
-  version: 0.0.1.beta
-  prerelease: 6
+  version: 0.0.2.beta
 platform: ruby
 authors:
 - Daniel Grawunder, Christian Mierich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-09 00:00:00.000000000 Z
+date: 2013-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,20 +41,18 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 3.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.6.0
-description: A Ruby on Rails authorization gem
+        version: 3.0.1
+description: A Ruby on  Rails authorization gem
 email:
 - gramie.sw@gmail.com
 executables: []
@@ -89,29 +82,29 @@ files:
 - spec/permissioner/permission_configurer_spec.rb
 - spec/permissioner/permission_service_additions_spec.rb
 - spec/spec_helper.rb
-homepage: 
-licenses: []
+homepage: https://github.com/gramie-sw/permissioner
+licenses:
+- EPL 1.0
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>'
+  - - '>'
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: An easy to use authorization solution for Ruby on Rails.
 test_files:
 - spec/permissioner/controller_additions_spec.rb