permisi 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '082297c3c88cb77bf0fe05e8c855d27d8bd5293c7db4d55cc3f0a6e0b982ac84'
-  data.tar.gz: caa2bef94cfaba331a10e5f27ee45c0d8256690139f3de39447d1d515ad3daa0
+  metadata.gz: 4b56c15224ab819fd173b51ce3cd341836a9edcbf6d2a0c0496813826c168f4c
+  data.tar.gz: 1eb2ef335b4fa1a2790573ca118c9178cff6d96ef6d3334cc165650c216bbc97
 SHA512:
-  metadata.gz: c06509c2a113376920a1f41f6382f2542642c5ca83a1f37b330b28474f426566a3a526942417345a6ba7c4860dc87cd4744c669f2535f15f25f216cec61cf5b6
-  data.tar.gz: 2f497885ec26787708b26900576d95c5ee2ff127b1d48f14560ddd5826edfcc0c01bbd6018a06bc05212e8ab73495cdbe1d1979902acefcfa88c34d9e819ddbe
+  metadata.gz: 9e099b2453555f7da80bfef2c4948a80523625271ba9666d2c053e455b0c42dc90d53f7f4a7233e1572696d58c7f1553dbdcaf38f9a4d6e351432a98de21d3ae
+  data.tar.gz: ea49a2fa692188d5864da2322a37c01de5856fb3d5bb4529966328f45e2ccc0114119c07289fa12c68afffc7f9e2030db99a10815480f180f3ea17fccd082218

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+# 0.1.4
+
+[_View the docs._](https://github.com/ukazap/permisi/blob/v0.1.4/README.md)
+
+- Add actor-role uniqueness constraint (previously it was possible to append the same role to an actor many times), if you are upgrading from previous versions, please create the following migration: `add_index :permisi_actor_roles, [:actor_id, :role_id], unique: true`
+- Show warning when calling "roles.delete" because it won't invalidate the cache
+
 # 0.1.3
 
 [_View the docs._](https://github.com/ukazap/permisi/blob/v0.1.3/README.md)

data/Gemfile

@@ -6,9 +6,9 @@ source "https://rubygems.org"
 gemspec
 
 gem "byebug", "~> 11.1"
+gem "codecov", "~> 0.4.3"
 gem "rake", "~> 13.0"
 gem "rspec", "~> 3.0"
 gem "rubocop", "~> 1.9"
 gem "simplecov", "~> 0.21.2"
 gem "sqlite3", "~> 1.4"
-gem "codecov", "~> 0.4.3"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    permisi (0.1.3)
+    permisi (0.1.4)
       activemodel (>= 3.2.0)
       activerecord (>= 3.2.0)
       activesupport (>= 3.2.0)

data/lib/generators/permisi/templates/migration.rb

@@ -18,6 +18,8 @@ class CreatePermisiTables < ActiveRecord::Migration<%= migration_version %>
       t.belongs_to :actor
       t.belongs_to :role
     end
+
+    add_index :permisi_actor_roles, [:actor_id, :role_id], unique: true
   end
 
   def down

data/lib/permisi/backend/active_record/actor.rb

@@ -6,10 +6,14 @@ module Permisi
       class Actor < ::ActiveRecord::Base
         belongs_to :aka, polymorphic: true, touch: true
         has_many :actor_roles, dependent: :destroy
-        has_many :roles, through: :actor_roles
+        has_many :roles, -> { distinct }, through: :actor_roles
 
         after_commit :reset_permissions
 
+        def roles
+          super.extend(ActorRolesCollectionProxy)
+        end
+
         def role?(role_slug)
           roles.load.any? { |role| role.slug == role_slug.to_s }
         end
@@ -38,6 +42,19 @@ module Permisi
 
         alias may? may_i?
         alias has_role? role?
+
+        module ActorRolesCollectionProxy
+          def <<(new_role)
+            super
+          rescue ::ActiveRecord::RecordNotUnique
+            self
+          end
+
+          def delete(*records)
+            warn "WARNING: `#delete(*records)` won't invalidate the cache, use `#destroy(*records)` instead."
+            super
+          end
+        end
       end
     end
   end

data/lib/permisi/config.rb

@@ -15,6 +15,16 @@ module Permisi
 
     def backend=(chosen_backend)
       chosen_backend = "::Permisi::Backend::#{chosen_backend.to_s.classify}".constantize if chosen_backend.is_a? Symbol
+
+      if chosen_backend == Backend::ActiveRecord && VERSION == "0.1.4"
+        warn <<~MESSAGE
+
+          WARNING: If you are upgrading from Permisi >v0.1.4, please create the following migration:
+          `add_index :permisi_actor_roles, [:actor_id, :role_id], unique: true`
+
+        MESSAGE
+      end
+
       @backend = chosen_backend
     rescue NameError
       raise Backend::InvalidBackend

data/lib/permisi/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Permisi
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: permisi
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Ukaza Perdana
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-22 00:00:00.000000000 Z
+date: 2021-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel