perf_check 0.7.5 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d095bb79a78a7359752c359b1d2aa7522f5940e3
-  data.tar.gz: dee373ee12cff0dfc9768569631e72b310e30dd3
+  metadata.gz: a0d9ae6fc8c0d7d6581b8c8202f82bd7b2cf6f1e
+  data.tar.gz: cdec3df9f3dc51ad2b329c652dffe1154f0f80a3
 SHA512:
-  metadata.gz: 5a68878b499d72dedf356b3f4b4d256ce20c4b8d6765eb9061de50361f386922633cdb9f40de20cdebdfdb2284e480031fcffdd0f11ebcf69cef1eeaa81a9baa
-  data.tar.gz: 267b3de573f6fa941ff4dcd2f81d00a31c6cc7459669f87d241674906a670e5de1db8f792c4e958ca4a91eca8c3a3cef92851d6f426d11779bdf063962da4ea7
+  metadata.gz: dcb0b85c4ff22bb9dd0cd7084b513b55942e74d2a18c24fd009cab27d7f0bbd95d241119e48679ce0f9becf96abaf9da6bbb9b74305017ea3eb210a06ffe0eb5
+  data.tar.gz: 3647a68aac43d4bd6f63678c988988de348c69ea276288d5966caef248ebe82f8226690e1d3ad0385df8bfc8cc4d5b8ab3dd56d3eff33d4b276003f7f7ef7297

data/bin/perf_check

@@ -18,7 +18,7 @@ app_root =
 
 
 if File.exists?("#{app_root}/tmp/pids/server.pid")
-  abort("It looks like a rails server is already running. Shut it down before continuing with perf_check.")
+  abort("It looks like a rails server is already running. Shut it down or remove the pid in tmp/pids/server.pid before continuing with perf_check.")
 end
 
 perf_check = PerfCheck.new(app_root).tap(&:load_config)

data/lib/perf_check/git.rb

@@ -93,7 +93,7 @@ class PerfCheck
     private
 
     def current_migrations_not_on_master
-      exec("git diff origin/master --name-only --diff-filter=A db/migrate/").
+      exec("git diff master --name-only --diff-filter=A db/migrate/").
         split.reverse
     end
 

data/lib/perf_check/middleware.rb

@@ -1,3 +1,5 @@
+require 'securerandom'
+
 class PerfCheck
   class Middleware
     attr_reader :app
@@ -17,21 +19,26 @@ class PerfCheck
 
       begin
         status, headers, body = app.call(env)
-      rescue ::Exception => e
-        trace_file = "#{Rails.root}/tmp/perf_check_traces" <<
-                     "/trace-#{SecureRandom.hex(16)}.txt"
-        FileUtils.mkdir_p(File.dirname(trace_file))
-
-        File.open(trace_file, 'w') do |f|
-          f.puts("#{e.class}: #{e.message}")
-          f.write(e.backtrace.join("\n"))
-        end
-        status, headers, body = 500, {"X-PerfCheck-StackTrace" => trace_file}, ['']
+      rescue => error
+        status, headers, body = 500, { "X-PerfCheck-StackTrace" => stacktrace_for(error) }, ['']
       end
-
       headers['X-PerfCheck-Query-Count'] = query_count.to_s
-
       [status, headers, body]
     end
+
+    # These files are used by the perf_check daemon app
+    def stacktrace_for(e)
+      trace_file = "#{Rails.root}/tmp/perf_check_traces" <<
+                   "/trace-#{SecureRandom.hex(16)}.txt"
+      FileUtils.mkdir_p(File.dirname(trace_file))
+
+      File.open(trace_file, 'w') do |f|
+        f.puts("#{e.class}: #{e.message}")
+        f.write(e.backtrace.join("\n"))
+      end
+      trace_file
+    end
+
+
   end
 end

data/lib/perf_check/railtie.rb

@@ -24,7 +24,7 @@ class PerfCheck
       end
 
       require 'perf_check/middleware'
-      app.middleware.use PerfCheck::Middleware
+      app.middleware.insert_before 0, PerfCheck::Middleware
     end
   end
 end

data/lib/perf_check/test_case.rb

@@ -76,7 +76,7 @@ class PerfCheck
     end
 
     def speedup_factor
-      reference_latency / this_latency
+      reference_latency.to_f / this_latency.to_f
     end
 
     def response_diff

data/lib/perf_check.rb

@@ -13,7 +13,7 @@ class PerfCheck
   attr_reader :app_root, :options, :git, :server, :test_cases
   attr_accessor :logger
 
-  def initialize(app_root, log: STDERR)
+  def initialize(app_root)
     @app_root = app_root
 
     @options = OpenStruct.new(
@@ -31,7 +31,7 @@ class PerfCheck
       json: false
     )
 
-    @logger = Logger.new(log).tap do |logger|
+    @logger = Logger.new(STDERR).tap do |logger|
       logger.formatter = proc do |severity, datetime, progname, msg|
         "[#{datetime.strftime("%Y-%m-%d %H:%M:%S")}] #{msg}\n"
       end
@@ -51,7 +51,7 @@ class PerfCheck
       begin
         Dir.chdir(app_root)
         load "#{app_root}/config/perf_check.rb"
-      rescue ::Exception => e
+      rescue LoadError => e
         error = ConfigLoadError.new(e.message)
         error.set_backtrace(e.backtrace)
         raise error
@@ -84,14 +84,14 @@ class PerfCheck
         (git.pop rescue nil) if git.stashed?
       end
 
-      cbdata = {}
+      callbacks = {}
 
       if $!
-        cbdata[:error_message] = "#{$!.class}: #{$!.message}\n"
-        cbdata[:error_message] << $!.backtrace.map{|x| "\t#{x}"}.join("\n")
+        callbacks[:error_message] = "#{$!.class}: #{$!.message}\n"
+        callbacks[:error_message] << $!.backtrace.map{|x| "\t#{x}"}.join("\n")
       end
 
-      trigger_when_finished_callbacks(cbdata)
+      trigger_when_finished_callbacks(callbacks)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: perf_check
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.8.0
 platform: ruby
 authors:
 - rubytune
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-30 00:00:00.000000000 Z
+date: 2017-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -42,30 +42,44 @@ dependencies:
   name: colorize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: diffy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.5
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.5
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email: 
 executables:
@@ -103,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: PERF CHECKKK!