perf_check 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff2a870f80503656b1009c03e5d9f70863816e07
-  data.tar.gz: 2e4be555c0c5e49ae514e5ca189e2d70fb393f3f
+  metadata.gz: 6733d94e8539da19fc3c00d781e5fe6e530e90f5
+  data.tar.gz: 3b2e5e2f196b87ffb7a875f5addb789bc459c83d
 SHA512:
-  metadata.gz: 5fd105fa1395240e9bd01a237f8fc0635770974e7d8b19198af349cbf76423c3fabe4f9b72f4f324156598c5ec162ea314f3b91df94eacb6e32d6ffe361102b3
-  data.tar.gz: a203a96de2dffc781725bc0d5c749620ddea759e3c09cfc97a249acf5a79d4b541d8ccbb1a2a5fb4c7e869520ed70ca8df1ad1a5eab5fcd54dd9582550b18cfc
+  metadata.gz: a7a0f4b87e397f962703a4767210d07d301b565f69b2eba7d2f993e5e7c14813ec371d176159025d86f36ba7cfabd116692d3079e544099b5ccb8644d1147706
+  data.tar.gz: ea20e68e17347b6da5380fa85132aab377b30fc4abfc192db3924028fd088b06e2b0bebb2bebcb61b102d2535091236a06ac08efb34bddfbb014e0bee1bed2db

data/lib/perf_check/config.rb

@@ -53,24 +53,28 @@ class PerfCheck
         end
       end
 
-      opts.on('--verify-responses',
-              'Check whether there is a diff between the responses of this and the reference branch') do
-        options.verify_responses = true
-      end
-
       opts.on('--brief', '-b') do
         options.brief = true
       end
 
+      opts.on('--verify-no-diff',
+              'Check whether there is a diff between the responses of this and the reference branch') do
+        options.verify_no_diff = true
+      end
+
      opts.on('--diff') do
        options.diff = true
        options.brief = true
-       options.verify_responses = true
+       options.verify_no_diff = true
        options.number_of_requests = 1
      end
 
-      opts.separator ''
-      opts.separator <<EOF
+     opts.on("--diff-option OPT") do |opt|
+       options.diff_options << opt
+     end
+
+     opts.separator ''
+     opts.separator <<EOF
 Usage examples:
   Benchmark PostController#index against master
      perf_check /user/45/posts
@@ -84,7 +88,7 @@ Usage examples:
      perf_check /user/45/posts -r HEAD
 
   Benchmark and diff the output against master
-     perf_check /user/45/posts --verify-responses
+     perf_check /user/45/posts --verify-no-diff
 
   Just diff the output on your branch with master
      perf_check /user/45/posts --diff
@@ -96,9 +100,4 @@ EOF
       opts.separator ''
     end
   end
-
-  def diff_options
-    @diff_options ||=
-      ['-U3', '--ignore-matching-lines=/mini-profiler-resources/includes.js']
-  end
 end

data/lib/perf_check/output.rb

@@ -20,7 +20,7 @@ class PerfCheck
       puts && next if test.reference_profiles.empty?
 
       print(sprintf(' (%+5.1fms)', test.latency_difference).bold)
-      print_diff_results(test.response_diff) if options.verify_responses
+      print_diff_results(test.response_diff) if options.verify_no_diff
       puts
     end
   end
@@ -63,7 +63,7 @@ class PerfCheck
       puts("your branch: ".rjust(15)+ "#{this_latency}")
       puts(("change: ".rjust(15)    + "#{formatted_change}").bold.send(color))
 
-      print_diff_results(test.response_diff) if options.verify_responses
+      print_diff_results(test.response_diff) if options.verify_no_diff
     end
   end
 end

data/lib/perf_check/server.rb

@@ -103,7 +103,7 @@ class PerfCheck
 
     def start
       ENV['PERF_CHECK'] = '1'
-      if perf_check.options.verify_responses
+      if perf_check.options.verify_no_diff
         ENV['PERF_CHECK_VERIFICATION'] = '1'
       end
       unless perf_check.options.caching

data/lib/perf_check/test_case.rb

@@ -25,7 +25,7 @@ class PerfCheck
         profile = issue_request(server, options)
         next if i.zero? # first request just warms up the server
 
-        if options.verify_responses && i == 1
+        if options.verify_no_diff && i == 1
           response_for_comparison(profile.response_body)
         end
 
@@ -82,15 +82,14 @@ class PerfCheck
     def response_diff
       diff = Diffy::Diff.new(reference_response, this_response,
                              include_diff_info: true,
-                             diff: perf_check.diff_options)
+                             diff: perf_check.options.diff_options)
       if diff.to_s.empty?
         OpenStruct.new(:changed? => false)
       else
         FileUtils.mkdir_p("#{perf_check.app_root}/tmp/perf_check/diffs")
         file = `mktemp -u "#{perf_check.app_root}/tmp/perf_check/diffs/XXXXXXXXX"`.strip
-        [:text, :html].each do |format|
-          ext = {:text => 'diff', :html => 'html'}[format]
-          File.open("#{file}.#{ext}", 'w'){ |f| f.write(diff.to_s(format)) }
+        File.open("#{file}.diff", "w") do |f|
+          f.write(diff.to_s(:text).lines[2..-1].join)
         end
         OpenStruct.new(:changed? => true, :file => "#{file}.diff")
       end

data/lib/perf_check.rb

@@ -22,7 +22,11 @@ class PerfCheck
       cookie: nil,
       headers: {},
       http_statuses: [200],
-      verify_responses: false,
+      verify_no_diff: false,
+      diff: false,
+      diff_options: ['-U3',
+                     '--ignore-matching-lines=/mini-profiler-resources/includes.js'],
+      brief: false,
       caching: true,
       json: false
     )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: perf_check
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - rubytune
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: colorize
   requirement: !ruby/object:Gem::Requirement