percy-common 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da785e6e731d99a3e9a2443232e3dafc8f9e7139
-  data.tar.gz: 662d50ea490653c199ca08a243348e0c41340bae
+  metadata.gz: 711a2ac9579789989cc96bb04e0f0b3b4449be39
+  data.tar.gz: 53358f2998aaaba1f64178c2bf948792656791c8
 SHA512:
-  metadata.gz: 101b3fda6f5c3fe97a81e6539eb5bbdd7f77ae720ebe19a808fe91d0231d6f5e7376291a12ce1091339c03c5a498a8fb6fc2e1113fb340ac8a2c38d77dde1a98
-  data.tar.gz: 4d23ec8e50cba05655c1dad3a3396d556bcb4904d21df120d2622e1f60f147d4073b99050ffd7ca2441d8156a8e6a3cfe4c118207c5bc5718c715eea68dbbfc3
+  metadata.gz: 001cb2a5c604a329b26ecbe8b80d78e6a773dc40ab4a0df2baac28c0820938d32eb32bd86ec2d03f3b838cfaad3e3f4e2f316c3a52d7da1696e3ab025dc19981
+  data.tar.gz: b77f16727712ee9c572478917d4b09f6f2e2a62c60f25189c0efba0f62446097f7c74e5d6ed2a4a04531e1efeed39730f6ecee6e6625920ac2803f0d0c178402

data/lib/percy/common/version.rb

@@ -1,5 +1,5 @@
 module Percy
   module Common
-    VERSION = '1.4.0'.freeze
+    VERSION = '1.4.1'.freeze
   end
 end

data/lib/percy/network_helpers.rb

@@ -3,14 +3,29 @@ require 'excon'
 
 module Percy
   class NetworkHelpers
+    MIN_PORT = 1_024 # 0-1023 are not available without privilege
+    MAX_PORT = 65_535 # (2^16) -1
+    MAX_PORT_ATTEMPTS = 50
+
     class ServerDown < RuntimeError; end
+    class OpenPortNotFound < RuntimeError; end
 
     def self.random_open_port
-      # Using a port of "0" relies on the system to pick an open port.
-      server = TCPServer.new('127.0.0.1', 0)
-      port = server.addr[1]
-      server.close
-      port
+      MAX_PORT_ATTEMPTS.times do
+        port = rand(MIN_PORT..MAX_PORT)
+        return port if port_open? port
+      end
+
+      raise OpenPortNotFound
+    end
+
+    def self.port_open?(port)
+      begin
+        TCPServer.new(port).close
+        true
+      rescue Errno::ECONNREFUSED, Errno::EHOSTUNREACH, Errno::EADDRINUSE
+        false
+      end
     end
 
     def self.verify_healthcheck(url:, expected_body: 'ok', retry_wait_seconds: 0.5)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-common
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-08 00:00:00.000000000 Z
+date: 2017-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dogstatsd-ruby
@@ -166,7 +166,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Server-side common library for Percy.