percy-client 1.13.5 → 1.13.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e0d958dccb6268ab3679e448bf45263d1fac005
-  data.tar.gz: 2ae421a83b94e20b1bf7c32e2b0e2e980eb1e4e2
+  metadata.gz: dd84cf9ac38282cc0057f714197b65e0e75a8122
+  data.tar.gz: 01f640d98197a7e4a34b0f09b33d31e8e05e7900
 SHA512:
-  metadata.gz: 0918a1918c049d77188323d387f33bbd83a4aa6ed0e947911564732034849e97581e62404f516962ab97a88f3095792ae4fb3683cdd5dad761b0c76d21abb7eb
-  data.tar.gz: 7967e3894498c7d3ee5d2008d011a377369f938bffc936cd856b3025d9a26315dfabfa95a59f8317f5286db7c1d469ea5b24b440cc3bfe5c8d7973aac392d2a2
+  metadata.gz: 015eec97ba845a645d0a9e3f309bc4542746bc101970ae5506a6c40df5444d7948393166361a4206e33683584cc0b57d97c9a50cb5e323dc408f5b3a781e14c3
+  data.tar.gz: 5513c0a98c57e71cb980f33373d2f0aa447bd4bbdd680cebc6af1ead78c01b9af58415429d3a6f3658a006a187a7a0d4d2263a8eac1a56179671bda28a432da3

data/lib/percy/client.rb

@@ -32,18 +32,38 @@ module Percy
       end
     end
 
-    class ClientError < HttpError; end # 4xx;
-    class BadRequestError < ClientError; end # 400.
-    class UnauthorizedError < ClientError; end # 401.
-    class PaymentRequiredError < ClientError; end # 402.
-    class ForbiddenError < ClientError; end # 403.
-    class NotFoundError < ClientError; end  # 404.
-    class ConflictError < ClientError; end  # 409.
-
-    class ServerError < HttpError; end # 5xx.
-    class InternalServerError < ServerError; end # 500.
-    class BadGatewayError < ServerError; end # 502.
-    class ServiceUnavailableError < ServerError; end # 503.
+    # 4xx
+    class ClientError < HttpError; end
+
+    # 400
+    class BadRequestError < ClientError; end
+
+    # 401
+    class UnauthorizedError < ClientError; end
+
+    # 402
+    class PaymentRequiredError < ClientError; end
+
+    # 403
+    class ForbiddenError < ClientError; end
+
+    # 404
+    class NotFoundError < ClientError; end
+
+    # 409
+    class ConflictError < ClientError; end
+
+    # 5xx
+    class ServerError < HttpError; end
+
+    # 500
+    class InternalServerError < ServerError; end
+
+    # 502
+    class BadGatewayError < ServerError; end
+
+    # 503
+    class ServiceUnavailableError < ServerError; end
 
     attr_reader :config, :client_info, :environment_info
 

data/lib/percy/client/connection.rb

@@ -91,6 +91,9 @@ module Percy
             request.body = data.to_json
           end
         rescue Faraday::TimeoutError
+          if (retries -= 1) >= 0
+            retry
+          end
           raise Percy::Client::TimeoutError
         rescue Faraday::ConnectionFailed
           raise Percy::Client::ConnectionFailed

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '1.13.5'.freeze
+    VERSION = '1.13.6'.freeze
   end
 end

data/spec/lib/percy/client/builds_spec.rb

@@ -39,6 +39,7 @@ RSpec.describe Percy::Client::Builds, :vcr do
       expect(build['data']['relationships']['missing-resources']).to be
       expect(build['data']['relationships']['missing-resources']['data']).to_not be
     end
+
     it 'accepts optional resources' do
       resources = []
       resources << Percy::Client::Resource.new('/css/test.css', sha: sha)
@@ -64,6 +65,7 @@ RSpec.describe Percy::Client::Builds, :vcr do
         ENV['PERCY_PARALLEL_NONCE'] = 'nonce'
         ENV['PERCY_PARALLEL_TOTAL'] = '4'
       end
+
       after(:each) do
         ENV['PERCY_BRANCH'] = nil
         ENV['PERCY_TARGET_BRANCH'] = nil
@@ -71,6 +73,7 @@ RSpec.describe Percy::Client::Builds, :vcr do
         ENV['PERCY_PARALLEL_NONCE'] = nil
         ENV['PERCY_PARALLEL_TOTAL'] = nil
       end
+
       it 'passes through some attributes from environment' do
         # Whitebox test to check POST data.
         expect_any_instance_of(Percy::Client).to \
@@ -99,7 +102,8 @@ RSpec.describe Percy::Client::Builds, :vcr do
         Percy.create_build('fotinakis/percy-examples')
       end
     end
-    context 'parallel test environment' do
+
+    context 'when in a parallel test environment' do
       it 'passes through parallelism variables' do
         build = Percy.create_build(
           'fotinakis/percy-examples',
@@ -111,6 +115,7 @@ RSpec.describe Percy::Client::Builds, :vcr do
       end
     end
   end
+
   describe '#finalize_build' do
     it 'finalizes a build' do
       build = Percy.create_build('fotinakis/percy-examples')

data/spec/lib/percy/client/connection_spec.rb

@@ -94,6 +94,15 @@ RSpec.describe Percy::Client::Connection do
       expect { response }.to raise_error(Percy::Client::ConnectionFailed)
     end
 
+    context 'with retries enabled' do
+      subject(:response) { Percy.client.post(uri, {}, retries: 3) }
+
+      it 'raises an exception on retry exhaustion' do
+        stub_request(:post, uri).to_raise(Faraday::TimeoutError)
+        expect { response }.to raise_error(Percy::Client::TimeoutError)
+      end
+    end
+
     shared_examples_for 'HTTP status raises custom error class' do |http_status, error_class|
       subject(:request) { Percy.client.post(uri, {}, retries: 0) }
 

data/spec/lib/percy/client/environment_spec.rb

@@ -103,7 +103,7 @@ RSpec.describe Percy::Client::Environment do
     ENV['TRAVIS_REPO_SLUG'] = @original_env['TRAVIS_REPO_SLUG']
   end
 
-  context 'no known CI environment' do
+  context 'with no known CI environment' do
     describe '#current_ci' do
       it 'is nil' do
         expect(Percy::Client::Environment.current_ci).to be_nil
@@ -243,7 +243,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Jenkins CI' do
+  context 'when in Jenkins CI' do
     before(:each) do
       ENV['JENKINS_URL'] = 'http://localhost:8080/'
       ENV['BUILD_NUMBER'] = '111'
@@ -263,7 +263,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Travis CI' do
+  context 'when in Travis CI' do
     before(:each) do
       ENV['TRAVIS_BUILD_ID'] = '1234'
       ENV['TRAVIS_BUILD_NUMBER'] = 'build-number'
@@ -286,7 +286,7 @@ RSpec.describe Percy::Client::Environment do
       expect(Percy::Client::Environment.parallel_total_shards).to be_nil
     end
 
-    context 'Pull Request build' do
+    context ' with a pull request build' do
       before(:each) do
         ENV['TRAVIS_PULL_REQUEST'] = '256'
         ENV['TRAVIS_PULL_REQUEST_BRANCH'] = 'travis-pr-branch'
@@ -300,7 +300,7 @@ RSpec.describe Percy::Client::Environment do
       end
     end
 
-    context 'parallel build' do
+    context 'with parallel build' do
       before(:each) do
         ENV['CI_NODE_TOTAL'] = '3'
       end
@@ -312,7 +312,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Circle CI' do
+  context 'when in Circle CI' do
     before(:each) do
       ENV['CIRCLECI'] = 'true'
       ENV['CIRCLE_BRANCH'] = 'circle-branch'
@@ -334,7 +334,7 @@ RSpec.describe Percy::Client::Environment do
       expect(Percy::Client::Environment.parallel_total_shards).to be_nil
     end
 
-    context 'parallel build' do
+    context 'with a parallel build' do
       before(:each) do
         ENV['CIRCLE_NODE_TOTAL'] = '3'
       end
@@ -346,7 +346,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Codeship' do
+  context 'when in Codeship' do
     before(:each) do
       ENV['CI_NAME'] = 'codeship'
       ENV['CI_BRANCH'] = 'codeship-branch'
@@ -366,7 +366,7 @@ RSpec.describe Percy::Client::Environment do
       expect(Percy::Client::Environment.parallel_total_shards).to be_nil
     end
 
-    context 'parallel build' do
+    context 'with a parallel build' do
       before(:each) do
         ENV['CI_NODE_TOTAL'] = '3'
       end
@@ -378,7 +378,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Drone' do
+  context 'when in Drone' do
     before(:each) do
       ENV['DRONE'] = 'true'
       ENV['DRONE_COMMIT'] = 'drone-commit-sha'
@@ -395,7 +395,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Semaphore CI' do
+  context 'when in Semaphore CI' do
     before(:each) do
       ENV['SEMAPHORE'] = 'true'
       ENV['BRANCH_NAME'] = 'semaphore-branch'
@@ -418,7 +418,7 @@ RSpec.describe Percy::Client::Environment do
       expect(Percy::Client::Environment.parallel_total_shards).to be_nil
     end
 
-    context 'parallel build' do
+    context 'with a parallel build' do
       before(:each) do
         ENV['SEMAPHORE_THREAD_COUNT'] = '3'
       end
@@ -431,7 +431,7 @@ RSpec.describe Percy::Client::Environment do
     end
   end
 
-  context 'in Buildkite' do
+  context 'when in Buildkite' do
     before(:each) do
       ENV['BUILDKITE'] = 'true'
       ENV['BUILDKITE_COMMIT'] = 'buildkite-commit-sha'
@@ -450,7 +450,8 @@ RSpec.describe Percy::Client::Environment do
       expect(Percy::Client::Environment.parallel_nonce).to eq('buildkite-build-id')
       expect(Percy::Client::Environment.parallel_total_shards).to be_nil
     end
-    context 'Parallel Build' do
+
+    context 'when running a parallel build' do
       before(:each) do
         ENV['BUILDKITE_PARALLEL_JOB_COUNT'] = '3'
       end
@@ -459,7 +460,8 @@ RSpec.describe Percy::Client::Environment do
         expect(Percy::Client::Environment.parallel_total_shards).to eq(3)
       end
     end
-    context 'Pull Request build' do
+
+    context 'with a pull request build' do
       before(:each) do
         ENV['BUILDKITE_PULL_REQUEST'] = '123'
       end
@@ -467,7 +469,8 @@ RSpec.describe Percy::Client::Environment do
         expect(Percy::Client::Environment.pull_request_number).to eq('123')
       end
     end
-    context 'UI-triggered HEAD build' do
+
+    context 'with a UI-triggered HEAD build' do
       before(:each) do
         ENV['BUILDKITE_COMMIT'] = 'HEAD'
       end
@@ -476,7 +479,8 @@ RSpec.describe Percy::Client::Environment do
       end
     end
   end
-  context 'in Gitlab CI' do
+
+  context 'when in Gitlab CI' do
     before(:each) do
       ENV['GITLAB_CI'] = 'yes'
       ENV['CI_BUILD_REF'] = 'gitlab-commit-sha'
@@ -495,6 +499,7 @@ RSpec.describe Percy::Client::Environment do
       expect(Percy::Client::Environment.repo).to eq('percy/percy-client') # From git, not env.
     end
   end
+
   describe 'local git repo methods' do
     describe '#commit' do
       it 'returns current local commit data' do
@@ -510,6 +515,7 @@ RSpec.describe Percy::Client::Environment do
         expect(commit[:committer_name]).to_not be_empty
         expect(commit[:message]).to_not be_empty
       end
+
       it 'returns only branch if commit data cannot be found' do
         expect(Percy::Client::Environment).to receive(:_raw_commit_output).once.and_return(nil)
 
@@ -524,6 +530,7 @@ RSpec.describe Percy::Client::Environment do
         expect(commit[:committer_name]).to be_nil
         expect(commit[:message]).to be_nil
       end
+
       it 'handles unicode characters in environment where LANG is not set' do
         output = "COMMIT_SHA:\nAUTHOR_NAME:Spêcìal Ñàme\nAUTHOR_EMAIL:\nCOMMITTER_NAME:\n" \
           "COMMITTER_EMAIL:\nCOMMITTED_DATE:\nCOMMIT_MESSAGE:".force_encoding('US-ASCII')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 1.13.5
+  version: 1.13.6
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-07 00:00:00.000000000 Z
+date: 2017-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -166,7 +166,7 @@ files:
 - percy-client.gemspec
 - spec/cassettes/Percy_Client_Builds/_create_build/accepts_optional_resources.yml
 - spec/cassettes/Percy_Client_Builds/_create_build/creates_a_build.yml
-- spec/cassettes/Percy_Client_Builds/_create_build/parallel_test_environment/passes_through_parallelism_variables.yml
+- spec/cassettes/Percy_Client_Builds/_create_build/when_in_a_parallel_test_environment/passes_through_parallelism_variables.yml
 - spec/cassettes/Percy_Client_Builds/_finalize_build/finalizes_a_build.yml
 - spec/cassettes/Percy_Client_Resources/_upload_resource/returns_true_with_success.yml
 - spec/cassettes/Percy_Client_Snapshots/_create_snapshot/creates_a_snapshot.yml
@@ -210,7 +210,7 @@ summary: Percy::Client
 test_files:
 - spec/cassettes/Percy_Client_Builds/_create_build/accepts_optional_resources.yml
 - spec/cassettes/Percy_Client_Builds/_create_build/creates_a_build.yml
-- spec/cassettes/Percy_Client_Builds/_create_build/parallel_test_environment/passes_through_parallelism_variables.yml
+- spec/cassettes/Percy_Client_Builds/_create_build/when_in_a_parallel_test_environment/passes_through_parallelism_variables.yml
 - spec/cassettes/Percy_Client_Builds/_finalize_build/finalizes_a_build.yml
 - spec/cassettes/Percy_Client_Resources/_upload_resource/returns_true_with_success.yml
 - spec/cassettes/Percy_Client_Snapshots/_create_snapshot/creates_a_snapshot.yml