percy-client 1.13.4 → 1.13.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea5367f8b1235063a60b2f8e530b31856eb397cc
-  data.tar.gz: 452d020054cfcb829c4d3a0d111debd16c72a8d2
+  metadata.gz: 2e0d958dccb6268ab3679e448bf45263d1fac005
+  data.tar.gz: 2ae421a83b94e20b1bf7c32e2b0e2e980eb1e4e2
 SHA512:
-  metadata.gz: 3648ecf2de77ea2965924b8c32d86e3cd3b90ef3b4de8b779b327de4225c373d9bfe5b9cd3952bbcf5eed3686872ae15f4c8ff0ce3f7c3b257fc34c6844a0c53
-  data.tar.gz: 121adbe5d8e8ac6934c3863cb7fea5d22a29c766dc14517eab2c731de128b4aa572342223f4b4400363f0802001a48c3fccb2673435087c42b521771aa6791b2
+  metadata.gz: 0918a1918c049d77188323d387f33bbd83a4aa6ed0e947911564732034849e97581e62404f516962ab97a88f3095792ae4fb3683cdd5dad761b0c76d21abb7eb
+  data.tar.gz: 7967e3894498c7d3ee5d2008d011a377369f938bffc936cd856b3025d9a26315dfabfa95a59f8317f5286db7c1d469ea5b24b440cc3bfe5c8d7973aac392d2a2

data/lib/percy/client/connection.rb

@@ -5,16 +5,6 @@ require 'faraday'
 module Percy
   class Client
     module Connection
-      class NoCookiesHTTPClientAdapter < Faraday::Adapter::HTTPClient
-        def client
-          @client ||= ::HTTPClient.new
-          @client.cookie_manager = nil
-          @client.ssl_config.options |= OpenSSL::SSL::OP_NO_SSLv2
-          @client.ssl_config.options |= OpenSSL::SSL::OP_NO_SSLv3
-          @client
-        end
-      end
-
       class NiceErrorMiddleware < Faraday::Response::Middleware
         CLIENT_ERROR_STATUS_RANGE = 400...600
 
@@ -61,9 +51,8 @@ module Percy
 
         @connection = Faraday.new(url: base_url) do |faraday|
           faraday.request :token_auth, config.access_token if config.access_token
-
-          faraday.use Percy::Client::Connection::NoCookiesHTTPClientAdapter
           faraday.use Percy::Client::Connection::NiceErrorMiddleware
+          faraday.adapter :excon
         end
 
         @connection

data/lib/percy/client/environment.rb

@@ -30,7 +30,7 @@ module Percy
       # not be found.
       def self.commit
         output = _raw_commit_output(_commit_sha) if _commit_sha
-        output = _raw_commit_output('HEAD') unless output
+        output ||= _raw_commit_output('HEAD')
         output = output.force_encoding('UTF-8') if output && output.encoding.to_s == 'US-ASCII'
 
         # Use the specified SHA or, if not given, the parsed SHA at HEAD.

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '1.13.4'.freeze
+    VERSION = '1.13.5'.freeze
   end
 end

data/percy-client.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'faraday', '>= 0.9'
-  spec.add_dependency 'httpclient', '>= 2.6'
+  spec.add_dependency 'excon'
   spec.add_dependency 'addressable'
 
   spec.add_development_dependency 'bundler', '~> 1.7'

data/spec/lib/percy/client/connection_spec.rb

@@ -11,12 +11,6 @@ RSpec.describe Percy::Client::Connection do
   let(:ci_name) { 'buildkite' }
   let(:uri) { "#{Percy.config.api_url}/test" }
 
-  describe '#connection' do
-    it 'disables cookies on faraday httpclient adapter' do
-      expect(Percy.client.connection.builder.app.client.cookie_manager).to be_nil
-    end
-  end
-
   shared_examples_for 'a connection that sets headers with HTTP method' do |http_method|
     it 'sets headers' do
       stub_request(http_method, uri)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 1.13.4
+  version: 1.13.5
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-08 00:00:00.000000000 Z
+date: 2017-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -25,19 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: httpclient
+  name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement