percy-client 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e254b456d41fa6938dc166b8c385f7c1dfc7f52e
-  data.tar.gz: 5af65a8a5cd85fb8b1ffaeb8a4a48ce9c1195038
+  metadata.gz: f7bdc0235c385840d4ec620b1acc715cf4d5ff5d
+  data.tar.gz: 348d42bf9fdb3eab082dcbe7792a5ceb908c1fb1
 SHA512:
-  metadata.gz: 316652c9b3d64f932cc591f34d6ba87516ec07f1c7539105653e15c4862945779553ed24a96bf5f42c3475123a23176cd33cdc8aceafed44f3af6e4b1235cb47
-  data.tar.gz: ab05b3201073e9ee858df2063536ac6b485bd1bf51f748a05a72cb3d67b0822cf5bef936b929d8373539c0e2df1f4292de252169ccc305ffd5101bd1bcc36f3c
+  metadata.gz: ee7213d7dc36a823973ddb6aafa6d6f2245da9cfe522f913ef48a50b09d4c60f6cd61d72d1056003703afe5ea00e0034545f13b7b1cff49a5a421a75df16653c
+  data.tar.gz: d3b374b37dc133b1167b9d02c8d8bbdf16e07ab64c7f1519b653a86ae923d5b6ec5766c858f695f5dc1fb33380df76888d138e2d48aae4bc5e4103cdb0eb6532

data/lib/percy/client/connection.rb

@@ -4,7 +4,15 @@ require 'faraday'
 module Percy
   class Client
     module Connection
-      class FaradayNiceErrorMiddleware < Faraday::Response::Middleware
+      class NoCookiesHTTPClientAdapter < Faraday::Adapter::HTTPClient
+        def client
+          @client ||= ::HTTPClient.new
+          @client.cookie_manager = nil
+          @client
+        end
+      end
+
+      class NiceErrorMiddleware < Faraday::Response::Middleware
         CLIENT_ERROR_STATUS_RANGE = 400...600
 
         def on_complete(env)
@@ -26,8 +34,8 @@ module Percy
         @connection = Faraday.new(url: base_url) do |faraday|
           faraday.request :token_auth, config.access_token if config.access_token
 
-          faraday.use Faraday::Adapter::HTTPClient
-          faraday.use Percy::Client::Connection::FaradayNiceErrorMiddleware
+          faraday.use Percy::Client::Connection::NoCookiesHTTPClientAdapter
+          faraday.use Percy::Client::Connection::NiceErrorMiddleware
         end
         @connection
       end

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '0.2.4'
+    VERSION = '0.2.5'
   end
 end

data/percy-client.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'faraday'
-  spec.add_dependency 'httpclient'
+  spec.add_dependency 'faraday', '>= 0.8'
+  spec.add_dependency 'httpclient', '>= 2.3'
 
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'

data/spec/lib/percy/client/connection_spec.rb

@@ -1,4 +1,9 @@
 RSpec.describe Percy::Client::Connection do
+  describe '#connection' do
+    it 'disables cookies on faraday httpclient adapter' do
+      expect(Percy.client.connection.builder.app.client.cookie_manager).to be_nil
+    end
+  end
   describe '#get' do
     it 'performs a GET request to the api_url and parses response' do
       stub_request(:get, "#{Percy.config.api_url}/test").to_return(body: {foo: true}.to_json)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-11 00:00:00.000000000 Z
+date: 2015-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: httpclient
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement