percy-capybara 4.3.1 → 4.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4fb6fdec485db075cfc8cf93eedf339ce2a51bd46e078bc524ce085736e07b3
-  data.tar.gz: 8d1aaaf79805bdb3aa765aa7c9a6747a33e23f8c598a62c8e92a08c9690ca2c7
+  metadata.gz: 2857e24e4b2bb5152dbfa2fa8313e1a32d9162cf4b71d04deb469d064da56c66
+  data.tar.gz: a4877b279d72980a454e1fff97e050755335c73de7ae8c6b3fbd9bce822c9f02
 SHA512:
-  metadata.gz: 04f23d009a4b53172d875385ecc85fca8b9de74976f43254d9a065a89df092e3ed01ebfe6890d84d36856feef12f0ef689797e4dbdad34f2e7d47ebf6a54c376
-  data.tar.gz: 848fbd8b7f815673d4bd7ff3dcd581f5fa7e04bf5a7610be83b5c700a762b2ccf6af36ba989ac45a31712da7fdf5d8ebb14e0137ccee14b7469ce95102796021
+  metadata.gz: 4d851ffc11d4abafbd8bd8974cb25a3d39aac3b9bbb1d05a814530c351425b7c0b6c7851e97bbb9e7742e4b91907facad0d5eeaa7d78a535a3213761b48b5beb
+  data.tar.gz: 971d7643e3e8100d8ba1229c3db968134e8ccde57ad70c08b7af9d39eea72ffb2209a00f513c0c818998213aa64b0b78b3b6bd8aaa74c32c311455ee8b8c57ea

data/lib/percy.rb

@@ -77,7 +77,18 @@ module Percy
 
     begin
       page.execute_script(agent_js)
-      page.execute_script("return new window.PercyAgent({ handleAgentCommunication: false }).domSnapshot(document, #{options.to_json})")
+      domsnapshot_js = "(function() { return new window.PercyAgent({ handleAgentCommunication: false }).domSnapshot(document, #{options.to_json}) })()"
+
+      # If we can use evalaute, use it (generally for capybara drivers)
+      # `execute_script` should work, but some Capybara drivers specifically return nil from this method
+      if page.respond_to?('evaluate_script')
+        dom_snapshot = page.evaluate_script(domsnapshot_js)
+      else
+        # if the driver doesn't have evaluate, it's probably a selenium driver
+        dom_snapshot = page.execute_script(domsnapshot_js)
+      end
+
+      return dom_snapshot
     rescue => e
       self._logger.error { "DOM snapshotting failed. Error: #{e}" }
       return nil

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Percy
-  VERSION = '4.3.1'.freeze
+  VERSION = '4.3.2'.freeze
 end

data/spec/spec_helper.rb

@@ -28,6 +28,6 @@ RSpec.configure do |config|
   Kernel.srand config.seed
 
   # See https://github.com/teamcapybara/capybara#selecting-the-driver for other options
-  Capybara.default_driver = :selenium_chrome
-  Capybara.javascript_driver = :selenium_chrome
+  Capybara.default_driver = :selenium_headless
+  Capybara.javascript_driver = :selenium_headless
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-capybara
 version: !ruby/object:Gem::Version
-  version: 4.3.1
+  version: 4.3.2
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-01 00:00:00.000000000 Z
+date: 2020-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler