percy-capybara 2.4.2 → 2.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f2c6b66630a9b989903633853eb47c1d74595a7
-  data.tar.gz: 1a747e278afafb60039383ec401c8d20b1cdb5f3
+  metadata.gz: 787ce577bbcab20de79c69d3605c60de4b04ffa9
+  data.tar.gz: 99820b82e25583e093ab9902c3642edc41fc811f
 SHA512:
-  metadata.gz: 6e134b285b13d3fdf24a305a7f79a1701c8a2defa16e0105de781da019484d80e8a8390915fb6b579d4834bd3eddeefde3a254850a649760b23ed225d59f85f8
-  data.tar.gz: 519a72136a56740eaec3c8f7dbd56dbbc10eb0ebae3d5b145cc10025c89306e569b84a11c1da85ac904900d7471d3179cc5411cb7766b8a7ad789eddbb18e504
+  metadata.gz: 1172af0a6cffff598252e2a86b81b5811b9ee41cf7fb87a32a788ec71fee286afa87c9f8164fdb51ae581d543c0580cb7b64a4f2f168bbcd52ac8f576bc82fef
+  data.tar.gz: 5b9857602fb38d55c12fe8072e5ffa2c15eff55ea30c17fdce449ed7477c1cdd62d7f21bb2c8dff9553fcd0a54351f4c7369d7692f6ef2ff066fbc36f6918969

data/lib/percy/capybara/loaders/base_loader.rb

@@ -82,18 +82,24 @@ module Percy
             iframe_url = iframe_element[:src]
             root_page_host = page.current_host
 
-            page.within_frame(iframe_element) do
-              next unless page.current_host == root_page_host
-              path = URI.parse(iframe_url).path
-              content = page.body
-              sha = Digest::SHA256.hexdigest(content)
-              resources <<
-                Percy::Client::Resource.new(
-                  path,
-                  content: content,
-                  sha: sha,
-                  mimetype: 'text/html',
-                )
+            begin
+              page.within_frame(iframe_element) do
+                next unless page.current_host == root_page_host
+                path = URI.parse(iframe_url).path
+                content = page.body
+                sha = Digest::SHA256.hexdigest(content)
+                resources <<
+                  Percy::Client::Resource.new(
+                    path,
+                    content: content,
+                    sha: sha,
+                    mimetype: 'text/html',
+                  )
+              end
+            rescue StandardError => e
+              # Skip frame not found errors. This library doesn't explicitly depend on Poltergeist,
+              # so we check the string class name.
+              raise e unless e.class.to_s == 'Capybara::Poltergeist::FrameNotFound'
             end
           end
 

data/lib/percy/capybara/version.rb

@@ -1,5 +1,5 @@
 module Percy
   module Capybara
-    VERSION = '2.4.2'.freeze
+    VERSION = '2.4.3'.freeze
   end
 end

data/spec/lib/percy/capybara/loaders/base_loader_spec.rb

@@ -6,6 +6,15 @@ class RackAppWithIframe
   end
 end
 
+# Mock dependency on Poltergeist so we can test an error class.
+module Capybara
+  module Poltergeist
+    class Error < StandardError; end
+    class ClientError < Error; end
+    class FrameNotFound < ClientError; end
+  end
+end
+
 RSpec.describe Percy::Capybara::Loaders::BaseLoader do
   let(:loader) { described_class.new }
 
@@ -36,6 +45,14 @@ RSpec.describe Percy::Capybara::Loaders::BaseLoader do
       expect(last_resource.mimetype).to eq('text/html')
       expect(last_resource.content).to include('Inside iframe')
     end
+    it 'skips poltergeist frame not found errors' do
+      visit '/test-iframe.html'
+
+      expect(page).to receive(:within_frame).twice.and_raise(Capybara::Poltergeist::FrameNotFound)
+      loader = described_class.new(page: page)
+      resources = loader.iframes_resources
+      expect(resources.size).to eq(0)
+    end
   end
   describe '#build_resources' do
     it 'raises a NotImplementedError' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-capybara
 version: !ruby/object:Gem::Version
-  version: 2.4.2
+  version: 2.4.3
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-13 00:00:00.000000000 Z
+date: 2017-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: percy-client