percy-capybara 2.3.5 → 2.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 11f1dee5dd730cd181442f4c90c09b525fcc3e7e
-  data.tar.gz: dde1b522f4bb4447e61f10d1816aaea6ca1007ad
+  metadata.gz: 09d303f9090ad8ce75b13714c58bcec25d711602
+  data.tar.gz: 108512d47e2d4e67e84cdfa2b9456e5368ac58a2
 SHA512:
-  metadata.gz: 807c1b706fc28de2da15f780afed95706828e8171847d866efdf29640759caa6dfd27569a7b46976fe2b032dc8d67fa43cbe9e55d2fd5cf0262d45eb07910b4d
-  data.tar.gz: cdcdf1d0cf88c23849248f88b0607158f57a07b9e24b56940a04ffcba5a94d48d4e419ffd9fad8e124a9886dc5b8badb1c9f489effd11dc3d0e7661fa508f2f9
+  metadata.gz: 67e7111b3708fbad2de5475ee88e8f74b9f47b25a30b66ba06e32372df70d15ccc8fb3d0e43052eeee3b82d1189209326c292691585c8d20b35a0205913184a2
+  data.tar.gz: 2dd5b305baaa6f592c84218537f2d1a125b9a78ffbc6d59bfcf1cf442fba38719edc6006494de46ae6bc6134f900f0f8390feb56515f82e988d731fd7104f42d

data/lib/percy/capybara/client/snapshots.rb

@@ -38,7 +38,14 @@ module Percy
           # Create the snapshot and upload any missing snapshot resources.
           start = Time.now
           rescue_connection_failures do
-            snapshot = client.create_snapshot(current_build_id, resources, options)
+            begin
+              snapshot = client.create_snapshot(current_build_id, resources, options)
+            rescue Percy::Client::BadRequestError => e
+              Percy.logger.warn('Bad request error, skipping snapshot:')
+              Percy.logger.warn(e)
+              return
+            end
+
             snapshot['data']['relationships']['missing-resources']['data'].each do |missing_resource|
               sha = missing_resource['id']
               client.upload_resource(current_build_id, resource_map[sha].content)

data/lib/percy/capybara/version.rb

@@ -1,5 +1,5 @@
 module Percy
   module Capybara
-    VERSION = '2.3.5'
+    VERSION = '2.3.6'
   end
 end

data/spec/lib/percy/capybara/client/snapshots_spec.rb

@@ -79,6 +79,12 @@ RSpec.describe Percy::Capybara::Client::Snapshots, type: :feature do
         expect(result).to eq(true)
         expect(capybara_client.failed?).to eq(false)
       end
+      it 'safely handles snapshot bad request errors' do
+        error = Percy::Client::BadRequestError.new(400, '', '', '', 'snapshot error msg')
+        expect(capybara_client.client).to receive(:create_snapshot).and_raise(error)
+        expect(capybara_client.snapshot(page)).to eq(nil)
+        expect(capybara_client.failed?).to eq(false)  # Build is not failed.
+      end
       it 'safely handles connection errors' do
         expect(capybara_client.client).to receive(:create_snapshot)
           .and_raise(Percy::Client::ConnectionFailed)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-capybara
 version: !ruby/object:Gem::Version
-  version: 2.3.5
+  version: 2.3.6
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-07 00:00:00.000000000 Z
+date: 2017-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: percy-client