percy-capybara 2.3.4 → 2.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf2e261e73d78a50c736b1821ec334ac00574a4f
-  data.tar.gz: eb8e02a61b51589136030b10a4c3bb888a905073
+  metadata.gz: 11f1dee5dd730cd181442f4c90c09b525fcc3e7e
+  data.tar.gz: dde1b522f4bb4447e61f10d1816aaea6ca1007ad
 SHA512:
-  metadata.gz: 13a5da1bcb56e9b2933a5c64de5d1c16cf9719a420957a138127df81a648501144144c02508479c6a23c9f1c81308edd793b1113590467a521fc084693c7447f
-  data.tar.gz: d4341e7c86de918ea31a908753c21f5e6f34981ed78c5ea6beae8cd6df673a4babed5f5ea941015635ae4f4d461fd06950586b98d1642e968a7c3c75bccc5cc1
+  metadata.gz: 807c1b706fc28de2da15f780afed95706828e8171847d866efdf29640759caa6dfd27569a7b46976fe2b032dc8d67fa43cbe9e55d2fd5cf0262d45eb07910b4d
+  data.tar.gz: cdcdf1d0cf88c23849248f88b0607158f57a07b9e24b56940a04ffcba5a94d48d4e419ffd9fad8e124a9886dc5b8badb1c9f489effd11dc3d0e7661fa508f2f9

data/lib/percy/capybara/client.rb

@@ -33,6 +33,13 @@ module Percy
 
       # Check that environment variables required for Percy::Client are set
       def required_environment_variables_set?
+        if !ENV['PERCY_TOKEN'].nil? && ENV['PERCY_PROJECT'].nil?
+          raise RuntimeError.new(
+            '[percy] It looks like you were trying to enable Percy because PERCY_TOKEN is set, ' +
+            'but you are missing the PERCY_PROJECT environment variable!'
+          )
+        end
+
         !(ENV['PERCY_PROJECT'].nil? || ENV['PERCY_TOKEN'].nil?)
       end
 

data/lib/percy/capybara/rspec.rb

@@ -1,5 +1,7 @@
 require 'rspec/core'
 
+# TODO: this has been deprecated for a long time, remove this file when releasing v3.0.0.
+
 RSpec.configure do |config|
   config.before(:suite) { Percy::Capybara.initialize_build }
   config.after(:suite) { Percy::Capybara.finalize_build }

data/lib/percy/capybara/version.rb

@@ -1,5 +1,5 @@
 module Percy
   module Capybara
-    VERSION = '2.3.4'
+    VERSION = '2.3.5'
   end
 end

data/spec/lib/percy/capybara/client_spec.rb

@@ -6,9 +6,9 @@ RSpec.describe Percy::Capybara::Client do
   end
   describe '#enabled?' do
     context 'when required environment variables set' do
-      before(:context) { set_required_env_variables }
-      after(:context) { clear_required_env_variables }
-      
+      before(:each) { set_required_env_variables }
+      after(:each) { clear_percy_env_variables }
+
       it 'is true when PERCY_ENABLE is 1' do
         ENV['PERCY_ENABLE'] = '1'
         expect(Percy::Capybara::Client.new.enabled?).to eq(true)
@@ -21,10 +21,15 @@ RSpec.describe Percy::Capybara::Client do
         ENV['PERCY_ENABLE'] = '0'
         expect(Percy::Capybara::Client.new.enabled?).to eq(false)
       end
+      it 'raises error if PERCY_TOKEN is set but PERCY_PROJECT is not' do
+        ENV.delete 'PERCY_PROJECT'
+        expect { Percy::Capybara::Client.new.enabled? }.to raise_error(RuntimeError)
+      end
     end
 
     context 'when required environment variables not set' do
-      before(:each) { clear_required_env_variables }
+      before(:each) { clear_percy_env_variables }
+
       it 'is false' do
         ENV.delete 'PERCY_ENABLE'
         expect(Percy::Capybara::Client.new.enabled?).to eq(false)

data/spec/support/test_helpers.rb

@@ -54,8 +54,9 @@ module TestHelpers
   end
 
   # Clear the environment variables required by Percy::Client
-  def clear_required_env_variables
+  def clear_percy_env_variables
     ENV.delete('PERCY_TOKEN')
     ENV.delete('PERCY_PROJECT')
+    ENV.delete('PERCY_ENABLE')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-capybara
 version: !ruby/object:Gem::Version
-  version: 2.3.4
+  version: 2.3.5
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-06 00:00:00.000000000 Z
+date: 2017-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: percy-client