percy-appium-app 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e78f2676c90003ca32a0a765f50825da64db7127bf7413c6836470b270323e92
-  data.tar.gz: 30aa4ab566db291ff462d230f6ea1d2a78a37f8dd5da6968c44eea90aa3296de
+  metadata.gz: b85f47e434a501c80e0bf46e7c32699099517b75a6db8c63ce3b50887a68cea5
+  data.tar.gz: 405d12bc2a4d8369821b2828ef408f6266fe4c644d5c111028cd18670facefc3
 SHA512:
-  metadata.gz: e2dc8e58117d35b93c3239fece03898ebc4599d0bc0c0ce8694ac8a4924cea8109e58def6ac93a5853ce235ea6a20db231995a293ae6cd43740387cbb37c511f
-  data.tar.gz: 82b18011008074818858a9120b25e026f34e7aac23bfc757155faaba52b6c033a00cc1aeba45710fdaca486506dc42d35cd0c21206516031ad14ac1c4f828e4c
+  metadata.gz: 336482f05ae03ca94a8afd4d7f770f9df9c2279b70a84be32c4d1c7a201830cef8b8dbadf8c6a3ead2732838adc6bb8b34a49adc1de1b2635bc93325f9b1cb90
+  data.tar.gz: 2fd10faace0a45f16470860f8945d39ab8c1a789453779cc8f8bede44492567c1665f726d06aad856984cc10875c370f6146e2d53a7097e5f80343a7d3db6ee9

data/.github/workflows/test.yml

@@ -37,4 +37,4 @@ jobs:
           key: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/
       - run: bundle install
-      - run: for file in specs/*.rb; do ruby $file; done
+      - run: for file in specs/*.rb; do echo $file; bundle exec ruby $file; done

data/percy/providers/generic_provider.rb

@@ -106,8 +106,8 @@ module Percy
 
     def get_region_object(selector, element)
       scale_factor = metadata.scale_factor
-      location = hashed(element.location)
-      size = hashed(element.size)
+      location = { 'x' => element.location.x, 'y' => element.location.y }
+      size = { 'height' => element.size.height, 'width' => element.size.width }
       coordinates = {
         'top' => location['y'] * scale_factor,
         'bottom' => (location['y'] + size['height']) * scale_factor,
@@ -133,7 +133,9 @@ module Percy
 
     def get_regions_by_ids(elements_array, ids)
       ids.each do |id|
-        element = driver.find_element(Appium::Core::Base::SearchContext::FINDERS[:accessibility_id], id)
+        # Appium::Core::Base::SearchContext::FINDERS[:xpath] returns `accessibility id`
+        # instead of `:accessibility_id`, causes error
+        element = driver.find_element(:accessibility_id, id)
         selector = "id: #{id}"
         region = get_region_object(selector, element)
         elements_array << region

data/percy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Percy
-  VERSION = '0.0.5'.freeze
+  VERSION = '0.0.6'.freeze
 end

data/specs/generic_providers.rb

@@ -233,8 +233,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_region_object
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
     result = @generic_provider.get_region_object('my-selector', mock_element)
     expected_result = {
@@ -248,8 +250,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_xpath
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
     @mock_webdriver.expect(:find_element, mock_element,
                            [Appium::Core::Base::SearchContext::FINDERS[:xpath], '//path/to/element'])
@@ -279,11 +283,12 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_ids
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
-    @mock_webdriver.expect(:find_element, mock_element,
-                           [Appium::Core::Base::SearchContext::FINDERS[:accessibility_id], 'some_id'])
+    @mock_webdriver.expect(:find_element, mock_element, [:accessibility_id, 'some_id'])
 
     elements_array = []
     ids = ['some_id']
@@ -299,8 +304,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_ids_with_non_existing_element
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
     @mock_webdriver.expect(:find_element, [Appium::Core::Base::SearchContext::FINDERS[:accessibility_id], 'id1']) do
       raise Appium::Core::Error::NoSuchElementError, 'Test error'
@@ -315,8 +322,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_elements
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
     mock_element.expect(:attribute, 'textView', ['class'])
 
     elements_array = []

data/specs/screenshot.rb

@@ -339,8 +339,10 @@ class TestPercyScreenshot < Minitest::Test
     mock_screenshot
 
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 200, 'height' => 400 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(200, 400))
+    end
 
     xpaths = ['//path/to/element']
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-appium-app
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - BroswerStack
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-19 00:00:00.000000000 Z
+date: 2024-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appium_lib