percona_ar 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74aa2892abe01b7bfdf7b2d76c7a2280988f0ce6
-  data.tar.gz: 3a9d05ab76286e3b69efb064a924c15efc9541c0
+  metadata.gz: '08f2af03efb53e6609e056679802973a175aaf3b'
+  data.tar.gz: a53808c378db1b478664226f11ecb7f7bd11115c
 SHA512:
-  metadata.gz: 7b60c5dd9df628354ed4301d8ccd08299e0543082fe58034fe61579d9262f09137b96c8502076a5531ece33a6ddaf27ca6ccc0705ebeea4426f1d9d04f3f8aee
-  data.tar.gz: 719338d2f6eb607b66ceddea7c148f9a2e28c5411badcf962701336bc9d24e9e5295ca118a69f62be2c0d2eda0aba7d13222ce5bc8c8724df9419981c4b54a7f
+  metadata.gz: b59b29776cbefbe1a4320ee011f1f6ffc7ddf25871fbeab81a56cd4a3eeff09696a62ce783d50337e49fb13b3db819de46e4fdcd7c3ac030567ff34aab58356e
+  data.tar.gz: b54a20272536118359e67cc537f4d848e0a932310d1192539082a89a61008f53f90ba2f77a822292a1b2ffc33e66c7448958b1610a1942775d746ae07ad353f3

data/CHANGELOG.md

@@ -0,0 +1,27 @@
+*   Generate valid MySQL syntax when executing ALTER statements for NOT NULL columns that have string default values
+
+    *Brian Cheung*
+
+*   enable to override connection
+
+    *Bonty Shushusha*
+
+*   add compatibility for rails 5
+
+    *James Mac William*
+
+*   Added Documentation for Alternate Connections
+
+    *Kaid Shajrah*
+
+*   Added support for DROP INDEX
+
+    *Roderick Monje*
+
+*   Ensure that alter statements without backticks work
+
+    *James Mac William*
+
+*   Added support for CREATE INDEX
+
+    *Roderick Monje*

data/README.md

@@ -3,12 +3,6 @@
 [![Build
 Status](https://travis-ci.org/jamesmacwilliam/percona_ar.svg?branch=master)](https://travis-ci.org/jamesmacwilliam/percona_ar)
 
-[![Code
-Climate](https://codeclimate.com/github/jamesmacwilliam/percona_ar/badges/gpa.svg)](https://codeclimate.com/github/jamesmacwilliam/percona_ar)
-
-[![Test
-Coverage](https://codeclimate.com/github/jamesmacwilliam/percona_ar/badges/coverage.svg)](https://codeclimate.com/github/jamesmacwilliam/percona_ar/coverage)
-
 This gem adds another tool in your belt for rails migrations.  You can
 stil generate migrations, and they will function just as they always
 have, but there is also the option of generating percona_ar migrations,
@@ -52,6 +46,22 @@ https://www.percona.com/doc/percona-toolkit/2.1/pt-online-schema-change.html
   version gets added to schema_migrations, and rails yells at you if you
   haven't yet migrated.
 
+- Example:
+```Ruby
+class SomeMigration < PerconaAr::Migration
+  def change
+    # ALTER commands will get run by the Percona tool,
+    # all other commands will get run by ActiveRecord
+    add_column :users, :foo, :string
+  end
+
+  # Optional uses ActiveRecord by default
+  def connection
+   @percona_connection ||= PerconaAr::Connection.new(SomeModel.connection)
+ end
+end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -66,4 +76,3 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/jamesm
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-

data/lib/percona_ar/migration.rb

@@ -1,11 +1,17 @@
-class PerconaAr::Migration < ActiveRecord::Migration
+if ActiveRecord.gem_version >= Gem::Version.new('5.0')
+  class PerconaAr::Migration < ActiveRecord::Migration[4.2]; end
+else
+  class PerconaAr::Migration < ActiveRecord::Migration; end
+end
+
+PerconaAr::Migration.class_eval do
   def connection
     @percona_connection ||=
       PerconaAr::Connection.new(ActiveRecord::Base.connection)
   end
 
   def migrate(*args)
-    $query_builder = PerconaAr::QueryBuilder.new
+    $query_builder = PerconaAr::QueryBuilder.new connection
     super
     $query_builder.execute
   end

data/lib/percona_ar/pt_online_schema_change_executor.rb

@@ -4,11 +4,12 @@ require 'rake/file_utils'
 class PerconaAr::PtOnlineSchemaChangeExecutor
   include FileUtils
 
-  attr_accessor :sql, :table
+  attr_accessor :sql, :table, :conn
 
-  def initialize(table, sql)
+  def initialize(table, sql, conn = ActiveRecord::Base.connection)
     @table = table
     @sql = sql
+    @conn = conn
   end
 
   def call
@@ -18,7 +19,7 @@ class PerconaAr::PtOnlineSchemaChangeExecutor
   private
 
   def suffix(table, cmd)
-    %Q('#{cmd.gsub("'","\"")}' --recursion-method none --no-check-alter --execute D=#{config[:database]},t=#{table})
+    %Q('#{cmd.gsub("'","\"")}' --recursion-method none --no-check-alter --alter-foreign-keys-method 'auto' --execute D=#{config[:database]},t=#{table})
   end
 
   def boilerplate
@@ -26,6 +27,6 @@ class PerconaAr::PtOnlineSchemaChangeExecutor
   end
 
   def config
-    ActiveRecord::Base.connection_config
+    conn.instance_variable_get(:@config)
   end
 end

data/lib/percona_ar/query_builder.rb

@@ -1,17 +1,23 @@
 class PerconaAr::QueryBuilder
-  def initialize
+  def initialize(conn = ActiveRecord::Base.connection)
     @tables = Hash.new {|h, k| h[k] = [] }
+    @conn = conn
   end
 
   def execute
     @tables.each do |table, snippets|
-      PerconaAr::PtOnlineSchemaChangeExecutor.new(table, snippets.join(", ")).call
+      PerconaAr::PtOnlineSchemaChangeExecutor.new(table, snippets.join(", "), @conn).call
     end
   end
 
   def add(sql)
-    if sql =~ /^ALTER TABLE `([^`]*)` (.*)/i
+    if sql =~ /^ALTER TABLE `?([^ `]*)`? (.*)/i
       @tables[$1.to_s] << get_sql_for($2)
+    elsif sql =~ /DROP INDEX/i
+      drop_clause, table = sql.split(/ ON /i)
+      @tables[table.delete('`')] << get_sql_for(drop_clause)
+    elsif sql =~ /CREATE  INDEX (`?[^ ]*)  ON `?([^ `]*)`? (.*)/i
+      @tables[$2] << get_sql_for("ADD INDEX #{$1} #{$3}")
     end
     self
   end
@@ -20,6 +26,7 @@ class PerconaAr::QueryBuilder
 
   def get_sql_for(cmd)
     return cmd unless cmd =~ /DROP/i && !(cmd =~ /COLUMN/i)
+    return cmd if cmd =~ /DROP INDEX/i
     cmd.gsub(/DROP/i, "DROP COLUMN")
   end
 

data/lib/percona_ar/version.rb

@@ -1,3 +1,3 @@
 module PerconaAr
-  VERSION = "0.1.4"
+  VERSION = "0.2.0"
 end

data/percona_ar.gemspec

@@ -18,11 +18,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.10"
-  spec.add_development_dependency "rake",    "~> 10.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "rails",   ">= 4.0.0"
   spec.add_development_dependency "mysql2",  ">= 0.3.0"
-  spec.add_development_dependency "codeclimate-test-reporter"
-  spec.add_development_dependency "coveralls"
   spec.add_development_dependency "rspec"
 end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: percona_ar
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - James Mac William
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-06 00:00:00.000000000 Z
+date: 2017-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -66,34 +66,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.3.0
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -118,6 +90,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -153,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Use Percona (pt-online-schema-change) for migrations generated with this