percona-migrations-livelink 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c29d8f765c6e4e9390abbb7fdbda4f69b7260ee9
-  data.tar.gz: c2fbfde2707fd123a5417b4197ba640f7f957f3a
+  metadata.gz: 8b7d274d7167e6920a383959a8eb4c239e94ddbd
+  data.tar.gz: 60dcfcf9186f425062f5d3ece10a955df6694419
 SHA512:
-  metadata.gz: ad946d3a0fffe22be05b9388c0acfcda86f4abd845cc8f019ef3c5e1969e0f356236fddab42df876ab7d2c5b1d7519f464b3e7e9706dccddac6b77aee827f872
-  data.tar.gz: 48b8a9f219ac990b6606e4556272085f2f70488f3e344d7ee3ccb498859d2ef63130b90fe74f8736d35664cffe66ee2b215638cb6316526e9a4fbf30470c0184
+  metadata.gz: 14a5a5b3a3215d72bfcfcae00e7db11be082809ac768374ac20bb3d3a3e84c3ce2aa7ac98bef36ea0e5fd3984cdba00de9a4a8e22fe382673944844693978cc4
+  data.tar.gz: 5dbaa2a59ff404b7264dbb279cb13b6b3ed3ba35c52f42f55e3347e4dce1a6c2572fb44552d7950761eeeba9ff069945f307d50cc37d8b0b1108a704794e0c01

data/CHANGELOG.md

@@ -0,0 +1,24 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [0.0.5] - 10-08-2020
+- Allow passing config options to percona_alter_table as a hash
+- Add documentation for config options
+- Create changelog
+
+## [0.0.4] - 18-03-2016
+- Create lib/percona-migrations-livelink.rb
+
+## [0.0.3] - 17-03-2016
+- Fork project from original repo
+- Add support for most pt-online-schema-change config options
+- Set up travis-ci
+
+## [0.0.2] - 12-02-2015
+- Add link to homepage
+
+## [0.0.1] - 12-02-2015
+- First official release tag

data/README.md

@@ -48,6 +48,30 @@ class AddAddressToUsers < ActiveRecord::Migration
 end
 ```
 
+## Configuration
+
+Additional config can optionally be passed either in the initializer or in the migration itself
+
+### As a block in the initializer
+
+```ruby
+PerconaMigrations.config do |c|
+  c.drop_old_table = false
+  c.max_load       = 'Threads_running=60'
+end
+```
+
+### As a hash argument to the `percona_alter_table` command
+
+```ruby
+def up
+  commands = columns.map { |name, type| "ADD COLUMN #{name} #{type}" }
+  options = { drop_old_table: false, max_load: 'Threads_running=60' }
+
+  percona_alter_table :users, commands, options: options
+end
+```
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/percona-migrations/fork )

data/lib/percona-migrations.rb

@@ -0,0 +1 @@
+require 'percona_migrations'

data/lib/percona_migrations.rb

@@ -53,12 +53,10 @@ module PerconaMigrations
     end
   end
 
-  def pt_schema_tool_args
-
+  def pt_schema_tool_args(options: {})
     @config.members.map do |key|
-
+      val = options.key?(key) ? options[key] : config[key]
       arg = key.to_s.gsub(/_/,'-')
-      val = @config[key]
 
       case val
       when nil

data/lib/percona_migrations/runners/base.rb

@@ -5,9 +5,10 @@ module PerconaMigrations
         true
       end
 
-      def initialize(table_name, commands)
+      def initialize(table_name, commands, options: {})
         @table_name = table_name
         @commands = commands
+        @options = options
       end
 
       def run

data/lib/percona_migrations/runners/percona.rb

@@ -12,8 +12,8 @@ module PerconaMigrations
       end
 
       def run
-        options = [
-          PerconaMigrations.pt_schema_tool_args,
+        params = [
+          PerconaMigrations.pt_schema_tool_args(options: @options),
           "--alter '#{@commands.join(', ')}'",
           "-h #{database_config['host']}",
           "-P #{database_config['port']}",
@@ -23,10 +23,10 @@ module PerconaMigrations
 
         password = database_config['password']
         if password && !password.empty?
-          options << "-p $PASSWORD"
+          params << "-p $PASSWORD"
         end
 
-        run_command(options.reject(&:empty?).join(' '), { 'PASSWORD' => password })
+        run_command(params.reject(&:empty?).join(' '), { 'PASSWORD' => password })
       end
 
       private
@@ -35,9 +35,9 @@ module PerconaMigrations
         PerconaMigrations.database_config
       end
 
-      def run_command(options, env_vars = {})
+      def run_command(params, env_vars = {})
         %w(dry-run execute).each do |mode|
-          cmd = "#{self.class.percona_command} #{options} --#{mode}"
+          cmd = "#{self.class.percona_command} #{params} --#{mode}"
 
           log "Running percona command: \"#{cmd}\""
 

data/lib/percona_migrations/version.rb

@@ -1,3 +1,3 @@
 module PerconaMigrations
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/lib/percona_migrations_spec.rb

@@ -70,4 +70,21 @@ RSpec.describe PerconaMigrations do
       end
     end
   end
+
+  describe '::pt_schema_tool_args' do
+    before do
+      subject.instance_eval { @config = @config.class.new }
+      subject.config do |c|
+        c.statistics = true
+        c.drop_old_table = false
+      end
+    end
+
+    it 'returns arguments, overriding any conflicting config settings' do
+      options = { drop_old_table: true, drop_new_table: false }
+      expect(subject.pt_schema_tool_args(options: options)).to eq(
+        '--no-drop-new-table --drop-old-table --statistics'
+      )
+    end
+  end
 end

metadata

@@ -1,73 +1,73 @@
 --- !ruby/object:Gem::Specification
 name: percona-migrations-livelink
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Sergey Varaksin
 - Geoff Youngs
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-03-18 00:00:00.000000000 Z
+date: 2020-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - varaksin86@gmail.com
 - git@intersect-uk.co.uk
@@ -75,14 +75,16 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/percona-migrations-livelink.rb
+- lib/percona-migrations.rb
 - lib/percona_migrations.rb
 - lib/percona_migrations/helper_methods.rb
 - lib/percona_migrations/runners.rb
@@ -101,24 +103,24 @@ homepage: https://github.com/svarks/percona-migrations
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.14
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.5.2.2
+signing_key:
 specification_version: 4
 summary: Allows to use percona in rails migrations.
 test_files: