pennmarc 1.2.7 → 1.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 920cef15f1cac246074afedbe31a0f456ee81d9e9bcbb04c0dde024901d925db
-  data.tar.gz: edf42bff8a460373147e52e4cc3bf1c277655486635952ebf6604bc83fab5912
+  metadata.gz: 3b8115ac66bc671e876756b8f20e16fe119373cce76cd17cf00e94d9d9a5c1ad
+  data.tar.gz: 584620d7645a8cef217415def55a66f3f611fb4e9611d61d4e5b330dbe21bf2e
 SHA512:
-  metadata.gz: 614f6a26980656a8030bdaf28b0c901a9d5a841e0bad65b1e0455e9f09b3071e6c1f379ea3a54c4267c66403efdef3de0e7be4862c9e05c84d3d1f228921ccd8
-  data.tar.gz: 6b85c2040e4b9dbb0bb95b5e5d0914ada840399338246b54ee94b338ebb7c7c58dd32a22d9ae425337b6ce7074c03124e826a7b4b117bc40cc3d05405cfe2e29
+  metadata.gz: 1a18c1297db9093b61e974cfc8593bdbcf34c55097427a17a6eed60322ee0789efa9c81ed96ee13f7662d617378392aa6409b496f142b07561616d6d02cf0f32
+  data.tar.gz: '089da372f1421c4a8dc524c24d245be4b1a80b491a87eb5ed30f7c4feb88329bc6f9981b421fab3638b8bf48012b71d7d2012a4d83a36df804861c2c87af374c'

data/lib/pennmarc/helpers/title.rb

@@ -123,7 +123,7 @@ module PennMARC
         }.first
         return unless field
 
-        values = title_values(field)
+        values = title_values(field, include_subfield_c: true)
         [format_title(values[:title_or_form]), values[:punctuation], values[:other_info]].compact_blank.join(' ')
       end
 
@@ -253,17 +253,17 @@ module PennMARC
 
       # Extract title values from provided 245 subfields. Main title components are the following:
       # - title_or_form: subfields a and k
-      # - inclusive_dates: subfield c
-      # - other_info: subfields b, n, and p
+      # - other_info: subfields b, n, and p (for alternate title, include subfield c)
       # https://www.oclc.org/bibformats/en/2xx/245.html
       #
       # @param field [MARC::Field]
+      # @param include_subfield_c [Boolean]
       # @return [Hash] title values
-      def title_values(field)
+      def title_values(field, include_subfield_c: false)
         title_or_form = field.find_all(&subfield_in?(%w[a k]))
                              .map { |sf| trim_trailing(:comma, trim_trailing(:slash, sf.value).rstrip) }
                              .first || ''
-        other_info = field.find_all(&subfield_in?(%w[b n p]))
+        other_info = field.find_all(&subfield_in?(include_subfield_c ? %w[b c n p] : %w[b n p]))
                           .map { |sf| trim_trailing(:slash, sf.value) }
                           .join(' ')
         title_punctuation = title_or_form.last

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.2.7'
+  VERSION = '1.2.8'
 end

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -117,6 +117,15 @@ describe 'PennMARC::Title' do
       end
     end
 
+    context 'with ǂa, ǂc and ǂn defined' do
+      let(:fields) { [marc_field(tag: '245', subfields: subfields)] }
+      let(:subfields) { { a: 'Five Decades of MARC usage', c: 'Should not be shown', n: 'Part One' } }
+
+      it 'returns single title value with text from ǂa and ǂn but not #c' do
+        expect(helper.show(record)).to eq 'Five Decades of MARC usage Part One'
+      end
+    end
+
     context 'with no ǂa but a ǂk and ǂn defined' do
       let(:fields) { [marc_field(tag: '245', subfields: subfields)] }
       let(:subfields) { { k: 'journals', n: 'Part One' } }
@@ -182,17 +191,29 @@ describe 'PennMARC::Title' do
   end
 
   describe '.alternate_show' do
-    let(:fields) do
-      [marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford. ' }),
-       marc_field(tag: '880', subfields: { '6': '245', k: 'Lettres', b: 'à Lewis Mumford.' })]
-    end
-
     context 'with subfields ǂk and ǂb' do
+      let(:fields) do
+        [marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford. ' }),
+         marc_field(tag: '880', subfields: { '6': '245', k: 'Lettres', b: 'à Lewis Mumford.' })]
+      end
+
       it 'returns alternate title values' do
         expect(helper.alternate_show(record)).to eq 'Lettres à Lewis Mumford.'
       end
     end
 
+    context 'with subfields ǂk, ǂb and ǂc' do
+      let(:fields) do
+        [marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford. ' }),
+         marc_field(tag: '880', subfields: { '6': '245', k: 'Lettres',
+                                             b: 'à Lewis Mumford.', c: 'Additional copy' })]
+      end
+
+      it 'returns alternate title values' do
+        expect(helper.alternate_show(record)).to eq 'Lettres à Lewis Mumford. Additional copy'
+      end
+    end
+
     context 'when 880 field is not present' do
       let(:fields) do
         [marc_field(tag: '245', subfields: { k: 'Letters', b: 'to Lewis Mumford. ' })]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.2.7
+  version: 1.2.8
 platform: ruby
 authors:
 - Mike Kanning
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-23 00:00:00.000000000 Z
+date: 2025-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport