pennmarc 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9aa7e5cf7ade86fc51db4d35791eed5e3e38784e35d33bd9b82379a91ab3786e
-  data.tar.gz: 8b2668fbfd1fc645b203e23f12cfe5681014a870fa504f45c7c0b034682be325
+  metadata.gz: cb8a665310aaf17d406fcfbfe562894a71f17d35b2d63173ca587a9c0e343b54
+  data.tar.gz: 671549b45eb522db5f4350aa0743bcd16585398c6c07f71e2d2a772367a0f33c
 SHA512:
-  metadata.gz: aff6902488cb0d85bee32f3a3c5f4b613c8c5867ab3b594af40dad4c54e501b735b79fbed1ba8656c1144b87b58a9edc6e0ed961cc62603c7ccefb0c244b3117
-  data.tar.gz: e262a56ed0512de8c93c4ef0f94f87c322904d44ed845a64b9eb8dc58c8c3cc9c62675d52e314c5cd15eba0d7f4daea4725675af0c3e96ac7cb501a55074edf7
+  metadata.gz: 9a1374b40186e61a56e33924a6f76561877af209e3b8486b185599766e5cc7bc1b45362cf4f3f9e18fc5cf2cb4328b46f8b0f83b0e2c374a1f31164bce3b8483
+  data.tar.gz: 7a098756899b310a694dbcc1409516de62ff9897b624ac4783b793de145ac61c497bc183409343269e5e33b7b21a07728fa74148fe6af2ad8aaef8149acd71c5

data/lib/pennmarc/helpers/access.rb

@@ -5,20 +5,22 @@ module PennMARC
   class Access < Helper
     ONLINE = 'Online'
     AT_THE_LIBRARY = 'At the library'
+    ELEC_AVAILABILITY_TAG = 'AVE'
+    PHYS_AVAILABILITY_TAG = 'AVA'
 
     class << self
-      # Based primarily on the "enhanced MARC" fields added by Alma, determine if the record has
-      # electronic access or has physical holding, and is therefore "Online" or "At the library". If a record is "At the
-      # library", but has a link to a finding aid in the 856 field (matching certain criteria), also add 'Online' as an
-      # access method.
+      # Based on enhanced metadata fields added by Alma publishing process or API, determine if the record has
+      # electronic access or has physical holdings, and is therefore "Online" or "At the library". If a record is "At
+      # the library", but has a link to a finding aid in the 856 field (matching certain criteria), also add 'Online' as
+      # an access method.
       # @todo What if none of these criteria match? Should we include "At the library" by default? Records with no value
       #       in this field would be lost if the user selects a facet value.
       # @param [MARC::Record] record
       # @return [Array]
       def facet(record)
         acc = record.filter_map do |field|
-          next AT_THE_LIBRARY if field.tag == EnrichedMarc::TAG_HOLDING
-          next ONLINE if field.tag == EnrichedMarc::TAG_ELECTRONIC_INVENTORY
+          next AT_THE_LIBRARY if physical_holding_tag?(field)
+          next ONLINE if electronic_holding_tag?(field)
         end
 
         return acc if acc.size == 2 # return early if all values are already present
@@ -29,6 +31,20 @@ module PennMARC
 
       private
 
+      # Does the record have added electronic holding info?
+      # @param [MARC::Field] field
+      # @return [Boolean]
+      def electronic_holding_tag?(field)
+        field.tag.in? [EnrichedMarc::TAG_ELECTRONIC_INVENTORY, ELEC_AVAILABILITY_TAG]
+      end
+
+      # Does the record have added physical holding info?
+      # @param [MARC::Field] field
+      # @return [Boolean]
+      def physical_holding_tag?(field)
+        field.tag.in? [EnrichedMarc::TAG_HOLDING, PHYS_AVAILABILITY_TAG]
+      end
+
       # Check if a record contains an 856 entry for an online finding aid, meeting these criteria:
       # 1. Indicator 1 is 4 (HTTP resource)
       # 2. Indicator 2 is NOT 2 (indicating the linkage is to a "related" thing)

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.0.5'
+  VERSION = '1.0.6'
 end

data/spec/lib/pennmarc/helpers/access_spec.rb

@@ -7,28 +7,48 @@ describe 'PennMARC::Access' do
 
   describe '.facet' do
     context 'with an electronic record' do
-      let(:record) do
-        marc_record fields: [marc_field(tag: 'prt')]
+      let(:record) { marc_record fields: [marc_field(tag: tag)] }
+
+      context 'with enrichment via the Alma publishing process' do
+        let(:tag) { PennMARC::EnrichedMarc::TAG_ELECTRONIC_INVENTORY }
+
+        it 'returns expected access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+        end
       end
 
-      it 'returns expected access value' do
-        expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+      context 'with enrichment with availability info via the Alma API' do
+        let(:tag) { PennMARC::Access::ELEC_AVAILABILITY_TAG }
+
+        it 'returns expected access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+        end
       end
     end
 
     context 'with a print record' do
-      let(:record) do
-        marc_record fields: [marc_field(tag: 'hld')]
+      let(:record) { marc_record fields: [marc_field(tag: tag)] }
+
+      context 'with enrichment via the Alma publishing process' do
+        let(:tag) { PennMARC::EnrichedMarc::TAG_HOLDING }
+
+        it 'returns expected access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::AT_THE_LIBRARY)
+        end
       end
 
-      it 'returns expected access value' do
-        expect(helper.facet(record)).to contain_exactly(PennMARC::Access::AT_THE_LIBRARY)
+      context 'with enrichment with availability info via the Alma API' do
+        let(:tag) { PennMARC::Access::PHYS_AVAILABILITY_TAG }
+
+        it 'returns expected access value' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::AT_THE_LIBRARY)
+        end
       end
     end
 
     context 'with a record containing a link to a finding aid (as a handle link)' do
       let(:record) do
-        marc_record fields: [marc_field(tag: 'hld'),
+        marc_record fields: [marc_field(tag: PennMARC::EnrichedMarc::TAG_HOLDING),
                              marc_field(tag: '856', subfields: location_and_access_subfields, **indicators)]
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Mike Kanning