pennmarc 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50fd0383f0e78807f62f8abe784f75d8dace6e5b0ecf64877f79ad90b6d40354
-  data.tar.gz: 3df19d10534fc787c55814e30bd1b066a8c5ea10e7da15f9b320c4500891e0be
+  metadata.gz: 9aa7e5cf7ade86fc51db4d35791eed5e3e38784e35d33bd9b82379a91ab3786e
+  data.tar.gz: 8b2668fbfd1fc645b203e23f12cfe5681014a870fa504f45c7c0b034682be325
 SHA512:
-  metadata.gz: 277bb7c15e224c8134b8cea8b28de474d27022a1537904844af8c5542ff3f0080c37f13db38a5a9463a07453bcc403ccf346c2b5538c2fe26012df6a67dec24f
-  data.tar.gz: 1ca8e643758f86aeabdfbeb1576f513c866ba5ef1a40b6edaa279f687af7644baf6b953db6f078548fc72ca99b75b6377db7d80d98a19059c797b6ad41b5f648
+  metadata.gz: aff6902488cb0d85bee32f3a3c5f4b613c8c5867ab3b594af40dad4c54e501b735b79fbed1ba8656c1144b87b58a9edc6e0ed961cc62603c7ccefb0c244b3117
+  data.tar.gz: e262a56ed0512de8c93c4ef0f94f87c322904d44ed845a64b9eb8dc58c8c3cc9c62675d52e314c5cd15eba0d7f4daea4725675af0c3e96ac7cb501a55074edf7

data/.rubocop_todo.yml

@@ -1,36 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 10000`
-# on 2023-08-25 13:55:25 UTC using RuboCop version 1.51.0.
+# on 2023-11-08 20:19:45 UTC using RuboCop version 1.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/ArgumentAlignment:
-  Exclude:
-    - 'spec/lib/pennmarc/helpers/series_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'spec/lib/pennmarc/helpers/identifer_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingEmptyLines:
-  Exclude:
-    - 'spec/lib/pennmarc/helpers/identifer_spec.rb'
-
-# Offense count: 22
+# Offense count: 23
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
@@ -38,6 +14,7 @@ Metrics/AbcSize:
     - 'lib/pennmarc/helpers/edition.rb'
     - 'lib/pennmarc/helpers/format.rb'
     - 'lib/pennmarc/helpers/genre.rb'
+    - 'lib/pennmarc/helpers/language.rb'
     - 'lib/pennmarc/helpers/location.rb'
     - 'lib/pennmarc/helpers/note.rb'
     - 'lib/pennmarc/helpers/production.rb'
@@ -66,6 +43,7 @@ Metrics/CyclomaticComplexity:
     - 'lib/pennmarc/helpers/edition.rb'
     - 'lib/pennmarc/helpers/format.rb'
     - 'lib/pennmarc/helpers/genre.rb'
+    - 'lib/pennmarc/helpers/language.rb'
     - 'lib/pennmarc/helpers/note.rb'
     - 'lib/pennmarc/helpers/production.rb'
     - 'lib/pennmarc/helpers/relation.rb'
@@ -104,6 +82,7 @@ Metrics/PerceivedComplexity:
     - 'lib/pennmarc/helpers/edition.rb'
     - 'lib/pennmarc/helpers/format.rb'
     - 'lib/pennmarc/helpers/genre.rb'
+    - 'lib/pennmarc/helpers/language.rb'
     - 'lib/pennmarc/helpers/note.rb'
     - 'lib/pennmarc/helpers/production.rb'
     - 'lib/pennmarc/helpers/series.rb'
@@ -152,16 +131,9 @@ RSpec/FilePath:
   Exclude:
     - 'spec/lib/pennmarc/parser_spec.rb'
 
-# Offense count: 4
+# Offense count: 6
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:
+    - 'spec/lib/pennmarc/helpers/access_spec.rb'
     - 'spec/lib/pennmarc/helpers/format_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Exclude:
-    - 'spec/lib/pennmarc/helpers/creator_spec.rb'

data/lib/pennmarc/helpers/access.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module PennMARC
+  # Methods for extracting how a record can be accessed
+  class Access < Helper
+    ONLINE = 'Online'
+    AT_THE_LIBRARY = 'At the library'
+
+    class << self
+      # Based primarily on the "enhanced MARC" fields added by Alma, determine if the record has
+      # electronic access or has physical holding, and is therefore "Online" or "At the library". If a record is "At the
+      # library", but has a link to a finding aid in the 856 field (matching certain criteria), also add 'Online' as an
+      # access method.
+      # @todo What if none of these criteria match? Should we include "At the library" by default? Records with no value
+      #       in this field would be lost if the user selects a facet value.
+      # @param [MARC::Record] record
+      # @return [Array]
+      def facet(record)
+        acc = record.filter_map do |field|
+          next AT_THE_LIBRARY if field.tag == EnrichedMarc::TAG_HOLDING
+          next ONLINE if field.tag == EnrichedMarc::TAG_ELECTRONIC_INVENTORY
+        end
+
+        return acc if acc.size == 2 # return early if all values are already present
+
+        acc << ONLINE if acc.exclude?(ONLINE) && finding_aid_linkage?(record) # only check if ONLINE isn't already there
+        acc
+      end
+
+      private
+
+      # Check if a record contains an 856 entry for an online finding aid, meeting these criteria:
+      # 1. Indicator 1 is 4 (HTTP resource)
+      # 2. Indicator 2 is NOT 2 (indicating the linkage is to a "related" thing)
+      # 3. The URL specified in subfield u (URI) is a Penn Handle link
+      # See: https://www.loc.gov/marc/bibliographic/bd856.html
+      # @param [MARC::Record] record
+      # @return [Boolean]
+      def finding_aid_linkage?(record)
+        record.fields('856').filter_map do |field|
+          next if field.indicator2 == '2' || field.indicator1 != '4'
+
+          subz = subfield_values(field, 'z')
+          subfield_values(field, 'u').filter_map do |value|
+            return true if subz.include?('Finding aid') && value.include?('hdl.library.upenn.edu')
+          end
+        end
+        false
+      end
+    end
+  end
+end

data/lib/pennmarc/util.rb

@@ -5,6 +5,14 @@ require_relative 'heading_control'
 module PennMARC
   # class to hold "utility" methods used in MARC parsing methods
   module Util
+    # Check if a given record has a field present by tag (e.g., '041')
+    # @param [MARC::Record] record
+    # @param [String] marc_field
+    # @return [Boolean]
+    def field_defined?(record, marc_field)
+      record.select { |field| field.tag == marc_field }.any?
+    end
+
     # Join subfields from a field selected based on a provided proc
     # @param [MARC::DataField] field
     # @param [Proc] selector

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.0.4'
+  VERSION = '1.0.5'
 end

data/spec/lib/pennmarc/helpers/access_spec.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+describe 'PennMARC::Access' do
+  include MarcSpecHelpers
+
+  let(:helper) { PennMARC::Access }
+
+  describe '.facet' do
+    context 'with an electronic record' do
+      let(:record) do
+        marc_record fields: [marc_field(tag: 'prt')]
+      end
+
+      it 'returns expected access value' do
+        expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE)
+      end
+    end
+
+    context 'with a print record' do
+      let(:record) do
+        marc_record fields: [marc_field(tag: 'hld')]
+      end
+
+      it 'returns expected access value' do
+        expect(helper.facet(record)).to contain_exactly(PennMARC::Access::AT_THE_LIBRARY)
+      end
+    end
+
+    context 'with a record containing a link to a finding aid (as a handle link)' do
+      let(:record) do
+        marc_record fields: [marc_field(tag: 'hld'),
+                             marc_field(tag: '856', subfields: location_and_access_subfields, **indicators)]
+      end
+
+      context 'with an 856 describing a related record, not the record itself' do
+        let(:indicators) { { indicator1: '4', indicator2: '2' } }
+        let(:location_and_access_subfields) do
+          { z: 'Finding Aid', u: 'http://hdl.library.upenn.edu/1017/d/pacscl/UPENN_RBML_MsColl200' }
+        end
+
+        it 'does not include online access' do
+          expect(helper.facet(record)).not_to include PennMARC::Access::ONLINE
+        end
+      end
+
+      context 'with an 865 describing a link to a finding aid' do
+        let(:indicators) { { indicator1: '4', indicator2: '1' } }
+        let(:location_and_access_subfields) do
+          { z: 'Finding aid', u: 'http://hdl.library.upenn.edu/1017/d/pacscl/UPENN_RBML_MsColl200' }
+        end
+
+        it 'includes online access' do
+          expect(helper.facet(record)).to contain_exactly(PennMARC::Access::ONLINE, PennMARC::Access::AT_THE_LIBRARY)
+        end
+      end
+    end
+  end
+end

data/spec/lib/pennmarc/helpers/creator_spec.rb

@@ -17,9 +17,11 @@ describe 'PennMARC::Creator' do
       end
 
       it 'contains the expected search field values for a single author work' do
-        expect(helper.search(record, relator_map: mapping)).to eq ['Name Surname http://cool.uri/12345 author 1900-2000.',
-                                                                   'Surname, Name http://cool.uri/12345 author 1900-2000.',
-                                                                   'Alternative Surname']
+        expect(helper.search(record, relator_map: mapping)).to eq [
+          'Name Surname http://cool.uri/12345 author 1900-2000.',
+          'Surname, Name http://cool.uri/12345 author 1900-2000.',
+          'Alternative Surname'
+        ]
       end
     end
 
@@ -58,7 +60,9 @@ describe 'PennMARC::Creator' do
       end
 
       it 'returns values for the corporate author, including mapped relator code from ǂ4' do
-        expect(helper.values(record, relator_map: mapping)).to contain_exactly 'Annual Report Leader author, Author.'
+        expect(helper.values(record, relator_map: mapping)).to contain_exactly(
+          'Annual Report Leader author, Author.'
+        )
       end
     end
   end
@@ -146,7 +150,8 @@ describe 'PennMARC::Creator' do
       end
 
       it 'includes corporate author and creator values from allowed subfields' do
-        expect(values).to contain_exactly 'Conference on Things Earth', 'Series of Things Earth', 'Thing Institute'
+        expect(values).to contain_exactly 'Conference on Things Earth', 'Series of Things Earth',
+                                          'Thing Institute'
       end
     end
   end

data/spec/lib/pennmarc/helpers/date_spec.rb

@@ -39,7 +39,7 @@ describe 'PennMARC::Date' do
       it 'does not output any warning to STDOUT' do
         expect {
           helper.added(record)
-        }.to_not output(a_string_including('Error parsing date in date added subfield')).to_stdout
+        }.not_to output(a_string_including('Error parsing date in date added subfield')).to_stdout
       end
     end
 

data/spec/lib/pennmarc/helpers/identifer_spec.rb

@@ -113,7 +113,6 @@ describe 'PennMARC::Identifier' do
     it 'does not return DOI values' do
       expect(helper.publisher_number_show(record)).not_to include('10.18574/9781479842865')
       expect(helper.publisher_number_show(record)).not_to include('doi')
-
     end
   end
 

data/spec/lib/pennmarc/helpers/series_spec.rb

@@ -19,9 +19,11 @@ describe 'PennMARC::Series' do
 
   describe '.show' do
     it 'returns the series' do
-      expect(helper.show(record, relator_map: mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1',
-                                                              'Teachings of the feathered pillow',
-                                                              'Учения пернатой подушки', 'Evil Giant Megacorp')
+      expect(helper.show(record, relator_map: mapping)).to contain_exactly(
+        'Bean Bagatolvski 1997- bk. 1',
+        'Teachings of the feathered pillow',
+        'Учения пернатой подушки', 'Evil Giant Megacorp'
+      )
     end
   end
 

data/spec/lib/pennmarc/marc_util_spec.rb

@@ -7,6 +7,18 @@ describe 'PennMARC::Util' do
     Class.new { extend PennMARC::Util }
   end
 
+  describe '.field_defined?' do
+    let(:record) { marc_record fields: [marc_field(tag: '100')] }
+
+    it 'returns true if the field is present in the record' do
+      expect(util.field_defined?(record, '100')).to be true
+    end
+
+    it 'returns false if the field is not present in the record' do
+      expect(util.field_defined?(record, '101')).to be false
+    end
+  end
+
   describe '.join_subfields' do
     let(:field) { marc_field subfields: { a: 'bad', '1': 'join', '3': '', '9': 'subfields' } }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Mike Kanning
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-19 00:00:00.000000000 Z
+date: 2023-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -89,6 +89,7 @@ files:
 - lib/pennmarc/encoding_level.rb
 - lib/pennmarc/enriched_marc.rb
 - lib/pennmarc/heading_control.rb
+- lib/pennmarc/helpers/access.rb
 - lib/pennmarc/helpers/citation.rb
 - lib/pennmarc/helpers/creator.rb
 - lib/pennmarc/helpers/database.rb
@@ -117,6 +118,7 @@ files:
 - lib/pennmarc/version.rb
 - pennmarc.gemspec
 - spec/fixtures/marcxml/test.xml
+- spec/lib/pennmarc/helpers/access_spec.rb
 - spec/lib/pennmarc/helpers/citation_spec.rb
 - spec/lib/pennmarc/helpers/creator_spec.rb
 - spec/lib/pennmarc/helpers/database_spec.rb