pennmarc 1.0.25 → 1.0.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b540ecd84333f097b50a3682732229854b188fcde76921eb0ec184622a690dd
-  data.tar.gz: 9203fadee45b9ad65ec20880a1acbc23356000b748d32d07428ec093590cd55a
+  metadata.gz: 8b4d6a53347f4532faa566debcc59bde1fb7043cfbd4530d0a06489a36db8599
+  data.tar.gz: 8a92c36c80406541ac454025e6c2adc53af80dab20af5af16b8995dc5bacfe9d
 SHA512:
-  metadata.gz: 6770815e8f5f828c15451fc71c04dbef6a131203e8c58d721c063b15f218d5814a71b37fd6c4f088a9c7164d5d989ff6933abc820094068921f218c937a87410
-  data.tar.gz: 94eee63c29ae06151816a532a5afb7db1f27490de798651c909dc07fd0f33de1b4a1ee26057b6e3a8abc5d15c54d09709df8942e6e21ad828c1296fe3191725e
+  metadata.gz: 8b1f0be0caba6a00adc8ccc5516556b2de250d93861157c49a60e17f52810b6eed7942efe8b51843d7428bb329c6dcad58a0887c17e9132004fe3d7d29729682
+  data.tar.gz: b06dad73899b13254391b74832d3b99745d82bc9f871801d7a617e2416f9d70039d45a9122a292377628b638c4044e692432688dbce48497cb6394fa48ba0d6e

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 10000`
-# on 2024-01-17 17:00:02 UTC using RuboCop version 1.51.0.
+# on 2024-07-02 15:41:46 UTC using RuboCop version 1.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,7 +14,7 @@ Gemspec/RequireMFA:
   Exclude:
     - 'pennmarc.gemspec'
 
-# Offense count: 23
+# Offense count: 25
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
@@ -26,18 +26,18 @@ Metrics/AbcSize:
     - 'lib/pennmarc/helpers/location.rb'
     - 'lib/pennmarc/helpers/note.rb'
     - 'lib/pennmarc/helpers/production.rb'
-    - 'lib/pennmarc/helpers/relation.rb'
     - 'lib/pennmarc/helpers/series.rb'
     - 'lib/pennmarc/helpers/subject.rb'
     - 'lib/pennmarc/helpers/title.rb'
     - 'lib/pennmarc/util.rb'
 
-# Offense count: 5
+# Offense count: 8
 # Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ClassLength:
   Exclude:
     - 'lib/pennmarc/helpers/creator.rb'
     - 'lib/pennmarc/helpers/format.rb'
+    - 'lib/pennmarc/helpers/production.rb'
     - 'lib/pennmarc/helpers/series.rb'
     - 'lib/pennmarc/helpers/subject.rb'
     - 'lib/pennmarc/helpers/title.rb'
@@ -54,13 +54,12 @@ Metrics/CyclomaticComplexity:
     - 'lib/pennmarc/helpers/language.rb'
     - 'lib/pennmarc/helpers/note.rb'
     - 'lib/pennmarc/helpers/production.rb'
-    - 'lib/pennmarc/helpers/relation.rb'
     - 'lib/pennmarc/helpers/series.rb'
     - 'lib/pennmarc/helpers/subject.rb'
     - 'lib/pennmarc/helpers/title.rb'
     - 'lib/pennmarc/util.rb'
 
-# Offense count: 26
+# Offense count: 28
 # Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Exclude:
@@ -82,7 +81,7 @@ Metrics/ModuleLength:
   Exclude:
     - 'lib/pennmarc/util.rb'
 
-# Offense count: 12
+# Offense count: 14
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
   Exclude:
@@ -123,7 +122,7 @@ Naming/VariableNumber:
   Exclude:
     - 'lib/pennmarc/util.rb'
 
-# Offense count: 7
+# Offense count: 8
 # Configuration parameters: Max, CountAsOne.
 RSpec/ExampleLength:
   Exclude:
@@ -139,7 +138,7 @@ RSpec/FilePath:
   Exclude:
     - 'spec/lib/pennmarc/parser_spec.rb'
 
-# Offense count: 12
+# Offense count: 23
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:

data/lib/pennmarc/helpers/creator.rb

@@ -7,26 +7,27 @@ module PennMARC
   # @todo can there ever be multiple 100 fields?
   #       can ǂe and ǂ4 both be used at the same time? seems to result in duplicate values
   class Creator < Helper
-    class << self
-      # Main tags for Author/Creator information
-      TAGS = %w[100 110].freeze
+    # Main tags for Author/Creator information
+    TAGS = %w[100 110].freeze
 
-      # Aux tags for Author/Creator information, for use in search_aux method
-      AUX_TAGS = %w[100 110 111 400 410 411 700 710 711 800 810 811].freeze
+    # Aux tags for Author/Creator information, for use in search_aux method
+    AUX_TAGS = %w[100 110 111 400 410 411 700 710 711 800 810 811].freeze
 
-      CONFERENCE_SEARCH_TAGS = %w[111 711 811].freeze
+    CONFERENCE_SEARCH_TAGS = %w[111 711 811].freeze
+    CORPORATE_SEARCH_TAGS = %w[110 710 810].freeze
 
-      # subfields NOT to join when combining raw subfield values
-      NAME_EXCLUDED_SUBFIELDS = %w[a 1 4 5 6 8 t].freeze
+    # subfields NOT to join when combining raw subfield values
+    NAME_EXCLUDED_SUBFIELDS = %w[a 1 4 5 6 8 t].freeze
 
-      CONTRIBUTOR_TAGS = %w[700 710].freeze
+    CONTRIBUTOR_TAGS = %w[700 710].freeze
 
-      FACET_SOURCE_MAP = {
-        100 => 'abcdjq', 110 => 'abcdjq', 111 => 'abcen',
-        700 => 'abcdjq', 710 => 'abcdjq', 711 => 'abcen',
-        800 => 'abcdjq', 810 => 'abcdjq', 811 => 'abcen'
-      }.freeze
+    FACET_SOURCE_MAP = {
+      100 => 'abcdjq', 110 => 'abcdjq', 111 => 'abcen',
+      700 => 'abcdjq', 710 => 'abcdjq', 711 => 'abcen',
+      800 => 'abcdjq', 810 => 'abcdjq', 811 => 'abcen'
+    }.freeze
 
+    class << self
       # Author/Creator search field. Includes all subfield values (even ǂ0 URIs) from
       # {https://www.oclc.org/bibformats/en/1xx/100.html 100 Main Entry--Personal Name} and
       # {https://www.oclc.org/bibformats/en/1xx/110.html 110 Main Entry--Corporate Name}. Maps any relator codes found
@@ -35,8 +36,8 @@ module PennMARC
       # @todo are we including too many details here and gumming up our index? consider UIRs, relator labels, dates...
       # @todo shouldn't indicator1 tell us the order of the name? do we not trust the indicator?
       # @note ported from get_author_creator_1_search_values
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>] array of author/creator values for indexing
       def search(record, relator_map: Mappers.relator)
         name_search_values record: record, tags: TAGS, relator_map: relator_map
@@ -50,7 +51,7 @@ module PennMARC
       # and {https://www.loc.gov/marc/bibliographic/bd711.html MARC 711}. The 800, 810 and 8111 tags are similar in
       # theme to the 7xx fields but apply to serial records.
       # @note ported from get_author_creator_2_search_values
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of extended author/creator values for indexing
       def search_aux(record, relator_map: Mappers.relator)
         name_search_values record: record, tags: AUX_TAGS, relator_map: relator_map
@@ -60,7 +61,7 @@ module PennMARC
       # and {https://www.loc.gov/marc/bibliographic/bd110.html 110} and their linked alternates. First, joins subfields
       # other than $0, $1, $4, $6, $8, $e, and w. Then, appends any encoded relators found in $4.
       # If there are no valid encoded relators, uses the value found in $e.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of author/creator values for display
       def show(record, relator_map: Mappers.relator)
         fields = record.fields(TAGS)
@@ -72,8 +73,8 @@ module PennMARC
 
       # Hash with main creator show values as the fields and the corresponding facet as the values.
       # Does not include linked 880s.
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Hash]
       def show_facet_map(record, relator_map: Mappers.relator)
         creators = record.fields(TAGS).filter_map do |field|
@@ -84,11 +85,82 @@ module PennMARC
         creators.to_h { |h| [h[:show], h[:facet]] }
       end
 
+      # Returns the list of authors with name (subfield $a) only
+      # @param [MARC::Record] record
+      # @param [Boolean] main_tags_only, if true, only use TAGS; otherwise use both TAGS and CONTRIBUTOR_TAGS
+      # @param [Boolean] first_initial_only: true to only use the first initial instead of first name
+      # @return [Array<String>] names of the authors
+      def authors_list(record, main_tags_only: false, first_initial_only: false)
+        tags = if main_tags_only
+                 TAGS
+               else
+                 TAGS + CONTRIBUTOR_TAGS
+               end
+
+        fields = record.fields(tags)
+        fields.filter_map { |field|
+          if first_initial_only
+            abbreviate_name(field['a']) if field['a']
+          else
+            field['a']
+          end
+        }.uniq
+      end
+
+      # Show the authors and contributors grouped together by relators with only names
+      # @param [MARC::Record] record
+      # @param [Hash] relator_map
+      # @param [Boolean] include_authors: true to include author fields TAGS
+      # @param [Boolean] name_only: true to include only the name subfield $a
+      # @param [Boolean] vernacular: true to include field 880 with subfield $6
+      # @return [Hash]
+      def contributors_list(record, relator_map: Mappers.relator, include_authors: true, name_only: true,
+                            vernacular: false)
+        indicator_2_options = ['', ' ', '0']
+        tags = CONTRIBUTOR_TAGS
+
+        fields = record.fields(tags)
+        fields += record.fields('880').select { |field| subfield_value_in?(field, '6', CONTRIBUTOR_TAGS) } if vernacular
+
+        contributors = {}
+        fields.each do |field|
+          next if indicator_2_options.exclude?(field.indicator2) && field.tag.in?(CONTRIBUTOR_TAGS)
+          next if subfield_defined? field, 'i'
+
+          relator = relator(field: field, relator_term_sf: 'e', relator_map: relator_map)
+          relator = 'Contributor' if relator.blank?
+          relator = trim_punctuation(relator).capitalize
+
+          name = if name_only
+                   field['a']
+                 else
+                   join_subfields(field, &subfield_in?(%w[a b c d j q u 3])) + ", #{relator}"
+                 end
+
+          if contributors.key?(relator)
+            contributors[relator].push(name)
+          else
+            contributors[relator] = [name]
+          end
+        end
+
+        # add the authors
+        if include_authors
+          authors = authors_list(record, main_tags_only: true)
+          if contributors.key?('Author')
+            contributors['Author'] += authors
+          else
+            contributors['Author'] = authors
+          end
+        end
+        contributors
+      end
+
       # All author/creator values for display (like #show, but multivalued?) - no 880 linkage
       # Performs additional normalization of author names
       # @note ported from get_author_creator_values (indexed as author_creator_a) - shown on results page
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>] array of author/creator values for display
       def show_aux(record, relator_map: Mappers.relator)
         record.fields(TAGS).map { |field|
@@ -99,7 +171,7 @@ module PennMARC
       # Author/Creator sort. Does not map and include any relator codes.
       # @todo This includes any URI from ǂ0 which could help to disambiguate in sorts, but ǂ1 is excluded...
       # @note ported from get_author_creator_sort_values
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [String] string with author/creator value for sorting
       def sort(record)
         field = record.fields(TAGS).first
@@ -107,11 +179,11 @@ module PennMARC
       end
 
       # Author/Creator for faceting. Grabs values from a plethora of fields, joins defined subfields, then trims some
-      # punctuation (@see trim_punctuation)
+      # punctuation (@see Util.trim_punctuation)
       # @todo should trim_punctuation apply to each subfield value, or the joined values? i think the joined values
       # @note ported from author_creator_xfacet2_input - is this the best choice? check the copyField declarations -
       #       franklin uses author_creator_f
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of author/creator values for faceting
       def facet(record)
         FACET_SOURCE_MAP.flat_map { |field_num, subfields|
@@ -123,8 +195,8 @@ module PennMARC
 
       # Conference for display, intended for results display
       # @note ported from get_conference_values
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>] array of conference values
       def conference_show(record, relator_map: Mappers.relator)
         record.fields('111').filter_map { |field|
@@ -139,7 +211,7 @@ module PennMARC
       # using subfields $e and $w. We append any relators, preferring those defined in $4 and using $j as a fallback.
       # @note ported from get_conference_values
       # @todo what is ǂi for?
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of conference values
       def conference_detail_show(record, relator_map: Mappers.relator)
         conferences = record.fields(%w[111 711]).filter_map do |field|
@@ -164,8 +236,8 @@ module PennMARC
       # Return hash of detailed conference values mapped to their corresponding facets from fields
       # {https://www.loc.gov/marc/bibliographic/bd111.html 111} and
       # {https://www.loc.gov/marc/bibliographic/bd711.html 711}. Does not include linked 880s.
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Hash]
       def conference_detail_show_facet_map(record, relator_map: Mappers.relator)
         conferences = record.fields(%w[111 711]).filter_map do |field|
@@ -180,7 +252,7 @@ module PennMARC
       end
 
       # Conference name values for searching
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def conference_search(record)
         record.fields(CONFERENCE_SEARCH_TAGS).filter_map { |field|
@@ -188,14 +260,23 @@ module PennMARC
         }.uniq
       end
 
+      # Corporate author search values for searching
+      # @param record [MARC::Record]
+      # @return [Array<String>]
+      def corporate_search(record)
+        record.fields(CORPORATE_SEARCH_TAGS).filter_map do |field|
+          join_subfields(field, &subfield_in?(%w[a b c d]))
+        end
+      end
+
       # Retrieve contributor values for display from fields {https://www.oclc.org/bibformats/en/7xx/700.html 700}
       # and {https://www.oclc.org/bibformats/en/7xx/710.html 710} and their linked alternates. Joins subfields
       # 'a', 'b', 'c', 'd', 'j', and 'q', 'u', and '3'. Then appends resulting string with any encoded relationships
       # found in $4. If there are no valid encoded relationships, uses the value found in $e.
       # @note legacy version returns array of hash objects including data for display link
       # @todo is it okay to include 880 $4 here? Legacy includes $4 in main author display 880 but not here.
-      # @param [MARC::Record] record
-      # @ param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>]
       def contributor_show(record, relator_map: Mappers.relator)
         indicator_2_options = ['', ' ', '0']
@@ -212,9 +293,9 @@ module PennMARC
 
       private
 
-      # @param [MARC::Record] record
-      # @param [Array] tags to consider
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param tags [Array] to consider
+      # @param relator_map [Hash]
       # @return [Array<String>] name values from given tags
       def name_search_values(record:, tags:, relator_map:)
         acc = record.fields(tags).filter_map do |field|
@@ -238,30 +319,10 @@ module PennMARC
         acc.uniq
       end
 
-      # Trim punctuation method extracted from Traject macro, to ensure consistent output
-      # @todo move to Util?
-      # @param [String] string
-      # @return [String] string with relevant punctuation removed
-      def trim_punctuation(string)
-        return string unless string
-
-        string = string.sub(%r{ *[ ,/;:] *\Z}, '')
-
-        # trailing period if it is preceded by at least three letters (possibly preceded and followed by whitespace)
-        string = string.sub(/( *[[:word:]]{3,})\. *\Z/, '\1')
-
-        # single square bracket characters if they are the start and/or end chars and there are no internal square
-        # brackets.
-        string = string.sub(/\A\[?([^\[\]]+)\]?\Z/, '\1')
-
-        # trim any leading or trailing whitespace
-        string.strip
-      end
-
       # Extract the information we care about from 1xx fields, map relator codes, and use appropriate punctuation
-      # @param [MARC::Field] field
-      # @param [Hash] mapping
-      # @param [Boolean] should_convert_name_order
+      # @param field [MARC::Field]
+      # @param mapping [Hash]
+      # @param should_convert_name_order [Boolean]
       # @return [String] joined subfield values for value from field
       def name_from_main_entry(field, mapping, should_convert_name_order: false)
         relator_term_sf = relator_term_subfield(field)
@@ -284,7 +345,7 @@ module PennMARC
       end
 
       # Convert "Lastname, First" to "First Lastname"
-      # @param [String] name value for processing
+      # @param name [String] value for processing
       # @return [String]
       def convert_name_order(name)
         return name unless name.include? ','
@@ -294,17 +355,30 @@ module PennMARC
         "#{after_comma} #{before_comma}".squish
       end
 
+      # Convert "Lastname, First" to "Lastname, F"
+      # @param [String] name
+      def abbreviate_name(name)
+        name_parts = name.split(', ')
+        return '' if name_parts.empty?
+
+        first_name_parts = name_parts.last.split
+        temp_name = "#{name_parts.first}, #{first_name_parts.first[0, 1]}."
+        first_name_parts.shift
+        temp_name += " #{first_name_parts.join(' ')}" unless first_name_parts.empty?
+        temp_name
+      end
+
       # Parse creator facet value from given creator field and desired subfields
-      # @param [MARC::Field] field
-      # @param [Array<String>] subfields
+      # @param field [MARC::Field]
+      # @param subfields [Array<String>]
       # @return [String]
       def parse_facet_value(field, subfields)
         trim_punctuation(join_subfields(field, &subfield_in?(subfields)))
       end
 
       # Parse creator show value from given main creator fields (100/110).
-      # @param [MARC::Field] field
-      # @param [Hash] relator_map
+      # @param field [MARC::Field]
+      # @param relator_map [Hash]
       # @return [String]
       def parse_show_value(field, relator_map: Mappers.relator)
         creator = join_subfields(field, &subfield_not_in?(%w[0 1 4 6 8 e w]))
@@ -314,7 +388,7 @@ module PennMARC
       # Parse detailed conference show value from given conference field (111/711). If there is no $i, we join subfield
       # values other than $0, $4, $5, $6, $8, $e, $j, and $w to create conference value. We join subfields $e and $w to
       # determine the subunit value. We append any relators, preferring those defined in $4 and using $j as a fallback.
-      # @param [MARC::Field] field
+      # @param field [MARC::Field]
       # @return [String]
       def parse_conference_detail_show_value(field, relator_map: Mappers.relator)
         conf = if subfield_undefined? field, 'i'

data/lib/pennmarc/helpers/edition.rb

@@ -13,10 +13,12 @@ module PennMARC
       # https://www.loc.gov/marc/bibliographic/bd250.html
       # @param [MARC::Record] record
       # @return [Array<String>] array of editions and their alternates
-      def show(record)
-        editions = record.fields('250').map { |field|
+      def show(record, with_alternate: true)
+        editions = record.fields('250').map do |field|
           join_subfields(field, &subfield_not_in?(%w[6 8]))
-        } + linked_alternate_not_6_or_8(record, '250')
+        end
+        editions += linked_alternate_not_6_or_8(record, '250') if with_alternate
+
         editions.uniq
       end
 

data/lib/pennmarc/helpers/note.rb

@@ -12,7 +12,7 @@ module PennMARC
       # {https://www.oclc.org/bibformats/en/5xx/580.html 580}, {https://www.oclc.org/bibformats/en/5xx/586.html 586},
       # {https://www.oclc.org/bibformats/en/5xx/588.html 588}
       # and their linked alternates.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def notes_show(record)
         notes_fields = %w[500 502 504 515 518 525 533 540 550 580 586 588]
@@ -27,7 +27,7 @@ module PennMARC
       # {https://www.oclc.org/bibformats/en/5xx/562.html 562}, {https://www.oclc.org/bibformats/en/5xx/563.html 563},
       # {https://www.oclc.org/bibformats/en/5xx/585.html 585}, {https://www.oclc.org/bibformats/en/5xx/590.html 590}.
       # Includes linked alternates except for 561.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def local_notes_show(record)
         local_notes = record.fields('561').filter_map do |field|
@@ -50,7 +50,7 @@ module PennMARC
       # prefixed subject field {https://www.oclc.org/bibformats/en/6xx/650.html 650} and its linked alternate.
       # Ignores 561 fields with subfield 'a' values that begin with 'Athenaeum copy: ' and 650 fields where subfield 'a'
       # does not have the prefix 'PRO'.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def provenance_show(record)
         provenance_notes = record.fields(%w[561 880]).filter_map do |field|
@@ -68,20 +68,25 @@ module PennMARC
         notes.uniq
       end
 
-      # Retrieve contents notes for display from fields {https://www.oclc.org/bibformats/en/5xx/505.html 505} and
-      # its linked alternate.
-      # @param [MARC::Record] record
+      # Retrieve contents notes for display from fields {https://www.oclc.org/bibformats/en/5xx/505.html 505} and, if
+      # include_vernacular param is true, its linked alternate. Used for display and searching.
+      # @param record [MARC::Record]
+      # @param with_alternate [Boolean]
       # @return [Array<String>]
-      def contents_show(record)
+      def contents_values(record, with_alternate: true)
         record.fields(%w[505 880]).filter_map { |field|
-          next if field.tag == '880' && no_subfield_value_matches?(field, '6', /^505/)
+          if field.tag == '880'
+            next unless with_alternate
+
+            next if no_subfield_value_matches?(field, '6', /^505/)
+          end
 
           join_subfields(field, &subfield_not_in?(%w[6 8])).split('--')
         }.flatten.uniq
       end
 
       # Retrieve access restricted notes for display from field {https://www.oclc.org/bibformats/en/5xx/506.html 506}.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def access_restriction_show(record)
         record.fields('506').filter_map { |field|
@@ -91,7 +96,7 @@ module PennMARC
 
       # Retrieve finding aid notes for display from field {https://www.oclc.org/bibformats/en/5xx/555.html 555} and its
       # linked alternate.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def finding_aid_show(record)
         datafield_and_linked_alternate(record, '555')
@@ -99,7 +104,7 @@ module PennMARC
 
       # Retrieve participant notes for display from field {https://www.oclc.org/bibformats/en/5xx/511.html 511} and its
       # linked alternate.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def participant_show(record)
         datafield_and_linked_alternate(record, '511')
@@ -107,7 +112,7 @@ module PennMARC
 
       # Retrieve credits notes for display from field {https://www.oclc.org/bibformats/en/5xx/508.html 508} and its
       # linked alternate.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def credits_show(record)
         datafield_and_linked_alternate(record, '508')
@@ -115,7 +120,7 @@ module PennMARC
 
       # Retrieve biography notes for display from field {https://www.oclc.org/bibformats/en/5xx/545.html 545} and its
       # linked alternate.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def biography_show(record)
         datafield_and_linked_alternate(record, '545')
@@ -123,14 +128,14 @@ module PennMARC
 
       # Retrieve summary notes for display from field {https://www.oclc.org/bibformats/en/5xx/520.html 520} and its
       # linked alternate.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def summary_show(record)
         datafield_and_linked_alternate(record, '520')
       end
 
       # Retrieve arrangement values for display from field field {https://www.oclc.org/bibformats/en/3xx/351.html 351}.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def arrangement_show(record)
         datafield_and_linked_alternate(record, '351')
@@ -140,7 +145,7 @@ module PennMARC
       # {https://www.oclc.org/bibformats/en/3xx/344.html 344}, {https://www.oclc.org/bibformats/en/3xx/345.html 345},
       # {https://www.oclc.org/bibformats/en/3xx/346.html 346}, {https://www.oclc.org/bibformats/en/3xx/347.html 347},
       # and their linked alternates.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def system_details_show(record)
         system_details_notes = record.fields(%w[538 880]).filter_map do |field|
@@ -167,7 +172,7 @@ module PennMARC
       end
 
       # Retrieve "With" notes for display from field {https://www.loc.gov/marc/bibliographic/bd501.html 501}
-      # @param [Marc::Record] record
+      # @param record [Marc::Record]
       # @return [Array<String>]
       def bound_with_show(record)
         record.fields('501').filter_map { |field| join_subfields(field, &subfield_in?(['a'])).presence }.uniq
@@ -177,8 +182,8 @@ module PennMARC
 
       # For system details: extract subfield ǂ3 plus other subfields as specified by passed-in block. Pays special
       # attention to punctuation, joining subfield ǂ3 values with a colon-space (': ').
-      # @param [MARC::DataField] field
-      # @param [Proc] &
+      # @param field [MARC::DataField]
+      # @param & [Proc]
       # @return [String]
       def sub3_and_other_subs(field, &)
         sub3 = field.filter_map { |sf| trim_trailing('period', sf.value) if sf.code == '3' }.join(': ')