pennmarc 1.0.9 → 1.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 652039b781e2ce7442f628ca722f4fda59207d1d8171bfd2fad84d2c67f3c06f
-  data.tar.gz: 166bbf8498f673b36373671db47031ef8a2f4d5496ed1fddeee89718bd23e09c
+  metadata.gz: 27d9b9618c0824c62064d486d486850948dd079dd9667c2955cc7c04556e4656
+  data.tar.gz: d741e303841db97060e8747e751ebfa79e3b37b9391eec6ab072d71cb560267a
 SHA512:
-  metadata.gz: 68df667344adaff013da3eab5417bdd44748726a113190d20c44cc1cf4d061269619265e3de1edc9c7c767ffff5a4548a9fcb3ed2039b28a2608ec62a6e024d1
-  data.tar.gz: 8df6d32dbc84ff3851e4b35576e24c96c42b536330ded1f0f1678de3d1aa0729547a71b0c6ccea15e7c949ee15e068d1c0f19b18a6b414167cb736effa2b01dd
+  metadata.gz: 36b165a655fc431225d39004be0470e35760a41d62693455a63c2e6b6f346391803fdd7955b418b890a7531eb45b3a687fb5f9a5cd0a8aecce884ae3f8d2b82f
+  data.tar.gz: 01cfac580c76988881af4b639957f6351db48f6998947b84e68aa3450c9c905bef9c04c5895489db063296d8e7810c332218fb5cf36ff42b3f4bb5cb519ea098

data/lib/pennmarc/helpers/database.rb

@@ -18,7 +18,7 @@ module PennMARC
       # local field 944}. Only returns database subtype if Penn's Database facet value is present in subfield 'a'.
       # @param [Marc::Record]
       # @return [Array<string>] Array of types
-      def type(record)
+      def type_facet(record)
         record.fields('944').filter_map do |field|
           # skip unless specified database format type present
           next unless subfield_value?(field, 'a', /#{DATABASES_FACET_VALUE}/o)
@@ -34,7 +34,7 @@ module PennMARC
       # subfield '2'.
       # @param [Marc::Record]
       # @return [Array<string>] Array of categories
-      def db_category(record)
+      def category_facet(record)
         return [] unless curated_db?(record)
 
         record.fields('943').filter_map do |field|
@@ -55,7 +55,7 @@ module PennMARC
       #   an empty array.
       # @param [Marc::Record]
       # @return [Array<string>] Array of "category--subcategory"
-      def db_subcategory(record)
+      def subcategory_facet(record)
         return [] unless curated_db?(record)
 
         record.fields('943').filter_map do |field|

data/lib/pennmarc/helpers/link.rb

@@ -13,7 +13,7 @@ module PennMARC
       # Full text links from MARC 856 fields.
       # @param [MARC::Record] record
       # @return [Array] array of hashes
-      def full_text(record)
+      def full_text_links(record)
         indicator2_options = %w[0 1]
         links_from_record(record, indicator2_options)
       end
@@ -21,7 +21,7 @@ module PennMARC
       # Web text links from MARC 856 fields.
       # @param [MARC::Record] record
       # @return [Array] array of hashes
-      def web(record)
+      def web_links(record)
         indicator2_options = ['2', ' ', '']
         links_from_record(record, indicator2_options)
       end

data/lib/pennmarc/helpers/note.rb

@@ -6,15 +6,16 @@ module PennMARC
     class << self
       # Retrieve notes for display from fields {https://www.oclc.org/bibformats/en/5xx/500.html 500},
       # {https://www.oclc.org/bibformats/en/5xx/502.html 502}, {https://www.oclc.org/bibformats/en/5xx/504.html 504},
-      # {https://www.oclc.org/bibformats/en/5xx/515.html 515}, {https://www.oclc.org/bibformats/en/5xx/518.html 518}
+      # {https://www.oclc.org/bibformats/en/5xx/515.html 515}, {https://www.oclc.org/bibformats/en/5xx/518.html 518},
       # {https://www.oclc.org/bibformats/en/5xx/525.html 525}, {https://www.oclc.org/bibformats/en/5xx/533.html 533},
-      # {https://www.oclc.org/bibformats/en/5xx/550.html 550}, {https://www.oclc.org/bibformats/en/5xx/580.html 580},
-      # {https://www.oclc.org/bibformats/en/5xx/586.html 586}, {https://www.oclc.org/bibformats/en/5xx/588.html 588},
+      # {https://www.oclc.org/bibformats/en/5xx/540.html 540}, {https://www.oclc.org/bibformats/en/5xx/550.html 550},
+      # {https://www.oclc.org/bibformats/en/5xx/580.html 580}, {https://www.oclc.org/bibformats/en/5xx/586.html 586},
+      # {https://www.oclc.org/bibformats/en/5xx/588.html 588}
       # and their linked alternates.
       # @param [MARC::Record] record
       # @return [Array<String>]
       def notes_show(record)
-        notes_fields = %w[500 502 504 515 518 525 533 550 580 586 588]
+        notes_fields = %w[500 502 504 515 518 525 533 540 550 580 586 588]
         record.fields(notes_fields + ['880']).filter_map do |field|
           next if field.tag == '880' && subfield_value_not_in?(field, '6', notes_fields)
 

data/lib/pennmarc/helpers/series.rb

@@ -84,7 +84,7 @@ module PennMARC
       # https://www.loc.gov/marc/bibliographic/bd780.html
       # @param [MARC::Record] record
       # @return [String] continues fields string
-      def get_continues_display(record)
+      def get_continues_show(record)
         continues(record, '780')
       end
 
@@ -94,7 +94,7 @@ module PennMARC
       # https://www.loc.gov/marc/bibliographic/bd785.html
       # @param [MARC::Record] record
       # @return [String] continued by fields string
-      def get_continued_by_display(record)
+      def get_continued_by_show(record)
         continues(record, '785')
       end
 

data/lib/pennmarc/helpers/title.rb

@@ -149,7 +149,7 @@ module PennMARC
       #       title browse and we will not be supporting that at this time
       # @param [MARC::Record] record
       # @return [Array<String>] Array of standardized titles as strings
-      def standardized(record)
+      def standardized_show(record)
         standardized_titles = record.fields(%w[130 240]).map do |field|
           join_subfields(field, &subfield_not_in?(%w[0 6 8 e w]))
         end
@@ -177,7 +177,7 @@ module PennMARC
       #
       # @param [MARC::Record] record
       # @return [Array<String>] Array of other titles as strings
-      def other(record)
+      def other_show(record)
         other_titles = record.fields('246').map do |field|
           join_subfields(field, &subfield_not_in?(%w[6 8]))
         end
@@ -202,7 +202,7 @@ module PennMARC
       # @todo what are e and w subfields?
       # @param [MARC::Record] record
       # @return [Array<String>] array of former titles
-      def former(record)
+      def former_show(record)
         record.fields
               .filter_map do |field|
           next unless field.tag == '247' || (field.tag == '880' && subfield_value?(field, '6', /^247/))

data/lib/pennmarc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PennMARC
-  VERSION = '1.0.9'
+  VERSION = '1.0.10'
 end

data/spec/lib/pennmarc/helpers/database_spec.rb

@@ -21,39 +21,39 @@ describe 'PennMARC::Database' do
                 ])
   end
 
-  describe '.type' do
+  describe '.type_facet' do
     it 'returns database types' do
-      expect(helper.type(record)).to contain_exactly('Dictionaries and Thesauri (language based)',
-                                                     'Reference and Handbooks')
+      expect(helper.type_facet(record)).to contain_exactly('Dictionaries and Thesauri (language based)',
+                                                           'Reference and Handbooks')
     end
 
     context 'with uncurated database' do
       it 'returns empty array' do
-        expect(helper.type(record_uncurated_db)).to be_empty
+        expect(helper.type_facet(record_uncurated_db)).to be_empty
       end
     end
   end
 
-  describe '.db_category' do
+  describe '.category_facet' do
     it 'returns database categories' do
-      expect(helper.db_category(record)).to contain_exactly('Humanities', 'Social Sciences')
+      expect(helper.category_facet(record)).to contain_exactly('Humanities', 'Social Sciences')
     end
 
     context 'with uncurated database' do
       it 'returns empty array' do
-        expect(helper.db_category(record_uncurated_db)).to be_empty
+        expect(helper.category_facet(record_uncurated_db)).to be_empty
       end
     end
   end
 
-  describe '.db_subcategory' do
+  describe '.subcategory_facet' do
     it 'returns database subcategories' do
-      expect(helper.db_subcategory(record)).to contain_exactly('Social Sciences--Linguistics')
+      expect(helper.subcategory_facet(record)).to contain_exactly('Social Sciences--Linguistics')
     end
 
     context 'with uncurated database' do
       it 'returns empty array' do
-        expect(helper.db_subcategory(record_uncurated_db)).to be_empty
+        expect(helper.subcategory_facet(record_uncurated_db)).to be_empty
       end
     end
   end

data/spec/lib/pennmarc/helpers/link_spec.rb

@@ -5,7 +5,7 @@ describe 'PennMARC::Link' do
 
   let(:helper) { PennMARC::Link }
 
-  describe '.full_text' do
+  describe '.full_text_link' do
     let(:record) do
       marc_record fields: [marc_field(tag: '856', subfields: { '3': 'Materials specified',
                                                                z: 'Public note',
@@ -15,12 +15,12 @@ describe 'PennMARC::Link' do
     end
 
     it 'returns full text link text and url' do
-      expect(helper.full_text(record)).to contain_exactly({ link_text: 'Materials specified Public note',
-                                                            link_url: 'https://www.test-uri.com/' })
+      expect(helper.full_text_link(record)).to contain_exactly({ link_text: 'Materials specified Public note',
+                                                                 link_url: 'https://www.test-uri.com/' })
     end
   end
 
-  describe '.web' do
+  describe '.web_link' do
     let(:record) do
       marc_record fields: [marc_field(tag: '856', subfields: { '3': 'Materials specified',
                                                                z: 'Public note',
@@ -30,8 +30,8 @@ describe 'PennMARC::Link' do
     end
 
     it 'returns web link text and url' do
-      expect(helper.web(record)).to contain_exactly({ link_text: 'Materials specified Public note',
-                                                      link_url: 'https://www.test-uri.com/' })
+      expect(helper.web_link(record)).to contain_exactly({ link_text: 'Materials specified Public note',
+                                                           link_url: 'https://www.test-uri.com/' })
     end
   end
 end

data/spec/lib/pennmarc/helpers/note_spec.rb

@@ -18,6 +18,7 @@ describe 'PennMARC::Note' do
                                 b: 'UK', c: 'Historical Association',
                                 d: '1917', e: '434 reels',
                                 f: '(Seized records)' }),
+        marc_field(tag: '540', subfields: { a: 'Restricted: Copying allowed only for nonprofit organizations' }),
         marc_field(tag: '588', subfields: { a: 'Print version record', '5': 'LoC' }),
         marc_field(tag: '880', subfields: { b: 'Alt PhD', c: 'Alt UPenn', d: 'Alt 2021', '6': '502' }),
         marc_field(tag: '880', subfields: { b: 'Ignore Note', '6': '501' })
@@ -32,6 +33,7 @@ describe 'PennMARC::Note' do
                                         'PhD University of Pennsylvania 2021',
                                         'Includes bibliographical references (pages 329-[342]) and index.',
                                         'Archives Microfilm UK Historical Association 1917 434 reels (Seized records)',
+                                        'Restricted: Copying allowed only for nonprofit organizations',
                                         'Print version record', 'Alt PhD Alt UPenn Alt 2021')
     end
   end

data/spec/lib/pennmarc/helpers/series_spec.rb

@@ -18,7 +18,7 @@ describe 'PennMARC::Series' do
   end
 
   describe '.show' do
-    it 'returns the series' do
+    it 'returns the series values for display' do
       expect(helper.show(record, relator_map: mapping)).to contain_exactly(
         'Bean Bagatolvski 1997- bk. 1',
         'Teachings of the feathered pillow',
@@ -28,7 +28,7 @@ describe 'PennMARC::Series' do
   end
 
   describe '.values' do
-    it 'returns the values' do
+    it 'returns the series values' do
       expect(helper.values(record, relator_map: mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1.')
     end
   end
@@ -43,15 +43,15 @@ describe 'PennMARC::Series' do
     end
   end
 
-  describe '.get_continues_display' do
-    it 'gets continues for display' do
-      expect(helper.get_continues_display(record)).to contain_exactly('National Comfort Association')
+  describe '.get_continues_show' do
+    it 'gets continues values for display' do
+      expect(helper.get_continues_show(record)).to contain_exactly('National Comfort Association')
     end
   end
 
-  describe '.get_continued_by_display' do
-    it 'gets continued by display' do
-      expect(helper.get_continued_by_display(record)).to contain_exactly('NCA quarterly comfortology bulletin')
+  describe '.get_continued_by_show' do
+    it 'gets continued by values for display' do
+      expect(helper.get_continued_by_show(record)).to contain_exactly('NCA quarterly comfortology bulletin')
     end
   end
 end

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -195,7 +195,7 @@ describe 'PennMARC::Title' do
     end
   end
 
-  describe '.standardized' do
+  describe '.standardized_show' do
     let(:record) do
       marc_record fields: [
         marc_field(tag: '130', subfields: { a: 'Uniform Title', f: '2000', '8': 'Not Included' }),
@@ -208,7 +208,7 @@ describe 'PennMARC::Title' do
     end
 
     it 'returns the expected standardized title display values' do
-      values = helper.standardized(record)
+      values = helper.standardized_show(record)
       expect(values).to contain_exactly(
         'Another Uniform Title', 'Translated Uniform Title', 'Uniform Title 2000', 'Yet Another Uniform Title'
       )
@@ -216,7 +216,7 @@ describe 'PennMARC::Title' do
     end
   end
 
-  describe '.other' do
+  describe '.other_show' do
     let(:record) do
       marc_record fields: [
         marc_field(tag: '246', subfields: { a: 'Varied Title', f: '2000', '8': 'Not Included' }),
@@ -227,13 +227,13 @@ describe 'PennMARC::Title' do
     end
 
     it 'returns the expected other title display values' do
-      expect(helper.other(record)).to contain_exactly(
+      expect(helper.other_show(record)).to contain_exactly(
         'Alternate Varied Title', 'Uncontrolled Title', 'Varied Title 2000'
       )
     end
   end
 
-  describe '.former' do
+  describe '.former_show' do
     let(:record) do
       marc_record fields: [
         marc_field(tag: '247', subfields: { a: 'Former Title', n: 'Part', '6': 'Linkage', e: 'Append' }),
@@ -242,7 +242,7 @@ describe 'PennMARC::Title' do
     end
 
     it 'returns the expected former title value' do
-      values = helper.former(record)
+      values = helper.former_show(record)
       expect(values).to contain_exactly 'Former Title Part Append', 'Alt Title Part'
       expect(values).not_to include 'Linkage', '247'
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.0.10
 platform: ruby
 authors:
 - Mike Kanning
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-08 00:00:00.000000000 Z
+date: 2023-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport