pelusa 0.2.0 → 0.2.1

data/lib/pelusa/lint.rb

@@ -9,6 +9,7 @@ require 'pelusa/lint/collection_wrappers'
 require 'pelusa/lint/short_identifiers'
 require 'pelusa/lint/case_statements'
 require 'pelusa/lint/many_arguments'
+require 'pelusa/lint/eval_usage'
 
 module Pelusa
   # Public: A Lint is a quality standard, applicable on a given piece of code to
@@ -25,7 +26,8 @@ module Pelusa
         Properties,
         CollectionWrappers,
         ShortIdentifiers,
-        ManyArguments
+        ManyArguments,
+        EvalUsage
       ]
     end
   end

data/lib/pelusa/lint/eval_usage.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+
+module Pelusa
+  module Lint
+    class EvalUsage
+
+      def initialize
+        @violations = Set.new
+      end
+
+      def check(klass)
+        iterate_lines!(klass)
+
+        if @violations.empty?
+          SuccessfulAnalysis.new(name)
+        else
+          FailedAnalysis.new(name, @violations) do |violations|
+            "There are #{violations.length} eval statement in lines #{violations.to_a.join(', ')}"
+          end
+        end
+      end
+
+      private
+
+      def name
+        "Doesn't use eval statement"
+      end
+
+      def iterate_lines!(klass)
+        iterator = Iterator.new do |node|
+          @violations << node.line if eval_violation?(node)
+        end
+        Array(klass).each(&iterator)
+      end
+
+      def eval_violation?(node)
+        node.is_a?(Rubinius::AST::SendWithArguments) && node.name == :eval && node.receiver.is_a?(Rubinius::AST::Self)
+      end
+
+    end
+  end
+end

data/lib/pelusa/version.rb

@@ -1,3 +1,3 @@
 module Pelusa
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/test/pelusa/lint/eval_usage_test.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+require 'test_helper'
+
+module Pelusa
+  module Lint
+    describe EvalUsage do
+      before { @lint = EvalUsage.new }
+
+      describe '#check' do
+        describe 'when class does not use eval statement' do
+          it 'return successful analysis' do
+            klass_str = <<RUBY
+class WithoutEval
+  def initialize
+    @good = true
+  end
+end
+RUBY
+            klass = klass_str.to_ast
+            analysis = @lint.check(klass)
+            analysis.successful?.must_equal true
+          end
+        end
+
+        describe 'when class use eval statement' do
+          it 'return failed analysis' do
+            klass_str = <<RUBY
+class WithEval
+  def initialize
+    eval "@good = false"
+  end
+end
+RUBY
+            klass = klass_str.to_ast
+            analysis = @lint.check(klass)
+            analysis.failed?.must_equal true
+          end
+        end
+
+        describe 'when class define method named eval' do
+          it 'return successful analysis' do
+            klass_str = <<RUBY
+class WithEvalUse
+  def initialize
+    @other_obj = Object.new
+    @other_obj.eval "boom"
+  end
+end
+RUBY
+            klass = klass_str.to_ast
+            analysis = @lint.check(klass)
+            analysis.successful?.must_equal true
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,46 +1,35 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: pelusa
-version: !ruby/object:Gem::Version 
-  hash: 2380615109590600174
+version: !ruby/object:Gem::Version
+  version: 0.2.1
   prerelease: 
-  segments: 
-  - 0
-  - 2
-  - 0
-  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Josep M. Bach
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-03-23 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-05-29 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  requirement: &7212 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   name: mocha
+  version_requirements: *7212
   prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 2002549777813010636
-        segments: 
-        - 0
-        version: "0"
   type: :development
-  version_requirements: *id001
 description: Static analysis Lint-type tool to improve your OO Ruby code
-email: 
+email:
 - josep.m.bach@gmail.com
-executables: 
+executables:
 - pelusa
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .pelusa.yml
 - .rvmrc
@@ -61,6 +50,7 @@ files:
 - lib/pelusa/lint/collection_wrappers.rb
 - lib/pelusa/lint/demeter_law.rb
 - lib/pelusa/lint/else_clauses.rb
+- lib/pelusa/lint/eval_usage.rb
 - lib/pelusa/lint/indentation_level.rb
 - lib/pelusa/lint/instance_variables.rb
 - lib/pelusa/lint/line_restriction.rb
@@ -85,6 +75,7 @@ files:
 - test/pelusa/lint/collection_wrappers_test.rb
 - test/pelusa/lint/demeter_law_test.rb
 - test/pelusa/lint/else_clauses_test.rb
+- test/pelusa/lint/eval_usage_test.rb
 - test/pelusa/lint/indentation_level_test.rb
 - test/pelusa/lint/instance_variables_test.rb
 - test/pelusa/lint/line_restriction_test.rb
@@ -97,38 +88,29 @@ files:
 - test/test_helper.rb
 homepage: http://github.com/codegram/pelusa
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 2002549777813010636
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 2002549777813010636
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: pelusa
 rubygems_version: 1.8.12
 signing_key: 
 specification_version: 3
 summary: Static analysis Lint-type tool to improve your OO Ruby code
-test_files: 
+test_files:
 - test/pelusa_test.rb
 - test/test_helper.rb
 - test/pelusa/analysis_test.rb
@@ -142,6 +124,7 @@ test_files:
 - test/pelusa/lint/collection_wrappers_test.rb
 - test/pelusa/lint/demeter_law_test.rb
 - test/pelusa/lint/else_clauses_test.rb
+- test/pelusa/lint/eval_usage_test.rb
 - test/pelusa/lint/indentation_level_test.rb
 - test/pelusa/lint/instance_variables_test.rb
 - test/pelusa/lint/line_restriction_test.rb