peatio-ndc 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bcdfa5787e2d9335d2c7ae05b6cfab3766e02c48ff573e8cf2370b6ac6df444b
-  data.tar.gz: 2134ef963edadc80ece9ba10a36a0ebff4acf87469b86e0b6f2c9b48c159f7ba
+  metadata.gz: ca92d7872c52df3e6caab7a8dc0f10f970b753d4aab007f0676275d731c38603
+  data.tar.gz: 98dc57297a2285be0dce49550a9e0410393c34ceaf6f48aaa908144ac429b692
 SHA512:
-  metadata.gz: 143306fe99d88f6ace1b5b2aadf0921e70378ed74950cddb8ba6472e5807245ef8285ed9d4a88b1892470f5eeffe444fb704fa6dd3ade071352698eb948ebc81
-  data.tar.gz: 7a5626f155c8bce791e10775bc432c1d471d2e1a97a34c8c39ab55f0cabb39142bd39882ae8c10bd8ce2246c73dd9a31d59eeebd15f481b803b39b1704c11bc2
+  metadata.gz: 46cf47e863f7cc790f2d4dcd2c464daf02ff1f32bceee479fe1416086d0132284600618419f1c1b90a6126b33310c2b5083c1c542525435103ace2de836c2b3b
+  data.tar.gz: 38cab011b4fca422f717ea3d8d4a7839489dedefdf6ad111f8c085f9c5f7fd01b8af2e0ea51b001f5d6ef2ed07924a90e735a9cf025aaaf1929f43b36d80c1e8

data/.travis.yml

@@ -1,8 +1,6 @@
 ---
-sudo: false
 language: ruby
 cache: bundler
 rvm:
-  - 2.5.3
   - 2.6.5
-before_install: gem install bundler -v 1.17.0
+before_install: gem install bundler -v 2.1.2

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,74 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at tanvirtex@gmail.com. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at [https://contributor-covenant.org/version/1/4][version]
+
+[homepage]: https://contributor-covenant.org
+[version]: https://contributor-covenant.org/version/1/4/

data/Gemfile

@@ -1,6 +1,7 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
-# Specify your gem's dependencies in peatio-umbru.gemspec
+# Specify your gem's dependencies in peatio-ndc.gemspec
 gemspec
+
+gem "rake", "~> 12.0"
+gem "rspec", "~> 3.0"

data/Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    peatio-ndc (0.2.1)
+    peatio-ndc (0.2.2)
       activesupport (~> 5.2.3)
       better-faraday (~> 1.0.5)
-      faraday (~> 0.15.4)
+      faraday (~> 0.17)
       memoist (~> 0.16.0)
-      peatio (= 0.6.3)
+      net-http-persistent (~> 3.0.1)
+      peatio (>= 0.6.3)
 
 GEM
   remote: https://rubygems.org/
@@ -24,6 +25,7 @@ GEM
     amqp (1.8.0)
       amq-protocol (>= 2.2.0)
       eventmachine
+    ast (2.4.0)
     better-faraday (1.0.8)
       activesupport (>= 4.0, < 6.0)
       faraday (~> 0.12)
@@ -33,35 +35,78 @@ GEM
     clamp (1.3.1)
     coderay (1.1.2)
     concurrent-ruby (1.1.6)
+    connection_pool (2.2.2)
+    cookiejar (0.3.3)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
+    daemons (1.3.1)
     diff-lcs (1.3)
+    docile (1.3.2)
+    em-http-request (1.1.5)
+      addressable (>= 2.3.4)
+      cookiejar (!= 0.3.1)
+      em-socksify (>= 0.3)
+      eventmachine (>= 1.0.3)
+      http_parser.rb (>= 0.6.0)
+    em-socksify (0.3.2)
+      eventmachine (>= 1.0.0.beta.4)
+    em-synchrony (1.0.6)
+      eventmachine (>= 1.0.0.beta.1)
     em-websocket (0.5.1)
       eventmachine (>= 0.12.9)
       http_parser.rb (~> 0.6.0)
     eventmachine (1.2.7)
-    faraday (0.15.4)
+    faraday (0.17.3)
       multipart-post (>= 1.2, < 3)
+    faraday_middleware (0.13.1)
+      faraday (>= 0.7.4, < 1.0)
+    faye (1.2.5)
+      cookiejar (>= 0.3.0)
+      em-http-request (>= 0.3.0)
+      eventmachine (>= 0.12.0)
+      faye-websocket (>= 0.9.1)
+      multi_json (>= 1.0.0)
+      rack (>= 1.0.0)
+      websocket-driver (>= 0.5.1)
+    faye-websocket (0.10.9)
+      eventmachine (>= 0.12.0)
+      websocket-driver (>= 0.5.1)
     hashdiff (1.0.1)
     http_parser.rb (0.6.0)
     i18n (1.8.2)
       concurrent-ruby (~> 1.0)
+    io-console (0.5.6)
+    irb (1.2.4)
+      reline (>= 0.0.1)
+    jaro_winkler (1.5.4)
     jwt (2.2.1)
     memoist (0.16.2)
     method_source (1.0.0)
     minitest (5.14.1)
     mocha (1.11.2)
+    multi_json (1.14.1)
     multipart-post (2.1.1)
     mysql2 (0.5.3)
-    peatio (0.6.3)
+    net-http-persistent (3.0.1)
+      connection_pool (~> 2.2)
+    parallel (1.19.1)
+    parser (2.7.1.3)
+      ast (~> 2.4.0)
+    peatio (2.4.4)
       activemodel (> 5.2, <= 6.0.0)
       amqp
       bunny
       clamp
+      em-synchrony (~> 1.0)
       em-websocket
       eventmachine
+      faraday_middleware (~> 0.13.1)
+      faye (~> 1.2)
       jwt
       mysql2
+      prometheus-client
+      thin
+    prometheus-client (2.0.0)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -69,7 +114,12 @@ GEM
       byebug (~> 11.0)
       pry (~> 0.13.0)
     public_suffix (4.0.5)
-    rake (10.5.0)
+    rack (2.2.2)
+    rainbow (3.0.0)
+    rake (12.3.3)
+    reline (0.1.4)
+      io-console (~> 0.5)
+    rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -83,26 +133,60 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
+    rubocop (0.82.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-github (0.16.0)
+      rubocop (<= 0.82.0)
+      rubocop-performance (~> 1.0)
+      rubocop-rails (~> 2.0)
+    rubocop-performance (1.6.0)
+      rubocop (>= 0.71.0)
+    rubocop-rails (2.5.2)
+      activesupport
+      rack (>= 1.1)
+      rubocop (>= 0.72.0)
+    ruby-progressbar (1.10.1)
     safe_yaml (1.0.5)
+    simplecov (0.18.5)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
+    thin (1.7.2)
+      daemons (~> 1.0, >= 1.0.9)
+      eventmachine (~> 1.0, >= 1.0.4)
+      rack (>= 1, < 3)
     thread_safe (0.3.6)
     tzinfo (1.2.7)
       thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
     webmock (3.8.3)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
+    websocket-driver (0.7.2)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.4)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 2.1.2)
+  bundler (~> 1.17)
+  irb
   mocha (~> 1.8)
   peatio-ndc!
-  pry-byebug (~> 3.7)
-  rake (~> 10.0)
+  pry-byebug
+  rake (~> 12.0)
   rspec (~> 3.0)
+  rubocop-github
+  simplecov
   webmock (~> 3.5)
 
 BUNDLED WITH
-   2.1.2
+   1.17.3

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2020 Md Tanvir Rahaman, NEXBIT.IO
+Copyright (c) 2020 Md Tanvir Rahaman
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,6 +1,8 @@
-# Peatio::NDC
+# Peatio::Ndc
 
-Peatio ndc plugin for Rubykube stack
+Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/peatio/ndc`. To experiment with that code, run `bin/console` for an interactive prompt.
+
+TODO: Delete this and the text above, and describe your gem
 
 ## Installation
 
@@ -12,7 +14,7 @@ gem 'peatio-ndc'
 
 And then execute:
 
-    $ bundle
+    $ bundle install
 
 Or install it yourself as:
 
@@ -20,48 +22,23 @@ Or install it yourself as:
 
 ## Usage
 
-For Peatio NDC plugin integration you need to do the following steps:
-
-### Image Build.
-
-1. Add peatio-ndc gem into your Gemfile.plugin
-```ruby
-gem 'peatio-ndc', '~> 0.1.3'
-```
-
-2. Run `bundle install` for updating Gemfile.lock
-
-3. Build custom Peatio [docker image with NDC plugin](https://github.com/nexbitio/peatio/blob/master/docs/plugins.md#build)
-
-4. Push your image using `docker push`
-
-5. Update your deployment to use image with peatio-ndc gem
-
-### Peatio Configuration.
-
-1. Create NDC Blockchain [config example](../config/blockchains.yml).
-    * No additional steps are needed
-
-2. Create NDC Currency [config example](../config/currencies.yml).
-    * No additional steps are needed
-
-3. Create NDC Wallets [config example](../config/wallets.yml)(deposit and hot wallets are required).
-    * No additional steps are needed
-
+TODO: Write usage instructions here
 
 ## Development
 
-Plugin development [example](https://github.com/nexbitio/peatio/blob/master/docs/coins/development.md).
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/nexbitio/peatio-ndc.
+Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/peatio-ndc. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/peatio-ndc/blob/master/CODE_OF_CONDUCT.md).
+
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 
-## Consulting
+## Code of Conduct
 
-You can contact Openware for finding certified vendors:
-[NEXBIT.IO](https://www.nexbit.io)
+Everyone interacting in the Peatio::Ndc project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/peatio-ndc/blob/master/CODE_OF_CONDUCT.md).

data/lib/peatio/ndc.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/object/blank"
 require "active_support/core_ext/enumerable"
 require "peatio"
@@ -6,10 +8,13 @@ module Peatio
   module Ndc
     require "bigdecimal"
     require "bigdecimal/util"
+
     require "peatio/ndc/blockchain"
     require "peatio/ndc/client"
     require "peatio/ndc/wallet"
+
     require "peatio/ndc/hooks"
+
     require "peatio/ndc/version"
   end
 end

data/lib/peatio/ndc/blockchain.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
 
 module Peatio
   module Ndc
     # TODO: Processing of unconfirmed transactions from mempool isn't supported now.
     class Blockchain < Peatio::Blockchain::Abstract
-
       DEFAULT_FEATURES = {case_sensitive: true, cash_addr_format: false}.freeze
 
-      def initialize(custom_features = {})
+      def initialize(custom_features={})
         @features = DEFAULT_FEATURES.merge(custom_features).slice(*SUPPORTED_FEATURES)
         @settings = {}
       end
 
-      def configure(settings = {})
+      def configure(settings={})
         # Clean client state during configure.
         @client = nil
         @settings.merge!(settings.slice(*SUPPORTED_SETTINGS))
@@ -20,13 +20,15 @@ module Peatio
       def fetch_block!(block_number)
         block_hash = client.json_rpc(:getblockhash, [block_number])
 
-        client.json_rpc(:getblock, [block_hash, 2])
-          .fetch('tx').each_with_object([]) do |tx, txs_array|
+        block_txs = client.json_rpc(:getblock, [block_hash, 2])
+                          .fetch("tx").each_with_object([]) do |tx, txs_array|
           txs = build_transaction(tx).map do |ntx|
             Peatio::Transaction.new(ntx.merge(block_number: block_number))
           end
           txs_array.append(*txs)
-        end.yield_self { |txs_array| Peatio::Block.new(block_number, txs_array) }
+        end
+
+        Peatio::Block.new(block_number, block_txs)
       rescue Client::Error => e
         raise Peatio::Blockchain::ClientError, e
       end
@@ -39,12 +41,10 @@ module Peatio
 
       def load_balance_of_address!(address, _currency_id)
         address_with_balance = client.json_rpc(:listaddressgroupings)
-                                 .flatten(1)
-                                 .find { |addr| addr[0] == address }
+                                     .flatten(1)
+                                     .find {|addr| addr[0] == address }
 
-        if address_with_balance.blank?
-          raise Peatio::Blockchain::UnavailableAddressBalanceError, address
-        end
+        raise Peatio::Blockchain::UnavailableAddressBalanceError, address if address_with_balance.blank?
 
         address_with_balance[1].to_d
       rescue Client::Error => e
@@ -53,18 +53,18 @@ module Peatio
 
       private
 
-      def build_transaction(tx_hash)
-        tx_hash.fetch('vout')
-          .select do |entry|
-          entry.fetch('value').to_d > 0 &&
-            entry['scriptPubKey'].has_key?('addresses')
+      def filter_vout(tx_hash)
+        tx_hash.fetch("vout").select do |entry|
+          entry.fetch("value").to_d.positive? && entry["scriptPubKey"].has_key?("addresses")
         end
-          .each_with_object([]) do |entry, formatted_txs|
-          no_currency_tx =
-            { hash: tx_hash['txid'], txout: entry['n'],
-              to_address: entry['scriptPubKey']['addresses'][0],
-              amount: entry.fetch('value').to_d,
-              status: 'success' }
+      end
+
+      def build_transaction(tx_hash)
+        filter_vout(tx_hash).each_with_object([]) do |entry, formatted_txs|
+          no_currency_tx = {hash: tx_hash["txid"], txout: entry["n"],
+                            to_address: entry["scriptPubKey"]["addresses"][0],
+                            amount: entry.fetch("value").to_d,
+                            status: "success"}
 
           # Build transaction for each currency belonging to blockchain.
           settings_fetch(:currencies).pluck(:id).each do |currency_id|
@@ -83,3 +83,4 @@ module Peatio
     end
   end
 end
+

data/lib/peatio/ndc/client.rb

@@ -1,12 +1,14 @@
-require 'memoist'
-require 'faraday'
-require 'better-faraday'
+# frozen_string_literal: true
+
+require "memoist"
+require "faraday"
+require "better-faraday"
 
 module Peatio
   module Ndc
     class Client
       Error = Class.new(StandardError)
-      class ConnectionError < Error; end
+      ConnectionError = Class.new(Error)
 
       class ResponseError < Error
         def initialize(code, msg)
@@ -25,37 +27,39 @@ module Peatio
         @json_rpc_endpoint = URI.parse(endpoint)
       end
 
-      def json_rpc(method, params = [])
-        response = connection.post \
-          '/',
-          { jsonrpc: '1.0', method: method, params: params }.to_json,
-          { 'Accept'       => 'application/json',
-            'Content-Type' => 'application/json' }
+      def json_rpc(method, params=[])
+        response = post(method, params)
+
         response.assert_2xx!
         response = JSON.parse(response.body)
-        response['error'].tap { |e| raise ResponseError.new(e['code'], e['message']) if e }
-        response.fetch('result')
-      rescue => e
-        if e.is_a?(Error)
-          raise e
-        elsif e.is_a?(Faraday::Error)
-          raise ConnectionError, e
-        else
-          raise Error, e
+
+        response["error"].tap do |e|
+          raise ResponseError.new(e["code"], e["message"]) if e
         end
+
+        response.fetch("result")
+      rescue Faraday::Error => e
+        raise ConnectionError, e
       end
 
       private
 
+      def post(method, params)
+        connection.post("/", {jsonrpc: "1.0", method: method, params: params}.to_json,
+                        "Accept" => "application/json", "Content-Type" => "application/json")
+      end
+
       def connection
-        Faraday.new(@json_rpc_endpoint).tap do |connection|
+        @connection ||= Faraday.new(@json_rpc_endpoint) do |f|
+          f.adapter :net_http_persistent, pool_size: 5
+        end.tap do |connection|
           unless @json_rpc_endpoint.user.blank?
             connection.basic_auth(@json_rpc_endpoint.user,
                                   @json_rpc_endpoint.password)
           end
         end
       end
-      memoize :connection
     end
   end
 end
+

data/lib/peatio/ndc/hooks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peatio
   module Ndc
     module Hooks
@@ -12,7 +14,7 @@ module Peatio
               "Ndc blockchain version requiremnt was not suttisfied by Peatio::Blockchain.",
               "Ndc blockchain requires #{BLOCKCHAIN_VERSION_REQUIREMENT}.",
               "Peatio::Blockchain version is #{Peatio::Blockchain::VERSION}"
-            ].join('\n').tap { |s| Kernel.abort s }
+            ].join('\n').tap {|s| Kernel.abort s }
           end
 
           unless Gem::Requirement.new(WALLET_VERSION_REQUIREMENT)
@@ -21,13 +23,13 @@ module Peatio
               "Ndc wallet version requiremnt was not suttisfied by Peatio::Wallet.",
               "Ndc wallet requires #{WALLET_VERSION_REQUIREMENT}.",
               "Peatio::Wallet version is #{Peatio::Wallet::VERSION}"
-            ].join('\n').tap { |s| Kernel.abort s }
+            ].join('\n').tap {|s| Kernel.abort s }
           end
         end
 
         def register
-          Peatio::Blockchain.registry[:ndc] = Ndc::Blockchain.new
-          Peatio::Wallet.registry[:ndcd] = Ndc::Wallet.new
+          Peatio::Blockchain.registry[:ndc] = Ndc::Blockchain
+          Peatio::Wallet.registry[:ndcd] = Ndc::Wallet
         end
       end
 
@@ -40,3 +42,4 @@ module Peatio
     end
   end
 end
+

data/lib/peatio/ndc/railtie.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peatio
   module Ndc
     class Railtie < Rails::Railtie
@@ -11,3 +13,4 @@ module Peatio
     end
   end
 end
+

data/lib/peatio/ndc/version.rb

@@ -1,5 +1,5 @@
 module Peatio
   module Ndc
-    VERSION = "0.2.1".freeze
+    VERSION = "0.2.2"
   end
 end

data/lib/peatio/ndc/wallet.rb

@@ -1,40 +1,41 @@
+# frozen_string_literal: true
+
 module Peatio
   module Ndc
     class Wallet < Peatio::Wallet::Abstract
-
-      def initialize(settings = {})
+      def initialize(settings={})
         @settings = settings
       end
 
-      def configure(settings = {})
+      def configure(settings={})
         # Clean client state during configure.
         @client = nil
 
         @settings.merge!(settings.slice(*SUPPORTED_SETTINGS))
 
-        @wallet = @settings.fetch(:wallet) do
+        @wallet = @settings.fetch(:wallet) {
           raise Peatio::Wallet::MissingSettingError, :wallet
-        end.slice(:uri, :address)
+        }.slice(:uri, :address)
 
-        @currency = @settings.fetch(:currency) do
+        @currency = @settings.fetch(:currency) {
           raise Peatio::Wallet::MissingSettingError, :currency
-        end.slice(:id, :base_factor, :options)
+        }.slice(:id, :base_factor, :options)
       end
 
-      def create_address!(_options = {})
-        { address: client.json_rpc(:getnewaddress) }
+      def create_address!(_options={})
+        {address: client.json_rpc(:getnewaddress)}
       rescue Ndc::Client::Error => e
         raise Peatio::Wallet::ClientError, e
       end
 
-      def create_transaction!(transaction, options = {})
+      def create_transaction!(transaction, options={})
         txid = client.json_rpc(:sendtoaddress,
                                [
                                  transaction.to_address,
                                  transaction.amount,
-                                 '',
-                                 '',
-                                 options[:subtract_fee].to_s == 'true' # subtract fee from transaction amount.
+                                 "",
+                                 "",
+                                 options[:subtract_fee].to_s == "true" # subtract fee from transaction amount.
                                ])
         transaction.hash = txid
         transaction
@@ -44,7 +45,6 @@ module Peatio
 
       def load_balance!
         client.json_rpc(:getbalance).to_d
-
       rescue Ndc::Client::Error => e
         raise Peatio::Wallet::ClientError, e
       end
@@ -58,3 +58,4 @@ module Peatio
     end
   end
 end
+

data/peatio-ndc.gemspec

@@ -1,18 +1,19 @@
-
-lib = File.expand_path("../lib", __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "peatio/ndc/version"
+require_relative 'lib/peatio/ndc/version'
 
 Gem::Specification.new do |spec|
   spec.name          = "peatio-ndc"
   spec.version       = Peatio::Ndc::VERSION
-  spec.authors       = ["BitBD"]
-  spec.email         = ["me@bitbd.co"]
+  spec.authors       = ["Md Tanvir Rahaman"]
+  spec.email         = ["tanvirtex@gmail.com"]
 
-  spec.summary       = %q{Gem for extending Peatio plugable system with Ndc implementation.}
-  spec.description   = %q{Ndc Peatio gem which implements Peatio::Blockchain::Abstract & Peatio::Wallet::Abstract.}
-  spec.homepage      = "https://ndcwallet.pro/"
+  spec.summary       = %q{Peatio Blockchain Gem for NDC Wallet.}
+  spec.description   = %q{Peatio Blockchain Plugin for easy integration of NDC Wallet Blockchain platform.}
+  spec.homepage      = "https://ndcwallet.pro."
   spec.license       = "MIT"
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/ndcwallet/peatio-ndc"
+  spec.metadata["changelog_uri"] = "https://github.com/ndcwallet/peatio-ndc/blob/master/CHANGELOG.md"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -25,15 +26,18 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activesupport", "~> 5.2.3"
   spec.add_dependency "better-faraday", "~> 1.0.5"
-  spec.add_dependency "faraday", "~> 0.15.4"
+  spec.add_dependency "faraday", "~> 0.17"
   spec.add_dependency "memoist", "~> 0.16.0"
-  spec.add_dependency "peatio", "= 0.6.3"
-  
+  spec.add_dependency "peatio", ">= 0.6.3"
+  spec.add_dependency 'net-http-persistent', '~> 3.0.1'
 
-  spec.add_development_dependency "bundler", "~> 2.1.2"
+  spec.add_development_dependency "bundler", "~> 1.17"
+  spec.add_development_dependency "irb"
   spec.add_development_dependency "mocha", "~> 1.8"
-  spec.add_development_dependency "pry-byebug", "~> 3.7"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rubocop-github"
+  spec.add_development_dependency "simplecov"
   spec.add_development_dependency "webmock", "~> 3.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: peatio-ndc
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
-- BitBD
+- Md Tanvir Rahaman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-22 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.4
+        version: '0.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.4
+        version: '0.17'
 - !ruby/object:Gem::Dependency
   name: memoist
   requirement: !ruby/object:Gem::Requirement
@@ -70,30 +70,58 @@ dependencies:
   name: peatio
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.3
+- !ruby/object:Gem::Dependency
+  name: net-http-persistent
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.0.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.0.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.2
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.2
+        version: '1.17'
+- !ruby/object:Gem::Dependency
+  name: irb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -112,30 +140,30 @@ dependencies:
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +178,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-github
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -164,9 +220,10 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
-description: Ndc Peatio gem which implements Peatio::Blockchain::Abstract & Peatio::Wallet::Abstract.
+description: Peatio Blockchain Plugin for easy integration of NDC Wallet Blockchain
+  platform.
 email:
-- me@bitbd.co
+- tanvirtex@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -174,6 +231,8 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -181,11 +240,6 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- config/blockchains.yml
-- config/currencies.yml
-- config/wallets.yml
-- docs/integration.md
-- docs/json-rpc.md
 - lib/peatio/ndc.rb
 - lib/peatio/ndc/blockchain.rb
 - lib/peatio/ndc/client.rb
@@ -193,15 +247,14 @@ files:
 - lib/peatio/ndc/railtie.rb
 - lib/peatio/ndc/version.rb
 - lib/peatio/ndc/wallet.rb
-- peatio-ndc-0.1.0.gem
-- peatio-ndc-0.1.1.gem
-- peatio-ndc-0.1.2.gem
-- peatio-ndc-0.1.3.gem
 - peatio-ndc.gemspec
-homepage: https://ndcwallet.pro/
+homepage: https://ndcwallet.pro.
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: https://ndcwallet.pro.
+  source_code_uri: https://github.com/ndcwallet/peatio-ndc
+  changelog_uri: https://github.com/ndcwallet/peatio-ndc/blob/master/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -210,7 +263,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -220,5 +273,5 @@ requirements: []
 rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
-summary: Gem for extending Peatio plugable system with Ndc implementation.
+summary: Peatio Blockchain Gem for NDC Wallet.
 test_files: []

data/config/blockchains.yml

@@ -1,10 +0,0 @@
-- key:               ndc-mainet
-  name:              NDC Mainet
-  client:            ndc                                  # API client name.
-  server:            http://user:password@127.0.0.1:17798 # Public ndc node endpoint.
-  height:            5000                                 # Initial block number from which sync will be started.
-  min_confirmations: 6                                    # Minimal confirmations needed for withdraw and deposit confirmation.
-  explorer:
-    address:         https://explorer.ndcwallet.pro/address/#{address}
-    transaction:     https://explorer.ndcwallet.pro/tx/#{txid}
-  status:            active

data/config/currencies.yml

@@ -1,18 +0,0 @@
-- id:                     ndc
-  name:                   NDC
-  blockchain_key:         ndc-mainet
-  symbol:                 'C'
-  type:                   coin
-  precision:              8
-  base_factor:            100_000_000
-  enabled:                true
-  # Deposits with less amount are skipped during blockchain synchronization.
-  # We advise to set value 10 times bigger than the network fee to prevent losses.
-  min_deposit_amount:     0.0004488
-  min_collection_amount:  0.0004488
-  withdraw_limit_24h:     0.5
-  withdraw_limit_72h:     1.2
-  deposit_fee:            0
-  withdraw_fee:           0
-  position:               5
-  options:                {}

data/config/wallets.yml

@@ -1,44 +0,0 @@
-- name:             NDC Deposit Wallet
-  blockchain_key:   ndc-mainet
-  currency_id:      ndc
-  # Address where deposits will be collected to.
-  address:          'NrR24vjA6AwoLw9w34hCpJKytUiAJnpSTP'  # IMPORTANT: Always wrap this value in quotes!
-  kind:             deposit    # Wallet kind (deposit, hot, warm, cold or fee).
-  nsig:             1          # Number of signatures required for performing withdraw.
-  max_balance:      0.0
-  status:           active
-  gateway:          ndcd  # Gateway client name.
-  settings:
-    #
-    # NDCd gateway client settings.
-    uri:          http://user:password@127.0.0.1:17798
-
-- name:             NDC Hot Wallet
-  blockchain_key:   ndc-mainet
-  currency_id:      ndc
-  # Address where deposits will be collected to.
-  address:          'NrR24vjA6AwoLw9w34hCpJKytUiAJnpSTP'  # IMPORTANT: Always wrap this value in quotes!
-  kind:             hot     # Wallet kind (deposit, hot, warm, cold or fee).
-  nsig:             1       # Number of signatures required for performing withdraw.
-  max_balance:      5.0
-  status:           active
-  gateway:          ndcd   # Gateway client name.
-  settings:
-    #
-    # NDC gateway client settings.
-    uri:          http://user:password@127.0.0.1:17798
-
-- name:             NDC Warm Wallet
-  blockchain_key:   ndc-mainet
-  currency_id:      ndc
-  # Address where deposits will be collected to.
-  address:          'NrR24vjA6AwoLw9w34hCpJKytUiAJnpSTP'  # IMPORTANT: Always wrap this value in quotes!
-  kind:             warm    # Wallet kind (deposit, hot, warm, cold or fee).
-  nsig:             1       # Number of signatures required for performing withdraw.
-  max_balance:      50.0
-  status:           active
-  gateway:          ndcd   # Gateway client name.
-  settings:
-    #
-    # NDCd gateway client settings.
-    uri:          http://user:password@127.0.0.1:17798

data/docs/integration.md

@@ -1,29 +0,0 @@
-# Integration.
-
-For Peatio NDC plugin integration you need to do the following steps:
-
-## Image Build.
-
-1. Add peatio-ndc gem into your Gemfile.plugin
-```ruby
-gem 'peatio-ndc', '~> 0.1.3'
-```
-
-2. Run `bundle install` for updating Gemfile.lock
-
-3. Build custom Peatio [docker image with NDC plugin](https://github.com/nexbitio/peatio/blob/master/docs/plugins.md#build)
-
-4. Push your image using `docker push`
-
-5. Update your deployment to use image with peatio-ndc gem
-
-## Peatio Configuration.
-
-1. Create NDC Blockchain [config example](../config/blockchains.yml).
-    * No additional steps are needed
-
-2. Create NDC Currency [config example](../config/currencies.yml).
-    * No additional steps are needed
-
-3. Create NDC Wallets [config example](../config/wallets.yml)(deposit and hot wallets are required).
-    * No additional steps are needed

data/docs/json-rpc.md

@@ -1,29 +0,0 @@
-# JSON RPC
-
-The next list of JSON RPC calls where used for plugin development.
-For response examples see spec/resources:
-
-  * getbalance
-
-    `curl  --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getbalance", "params": [] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798`
-  * getblock
-
-    `curl  --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getblock", "params": ["51c209db5f7eaad7aee6983579a463eb49f03b9970d8cd852dc687a7380d3abb", 2] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798`
-  * getblockcount
-
-    `curl  --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getblockcount", "params": [] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798`
-  * getblockhash
-
-    `curl --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getblockhash", "params": [40500] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798 `
-  * getnewaddress
-
-    `curl --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getnewaddress", "params": [] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798 `
-  * listaddressgroupings
-
-    `curl --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "listaddressgroupings", "params": [] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798`
-  * sendtoaddress
-
-    `curl --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "sendtoaddress", "params": ["NrR24vjA6AwoLw9w34hCpJKytUiAJnpSTP", 0.11] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798`
-  * methodnotfound
-
-    `curl  --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "methodnotfound", "params": [] }' -H 'content-type: text/plain;' http://user:password@127.0.0.1:17798`