pdfshaver 0.0.1.alpha → 0.0.1.alpha1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a34c73145fff7cd843f8770b4cdb14648b0d8e8
-  data.tar.gz: 543a70e710dc09646580d1bb0fff7bce6f41fe5e
+  metadata.gz: 47c0de381cc44eaea49ef37b21928598d0c905cf
+  data.tar.gz: 08cdd9fb20961c659c24667652c1fe07dc4c29bc
 SHA512:
-  metadata.gz: 3bca072b82f7710883dec16c6be56fcd696ef074c40b55ca1139f3671985ea7690fad1f2e7cfb0333f4ec480d1b92b2c722e3fa990a1e7a8b19f6b2bbc814ac0
-  data.tar.gz: 3ec48a4b055c0b985567f5922194dbd853a489e392f64cf5ee9b641dd3e45ce9641b2028b4b93d6d802c10516b8cfb4e37575e73c29d27d6a831c31f0a551bf1
+  metadata.gz: 85f7c759a3ebd29a922db660626872f207579bd4706e2e1c4b14eee71d9b550ebca5e17d579ce30850f201ba63a418da0f3171850f0d6291a54af176f6a72801
+  data.tar.gz: 1c72fd8441a91e4b4245ec1e55894b4fd7693ac4b58a60d2178e00f8560ef952bcefcd2c5c562f1e8dcaf24be9d1c18a4740d3bd78c8828a28969a959b0d3dd4

data/ext/pdfium_ruby/page.cpp

@@ -35,12 +35,15 @@ bool Page::render(char* path, int width, int height) {
   
   // Create bitmap.  width, height, alpha 1=enabled,0=disabled
   bool alpha = false;
+  printf("just about to allocate bitmap w:%d, h:%d\n", width, height);
   FPDF_BITMAP bitmap = FPDFBitmap_Create(width, height, alpha);
-  if (!bitmap) { return false; }
+  printf("BITMAP CREATED\n");
+  if (!bitmap) { printf("ALLOCATING BITMAP FAILED"); return false; }
 
+  printf("FILLING BITMAP");
   // fill all pixels with white for the background color
   FPDFBitmap_FillRect(bitmap, 0, 0, width, height, 0xFFFFFFFF);
-
+  printf("BITMAP FILLED");
   // Render a page to a bitmap in RGBA format
   // args are: *buffer, page, start_x, start_y, size_x, size_y, rotation, and flags
   // flags are:
@@ -53,7 +56,7 @@ bool Page::render(char* path, int width, int height) {
   int rotation = 0;
   int flags = FPDF_PRINTING; // A flag defined in PDFium's codebase.
   FPDF_RenderPageBitmap(bitmap, this->fpdf_page, start_x, start_y, width, height, rotation, flags);
-
+  printf("RENDERED BITMAP");
   // The stride holds the width of one row in bytes.  It may not be an exact
   // multiple of the pixel width because the data may be packed to always end on a byte boundary
   int stride = FPDFBitmap_GetStride(bitmap);
@@ -66,6 +69,7 @@ bool Page::render(char* path, int width, int height) {
     ((stride * height) > (INT_MAX / 3))
   );
   if (bitmapIsntValid){
+      printf("BITMAP ISN'T VALID");
       FPDFBitmap_Destroy(bitmap);
       return false;
   }
@@ -79,16 +83,20 @@ bool Page::render(char* path, int width, int height) {
   FIBITMAP *raw = FreeImage_ConvertFromRawBits(
     (BYTE*)FPDFBitmap_GetBuffer(bitmap), width, height, stride, bpp, red_mask, green_mask, blue_mask, topdown);
 
+  printf("ALLOCATED MAP");
   // at this point we're done with the FPDF bitmap and can destroy it.
   FPDFBitmap_Destroy(bitmap);
-
+  printf("FREE BITMAP");
   // Conversion to jpg or gif require that the bpp be set to 24
   // since we're not exporting using alpha transparency above in FPDFBitmap_Create
   FIBITMAP *image = FreeImage_ConvertTo24Bits(raw);
+  printf("CONVERT TO 24BITS2");
   FreeImage_Unload(raw);
+  printf("DEALLOCATE RAW");
 
   // figure out the desired format from the file extension
   FREE_IMAGE_FORMAT format = FreeImage_GetFIFFromFilename(path);
+  printf("DEDUCE FORMAT");
 
   bool success = false;
   if ( FIF_GIF == format ){
@@ -100,10 +108,11 @@ bool Page::render(char* path, int width, int height) {
       // All other formats should be just a save call
       success = FreeImage_Save(format, image, path, 0);
   }
+  printf("SAVED IMAGE");
 
   // unload the image
   FreeImage_Unload(image);
-
+  printf("UNLOADED IMAGE");
   return success;
 }
 

data/lib/pdfshaver/page.rb

@@ -26,6 +26,8 @@ module PDFShaver
     
     def extract_dimensions_from_gm_geometry_string(arg)
       dimensions = {}
+      return dimensions if arg.nil? or arg.empty?
+      raise ArgumentError, "argument is not a String" unless arg.kind_of? String
       arg.match(GM_MATCHER) do |match|
         
         # grab parsed tokens

data/pdfshaver.gemspec

@@ -4,7 +4,7 @@ require 'pdfshaver/version'
 
 Gem::Specification.new do |s|
   s.name        = 'pdfshaver'
-  s.version     = PDFShaver::VERSION + ".alpha"
+  s.version     = PDFShaver::VERSION + ".alpha1"
   s.licenses    = ['MIT']
   s.summary     = "Shave pages off of PDFs as images"
   s.authors     = ["Ted Han", "Nathan Stitt"]

data/test/gm_compatability_spec.rb

@@ -62,6 +62,11 @@ describe "Resize arguments" do
       end
     end
   
+    it "should return an empty hash with nil or an empty string" do
+      @page.extract_dimensions_from_gm_geometry_string(nil).must_equal({})
+      @page.extract_dimensions_from_gm_geometry_string("").must_equal({})
+    end
+    
     it "should specify width and height" do
       w = @page.width.to_i
       h = @page.height.to_i

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pdfshaver
 version: !ruby/object:Gem::Version
-  version: 0.0.1.alpha
+  version: 0.0.1.alpha1
 platform: ruby
 authors:
 - Ted Han