pdfgen 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c60d3bdf99d2a23532c9087bdb757b7f8987a6e2
-  data.tar.gz: 8a8b1dd3a3b8d7ce0b69109ff027eb6994bd8757
+  metadata.gz: 8e28174877f0b28647fd1653c187ecf4bd0fe3b7
+  data.tar.gz: 98e2bbed6e8f2d4bf6252432f612e2cabee4540f
 SHA512:
-  metadata.gz: 774d4eaba9e179e1ab14cd04212232dceda6be0b82c0620174e17455eab4b9053910f0a149070ffc5af0fb7b54e3957575d45805d9ae12fb729a967b8df0be14
-  data.tar.gz: dccd796d164aa84040e6a4acf8a9808819cc309b2fa0e41878d289865aada2574fd02c6ee4983dac0ba0eca6d83c1c1331000d65dd54545f4ddc42bde947e944
+  metadata.gz: a47ffc3ad2f07bee137731ec1187da17e3c5b601ba0797ff6cf3b6613037f096bf8ca217dcf23165fa3a9a16a24a861e810c281dab84279b972bf332247351ac
+  data.tar.gz: 4bdb05250de0ec74f63dbf913387957add058f2c82d693c5a12a5237cf324389631da9bb848d82f288a529f74117addaca8c73519937c927cbcb9c88aff1434e

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## Pdfgen 0.4.2 (June 8, 2018)
+
+* Adds checking of minimum Node version required.
+
+  Need to soon add testing for different versions of Node to discover what the
+  compatible versions are.
+
+* Adds handling of any unhandled rejection by logging the error and then exiting.
+
+  This change provides better error messaged from Node and also prevents the process
+  from hanging and not exiting when there was an error.
+
+* Fixes bug where launch options were no longer being passed to the Javascript.
+
 ## Pdfgen 0.4.1 (May 15, 2018)
 
 * Fixes bug with regex that checks if a URL was passed.

data/README.md

@@ -2,7 +2,9 @@
 A tool for creating PDFs using [Puppeteer](https://github.com/GoogleChrome/puppeteer) and headless Chrome.
 
 # Dependencies
-This gem requires that node be installed along with puppeteer.
+This gem requires:
+* Node v7.6 or greater
+* Puppeteer (tested with v1.3.0)
 
 ### OSX (Homebrew)
 To install node on OSX you can use Homebrew:

data/VERSION

@@ -1 +1 @@
-0.4.1
+0.4.2

data/lib/javascript_bin/make_pdf.js

@@ -4,6 +4,12 @@ var stdin = process.stdin,
     stdout = process.stdout,
     inputChunks = [];
 
+// Exit if we have any unhandled rejections
+process.on('unhandledRejection', (err) => {
+    console.error(err)
+    process.exit(1)
+})
+
 stdin.resume();
 stdin.setEncoding('utf8');
 
@@ -58,7 +64,7 @@ stdin.on('end', function () {
             const pdf_output = await page.pdf(pdf_options);
             stdout.write(pdf_output);
         }
-        
+
         await browser.close();
     })();
 });

data/lib/pdfgen.rb

@@ -3,8 +3,11 @@
 require 'open3'
 require 'json'
 
-_, status = Open3.capture2('node', '-v')
-raise 'This gem requires node be installed and available on the PATH' unless status.success?
+MIN_REQUIRED_NODE_VERSION = '7.6'
+
+node_version, status = Open3.capture2('node', '-v')
+raise 'This gem requires Node be installed and available on the PATH' unless status.success?
+raise "This gem requires Node v#{MIN_REQUIRED_NODE_VERSION} or greater but found Node #{node_version}" unless Gem::Version.new(node_version[1..-1]) > Gem::Version.new(MIN_REQUIRED_NODE_VERSION)
 
 MAKE_PDF_COMMAND = File.expand_path('../javascript_bin/make_pdf.js', __FILE__)
 
@@ -66,6 +69,8 @@ class Pdfgen
       stdin_options = stdin_options.merge(wait_for_timeout: @debug_time)
       stdin_options = stdin_options.merge(launch_options: @launch_options.merge(headless: false))
       stdin_options = stdin_options.merge(debug_mode: true)
+    else
+      stdin_options = stdin_options.merge(launch_options: @launch_options)
     end
 
     pdf_output = nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pdfgen
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Daniel Fox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-15 00:00:00.000000000 Z
+date: 2018-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest