pdf_margins 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d41e2247fb4dead96b77524b5c4524bfc3802692
-  data.tar.gz: 73d2bd7d01f22f3232716376e64ee52a63c81a20
+  metadata.gz: 93ac8cfc2af90e3b2b6029e1da808127946bdff8
+  data.tar.gz: fdacb1fbf0720aba657351b072820ff220833880
 SHA512:
-  metadata.gz: 2231c4e3028feddc1b17ce1413d938518b27b11e14e84913683e90a1187c21b2ec47c91c1927116f063d11096d04822301b0c86fda17d3559b83cc3d2430e3b9
-  data.tar.gz: 1fe63baac8954e2b26774d7aa644ffaab0754c936a64fffca2c1f0e7edd3158995cf98a0d77a118c61695eee1d1b770ff799d752332dcf99470ed4e7564c9627
+  metadata.gz: b98d030553e32b3f719225347d5ff5b062aca530fcc91d811f85626c3cc806c4593d5c631b2ce77542a4ad26b6557649c0c5d17d049d77820abcabe298bb5ad6
+  data.tar.gz: 5bb64bddeee28f85607b75ddb6c5f606ad193b2da1551e7057c895008b2ba9c535a5973978874de573844ed6437cb04be8213485187eb18f8eea55c59f2e61b5

data/lib/pdf/margins/checker.rb

@@ -37,7 +37,11 @@ module PDF
 
           issues = []
 
-          Dir.glob("#{temp_dir_path}/*.png").each_with_index do |png_path, index|
+          files = Dir.glob("#{temp_dir_path}/*.png")
+          # ensure the files are sorted naturally
+          files = files.sort_by{ |f| f.split('/').last.to_i }
+
+          files.each_with_index do |png_path, index|
             image = ChunkyPNG::Image.from_file(png_path)
             page_number = index + 1
 
@@ -73,22 +77,26 @@ module PDF
 
       def dirty_top_margin?(image, mm)
         px = mm_to_pixels(mm)
+        return false if px.zero?
         dirty_pixels?(image, 0, px-1, 0, image.width-1)
       end
 
       def dirty_left_margin?(image, mm)
         px = mm_to_pixels(mm)
+        return false if px.zero?
         dirty_pixels?(image, 0, image.height-1, 0, px-1)
       end
 
       def dirty_right_margin?(image, mm)
         px = mm_to_pixels(mm)
+        return false if px.zero?
         offset = image.width - px - 1
         dirty_pixels?(image, 0, image.height-1, offset, image.width-1)
       end
 
       def dirty_bottom_margin?(image, mm)
         px = mm_to_pixels(mm)
+        return false if px.zero?
         offset = image.height - px - 1
         dirty_pixels?(image, offset, image.height-1, 0, image.width-1)
       end

data/lib/pdf/margins/version.rb

@@ -1,5 +1,5 @@
 module PDF
   module Margins
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/test/checker_test.rb

@@ -76,4 +76,14 @@ class CheckerTest < Test::Unit::TestCase
     ], checker.issues
   end
 
+  test "PDF with all dirty margins being checked as pages with a margin width of 0" do
+    checker = PDF::Margins::Checker.new(pdf_path('16-page-mini.pdf'), 0, 0, 0, 0, false)
+    assert_equal [], checker.issues
+  end
+
+  test "PDF with all dirty margins being checked as spreads with a margin width of 0" do
+    checker = PDF::Margins::Checker.new(pdf_path('16-page-mini.pdf'), 0, 0, 0, 0, true)
+    assert_equal [], checker.issues
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pdf_margins
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Tom Taylor
@@ -80,6 +80,7 @@ files:
 - Rakefile
 - README.md
 - test/checker_test.rb
+- test/pdfs/16-page-mini.pdf
 - test/pdfs/bottom-margin-only.pdf
 - test/pdfs/clear-margins-pages.pdf
 - test/pdfs/clear-margins-spreads.pdf
@@ -114,6 +115,7 @@ specification_version: 4
 summary: Simple library to checks whether the margins are clear in a PDF
 test_files:
 - test/checker_test.rb
+- test/pdfs/16-page-mini.pdf
 - test/pdfs/bottom-margin-only.pdf
 - test/pdfs/clear-margins-pages.pdf
 - test/pdfs/clear-margins-spreads.pdf