pdf_margins 0.0.2 → 0.1.1

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MmQwZDMwZTgyZWNlYWUzNGRmODUzZTkzYWRkMGViZTU5Mzg3NThjOA==
-  data.tar.gz: !binary |-
-    OGIyZjg0MzUyZmM4MjJlNDE2ZTFkMDg5MzE4NmUyMTAxNjIyZGI3MQ==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    M2QzN2FjMWFlN2Y5OTc4ZDM1YzIyNDZmMTVjMTc2NTdjMGY0NzI0ZDIwZTVm
-    YzgzZDA1OWIzN2E5NWIwMDM2MjM3OWYyZmVhZTE0YzkwZjcyYWYwZGIwMTZm
-    MTliZGMwMzkzMmFhZmY2OTAyMDFlMWIyOTNjMWFhMDVmYzM1NWE=
-  data.tar.gz: !binary |-
-    NDNiMzczMDkwYTkxYjRlN2E3Mzc5MDFlNDA0MmNlODU0YmQxNzA1Y2UyODdm
-    NzE4M2ZmZTg0MGY0MTVkZGQyZGI2ZTQ5MzM3NGExOWM2ODZjYmFmOTUyZjg1
-    ZjkwNjEwMjc4NGY2MjUyNGJhYWU4MzQ1ZTA2YjRmYzRjM2RhN2U=
+SHA1:
+  metadata.gz: 6065ffaa732ecbbbe1d9addb6275715ea9613596
+  data.tar.gz: 8a3e756c74ba210add152540fee7948255bd40ff
+SHA512:
+  metadata.gz: 5f89e8ca71ee8d320e7afc9cae7181a839429c23e306b6ce916a4294a6991bc9a4d99c407405d6f102648ab4bf489a0b5d73e97fff1fa68f4cd8eb8a4d569195
+  data.tar.gz: bc12bde2c429fe3eb0ed5b79daa775b837717a773b9ad391209f11c7747b544c650c9c984aecbe6c3c793a6f1d1b6fad57ecf504ffad4b9d5ddc58c3f29747bf

data/README.md

@@ -1,6 +1,9 @@
 pdf/margins
 ==
 
+[![Build
+Status](https://travis-ci.org/newspaperclub/pdf_margins.png)](https://travis-ci.org/newspaperclub/pdf_margins)
+
 Simple Ruby library to check a PDF for clear margin areas, by rendering to
 a CMYK bitmap, ensuring that the pixel area defined by each margin is empty.
 It's pretty slow, but this is a lot easier than attempting to work out which

data/lib/pdf/margins/checker.rb

@@ -12,15 +12,17 @@ module PDF
       SCALE_MULTIPLIER = 1 
       RESOLUTION = DEFAULT_RESOLUTION * SCALE_MULTIPLIER
 
-      attr_reader :file, :top_margin, :right_margin, :bottom_margin, :left_margin
+      attr_reader :file, :top_margin, :right_margin, :bottom_margin, :left_margin, :spreads
 
-      # Dimensions are in mm, to be converted to PDF points later.
-      def initialize(file, top_margin, right_margin, bottom_margin, left_margin)
+      # Dimensions are in mm, to be converted to PDF points later. Pass spreads
+      # as true to check left and right margins of spreads, not pages.
+      def initialize(file, top_margin, right_margin, bottom_margin, left_margin, spreads=false)
         @file          = file
         @top_margin    = top_margin
         @right_margin  = right_margin
         @bottom_margin = bottom_margin
         @left_margin   = left_margin
+        @spreads       = spreads
       end
 
       def issues
@@ -45,18 +47,12 @@ module PDF
               page_issues << Issue.new(page_number, :bottom)
             end
 
-            # Newspaper Club assumes that pages are two up, printed as spreads,
-            # so we only check right margins on odd numbered pages, and left
-            # margins on even numbered pages. This should probably be
-            # a configurable option for other types of printing.
-            if page_number % 2 == 0
-              if dirty_pixels?(left_pixels(image, left_margin))
-                page_issues << Issue.new(page_number, :left)
-              end
-            else
-              if dirty_pixels?(right_pixels(image, right_margin))
-                page_issues << Issue.new(page_number, :right)
-              end
+            if (!spreads || page_number % 2 == 0) && dirty_pixels?(left_pixels(image, left_margin))
+              page_issues << Issue.new(page_number, :left)
+            end
+            
+            if (!spreads || page_number % 2 != 0) && dirty_pixels?(right_pixels(image, right_margin))
+              page_issues << Issue.new(page_number, :right)
             end
           end
         end.flatten

data/lib/pdf/margins/version.rb

@@ -1,5 +1,5 @@
 module PDF
   module Margins
-    VERSION = "0.0.2"
+    VERSION = "0.1.1"
   end
 end

data/test/checker_test.rb

@@ -2,34 +2,78 @@ require 'test_helper'
 
 class CheckerTest < Test::Unit::TestCase
 
-  test "PDF with clear margins" do
-    checker = PDF::Margins::Checker.new(pdf_path('clear-margins.pdf'), 10, 10, 10, 10)
+  test "PDF as pages with clear margins tested as pages" do
+    checker = PDF::Margins::Checker.new(pdf_path('clear-margins-pages.pdf'), 15, 15, 15, 15)
     assert_equal [], checker.issues
   end
 
-  test "PDF with dirty left margin on page 1" do
-    checker = PDF::Margins::Checker.new(pdf_path('left-margin-only.pdf'), 10, 10, 10, 10)
+  test "PDF as spreads with clear margins tested as spreads" do
+    checker = PDF::Margins::Checker.new(pdf_path('clear-margins-spreads.pdf'), 15, 15, 15, 15, true)
     assert_equal [], checker.issues
   end
 
-  test "PDF with dirty left margin on page 2" do
-    checker = PDF::Margins::Checker.new(pdf_path('p2-left-margin-only.pdf'), 10, 10, 10, 10)
-    assert_equal [PDF::Margins::Issue.new(2, :left)], checker.issues
+  test "PDF as spreads with clear margins tested as pages" do
+    checker = PDF::Margins::Checker.new(pdf_path('clear-margins-spreads.pdf'), 15, 15, 15, 15)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :left),
+      PDF::Margins::Issue.new(2, :right),
+      PDF::Margins::Issue.new(3, :left),
+      PDF::Margins::Issue.new(4, :right)
+    ], checker.issues
   end
 
-  test "PDF with dirty right margin on page 1" do
-    checker = PDF::Margins::Checker.new(pdf_path('right-margin-only.pdf'), 10, 10, 10, 10)
-    assert_equal [PDF::Margins::Issue.new(1, :right)], checker.issues
+  test "PDF as pages with dirty left margin" do
+    checker = PDF::Margins::Checker.new(pdf_path('left-margin-only.pdf'), 15, 15, 15, 15)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :left)
+    ], checker.issues
   end
 
-  test "PDF with dirty top margin on page 1" do
-    checker = PDF::Margins::Checker.new(pdf_path('top-margin-only.pdf'), 10, 10, 10, 10)
-    assert_equal [PDF::Margins::Issue.new(1, :top)], checker.issues
+  test "PDF as pages with dirty right margin" do
+    checker = PDF::Margins::Checker.new(pdf_path('right-margin-only.pdf'), 15, 15, 15, 15)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :right)
+    ], checker.issues
   end
 
-  test "PDF with dirty bottom margin on page 1" do
-    checker = PDF::Margins::Checker.new(pdf_path('bottom-margin-only.pdf'), 10, 10, 10, 10)
-    assert_equal [PDF::Margins::Issue.new(1, :bottom)], checker.issues
+  test "PDF with dirty top margin as spreads" do
+    checker = PDF::Margins::Checker.new(pdf_path('top-margin-only.pdf'), 15, 15, 15, 15, true)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :top),
+      PDF::Margins::Issue.new(2, :top),
+      PDF::Margins::Issue.new(3, :top),
+      PDF::Margins::Issue.new(4, :top)
+    ], checker.issues
+  end
+
+  test "PDF with dirty bottom margin as spreads" do
+    checker = PDF::Margins::Checker.new(pdf_path('bottom-margin-only.pdf'), 15, 15, 15, 15, true)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :bottom),
+      PDF::Margins::Issue.new(2, :bottom),
+      PDF::Margins::Issue.new(3, :bottom),
+      PDF::Margins::Issue.new(4, :bottom)
+    ], checker.issues
+  end
+
+  test "PDF with dirty top margin as pages" do
+    checker = PDF::Margins::Checker.new(pdf_path('top-margin-only.pdf'), 15, 15, 15, 15)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :top),
+      PDF::Margins::Issue.new(2, :top),
+      PDF::Margins::Issue.new(3, :top),
+      PDF::Margins::Issue.new(4, :top)
+    ], checker.issues
+  end
+
+  test "PDF with dirty bottom margin as pages" do
+    checker = PDF::Margins::Checker.new(pdf_path('bottom-margin-only.pdf'), 15, 15, 15, 15)
+    assert_equal [
+      PDF::Margins::Issue.new(1, :bottom),
+      PDF::Margins::Issue.new(2, :bottom),
+      PDF::Margins::Issue.new(3, :bottom),
+      PDF::Margins::Issue.new(4, :bottom)
+    ], checker.issues
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pdf_margins
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.1
 platform: ruby
 authors:
 - Tom Taylor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-15 00:00:00.000000000 Z
+date: 2013-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rmagick
@@ -28,28 +28,28 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -67,9 +67,10 @@ files:
 - README.md
 - test/checker_test.rb
 - test/pdfs/bottom-margin-only.pdf
-- test/pdfs/clear-margins.pdf
+- test/pdfs/clear-margins-pages.pdf
+- test/pdfs/clear-margins-spreads.pdf
 - test/pdfs/left-margin-only.pdf
-- test/pdfs/p2-left-margin-only.pdf
+- test/pdfs/margins.indd
 - test/pdfs/right-margin-only.pdf
 - test/pdfs/top-margin-only.pdf
 - test/test_helper.rb
@@ -83,26 +84,27 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.2
 signing_key: 
 specification_version: 4
 summary: Simple library to checks whether the margins are clear in a PDF
 test_files:
 - test/checker_test.rb
 - test/pdfs/bottom-margin-only.pdf
-- test/pdfs/clear-margins.pdf
+- test/pdfs/clear-margins-pages.pdf
+- test/pdfs/clear-margins-spreads.pdf
 - test/pdfs/left-margin-only.pdf
-- test/pdfs/p2-left-margin-only.pdf
+- test/pdfs/margins.indd
 - test/pdfs/right-margin-only.pdf
 - test/pdfs/top-margin-only.pdf
 - test/test_helper.rb