pdf_cover 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25df97778fee656bffdf8fd3bc52cb42e554c43d
-  data.tar.gz: 75fdc0c927f65e3dbf7d6d9b689af46f12ec4b47
+  metadata.gz: 50f84966f940de9a7a2c76e5befb83f5365b3e94
+  data.tar.gz: 4813cc9fbec831e8951fb6d11cf74ab172372f17
 SHA512:
-  metadata.gz: cefbf74ed928e7b33de7554cd107a9d56aec18caf605488cf23376e00c8ffa54214ee90755560c787746f0924d69738dd5cfefeca00be0128102cddcc25ea39a
-  data.tar.gz: 70af3e25382ee8b3ee02f3791520d69562859e6d83187c520953607353303a32394fe8db259589cbf7aa7f1d888cef2a1fa320098a59d5a331547f36c6e8e22e
+  metadata.gz: a10fe4bba5600588ad392490a034b97c40e375e86d8f9818562c8c89544b4499ac0c48721a6b72a9407dee97090b7c877a4183cdd7f66b97a6dda4eda5022f7b
+  data.tar.gz: 2d308c23e2cdc4f5f12892d03fdacac234a84c3103171521d29ebf206019e335466263b670b1c9a92ffc34b724544e731fb0650bb091926ec6d30e0980e65467

data/lib/pdf_cover/converter.rb

@@ -1,3 +1,5 @@
+require "open3"
+
 module PdfCover
   class Converter
     # NOTE: Update the generate_jpegs.sh script when changing these values
@@ -5,6 +7,15 @@ module PdfCover
     DEFAULT_QUALITY = 85
     DEFAULT_RESOLUTION = 300
 
+    COMMAND_EXECUTION_SUCCESS_CODE = 0
+    COMMAND_NOT_FOUND_CODE = 127 # @see http://www.tldp.org/LDP/abs/html/exitcodes.html
+
+    class CommandFailedError < StandardError
+      def initialize(stdout_str, stderr_str)
+        super("PDF conversion failed:\nSTDOUT: #{stdout_str}\nSTDERR: #{stderr_str}")
+      end
+    end
+
     class CommandNotFoundError < StandardError
       def initialize
         super("Could not run the `gs` command. Make sure that GhostScript is in your PATH.")
@@ -23,15 +34,19 @@ module PdfCover
     end
 
     # @raises PdfCover::Converter::CommandNotFoundError if GhostScript is not found
+    # @raises PdfCover::Converter::CommandFailedError if GhostScript returns a non-zero status
     def converted_file
-      case convert_file
-        when :ok
-          destination_file
-        when :command_failed
-          @file
-        when :command_not_found
-          fail CommandNotFoundError
+      parameters = build_parameters(file_path, device)
+      stdout_str, stderr_str, status = execute_command("gs #{parameters}")
+
+      case status
+        when COMMAND_EXECUTION_SUCCESS_CODE then destination_file
+        when COMMAND_NOT_FOUND_CODE then fail CommandNotFoundError
+        else fail CommandFailedError.new(stdout_str, stderr_str)
       end
+    rescue => e
+      destination_file.close
+      raise e
     end
 
     private
@@ -40,8 +55,8 @@ module PdfCover
       @basename ||= File.basename(@file.path, File.extname(@file.path))
     end
 
-    def build_parameters(source, device, destination)
-      %W(-sOutputFile='#{destination}' -dNOPAUSE
+    def build_parameters(source, device)
+      %W(-sOutputFile='#{destination_path}' -dNOPAUSE
          -sDEVICE='#{device}' -dJPEGQ=#{@quality}
          -dFirstPage=1 -dLastPage=1
          -r#{@resolution} -q '#{source}'
@@ -49,29 +64,22 @@ module PdfCover
       ).join(" ")
     end
 
-    def convert_file
-      parameters = build_parameters(file_path, device, File.expand_path(destination_file.path))
-      result = execute_command("gs #{parameters}")
-
-      if result
-        :ok
-      else
-        failed_result(result)
-      end
-    end
-
     def destination_file
       @destination_file ||= Tempfile.new([basename, ".#{@format}"]).tap do |file|
         file.binmode
       end
     end
 
+    def destination_path
+      File.expand_path(destination_file.path)
+    end
+
     def device
       @format.to_s == "jpg" ? "jpeg" : @format.to_s
     end
 
     def execute_command(command)
-      Kernel.system(command)
+      Open3.capture3(command)
     end
 
     def extract_options(options)
@@ -84,23 +92,8 @@ module PdfCover
       fail InvalidOption.new(:resolution, @resolution) unless @resolution > 1
     end
 
-    def failed_result(result)
-      destination_file.close
-
-      if result == false
-        logger.warn("GhostScript execution failed: #{$CHILD_STATUS}")
-        :command_failed
-      else
-        :command_not_found
-      end
-    end
-
     def file_path
       @file_path ||= File.expand_path(@file.path)
     end
-
-    def logger
-      @logger ||= defined?(Rails) ? Rails.logger : Logger.new(STDERR)
-    end
   end
 end

data/lib/pdf_cover/version.rb

@@ -1,3 +1,3 @@
 module PdfCover
-  VERSION = "0.1.4".freeze
+  VERSION = "0.2.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pdf_cover
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - Juan González
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-12 00:00:00.000000000 Z
+date: 2016-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print