pdc 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92f8058cc0be41a5a3c04adfa2746b6e5220a2c7
-  data.tar.gz: 80cc4a9ccab91400ac9b24cb423ee817489ed4eb
+  metadata.gz: 5a63a931b11dc86a0902d4632e3a6cdfc8ac3812
+  data.tar.gz: 18be45c56ab85aeb2ebced876758df49052fdb32
 SHA512:
-  metadata.gz: 7775dc341f3444c9aec9e233d406c44da542ea4e6646764020e461d78ea974dae1c8b8f45fe2c54ff1f760642360d7ba16d3ef271894c3e8d81ff86825fcb599
-  data.tar.gz: bafeac858e978afbde52515f7d0011806598d334f92e658c29c6d19a4b6445fddfc3b94624f430ee0797280fac688dc2f0a3363f902849b6922a38d3b5a884fe
+  metadata.gz: 28df5bd5f63bef0af4d6122df37f3552df06ccb4bf108283f5396224fb1746e3c62a500d145bcfc3b38a16371e9394043e55a788f5af9be3b77daa23953d4ff1
+  data.tar.gz: 0e316110d183aab7b67357816124daa0b825b5b9d35fd56abf43093972607b4e1c066c85c89d5acd5afff6f7d8c09a108cf2d462a769c90fe5908cfd43e31aa8

data/.pronto.yml

@@ -0,0 +1,13 @@
+all:
+  exclude:
+    - 'spec/**/*'
+# exclude files for single runner
+eslint:
+  exclude:
+    - 'app/assets/**/*'
+github:
+  slug: product-definition-center/pdc-ruby-gem
+  api_endpoint: https://api.github.com/
+  web_endpoint: https://github.com/
+max_warnings: 150
+verbose: false

data/.rubocop.yml

@@ -0,0 +1,23 @@
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+
+  Exclude:
+    - spec/**/*
+
+Style/Documentation:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+  EnforcedStyle: compact
+
+Metrics/LineLength:
+  Max: 100
+
+Metrics/MethodLength:
+  Max: 25
+
+Metrics/AbcSize:
+  Max: 25
+

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+cache: bundler
 rvm:
 - 2.2.2
 addons:
@@ -8,14 +9,24 @@ addons:
 before_install: gem install bundler -v 1.11.2
 install:
 - bundle install --jobs=3 --retry=4
-- gem install coveralls
 - git config --global user.name  "Travis CI"
 - git config --global user.email "pdc@product-definition-center.com"
 - export REPO_URL_GITHUB="https://$GH_TOKEN@github.com/$GH_REPO.git"
+- export GITHUB_ACCESS_TOKEN=$GH_TOKEN
 script:
 - bundle exec rake test
-- if [ "$TRAVIS_BRANCH" = "master" -a "$TRAVIS_PULL_REQUEST" = "false" ]; then make deploy_doc; fi
+- >
+  if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then
+    bundle exec pronto run -f github_pr -c origin/${TRAVIS_BRANCH}
+  fi
+
+after_success:
+- >
+  [ "$TRAVIS_BRANCH" = "master" ] &&
+  [ "$TRAVIS_PULL_REQUEST" = "false" ] &&
+    make deploy_doc
 env:
   global:
   - GH_REPO="product-definition-center/pdc-ruby-gem"
+  - PULL_REQUEST_ID=${TRAVIS_PULL_REQUEST}
   - secure: Mf6k7ZwdsOOzP4woIo9z3X8e8hYZUOitBYPVOBeWpXPY8rruet3DhRYAEMNqf8iH9YAVqssE4Q0j76PQrQ6WyX+TXnayl62VAGeRjwQt4rs3orDjN+lZSP1tMt8w5fN906XeV2pcbuahRU1cFEEJ6iWhTbvhvgugsmuo8dzoS5uLRtv+VopyZjJaOqvsk5wCPKMKQLAqCvYDf2ugCm2qI3+FdjQb24WaTMLmF+vVXQSGvOpXx8Z6gLZRk0/bZeBLxFLFJcAFnRdbC09YI8Jt5nmwg7Lc+mX19qGUmracsYz2KKTDg3XC2b4n4O63woQFdwwvj0LQIoLmc/6YoxIPuCDQ92oXVCDGHB9kTh3GPxHPVwWsveg8Auvj0cPMSOTZId46Jox8sOXlIxZD0xXHiq8XQ1WSYJm0LJheO9mZHV4DIHp0o0Zm7ii7cxkb2It0c2oACRpiyBmXPfGKwNoMgfAzPo4dbbmbqoRD6XxxzLxKNwhKOAtcBMs6j/dKlKyo12h79+yqlkcYmvOLp+Bz/NqRRN63j1h5wR2Irl95uLv2PN26k2sod+Kmk22IcmDJP80ha/IodcxmPIDTZKnqLd7bcaK3mHvZMQ1DsKeuktaqKvnK8fdaZHAhVSfUlu0yCi5PfiH28+HbdpSK6VHQhH7c9/YgwrS9sgcE0Kh1Mw0=

data/Gemfile

@@ -1,31 +1,37 @@
 source 'https://rubygems.org'
 
 group :tools do
-  gem 'rubocop'
   gem 'guard', '<= 2.12.0'
   gem 'guard-minitest', '~> 2.4.4'
   gem 'guard-shell'
 end
 
 group :development do
-  gem 'rake', '~> 10.0'
-  gem 'rake-notes'
-  gem 'colorize'
   gem 'awesome_print'
+  gem 'colorize'
   gem 'pry'
   gem 'pry-byebug'
+  gem 'rake', '~> 10.0'
+  gem 'rake-notes'
 end
 
 group :test do
-  gem 'mocha'
-  gem 'webmock', '~> 1.18.0'
-  gem 'minitest-reporters', '~> 1.1.9'
-  gem 'minitest-focus'
-  gem 'simplecov'
   gem 'coveralls'
+  gem 'minitest-focus'
+  gem 'minitest-reporters', '~> 1.1.9'
+  gem 'mocha'
   gem 'rack', '~> 1.4.7'
-  gem 'vcr'
+  gem 'simplecov'
   gem 'timecop'
+  gem 'vcr'
+  gem 'webmock', '~> 1.18.0'
+end
+
+group :development, :test do
+  # Pronto
+  gem 'pronto'
+  gem 'pronto-flay', require: false
+  gem 'pronto-rubocop', require: false
 end
 
 # Specify your gem's dependencies in pdc-ruby.gemspec

data/Rakefile

@@ -1,10 +1,10 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 require 'rake/notes/rake_task'
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << "spec"
-  t.libs << "lib"
+  t.libs << 'spec'
+  t.libs << 'lib'
   t.test_files = FileList['spec/**/*_spec.rb']
 end
 

data/bin/console

@@ -1,11 +1,11 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "pry"
-require "ap"
+require 'bundler/setup'
+require 'pry'
+require 'ap'
 
-require "pdc"
-require_relative "../spec/support/fixtures"
+require 'pdc'
+require_relative '../spec/support/fixtures'
 
 include Fixtures
 Pry.start

data/examples/logger.rb

@@ -1,15 +1,19 @@
 require_relative '../lib/pdc'
 require 'ap'
 
+# :nodoc:
 class FakeLogger
   attr_accessor :level
 
   def debug(*args)
   end
+
   def info(*args)
   end
+
   def warn(*args)
   end
+
   def fatal(*args)
   end
 
@@ -17,22 +21,21 @@ class FakeLogger
   end
 end
 
-#PDC.logger = FakeLogger.new
-
+# PDC.logger = FakeLogger.new
 
 logger = PDC.logger
 
-logger.debug("Debug will be logged")
-logger.info("Info will be logged as well")
+logger.debug('Debug will be logged')
+logger.info('Info will be logged as well')
 
 logger.level = Logger::WARN
 
-logger.debug("Created logger")    # won't be logged
-logger.info("Program started")    # won't be logged
-logger.warn("Nothing to do!")
-logger.error("Error something really went wrong")
+logger.debug('Created logger')    # won't be logged
+logger.info('Program started')    # won't be logged
+logger.warn('Nothing to do!')
+logger.error('Error something really went wrong')
 
-path = "a_non_existent_file"
+path = 'a_non_existent_file'
 
 begin
   File.foreach(path) do |line|
@@ -41,10 +44,9 @@ begin
     end
   end
 rescue => err
-  logger.fatal("Caught exception; exiting")
+  logger.fatal('Caught exception; exiting')
   logger.fatal(err)
 end
 
 logger.level = Logger::INFO
-logger.info("will continue here")
-
+logger.info('will continue here')

data/examples/pdc_curb_access_token.rb

@@ -7,7 +7,7 @@ def obtain_token
   url = PDC.config.site + PDC.config.rest_api_path + '/' + PDC.config.token_obtain_path
 
   c = Curl::Easy.new(url) do |request|
-    request.headers["Accept"] = "application/json"
+    request.headers['Accept'] = 'application/json'
     request.http_auth_types = :gssnegotiate
 
     # The curl man page (http://curl.haxx.se/docs/manpage.html) specifes

data/examples/pdc_release_rpm_mapping.rb

@@ -0,0 +1,16 @@
+require './lib/pdc'
+
+def main
+  PDC.configure do |config|
+    config.site = 'https://pdc.engineering.redhat.com'
+    config.log_level = :debug
+    config.disable_caching = true
+  end
+
+  mapping = PDC::V1::ReleaseRpmMapping.where(
+    release_id: 'ceph-2.1-updates@rhel-7', package: 'ceph'
+  ).first
+  puts mapping.mapping
+end
+
+main if __FILE__ == $PROGRAM_NAME

data/examples/pdc_resource_tests.rb

@@ -171,3 +171,25 @@ describe PDC::V1::ReleaseVariant do
     end
   end
 end
+
+# using prod server to test PDC::V1::ReleaseRpmMapping
+pdc = server[:prod]
+
+PDC.configure do |config|
+  config.site = pdc[:site]
+  auth_token = pdc[:token]
+  config.token = pdc[:token].call if auth_token
+  config.requires_token = auth_token.present? # to_bool
+end
+
+describe PDC::V1::ReleaseRpmMapping do
+  let(:mapping) do
+    PDC::V1::ReleaseRpmMapping.where(
+      release_id: 'ceph-2.1-updates@rhel-7',
+      package: 'ceph'
+    ).first
+  end
+  it 'must has compose' do
+    mapping.mapping.must_be_instance_of OpenStruct
+  end
+end

data/examples/pdc_test_cache.rb

@@ -7,17 +7,18 @@ PDC.configure do |config|
   # dev server
   config.site = 'https://pdc.host.dev.eng.pek2.redhat.com/'
   config.cache_store = ActiveSupport::Cache.lookup_store(
-    :file_store, [File.join(ENV['TMPDIR'] || '/tmp', 'cache')])
+    :file_store, [File.join(ENV['TMPDIR'] || '/tmp', 'cache')]
+  )
   config.log_level = :info
 end
 
-ActiveSupport::Notifications.subscribe "http_cache.faraday" do |*args|
+ActiveSupport::Notifications.subscribe 'http_cache.faraday' do |*args|
   event = ActiveSupport::Notifications::Event.new(*args)
-  puts " >>> " + "cache: #{event.payload[:cache_status]}"
+  puts ' >>> ' + "cache: #{event.payload[:cache_status]}"
   ap event.payload
 end
 
-def benchmark(description, opts = {}, &block)
+def benchmark(description, _opts = {}, &block)
   puts "Running: #{description}"
 
   initial = Benchmark.measure(&block)
@@ -28,19 +29,19 @@ def benchmark(description, opts = {}, &block)
 end
 
 def main
-  benchmark "fetch all" do
+  benchmark 'fetch all' do
     PDC::V1::Release.all
   end
 
-  benchmark "fetch with page number" do
+  benchmark 'fetch with page number' do
     PDC::V1::Release.page(2).contents!
   end
 
-  benchmark "fetch with page number and size" do
+  benchmark 'fetch with page number and size' do
     PDC::V1::Release.page(2).page_size(30).contents!
   end
 
-  benchmark "fetch with page number and size and query condition" do
+  benchmark 'fetch with page number and size and query condition' do
     PDC::V1::Release.page(2).page_size(30).where(active: true).contents!
   end
 end

data/examples/prod_failures.rb

@@ -23,4 +23,4 @@ def main
   end
 end
 
-main if __FILE__ == $0
+main if __FILE__ == $PROGRAM_NAME

data/examples/prod_pdc.rb

@@ -11,4 +11,4 @@ def main
   ap releases
 end
 
-main if __FILE__ == $0
+main if __FILE__ == $PROGRAM_NAME

data/lib/pdc/base.rb

@@ -8,7 +8,7 @@ module PDC
     include PDC::Resource::Scopes
     include PDC::Resource::RestApi
 
-    scope :page, ->(value) { where(:page => value) }
-    scope :page_size, ->(value) { where(:page_size => value) }
+    scope :page, ->(value) { where(page: value) }
+    scope :page_size, ->(value) { where(page_size: value) }
   end
 end

data/lib/pdc/config.rb

@@ -1,6 +1,7 @@
 require 'faraday-http-cache'
 require 'pdc/http/request/token_fetcher'
 
+# rubocop:disable ModuleLength
 module PDC
   # This class is the main access point for all PDC::Resource instances.
   #
@@ -34,7 +35,7 @@ module PDC
       :logger,
 
       :cache_store,
-      :disable_caching,
+      :disable_caching
     ) do
       def initialize
         # site config
@@ -93,61 +94,60 @@ module PDC
 
     private
 
-      def apply_config
-        reset_logger
-        reset_token_fetcher
-        reset_base_connection
-      end
+    def apply_config
+      reset_logger
+      reset_token_fetcher
+      reset_base_connection
+    end
 
-      def reset_logger
-        PDC.logger = Logger.new(nil) unless config.enable_logging
-        logger.level = Logger.const_get(config.log_level.upcase)
-      end
+    def reset_logger
+      PDC.logger = Logger.new(nil) unless config.enable_logging
+      logger.level = Logger.const_get(config.log_level.upcase)
+    end
 
-      def reset_token_fetcher
-        Request::TokenFetcher.configure do |c|
-          c.url = token_url
-          c.ssl_verify_mode = config.ssl_verify_mode
-        end
+    def reset_token_fetcher
+      Request::TokenFetcher.configure do |c|
+        c.url = token_url
+        c.ssl_verify_mode = config.ssl_verify_mode
       end
+    end
 
-      # resets and returns the +Faraday+ +connection+ object
-      def reset_base_connection
-
-        faraday_config = {
-          url:      api_url,
-          headers:  PDC::Request.default_headers,
-          ssl:      ssl_config
-        }
-
-        PDC::Base.connection = Faraday.new(faraday_config) do |c|
-          c.request   :append_slash_to_path
-          c.request   :pdc_token, token: config.token if config.requires_token
-
-          c.response  :logger, config.logger
-          c.response  :pdc_paginator
-          c.response  :pdc_json_parser
-          c.response  :raise_error
-          c.response  :pdc_raise_error
-
-          c.use       FaradayMiddleware::FollowRedirects
-
-          unless config.disable_caching
-            c.use       Faraday::HttpCache, store: cache_store,
-                          logger: PDC.logger,
-                          instrumenter: ActiveSupport::Notifications
-          end
-          c.adapter   Faraday.default_adapter
+    # resets and returns the +Faraday+ +connection+ object
+    # rubocop:disable AbcSize
+    def reset_base_connection
+      faraday_config = {
+        url:      api_url,
+        headers:  PDC::Request.default_headers,
+        ssl:      ssl_config
+      }
+
+      PDC::Base.connection = Faraday.new(faraday_config) do |c|
+        c.request   :append_slash_to_path
+        c.request   :pdc_token, token: config.token if config.requires_token
+
+        c.response  :logger, config.logger
+        c.response  :pdc_paginator
+        c.response  :pdc_json_parser
+        c.response  :raise_error
+        c.response  :pdc_raise_error
+
+        c.use       FaradayMiddleware::FollowRedirects
+
+        unless config.disable_caching
+          c.use Faraday::HttpCache, store: cache_store,
+                                    logger: PDC.logger,
+                                    instrumenter: ActiveSupport::Notifications
         end
+        c.adapter Faraday.default_adapter
       end
+    end
 
-      def ssl_config
-        { verify: config.ssl_verify_mode == OpenSSL::SSL::VERIFY_PEER }
-      end
-
-      def cache_store
-        config.cache_store || ActiveSupport::Cache.lookup_store(:memory_store)
-      end
+    def ssl_config
+      { verify: config.ssl_verify_mode == OpenSSL::SSL::VERIFY_PEER }
+    end
 
+    def cache_store
+      config.cache_store || ActiveSupport::Cache.lookup_store(:memory_store)
+    end
   end
 end

data/lib/pdc/http/request/append_slash.rb

@@ -2,7 +2,7 @@ module PDC
   class Request::AppendSlashToPath < Faraday::Middleware
     include PDC::Logging
 
-    Faraday::Request.register_middleware :append_slash_to_path => self
+    Faraday::Request.register_middleware append_slash_to_path: self
 
     def call(env)
       logger.debug "\n..... append slash .........................................."

data/lib/pdc/http/request/pdc_token.rb

@@ -1,5 +1,4 @@
 module PDC::Request
-
   # Adds TokenAuthentication to request header. Uses the token if passed
   # else fetches token using the TokenFetcher to get the token once
   class Token < Faraday::Middleware
@@ -20,11 +19,11 @@ module PDC::Request
 
     private
 
-      attr_reader :options
+    attr_reader :options
 
-      # uses the token passed or fetches one only once
-      def token
-        @token ||= options[:token] || TokenFetcher.fetch
-      end
+    # uses the token passed or fetches one only once
+    def token
+      @token ||= options[:token] || TokenFetcher.fetch
+    end
   end
 end

data/lib/pdc/http/request/token_fetcher.rb

@@ -3,7 +3,6 @@ require 'json'
 
 module PDC::Request
   module TokenFetcher
-
     module Configuration
       VALID_KEYS = [:ssl_verify_mode, :url].freeze
 

data/lib/pdc/http/response/pagination.rb

@@ -2,7 +2,7 @@ module PDC::Response
   class Paginator < Faraday::Response::Middleware
     include PDC::Logging
 
-    Faraday::Response.register_middleware :pdc_paginator => self
+    Faraday::Response.register_middleware pdc_paginator: self
 
     def parse(json)
       logger.debug "\n.....paginate json ....................................."
@@ -18,7 +18,7 @@ module PDC::Response
         # schema://host:port/ of the next and previous
 
         next_page:        request_uri(metadata.delete(:next)),
-        previous_page:    request_uri(metadata.delete(:previous)),
+        previous_page:    request_uri(metadata.delete(:previous))
       }
 
       logger.debug '... after parsing pagination data:'
@@ -35,9 +35,8 @@ module PDC::Response
 
     def paginated?(metadata)
       metadata[:count].is_a?(Numeric) &&
-      metadata.key?(:next) &&
-      metadata.key?(:previous)
+        metadata.key?(:next) &&
+        metadata.key?(:previous)
     end
-
   end
 end

data/lib/pdc/http/response/parser.rb

@@ -5,20 +5,20 @@ module PDC::Response
   class Parser < Faraday::Response::Middleware
     include PDC::Logging
 
-    Faraday::Response.register_middleware :pdc_json_parser => self
+    Faraday::Response.register_middleware pdc_json_parser: self
 
     def parse(body)
       logger.debug "\n.....parse to json ....................................."
       logger.debug self.class
 
-      logger.debug '... parsing' +  body.to_s.truncate(55)
+      logger.debug '... parsing' + body.to_s.truncate(55)
       begin
         json = MultiJson.load(body, symbolize_keys: true)
       rescue MultiJson::ParseError => e
         raise PDC::JsonParseError, e
       end
 
-      res = {
+      {
         data:     extract_data(json),     # Always an Array
         errors:   extract_errors(json),   #
         metadata: extract_metadata(json)  # a hash
@@ -29,7 +29,7 @@ module PDC::Response
 
     def extract_data(json)
       return [] if error?(json)
-      return json[:results] if has_metadata?(json)
+      return json[:results] if metadata_present?(json)
       Array.wrap(json)
     end
 
@@ -38,11 +38,11 @@ module PDC::Response
     end
 
     def extract_metadata(json)
-      return json.except(:details, :results) if has_metadata?(json)
+      return json.except(:details, :results) if metadata_present?(json)
       data_only?(json) ? { count: json.length, next: nil, previous: nil } : {}
     end
 
-    def has_metadata?(json)
+    def metadata_present?(json)
       return false if data_only?(json) || error?(json)
 
       json[:results].is_a?(Array) &&

data/lib/pdc/resource/attribute_store.rb

@@ -8,15 +8,11 @@ module PDC::Resource
 
     private
 
-      def parse_value(value)
-
-        case
-        when value.is_a?(PDC::Base)           then value.attributes.to_params
-        when value.is_a?(Array)               then value.map { |v| parse_value(v) }
-        else value
-        end
+    def parse_value(value)
+      if value.is_a?(PDC::Base) then value.attributes.to_params
+      elsif value.is_a?(Array) then value.map { |v| parse_value(v) }
+      else value
       end
-
+    end
   end
 end
-