pco-url 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76f3a85257c51534d6c3c3b7cff02ef4e7ed031c
-  data.tar.gz: ed00adc04d8cf9cee80436b6d1202d8865d395cf
+  metadata.gz: ffffc4ec52600a23d033d2b75f4a7f0bc74db900
+  data.tar.gz: 7cd6fae8170dc6493aaffc2ad12ad776142cefcc
 SHA512:
-  metadata.gz: 18af49899e23166c8725c1e0c74cae5f4b4399b09dc274df17f33198684cf7921382e53766ed743d02e6550e6a975e6a33f0f468dfaad3b76dddf061fe8b83d1
-  data.tar.gz: 52248aba5e80184092128fd36984cf5047a60222d45e311448c3170506a632d5cbd2d4103532ed427d8dd55cc9c80ca1daa94d598d43b156037e89b881f48583
+  metadata.gz: fffaf131fa4586c17340d679e0545a314167dea60c1c027cac95b87ef0ad663295259e89d5a61b6fba0e337f96febd86e3ac6c49b64aecfffbf02dfa1f101c09
+  data.tar.gz: 67595608b41b2d9ea1493dac83bb938986f5def9834b6a6dd5328017bb4f59b4847068cce870b310f69907dc5f80a8ce46725c21010494d38457be4660924f8d

data/lib/pco/url/version.rb

@@ -1,5 +1,5 @@
 module PCO
   class URL
-    VERSION = "1.1.0"
+    VERSION = "1.2.0"
   end
 end

data/lib/pco/url.rb

@@ -4,29 +4,12 @@ module PCO
   class URL
 
     class << self
-      def applications
-        @applications ||= [
-          :accounts,
-          :avatars,
-          :services,
-          :check_ins,
-          :people,
-          :registrations,
-          :resources
-        ]
-      end
-      attr_writer :applications
-
       def method_missing(method_name)
-        if applications.include? method_name
-          app_name = method_name.to_s.gsub("_", "-")
-          env_var  = method_name.to_s.upcase + "_URL"
+        app_name = method_name.to_s.gsub("_", "-")
+        env_var  = method_name.to_s.upcase + "_URL"
 
-          # Try "CHECK_INS_URL" then url_for_app("check-ins")
-          ENV[env_var] || url_for_app(app_name)
-        else
-          super
-        end
+        # Try "CHECK_INS_URL" then url_for_app("check-ins")
+        ENV[env_var] || url_for_app(app_name)
       end
 
       private
@@ -48,5 +31,6 @@ module PCO
         end
       end
     end
+
   end
 end

data/spec/pco_url_spec.rb

@@ -1,5 +1,15 @@
 require "spec_helper"
 
+Applications = [
+  :accounts,
+  :avatars,
+  :services,
+  :check_ins,
+  :people,
+  :registrations,
+  :resources
+]
+
 describe PCO::URL do
   describe "defaults" do
     describe "development" do
@@ -7,7 +17,7 @@ describe PCO::URL do
         Rails.env = "development"
       end
 
-      PCO::URL.applications.map(&:to_s).each do |app|
+      Applications.map(&:to_s).each do |app|
         it "has an #{app} URL" do
           expect(PCO::URL.send(app)).to eq("http://#{app.gsub('_','-')}.pco.dev")
         end
@@ -19,7 +29,7 @@ describe PCO::URL do
         Rails.env = "staging"
       end
 
-      PCO::URL.applications.map(&:to_s).each do |app|
+      Applications.map(&:to_s).each do |app|
         it "has an #{app} URL" do
           expect(PCO::URL.send(app)).to eq("https://#{app.gsub('_','-')}-staging.planningcenteronline.com")
         end
@@ -31,7 +41,7 @@ describe PCO::URL do
         Rails.env = "production"
       end
 
-      PCO::URL.applications.map(&:to_s).each do |app|
+      Applications.map(&:to_s).each do |app|
         it "has an #{app} URL" do
           expect(PCO::URL.send(app)).to eq("https://#{app.gsub('_','-')}.planningcenteronline.com")
         end
@@ -43,7 +53,7 @@ describe PCO::URL do
         Rails.env = "test"
       end
 
-      PCO::URL.applications.map(&:to_s).each do |app|
+      Applications.map(&:to_s).each do |app|
         it "has an #{app} URL" do
           expect(PCO::URL.send(app)).to eq("http://#{app.gsub('_','-')}.pco.test")
         end
@@ -88,24 +98,4 @@ describe PCO::URL do
     end
   end
 
-  describe "custom applications" do
-    before do
-      Rails.env = "development"
-      ENV["DEPLOY_ENV"] = nil
-    end
-
-    describe "adding an app" do
-      it "adds a URL method for bazinga" do
-        PCO::URL.applications += [:bazinga]
-        expect(PCO::URL.bazinga).to eq("http://bazinga.pco.dev")
-      end
-    end
-
-    describe "removing an app" do
-      it "removes the URL method for accounts" do
-        PCO::URL.applications -= [:accounts]
-        expect{PCO::URL.accounts}.to raise_error(NoMethodError)
-      end
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pco-url
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - James Miller