pcbr 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ce39501eee28e4881d896c138a0049899912b8a
-  data.tar.gz: 68060e95d3921de4b105fd48227fc776d93ff744
+  metadata.gz: 94c525ae292660782aa466569e23c274024e1220
+  data.tar.gz: 409faba010ccd426ad3f5cab17aa0f9470f680b7
 SHA512:
-  metadata.gz: b7c3edd47fd4012722dffd750833187b5951943543aca19b3b507409f787f5ec60ea1e08adb337967770a9d4494ec8e0cc7d18337a0ae68230f0b42f226101be
-  data.tar.gz: 93051d2392065a23d4cb2918c79771e11cb08a1c6df7a13489f6bc58fe2284beb5410b850eec86251f94eed3f28e015664c3bf9d93ea1e073965fcafd160003a
+  metadata.gz: 4caa489706874b4ff8bf10d9a535485f083b5e8566d5ee97317541fc3d3f2193ffd8e557e23f50140482d0fa3200e9d5557cc7ec2719e11d5f683a8be01f77e7
+  data.tar.gz: 6390f836a93fc357aa7c184d6df9fbf1ac007077ebb4fc08d0312600798407abbd9136cb3d98da8ddcf5f506852e62dd85d531f33a1ac27e4358f5484f199a7e

data/lib/pcbr.rb

@@ -1,8 +1,4 @@
-require "deep_dup"
-
 module PCBR
-  VERSION = "0.3.0"
-
   class Error < RuntimeError
     # def initialize body
     #   super "#{Module.nesting[1]} error: #{body}"
@@ -30,11 +26,11 @@ module PCBR
 
     def store key, vector = nil
       raise Error.new "duplicating key" if @table.assoc key
-      key = DeepDup.deep_dup key
-      vector = if vector
-        DeepDup.deep_dup vector
-      else
+      key = [NilClass, FalseClass, TrueClass, Numeric, Symbol, Method].any?{ |c| key.is_a? c } ? key : key.dup
+      vector = if vector.nil?
         Array key
+      else
+        vector
       end
       score = 0
       @table.each do |item|

data/pcbr.gemspec

@@ -1,17 +1,19 @@
 Gem::Specification.new do |spec|
   spec.name          = "pcbr"
-  spec.version       = (require_relative "lib/pcbr"; PCBR::VERSION)
+  spec.version       = "0.4.0"
+  spec.summary       = "Pair Comparison Based Rating"
+
   spec.author        = "Victor Maslov"
   spec.email         = "nakilon@gmail.com"
-  spec.summary       = "Pair Comparison Based Rating"
-  spec.description   = "Making ratings is fun. After applying my method several times I've decided to gemify it."
-  spec.homepage      = "https://github.com/Nakilon/pcbr"
   spec.license       = "MIT"
+  spec.homepage      = "https://github.com/Nakilon/pcbr"
+  spec.description   = <<-EOF
+    Making ratings is fun. After applying my method several times I've decided to gemify it.
+    This is one of the first gems I made so it's far for being nicely done.
+  EOF
 
-  spec.files         = `git ls-files -z`.split("\x0")
   spec.test_files    = ["spec/"]
-
-  spec.add_dependency "deep_dup"
+  spec.files         = `git ls-files -z`.split(?\0) - spec.test_files
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rspec", "~> 3.3.0"

data/spec/_spec.rb

@@ -83,16 +83,23 @@ describe "basic specs" do
     expect{ rating.store 0 }.to raise_error PCBR::Error
   end
 
-  example "keys and vectors are dupped" do
+  example "keys are dupped" do
     rating = PCBR.new
     a = [[1]]
     v = [0]
     rating.store a, v
     a[0][0] = 2
-    rating.store [[2]], [1]   # expect no PCBR::Error
-    v[0] = 3
-    rating.store [[3]], [2]
-    expect(rating.sorted).to eq [[[3]], [[2]], [[1]]]
+    rating.store [[1]], [1]
+    expect(rating.sorted).to eq [[[1]], [[2]]]
+  end
+
+  example "keys are dupped but not deeply" do
+    rating = PCBR.new
+    a = [[1]]
+    v = [0]
+    rating.store a, v
+    a[0][0] = 2
+    expect{ rating.store [[2]], [1] }.to raise_error PCBR::Error
   end
 
 end

metadata

@@ -1,65 +1,52 @@
 --- !ruby/object:Gem::Specification
 name: pcbr
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Victor Maslov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-06-25 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: deep_dup
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.3.0
-description: Making ratings is fun. After applying my method several times I've decided
-  to gemify it.
+description: |2
+      Making ratings is fun. After applying my method several times I've decided to gemify it.
+      This is one of the first gems I made so it's far for being nicely done.
 email: nakilon@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .rspec
+- ".rspec"
 - Gemfile
 - README.md
 - Rakefile
@@ -76,17 +63,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Pair Comparison Based Rating