paypalhttp 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 910250d5540f67f211cda11bc4c0565ec3bbc4063277198b72fddf66a9a7f8db
-  data.tar.gz: a4574de9deaeed11f0808e0a38ad0ef5c9ad5628f9df8e6657cd1b9340279eaf
+  metadata.gz: e7b784f809b45daa88b7b605a078233f9d6d6389de4d22c58810ad904b1e6270
+  data.tar.gz: 83f24bf689519c48fb95474ffca65635b2c27eacecbabc4e4194761f88e2bceb
 SHA512:
-  metadata.gz: 7626a3dc47b0417902ea12147a4982b0acb39b3fe1e09aeaa0748de48aa5fa1a98cdcbeeb3a1b0f96205de58b21be735033f0154970121235948895be2c05d85
-  data.tar.gz: 0f01023ab3a9def51632d37a086e531cba7eec02007bc112273defd5d086f488f59a664e591f447332cad1e81e4de489dbc22de8ca0759869b9f4d479daf32d8
+  metadata.gz: f6ccd5a75ac2a07ef84c2cc55d4caacd529bd075315ec040066b1c5cdd625d5de048e11b483318eb7adc3065ceec1ac9d3aed568df4dbc1cba30bf390749cafb
+  data.tar.gz: cebe0720259ce83416259eed470253ba5ec716eb329216617fd79a4eabf16a576a4e5c54a9b967852c3a0009fe478a37910aacfff333bdf75b41fa2acdc1113e

data/lib/paypalhttp/serializers/form_encoded.rb

@@ -1,11 +1,15 @@
-require 'cgi'
+require 'uri'
 
 module PayPalHttp
   class FormEncoded
+    def initialize
+      @parser = URI::Parser.new()
+    end
+
     def encode(request)
       encoded_params = []
       request.body.each do |k, v|
-        encoded_params.push("#{CGI.escape(k.to_s)}=#{CGI.escape(v.to_s)}")
+        encoded_params.push("#{@parser.escape(k.to_s)}=#{@parser.escape(v.to_s)}")
       end
 
       encoded_params.join("&")

data/lib/paypalhttp/version.rb

@@ -1 +1 @@
-VERSION = "2.0.0"
+VERSION = "2.0.1"

data/spec/paypalhttp/encoder_spec.rb

@@ -105,10 +105,10 @@ describe Encoder do
       })
       serialized = Encoder.new.serialize_request(req)
 
-      expect(serialized).to eq("key=value+with+a+space&another_key=1013")
+      expect(serialized).to eq("key=value%20with%20a%20space&another_key=1013")
     end
 
-    it 'encodes different special/unsafe characters when using CGI.escape' do
+    it 'encodes different special/unsafe characters when using a URI parser' do
       req = OpenStruct.new({
         :verb => "POST",
         :path => "/v1/api",
@@ -116,13 +116,29 @@ describe Encoder do
           "content-type" => "application/x-www-form-urlencoded; charset=utf8"
         },
         :body => {
-          :key => " ..<..>..%..{..}..|../..^..`..!",
+          :key => " ..<..>..%..{..}..|..^..`..!",
           :another_key => 1013,
         }
       })
       serialized = Encoder.new.serialize_request(req)
 
-      expect(serialized).to eq("key=+..%3C..%3E..%25..%7B..%7D..%7C..%2F..%5E..%60..%21&another_key=1013")
+      expect(serialized).to eq("key=%20..%3C..%3E..%25..%7B..%7D..%7C..%5E..%60..!&another_key=1013")
+    end
+
+    it 'does not encode links given certain special characters' do
+      req = OpenStruct.new({
+        :verb => "POST",
+        :path => "/v1/api",
+        :headers => {
+          "content-type" => "application/x-www-form-urlencoded; charset=utf8"
+        },
+        :body => {
+          :key => "https://localhost:3001/"
+        }
+      })
+      serialized = Encoder.new.serialize_request(req)
+
+      expect(serialized).to eq("key=https://localhost:3001/")
     end
 
     it 'throws when content-type is unsupported' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paypalhttp
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - PayPal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-25 00:00:00.000000000 Z
+date: 2022-07-27 00:00:00.000000000 Z
 dependencies: []
 description: Used for generated API clients
 email: