paypal_fx 0.1.0 → 0.1.1

data/README.rdoc

@@ -1,12 +1,11 @@
 = paypal_fx
 
-fx = Devmask::PaypalFx.new(user_id: 'user',
+    fx = PaypalFx.new(user_id: 'user',
                       password: 'password',
                       signature: 'sign',
                       app_id: 'appid',
                       test: true)
-
-puts   fx.convert "1.0","USD", "MXN"
+    puts   fx.convert "1.0","USD", "MXN"
 
 == Contributing to paypal_fx
  

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/lib/paypal_fx.rb

@@ -6,10 +6,10 @@ require 'uri'
 
 class PaypalFx
 
-  SERVER = "svcs.sandbox.paypal.com"
-  SANDBOX = "svcs.sandbox.paypal.com"
+  SERVER = 'svcs.paypal.com'
+  SANDBOX = 'svcs.sandbox.paypal.com'
 
-  CLIENT_INFO = { VERSION: "60.0", SOURCE: "PayPalRubySDKV1.2.0" }
+  CLIENT_INFO = { VERSION: '60.0', SOURCE: 'PayPalRubySDKV1.2.0' }
 
   attr_accessor :params
 
@@ -26,15 +26,19 @@ class PaypalFx
   end
 
   # Converts an amount from origin currency to destination
+  #
+  # @param amount [Float] amount
+  # @param origin [String] ISO Currency code
+  # @param destination [String] ISO Currency code
   def convert(amount, origin, destination)
     request = {
-        "requestEnvelope.errorLanguage" => "en_US",
-        "baseAmountList.currency(0).amount" => amount,
-        "baseAmountList.currency(0).code" => origin,
-        "convertToCurrencyList.currencyCode(0)" => destination
+        'requestEnvelope.errorLanguage' => 'en_US',
+        'baseAmountList.currency(0).amount' => amount,
+        'baseAmountList.currency(0).code' => origin,
+        'convertToCurrencyList.currencyCode(0)' => destination
     }
 
-    commit "/AdaptivePayments/ConvertCurrency", request
+    commit '/AdaptivePayments/ConvertCurrency', request
   end
 
   # Sends the request to specified end point for paypal SANDBOX or SERVER
@@ -44,18 +48,18 @@ class PaypalFx
   # @return [Hash]  with the responce parameters
   def commit(endpoint, request)
 
-    headers = {"Content-Type" => "html/text",
-               "X-PAYPAL-SERVICE-VERSION" => "1.0.0",
-               "X-PAYPAL-SECURITY-USERID" => self.params[:user_id],
-               "X-PAYPAL-SECURITY-PASSWORD" => self.params[:password],
-               "X-PAYPAL-SECURITY-SIGNATURE" => self.params[:signature],
-               "X-PAYPAL-APPLICATION-ID" => self.params[:app_id],
-               "X-PAYPAL-DEVICE-IPADDRESS" => self.params[:ip_address] || "",
-               "X-PAYPAL-REQUEST-DATA-FORMAT" => "NV",
-               "X-PAYPAL-RESPONSE-DATA-FORMAT" => "NV"}
+    headers = {'Content-Type' => 'html/text',
+               'X-PAYPAL-SERVICE-VERSION' => '1.0.0',
+               'X-PAYPAL-SECURITY-USERID' => self.params[:user_id],
+               'X-PAYPAL-SECURITY-PASSWORD' => self.params[:password],
+               'X-PAYPAL-SECURITY-SIGNATURE' => self.params[:signature],
+               'X-PAYPAL-APPLICATION-ID' => self.params[:app_id],
+               'X-PAYPAL-DEVICE-IPADDRESS' => self.params[:ip_address] || '',
+               'X-PAYPAL-REQUEST-DATA-FORMAT' => 'NV',
+               'X-PAYPAL-RESPONSE-DATA-FORMAT' => 'NV'}
 
 
-    request_params = request.merge(CLIENT_INFO).map { |k, v| "#{k}=#{CGI.escape(v)}" }.join("&")
+    request_params = request.merge(CLIENT_INFO).map { |k, v| "#{k}=#{CGI.escape(v)}" }.join('&')
 
     http = Net::HTTP.new(params[:test] ? SANDBOX : SERVER, 443)
     http.verify_mode = OpenSSL::SSL::VERIFY_NONE
@@ -68,12 +72,15 @@ class PaypalFx
   end
 
   protected
+  # Cleans the named spaced returns and converts the keys to symlinks
+  #
+  # @param hash [Hash] Paypal return hash
   def clean_namespace(hash)
     #i hate my self for this
     h = {}
     hash.each do |k, v|
-      val = k.split(".").map { |k| k.tr('^A-Za-z0-9', '') }
-      key = val.count == 2 ? val[1] : val[val.count-2..val.count-1].join("_")
+      val = k.split('.').map { |s| s.tr('^A-Za-z0-9', '') }
+      key = val.count == 2 ? val[1] : val[val.count-2..val.count-1].join('_')
       h[key.to_sym] = v[0]
     end
     h

data/paypal_fx.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "paypal_fx"
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jonathan Garay"]
-  s.date = "2012-02-15"
+  s.date = "2012-02-16"
   s.description = " Paypal Currency Exchange Library"
   s.email = "jonathan@devmask.net"
   s.extra_rdoc_files = [

data/test/test_paypal_fx.rb

@@ -2,4 +2,13 @@ require 'helper'
 
 class TestPaypalFx < Test::Unit::TestCase
 
+  should "have commit method" do
+    assert PaypalFx.new({}).respond_to? :commit
+  end
+
+  should "have convert method" do
+    assert PaypalFx.new({}).respond_to? :convert
+  end
+
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paypal_fx
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-15 00:00:00.000000000 Z
+date: 2012-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &70229449754540 !ruby/object:Gem::Requirement
+  requirement: &70186707729020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70229449754540
+  version_requirements: *70186707729020
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &70229449769640 !ruby/object:Gem::Requirement
+  requirement: &70186707727760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3.12'
   type: :development
   prerelease: false
-  version_requirements: *70229449769640
+  version_requirements: *70186707727760
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70229449769080 !ruby/object:Gem::Requirement
+  requirement: &70186707726720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70229449769080
+  version_requirements: *70186707726720
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70229449767560 !ruby/object:Gem::Requirement
+  requirement: &70186707725120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.8.3
   type: :development
   prerelease: false
-  version_requirements: *70229449767560
+  version_requirements: *70186707725120
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70229449766460 !ruby/object:Gem::Requirement
+  requirement: &70186707712260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70229449766460
+  version_requirements: *70186707712260
 description: ! ' Paypal Currency Exchange Library'
 email: jonathan@devmask.net
 executables: []
@@ -100,7 +100,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -587940227317013269
+      hash: 1388245334991938184
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: