paypal-express 0.5.5 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a1efbcece6ca156968e202296852124d5671a31
-  data.tar.gz: 93d1c16722894988ab929e949a6feda827fd6c92
+  metadata.gz: a8bdf6de40dccab7020f6aec90598360e9ef5a4c
+  data.tar.gz: 58a4ab67ab38a81f6ca04c806c0771657b9b6455
 SHA512:
-  metadata.gz: 746fa1cd4af53dc83389e1cafb365efaa6e54ca8bb9a360cab880252caccc2721018aaa4f1f8c9e2159b8c7acf55cacdbb10de7189331ef3b6f07a9726fccda9
-  data.tar.gz: f68a8061a47c18598fbde8958ff71a8ce30705a15ea6ea919a8f90dfa1758532482702cce005910c127f14c6bfa638c63a21f9751a4336dfa3ff5dc449c0589c
+  metadata.gz: 5a0cc3dd83e0d42ac61b0ed5cef08a700b17b1b30fa45605645ef7a45e1b0dcffd81487ca62398dc99bdeb680b6e5771b4cf3f0029bfa74ba1f5803673884ff0
+  data.tar.gz: b2b16f82df3015e6c2e807c53a9e0b14d6c4019ab75db0cfc780379f8f63dd0ec0caae38f0983789b4cd6610e74472272bb7b2ed7e560a33cda0e6761612e819

data/.travis.yml

@@ -1,3 +1,3 @@
 rvm:
-  - 1.9.3
-  - 2.0.0
+  - 2.0.0
+  - 2.1.2

data/Rakefile

@@ -4,22 +4,16 @@ Bundler::GemHelper.install_tasks
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
-if RUBY_VERSION >= '1.9'
-  namespace :cover_me do
-    desc "Generates and opens code coverage report."
-    task :report do
-      require 'cover_me'
-      CoverMe.complete!
-    end
-  end
-  task :spec do
-    Rake::Task['cover_me:report'].invoke unless ENV['TRAVIS_RUBY_VERSION']
-  end
-else
-  RSpec::Core::RakeTask.new(:rcov) do |spec|
-    spec.rcov = true
-    spec.rcov_opts = ['-Ilib -Ispec --exclude spec,gems']
+namespace :coverage do
+  desc "Open coverage report"
+  task :report do
+    require 'simplecov'
+    `open "#{File.join SimpleCov.coverage_path, 'index.html'}"`
   end
 end
 
+task :spec do
+  Rake::Task[:'coverage:report'].invoke unless ENV['TRAVIS_RUBY_VERSION']
+end
+
 task :default => :spec

data/VERSION

@@ -1 +1 @@
-0.5.5
+0.6.0

data/lib/paypal/express/request.rb

@@ -13,12 +13,18 @@ module Paypal
           params[:REQCONFIRMSHIPPING] = 0
           params[:NOSHIPPING] = 1
         end
+
+        params[:ALLOWNOTE] = 0 if options[:allow_note] == false
+
         {
           :solution_type => :SOLUTIONTYPE,
           :landing_page  => :LANDINGPAGE,
           :email         => :EMAIL,
           :brand         => :BRANDNAME,
-          :locale        => :LOCALECODE
+          :locale        => :LOCALECODE,
+          :logo          => :LOGOIMG,
+          :cart_border_color => :CARTBORDERCOLOR,
+          :payflow_color => :PAYFLOWCOLOR
         }.each do |option_key, param_key|
           params[param_key] = options[option_key] if options[option_key]
         end

data/lib/paypal/express/response.rb

@@ -1,11 +1,12 @@
 module Paypal
   module Express
     class Response < NVP::Response
-      attr_accessor :pay_on_paypal
+      attr_accessor :pay_on_paypal, :mobile
 
       def initialize(response, options = {})
         super response
         @pay_on_paypal = options[:pay_on_paypal]
+        @mobile        = options[:mobile]
       end
 
       def redirect_uri
@@ -24,8 +25,9 @@ module Paypal
 
       def query(with_cmd = false)
         _query_ = {:token => self.token}
-        _query_.merge!(:cmd => '_express-checkout') if with_cmd
-        _query_.merge!(:useraction => 'commit')     if pay_on_paypal
+        _query_.merge!(:cmd => '_express-checkout')        if with_cmd
+        _query_.merge!(:cmd => '_express-checkout-mobile') if mobile
+        _query_.merge!(:useraction => 'commit')            if pay_on_paypal
         _query_
       end
     end

data/paypal-express.gemspec

@@ -17,11 +17,7 @@ Gem::Specification.new do |s|
   s.add_dependency "restclient_with_cert"
   s.add_dependency "attr_required", ">= 0.0.5"
   s.add_development_dependency "rake", ">= 0.8"
-  if RUBY_VERSION >= '1.9'
-    s.add_development_dependency "cover_me", ">= 1.2.0"
-  else
-    s.add_development_dependency "rcov", ">= 0.9"
-  end
-  s.add_development_dependency "rspec", ">= 2"
+  s.add_development_dependency "simplecov"
+  s.add_development_dependency "rspec", "< 2.99"
   s.add_development_dependency "fakeweb", ">= 1.3.0"
 end

data/spec/paypal/express/request_spec.rb

@@ -126,12 +126,31 @@ describe Paypal::Express::Request do
       }
     end
 
+    it 'should support allow_note=false option' do
+      expect do
+        instance.setup instant_payment_request, return_url, cancel_url, :allow_note => false
+      end.to request_to nvp_endpoint, :post
+      instance._method_.should == :SetExpressCheckout
+      instance._sent_params_.should == {
+        :PAYMENTREQUEST_0_DESC => 'Instant Payment Request',
+        :RETURNURL => return_url,
+        :CANCELURL => cancel_url,
+        :PAYMENTREQUEST_0_AMT => '1000.00',
+        :PAYMENTREQUEST_0_TAXAMT => "0.00",
+        :PAYMENTREQUEST_0_SHIPPINGAMT => "0.00",
+        :ALLOWNOTE => 0
+      }
+    end
+
     {
       :solution_type => :SOLUTIONTYPE,
       :landing_page => :LANDINGPAGE,
       :email => :EMAIL,
       :brand => :BRANDNAME,
-      :locale => :LOCALECODE
+      :locale => :LOCALECODE,
+      :logo => :LOGOIMG,
+      :cart_border_color => :CARTBORDERCOLOR,
+      :payflow_color => :PAYFLOWCOLOR
     }.each do |option_key, param_key|
       it "should support #{option_key} option" do
         expect do

data/spec/paypal/express/response_spec.rb

@@ -65,4 +65,16 @@ describe Paypal::Express::Response do
       it { should include 'https://www.sandbox.paypal.com/incontext?token=' }
     end
   end
+
+  context 'when mobile option is given' do
+    let(:response) { request.setup payment_request, return_url, cancel_url, :mobile => true }
+
+    subject { response }
+
+    describe '#redirect_uri' do
+      subject { response.redirect_uri }
+      it { should include 'https://www.paypal.com/cgi-bin/webscr?cmd=_express-checkout-mobile&token=' }
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
-if RUBY_VERSION >= '1.9'
-  require 'cover_me'
+require 'simplecov'
+
+SimpleCov.start do
+  add_filter 'spec'
 end
 
 require 'paypal'

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.6.0
 platform: ruby
 authors:
 - nov matake
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-11 00:00:00.000000000 Z
+date: 2014-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.3'
 - !ruby/object:Gem::Dependency
   name: restclient_with_cert
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: attr_required
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.5
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: cover_me
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '2.99'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '2.99'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
 description: PayPal Express Checkout API Client for Instance, Recurring and Digital
@@ -117,12 +117,11 @@ extra_rdoc_files:
 - LICENSE
 - README.rdoc
 files:
-- .document
-- .gitignore
-- .rspec
-- .travis.yml
+- ".document"
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -206,22 +205,22 @@ licenses: []
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --charset=UTF-8
+- "--charset=UTF-8"
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods

data/Gemfile.lock

@@ -1,59 +0,0 @@
-PATH
-  remote: .
-  specs:
-    paypal-express (0.5.4)
-      activesupport (>= 2.3)
-      attr_required (>= 0.0.5)
-      restclient_with_cert
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activesupport (4.0.2)
-      i18n (~> 0.6, >= 0.6.4)
-      minitest (~> 4.2)
-      multi_json (~> 1.3)
-      thread_safe (~> 0.1)
-      tzinfo (~> 0.3.37)
-    atomic (1.1.14)
-    attr_required (0.0.5)
-    configatron (2.13.0)
-      yamler (>= 0.1.0)
-    cover_me (1.2.0)
-      configatron
-      hashie
-    diff-lcs (1.2.5)
-    fakeweb (1.3.0)
-    hashie (2.0.5)
-    i18n (0.6.9)
-    mime-types (2.0)
-    minitest (4.7.5)
-    multi_json (1.8.2)
-    rake (10.1.0)
-    rest-client (1.6.7)
-      mime-types (>= 1.16)
-    restclient_with_cert (0.0.8)
-      rest-client (>= 1.6)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.7)
-    rspec-expectations (2.14.4)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.4)
-    thread_safe (0.1.3)
-      atomic
-    tzinfo (0.3.38)
-    yamler (0.1.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  cover_me (>= 1.2.0)
-  fakeweb (>= 1.3.0)
-  jruby-openssl (>= 0.7)
-  paypal-express!
-  rake (>= 0.8)
-  rspec (>= 2)