paypal-express 0.4.5 → 0.4.6

data/Gemfile.lock

@@ -1,50 +1,56 @@
 PATH
   remote: .
   specs:
-    paypal-express (0.4.1)
+    paypal-express (0.4.5)
       activesupport (>= 2.3)
-      attr_required (>= 0.0.3)
+      attr_required (>= 0.0.5)
       i18n
       restclient_with_cert
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (3.1.3)
+    activesupport (3.2.2)
+      i18n (~> 0.6)
       multi_json (~> 1.0)
-    attr_required (0.0.3)
+    attr_required (0.0.5)
     bouncy-castle-java (1.5.0146.1)
+    configatron (2.9.0)
+      yamler (>= 0.1.0)
+    cover_me (1.2.0)
+      configatron
+      hashie
     diff-lcs (1.1.3)
     fakeweb (1.3.0)
+    hashie (1.2.0)
     i18n (0.6.0)
-    jruby-openssl (0.7.4)
-      bouncy-castle-java
-    mime-types (1.17.2)
-    multi_json (1.0.3)
-    rake (0.9.2)
-    rcov (0.9.10)
-    rcov (0.9.10-java)
+    jruby-openssl (0.7.6.1)
+      bouncy-castle-java (>= 1.5.0146.1)
+    mime-types (1.18)
+    multi_json (1.1.0)
+    rake (0.9.2.2)
     rest-client (1.6.7)
       mime-types (>= 1.16)
     restclient_with_cert (0.0.8)
       rest-client (>= 1.6)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.4)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
+    rspec (2.9.0)
+      rspec-core (~> 2.9.0)
+      rspec-expectations (~> 2.9.0)
+      rspec-mocks (~> 2.9.0)
+    rspec-core (2.9.0)
+    rspec-expectations (2.9.0)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.9.0)
+    yamler (0.1.0)
 
 PLATFORMS
   java
   ruby
 
 DEPENDENCIES
+  cover_me (>= 1.2.0)
   fakeweb (>= 1.3.0)
   jruby-openssl (>= 0.7)
   paypal-express!
   rake (>= 0.8)
-  rcov (>= 0.9)
   rspec (>= 2)

data/VERSION

@@ -1 +1 @@
-0.4.5
+0.4.6

data/lib/paypal/express/request.rb

@@ -13,6 +13,13 @@ module Paypal
           params[:REQCONFIRMSHIPPING] = 0
           params[:NOSHIPPING] = 1
         end
+        {
+          :solution_type => :SOLUTIONTYPE,
+          :landing_page => :LANDINGPAGE,
+          :email => :EMAIL
+        }.each do |option_key, param_key|
+          params[param_key] = options[option_key] if options[option_key]
+        end
         Array(payment_requests).each_with_index do |payment_request, index|
           params.merge! payment_request.to_params(index)
         end
@@ -25,7 +32,7 @@ module Paypal
         Response.new response
       end
 
-      def transaction_details( transaction_id )
+      def transaction_details(transaction_id)
         response = self.request :GetTransactionDetails, {:TRANSACTIONID=> transaction_id}
         Response.new response
       end

data/lib/paypal/payment/request.rb

@@ -48,8 +48,8 @@ module Paypal
       end
 
       def items_amount
-        self.items.inject(0.0) do |total, item|
-          total += item.quantity * item.amount.to_f
+        self.items.sum do |item|
+          item.quantity * BigDecimal.new(item.amount.to_s)
         end
       end
     end

data/spec/paypal/express/request_spec.rb

@@ -126,6 +126,21 @@ describe Paypal::Express::Request do
       }
     end
 
+    {
+      :solution_type => :SOLUTIONTYPE,
+      :landing_page => :LANDINGPAGE,
+      :email => :EMAIL
+    }.each do |option_key, param_key|
+      it "should support #{option_key} option" do
+        expect do
+          instance.setup instant_payment_request, return_url, cancel_url, option_key => 'some value'
+        end.should request_to nvp_endpoint, :post
+        instance._method_.should == :SetExpressCheckout
+        instance._sent_params_.should include param_key
+        instance._sent_params_[param_key].should == 'some value'
+      end
+    end
+
     context 'when instance payment request given' do
       it 'should call SetExpressCheckout' do
         expect do

data/spec/paypal/payment/request_spec.rb

@@ -105,4 +105,24 @@ describe Paypal::Payment::Request do
       }
     end
   end
+
+  describe '#items_amount' do
+    context 'when BigDecimal'
+    let(:instance) do
+      Paypal::Payment::Request.new(
+        :items => [{
+          :quantity => 3,
+          :name => 'Item1',
+          :description => 'Awesome Item 1!',
+          :amount => 130.45
+        }]
+      )
+    end
+
+    # NOTE:
+    # 391.35 * 3 => 391.34999999999997 (in ruby 1.9)
+    it 'should calculate total amount correctly' do
+      instance.items_amount.should == 391.35
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-24 00:00:00.000000000Z
+date: 2012-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70190063841760 !ruby/object:Gem::Requirement
+  requirement: &70107968069980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.3'
   type: :runtime
   prerelease: false
-  version_requirements: *70190063841760
+  version_requirements: *70107968069980
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70190063841120 !ruby/object:Gem::Requirement
+  requirement: &70107968069300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70190063841120
+  version_requirements: *70107968069300
 - !ruby/object:Gem::Dependency
   name: restclient_with_cert
-  requirement: &70190063840100 !ruby/object:Gem::Requirement
+  requirement: &70107968105540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70190063840100
+  version_requirements: *70107968105540
 - !ruby/object:Gem::Dependency
   name: attr_required
-  requirement: &70190063829120 !ruby/object:Gem::Requirement
+  requirement: &70107968104480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: 0.0.5
   type: :runtime
   prerelease: false
-  version_requirements: *70190063829120
+  version_requirements: *70107968104480
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70190063827760 !ruby/object:Gem::Requirement
+  requirement: &70107968103600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0.8'
   type: :development
   prerelease: false
-  version_requirements: *70190063827760
+  version_requirements: *70107968103600
 - !ruby/object:Gem::Dependency
   name: cover_me
-  requirement: &70190063826720 !ruby/object:Gem::Requirement
+  requirement: &70107968102740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: 1.2.0
   type: :development
   prerelease: false
-  version_requirements: *70190063826720
+  version_requirements: *70107968102740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70190063826000 !ruby/object:Gem::Requirement
+  requirement: &70107968102040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *70190063826000
+  version_requirements: *70107968102040
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &70190063823880 !ruby/object:Gem::Requirement
+  requirement: &70107968101340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: 1.3.0
   type: :development
   prerelease: false
-  version_requirements: *70190063823880
+  version_requirements: *70107968101340
 description: PayPal Express Checkout API Client for Instance, Recurring and Digital
   Goods Payment.
 email: nov@matake.jp
@@ -211,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.12
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods