paypal-express 0.4.0 → 0.4.1

data/.gitignore

@@ -17,6 +17,5 @@ tmtags
 coverage
 rdoc
 pkg
-Gemfile.lock
 
 ## PROJECT::SPECIFIC

data/.travis.yml

@@ -0,0 +1,5 @@
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - jruby

data/Gemfile

@@ -1,2 +1,7 @@
 source 'http://rubygems.org'
+
+platform :jruby do
+  gem 'jruby-openssl', '>= 0.7'
+end
+
 gemspec

data/Gemfile.lock

@@ -0,0 +1,50 @@
+PATH
+  remote: .
+  specs:
+    paypal-express (0.4.0)
+      activesupport (>= 2.3)
+      attr_required (>= 0.0.3)
+      i18n
+      restclient_with_cert
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    activesupport (3.1.0)
+      multi_json (~> 1.0)
+    attr_required (0.0.3)
+    bouncy-castle-java (1.5.0146.1)
+    diff-lcs (1.1.3)
+    fakeweb (1.3.0)
+    i18n (0.6.0)
+    jruby-openssl (0.7.4)
+      bouncy-castle-java
+    mime-types (1.16)
+    multi_json (1.0.3)
+    rake (0.9.2)
+    rcov (0.9.10)
+    rcov (0.9.10-java)
+    rest-client (1.6.7)
+      mime-types (>= 1.16)
+    restclient_with_cert (0.0.8)
+      rest-client (>= 1.6)
+    rspec (2.6.0)
+      rspec-core (~> 2.6.0)
+      rspec-expectations (~> 2.6.0)
+      rspec-mocks (~> 2.6.0)
+    rspec-core (2.6.4)
+    rspec-expectations (2.6.0)
+      diff-lcs (~> 1.1.2)
+    rspec-mocks (2.6.0)
+
+PLATFORMS
+  java
+  ruby
+
+DEPENDENCIES
+  fakeweb (>= 1.3.0)
+  jruby-openssl (>= 0.7)
+  paypal-express!
+  rake (>= 0.8)
+  rcov (>= 0.9)
+  rspec (>= 2)

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.4.1

data/lib/paypal/exception/api_error.rb

@@ -8,7 +8,15 @@ module Paypal
         else
           response
         end
-        super 'PayPal API Error'
+      end
+
+      def message
+        if response.respond_to?(:short_messages) && response.short_messages.any?
+          "PayPal API Error: " <<
+            response.short_messages.map{ |m| "'#{m}'" }.join(", ")
+        else
+          "PayPal API Error"
+        end
       end
 
       class Response
@@ -75,6 +83,10 @@ module Paypal
             Paypal.log "Ignored Parameter (#{self.class}): #{key}=#{value}", :warn
           end
         end
+
+        def short_messages
+          details.map(&:short_message).compact
+        end
       end
     end
   end

data/spec/paypal/exception/api_error_spec.rb

@@ -9,15 +9,26 @@ describe Paypal::Exception::APIError do
         :VERSION=>"66.0",
         :TIMESTAMP=>"2011-03-03T06:33:51Z",
         :CORRELATIONID=>"758ebdc546b9c",
+        :BUILD=>"1741654",
+        :ACK=>"Failure",
         :L_SEVERITYCODE0=>"Error",
         :L_ERRORCODE0=>"10411",
         :L_LONGMESSAGE0=>"This Express Checkout session has expired.  Token value is no longer valid.",
-        :BUILD=>"1741654",
-        :ACK=>"Failure",
-        :L_SHORTMESSAGE0=>"This Express Checkout session has expired."
+        :L_SHORTMESSAGE0=>"This Express Checkout session has expired.",
+        :L_SEVERITYCODE1=>"Error",
+        :L_ERRORCODE1=>"2468",
+        :L_LONGMESSAGE1=>"Sample of a long message for the second item.",
+        :L_SHORTMESSAGE1=>"Second short message.",
       }
     end
 
+    describe "#message" do
+      it "aggregates short messages" do
+        error.message.should ==
+          "PayPal API Error: 'This Express Checkout session has expired.', 'Second short message.'"
+      end
+    end
+
     describe '#subject' do
       subject { error.response }
       its(:raw) { should == params }
@@ -55,11 +66,13 @@ describe Paypal::Exception::APIError do
       subject { error.response }
       its(:raw) { should == params }
     end
+    its(:message) { should == "PayPal API Error" }
   end
 
   context 'otherwise' do
     subject { error }
     let(:params) { 'Failure' }
     its(:response) { should == params }
+    its(:message) { should == "PayPal API Error" }
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: paypal-express
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors: 
 - nov matake
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-08 00:00:00 Z
+date: 2011-10-31 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
@@ -113,7 +113,9 @@ files:
 - .document
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -210,7 +212,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.5
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods Payment.