payoneer_csv 0.1.2 → 0.1.4

data/.travis.yml

@@ -3,11 +3,11 @@ language: ruby
 rvm:
   - 1.9.2
   - 1.9.3
-  - jruby-19mode
 
 before_install:
  - sudo apt-get update -qq
- - sudo apt-get install poppler-utils
+ - sudo apt-get install ghostscript
 
 script:
   - "rspec spec"
+  - "cucumber features"

data/Gemfile

@@ -5,8 +5,10 @@ gemspec
 
 group :development, :test do
   gem 'rspec'
+  gem 'cucumber'
+  gem 'aruba'
   gem 'simplecov', require: false
 
   gem 'awesome_print'
-  gem 'debugger', platforms: :ruby
+  gem 'debugger'
 end

data/README.md

@@ -6,9 +6,9 @@ Simple tool for converting payoneer pdf report to csv file.
 
 ## Installation
 
-First of all install `pdftotext` executable
+First of all install `ps2ascii` executable
 
-    $ sudo apt-get install poppler-utils
+    $ sudo apt-get install ghostscript
 
 Add this line to your application's Gemfile:
 

data/bin/payoneer_csv

@@ -1,18 +1,27 @@
 #!/usr/bin/env ruby
 
-unless ARGV[0]
-  puts 'Usage: payoneer_csv /path/to/transaction_list.pdf'
-  exit
-end
-
+require 'optparse'
+require 'methadone'
 require 'payoneer_csv'
 
-file_path = File.expand_path(ARGV[0])
-unless File.exist?(file_path)
-  puts "Cannot find file: #{file_path}"
-  exit
-end
+class App
+  include Methadone::Main
+  include Methadone::CLILogging
+
+  main do |file_path|
+    unless File.exist?(file_path)
+      puts "Cannot find file: #{file_path}"
+      exit
+    end
 
-reader = PayoneerCsv::PdfReader.new(file_path)
-csv_string = PayoneerCsv::Csv.new(reader.read).generate
-puts csv_string
+    reader = PayoneerCsv::PdfReader.new(file_path)
+    csv_string = PayoneerCsv::Csv.new(reader.read).generate
+    puts csv_string
+  end
+
+  arg :file_path
+
+  version PayoneerCsv::VERSION
+
+  go!
+end

data/features/payoneer_csv.feature

@@ -0,0 +1,57 @@
+Feature: My bootstrapped app kinda works
+  In order to get going on coding my awesome app
+  I want to have aruba and cucumber setup
+  So I don't have to do it myself
+
+  Scenario: App just runs
+    When I get help for "payoneer_csv"
+    Then the exit status should be 0
+    And the banner should be present
+    And the banner should document that this app takes options
+    And the following options should be documented:
+      | --version |
+    And the banner should document that this app's arguments are:
+      | file_path | which is required |
+
+  Scenario: Run with non existing file
+    When I run `payoneer_csv non-existing.pdf`
+    Then the output should contain "Cannot find file: non-existing.pdf"
+
+  Scenario: Run with existing file
+    When I run `payoneer_csv Transactions.pdf`
+    Then the output should contain:
+      """
+      Transaction Date,Description,Amount,Currency
+      10/17/2012 5:58:20 AM,ATM Withdrawal - Vaci u. 42.,-75.29,USD
+      10/16/2012 6:41:30 AM,ROSSMANN,-14.2,USD
+      10/15/2012 8:30:15 PM,Prima,-4.98,USD
+      10/15/2012 8:44:18 AM,PKP Intercity,-48.61,USD
+      10/18/2012 2:52:18 AM,ATM Withdrawal - OTP,-51.02,USD
+      10/19/2012 11:38:12 PM,PSS SKLEP NR 54,-17.36,USD
+      10/19/2012 6:41:14 AM,COSTA COFFEE,-7.41,USD
+      """
+
+  Scenario: Run with other existing file
+    When I run `payoneer_csv Transactions2.pdf`
+    Then the output should contain:
+      """
+      Transaction Date,Description,Amount,Currency
+      10/18/2012 2:52:18 AM,ATM Withdrawal - OTP,-51.02,USD
+      10/19/2012 6:41:14 AM,COSTA COFFEE,-7.41,USD
+      10/26/2012 8:10:10 PM,Delikatesy Alma,-13.19,USD
+      10/26/2012 12:25:14 AM,DEEZER,-4.87,USD
+      10/19/2012 11:38:12 PM,PSS SKLEP NR 54,-17.36,USD
+      10/26/2012 8:15:31 PM,Delikatesy Alma,-7.83,USD
+      10/23/2012 8:23:51 PM,Delikatesy Alma,-31.42,USD
+      10/21/2012 10:53:31 PM,CAFE ARTE,-3.14,USD
+      10/21/2012 10:21:28 PM,PSS SKLEP,-5.47,USD
+      10/23/2012 6:28:09 AM,SJO Empik,-23.17,USD
+      10/22/2012 2:47:05 AM,Delikatesy Alma,-77.25,USD
+      10/15/2012 8:44:18 AM,PKP Intercity,-48.61,USD
+      10/11/2012 8:31:56 PM,Delikatesy Alma,-42.89,USD
+      10/10/2012 8:10:37 PM,HAPPY,-4.31,USD
+      10/10/2012 8:02:27 PM,Withdrawal Notification Lukasz Bandzarewicz 1198,1198.0,USD
+      10/15/2012 8:30:15 PM,Prima,-4.98,USD
+      10/17/2012 5:58:20 AM,ATM Withdrawal - Vaci u. 42.,-75.29,USD
+      10/16/2012 6:41:30 AM,ROSSMANN,-14.2,USD
+      """

data/features/step_definitions/payoneer_csv_steps.rb

@@ -0,0 +1 @@
+# Put your step definitions here

data/features/support/env.rb

@@ -0,0 +1,17 @@
+require 'aruba/cucumber'
+require 'methadone/cucumber'
+
+ENV['PATH'] = "#{File.expand_path(File.dirname(__FILE__) + '/../../bin')}#{File::PATH_SEPARATOR}#{ENV['PATH']}"
+LIB_DIR = File.join(File.expand_path(File.dirname(__FILE__)),'..','..','lib')
+
+Before do
+  # Using "announce" causes massive warnings on 1.9.2
+  @puts = true
+  @dirs = ["spec/fixtures"]
+  @original_rubylib = ENV['RUBYLIB']
+  ENV['RUBYLIB'] = LIB_DIR + File::PATH_SEPARATOR + ENV['RUBYLIB'].to_s
+end
+
+After do
+  ENV['RUBYLIB'] = @original_rubylib
+end

data/lib/payoneer_csv/pdf_reader.rb

@@ -21,11 +21,11 @@ module PayoneerCsv
     end
 
     def raw_data
-      `less #{file_path}`
+      `ps2ascii #{file_path}`
     end
 
     def parse(row)
-      row.match /^(?<created_at>\d{1,2}\/\d{1,2}\/\d{4} \d{1,2}:\d{2}:\d{2} (AM|PM))\s+ (?<description>.+) (?<amount>-?(\d|,)+\.\d{2})\s+USD$/
+      row.match /^(?<created_at>\d{1,2}\/\d{1,2}\/\d{4} \d{1,2}:\d{2}:\d{2} (AM|PM))\s(?<description>.+) (?<amount>-?(\d|,)+\.\d{2})\s+USD$/
     end
   end
 

data/lib/payoneer_csv/version.rb

@@ -1,3 +1,3 @@
 module PayoneerCsv
-  VERSION = "0.1.2"
+  VERSION = "0.1.4"
 end

data/payoneer_csv.gemspec

@@ -14,4 +14,6 @@ Gem::Specification.new do |gem|
   gem.name          = "payoneer_csv"
   gem.require_paths = ["lib"]
   gem.version       = PayoneerCsv::VERSION
+
+  gem.add_dependency('methadone', '1.2.2')
 end

data/spec/payoneer_csv/pdf_reader_spec.rb

@@ -17,10 +17,10 @@ describe PayoneerCsv::PdfReader do
       it 'should include some transactions' do
         should_not be_empty
 
-        should include('10/19/2012 11:38:12 PM         PSS SKLEP NR 54                          -17.36     USD')
-        should include('10/19/2012 6:41:14 AM          COSTA COFFEE                              -7.41     USD')
+        should include('10/19/2012 11:38:12 PM PSS SKLEP NR 54 -17.36 USD')
+        should include('10/19/2012 6:41:14 AM COSTA COFFEE -7.41 USD')
         # ...
-        should include('10/15/2012 8:44:18 AM          PKP Intercity                            -48.61     USD')
+        should include('10/15/2012 8:44:18 AM PKP Intercity -48.61 USD')
       end
     end
   end
@@ -32,20 +32,20 @@ describe PayoneerCsv::PdfReader do
       subject { reader.parse(row) }
 
       context 'on valid row (with negative amount)' do
-        let(:row) { '10/17/2012 5:58:20 AM          ATM Withdrawal - Vaci u. 42.             -75.29     USD' }
+        let(:row) { '10/17/2012 5:58:20 AM ATM Withdrawal - Vaci u. 42. -75.29 USD' }
 
         it { should_not be_nil }
         its([:created_at]) { should == '10/17/2012 5:58:20 AM' }
-        its([:description]) { should == 'ATM Withdrawal - Vaci u. 42.            ' }
+        its([:description]) { should == 'ATM Withdrawal - Vaci u. 42.' }
         its([:amount]) { should == '-75.29' }
       end
 
       context 'on valid row (with positive amount)' do
-        let(:row) { '10/19/2012 11:38:12 PM         PSS SKLEP NR 54                        2,117.36     USD' }
+        let(:row) { '10/19/2012 11:38:12 PM PSS SKLEP NR 54 2,117.36 USD' }
 
         it { should_not be_nil }
         its([:created_at]) { should == '10/19/2012 11:38:12 PM' }
-        its([:description]) { should == 'PSS SKLEP NR 54                       ' }
+        its([:description]) { should == 'PSS SKLEP NR 54' }
         its([:amount]) { should == '2,117.36' }
       end
 
@@ -66,8 +66,8 @@ describe PayoneerCsv::PdfReader do
 
       it { should have(7).items }
 
-      describe 'first transaction' do
-        subject { result.first }
+      describe 'a transaction' do
+        subject { result[5] }
 
         its(:created_at) { should == '10/19/2012 11:38:12 PM' }
         its(:description) { should == 'PSS SKLEP NR 54' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: payoneer_csv
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-27 00:00:00.000000000 Z
-dependencies: []
+date: 2013-09-11 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: methadone
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.2.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.2.2
 description: Simple tool for converting payoneer pdf report to csv file
 email:
 - lucassus@gmail.com
@@ -27,6 +43,9 @@ files:
 - README.md
 - Rakefile
 - bin/payoneer_csv
+- features/payoneer_csv.feature
+- features/step_definitions/payoneer_csv_steps.rb
+- features/support/env.rb
 - lib/payoneer_csv.rb
 - lib/payoneer_csv/csv.rb
 - lib/payoneer_csv/pdf_reader.rb
@@ -34,6 +53,7 @@ files:
 - lib/payoneer_csv/version.rb
 - payoneer_csv.gemspec
 - spec/fixtures/Transactions.pdf
+- spec/fixtures/Transactions2.pdf
 - spec/payoneer_csv/csv_spec.rb
 - spec/payoneer_csv/pdf_reader_spec.rb
 - spec/payoneer_csv/transaction_spec.rb
@@ -58,12 +78,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Convert payoneer pdf report to csv file
 test_files:
+- features/payoneer_csv.feature
+- features/step_definitions/payoneer_csv_steps.rb
+- features/support/env.rb
 - spec/fixtures/Transactions.pdf
+- spec/fixtures/Transactions2.pdf
 - spec/payoneer_csv/csv_spec.rb
 - spec/payoneer_csv/pdf_reader_spec.rb
 - spec/payoneer_csv/transaction_spec.rb