payoneer-client 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 19a0562e4e086ea99c5724aa55b51fe8548b6759
-  data.tar.gz: e9a1a284f2dfd95ce72fe081990e74a21d85ed17
+SHA256:
+  metadata.gz: 40d1016bcb66c53acdd28ac3237841db3668a089a276a3d809396b480bb6994e
+  data.tar.gz: 0dd7222c3da2b4a95cb0f9cbbdb00809bd67c3495855616f059e08dd9c443f14
 SHA512:
-  metadata.gz: 8bff19483810c325edd15ae292369fc6d3fae3585119364cca9d02805583f543c59464851b340c3656a196d0db4f30d58beac6f1c500be26090c9bfeeb6ed9b7
-  data.tar.gz: 26f76baa623fb57591c12870114bceb7a31c4ad07e042f503024b6d979c3c228bb53b94289e50e6f70d645bc1f22314db34e76149ea8a3c56243b653f1d0e566
+  metadata.gz: 46b6432e3ce7da68809383ea0289bd441df39e529943005dc04b86105b4a7bb3a699cfac02915d94c11c04aa9c33df5d49a031548ea56b80a2e111e70ab0c42f
+  data.tar.gz: 636441a67541364fb12089b76e8fccee0319540d5ccfaccd9bb6be668aeb5a8ad9299bf6f7a4424282fd99383df6fbd7eec2f0502537212eb3a8bb82da8b8e19

data/README.md

@@ -66,6 +66,23 @@ client.payee_details('fake-payee-id').body
     
 ```
 
+##### Advanced HTTP Client Options
+
+If you need to do additional configuration on the underlying HTTP client (RestClient), you can pass additional config under an `http_client_options` key and this will be passed through directly to the HTTP client.
+
+```ruby
+client = Payoneer::Client.new(
+  Payoneer::Configuration.new(
+    username: 'fake-username',
+    api_password: 'fake-api-password',
+    partner_id: 'fake-partner-id',
+    http_client_options: {
+      verify_ssl: true
+    }
+  )
+)
+```
+
 ##### Performing a normal payout:
 ```ruby
 response = client.payout(

data/lib/payoneer/client.rb

@@ -65,10 +65,18 @@ module Payoneer
         }
       }
 
-      encoded_credentials = 'Basic ' + Base64.encode64("#{configuration.username}:#{configuration.api_password}").chomp
-
       begin
-        response = RestClient.post "#{configuration.json_base_uri}/payouts", params.to_json, content_type: 'application/json', accept: :json, Authorization: encoded_credentials
+        response = RestClient::Request.execute(
+          method: :post,
+          url: "#{configuration.json_base_uri}/payouts",
+          payload: params.to_json,
+          headers: {
+            content_type: 'application/json',
+            accept: :json,
+            Authorization: 'Basic ' + Base64.encode64("#{configuration.username}:#{configuration.api_password}").chomp
+          },
+          **configuration.http_client_options
+        )
 
         hash = JSON.parse(response.body)
         hash['PaymentID'] = hash['payout_id'] # Keep consistent with the normal payout response body
@@ -89,12 +97,17 @@ module Payoneer
     private
 
     def post(method_name, params = {})
-      response = RestClient.post(configuration.xml_base_uri, {
-        mname: method_name,
-        p1: configuration.username,
-        p2: configuration.api_password,
-        p3: configuration.partner_id
-      }.merge(params))
+      response = RestClient::Request.execute(
+        method: :post,
+        url: configuration.xml_base_uri,
+        payload: {
+          mname: method_name,
+          p1: configuration.username,
+          p2: configuration.api_password,
+          p3: configuration.partner_id
+        }.merge(params),
+        **configuration.http_client_options
+      )
 
       raise ResponseError.new(code: response.code, body: response.body) if response.code != 200
 

data/lib/payoneer/configuration.rb

@@ -1,13 +1,14 @@
 module Payoneer
   class Configuration
-    attr_reader :partner_id, :username, :api_password, :auto_approve_sandbox_accounts
+    attr_reader :partner_id, :username, :api_password, :auto_approve_sandbox_accounts, :http_client_options
 
-    def initialize(partner_id:, username:, api_password:, environment: 'development', auto_approve_sandbox_accounts: true)
+    def initialize(partner_id:, username:, api_password:, environment: 'development', auto_approve_sandbox_accounts: true, http_client_options: {})
       @partner_id                    = partner_id
       @username                      = username
       @api_password                  = api_password
       @host                          = 'api.sandbox.payoneer.com' if environment != 'production'
       @auto_approve_sandbox_accounts = auto_approve_sandbox_accounts && environment != 'production'
+      @http_client_options           = http_client_options
     end
 
     def protocol

data/payoneer-client.gemspec

@@ -3,11 +3,11 @@
 # gem push payoneer-client-{VERSION}.gem
 Gem::Specification.new do |s|
   s.name        = 'payoneer-client'
-  s.version     = '0.4.1'
+  s.version     = '0.5.0'
   s.platform    = Gem::Platform::RUBY
   s.licenses    = ['MIT']
-  s.authors     = ['Chris Estreich']
-  s.email       = ['chris@tophatter.com']
+  s.authors     = ['Chris Estreich', 'Todd Eichel']
+  s.email       = ['chris@tophatter.com', 'todd@tophatter.com']
   s.homepage    = 'https://github.com/tophatter/payoneer-api-ruby'
   s.summary     = 'Payoneer SDK for ruby.'
   s.description = 'Payoneer SDK for ruby.'

data/spec/client_spec.rb

@@ -10,7 +10,9 @@ describe Payoneer::Client do
   end
 
   let(:endpoint) { 'https://api.payoneer.com/Payouts/HttpApi/API.aspx' }
-  let(:configuration) { Payoneer::Configuration.new(username: 'fake-username', api_password: 'fake-password', partner_id: 'fake-partner-id', environment: 'production') }
+  let(:default_config_options) { { username: 'fake-username', api_password: 'fake-password', partner_id: 'fake-partner-id', environment: 'production' } }
+  let(:config_options) { default_config_options }
+  let(:configuration) { Payoneer::Configuration.new(config_options) }
   let(:client) { Payoneer::Client.new(configuration) }
 
   describe '#status' do
@@ -18,7 +20,7 @@ describe Payoneer::Client do
       let(:xml) { "<?xml version='1.0' encoding='ISO-8859-1' ?><PayoneerResponse><Status>000</Status><Description>Echo Ok - All systems are up.</Description></PayoneerResponse>" }
 
       it 'returns a successful response' do
-        expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, hash_including(mname: 'Echo')).and_return(response)
+        expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: hash_including(mname: 'Echo')).and_return(response)
         response = client.status
         expect(response.ok?).to be_truthy
         expect(response.body['Description']).to eq('Echo Ok - All systems are up.')
@@ -29,7 +31,7 @@ describe Payoneer::Client do
       let(:xml) { "<?xml version='1.0' encoding='ISO-8859-1' ?><PayoneerResponse><Code>999</Code><Description>Echo Failure - All systems are down.</Description></PayoneerResponse>" }
 
       it 'returns a failure response' do
-        expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, hash_including(mname: 'Echo')).and_return(response)
+        expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: hash_including(mname: 'Echo')).and_return(response)
         response = client.status
         expect(response.ok?).to be_falsey
         expect(response.body).to eq('Echo Failure - All systems are down.')
@@ -45,7 +47,7 @@ describe Payoneer::Client do
       end
 
       it 'raises an error' do
-        expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, hash_including(mname: 'Echo')).and_return(response)
+        expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: hash_including(mname: 'Echo')).and_return(response)
         expect { client.status }.to raise_error(Payoneer::ResponseError)
       end
     end
@@ -55,7 +57,7 @@ describe Payoneer::Client do
     let(:xml) { "<?xml version='1.0' encoding='ISO-8859-1' ?><PayoneerResponse><Version>4.15</Version></PayoneerResponse>" }
 
     it 'generates the correct request' do
-      expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, hash_including(mname: 'GetVersion')).and_return(response)
+      expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: hash_including(mname: 'GetVersion')).and_return(response)
       response = client.version
       expect(response.ok?).to be_truthy
       expect(response.body['Version']).to eq('4.15')
@@ -66,7 +68,7 @@ describe Payoneer::Client do
     let(:xml) { '<?xml version="1.0" encoding="UTF-8" ?><PayoneerToken><Token>https://payouts.sandbox.payoneer.com/partners/lp.aspx?token=fake-token</Token></PayoneerToken>' }
 
     it 'generates the correct request' do
-      expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, hash_including(mname: 'GetToken')).and_return(response)
+      expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: hash_including(mname: 'GetToken')).and_return(response)
       response = client.payee_signup_url('test')
       expect(response.ok?).to be_truthy
       expect(response.body).to eq('https://payouts.sandbox.payoneer.com/partners/lp.aspx?token=fake-token')
@@ -77,7 +79,7 @@ describe Payoneer::Client do
     let(:xml) { '<?xml version="1.0" encoding="ISO-8859-1" standalone="yes"?><GetPayeeDetails><Payee><FirstName>Foo</FirstName><LastName>Bar</LastName><Email>foo@bar.com</Email><Address1>185 Berry Street</Address1><Address2>Suite 2400</Address2><City>San Francisco</City><State>CA</State><Zip>94107</Zip><Country>US</Country><Phone></Phone><Mobile>15552223333</Mobile><PayeeStatus>Active</PayeeStatus><PayOutMethod>Prepaid Card</PayOutMethod><Cards><Card><CardID>123456789</CardID><Currency>USD</Currency><ActivationStatus>Card Issued, Not Activated</ActivationStatus><CardShipDate>11/25/2015</CardShipDate><CardStatus>Active</CardStatus></Card></Cards><RegDate>10/9/2017 7:58:44 PM</RegDate></Payee><CompanyDetails><CompanyName></CompanyName></CompanyDetails></GetPayeeDetails>' }
 
     it 'generates the correct request' do
-      expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, hash_including(mname: 'GetPayeeDetails')).and_return(response)
+      expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: hash_including(mname: 'GetPayeeDetails')).and_return(response)
       response = client.payee_details('fake-payee-id')
       expect(response.ok?).to be_truthy
       expect(response.body).to include('FirstName' => 'Foo', 'LastName' => 'Bar')
@@ -129,7 +131,7 @@ describe Payoneer::Client do
     end
 
     it 'generates the correct response' do
-      expect(RestClient).to receive(:post).exactly(1).times.with(endpoint, params.to_json, headers).and_return(response)
+      expect(RestClient::Request).to receive(:execute).exactly(1).times.with(method: :post, url: endpoint, payload: params.to_json, headers: headers).and_return(response)
       response = client.expanded_payout(payee_id: payee_id, client_reference_id: client_reference_id, amount: amount, description: description, currency: currency, seller_id: seller_id, seller_name: seller_name, seller_url: seller_url, path: path, credentials: credentials)
       expect(response.ok?).to be_truthy
       expect(response.body).to include('payee_id' => payee_id, 'amount' => amount)
@@ -138,4 +140,14 @@ describe Payoneer::Client do
       expect(response.body['orders_report']['orders']).to include('path' => path)
     end
   end
+
+  describe 'configuration' do
+    let(:config_options) { default_config_options.merge(http_client_options: { verify_ssl: true }) }
+    let(:xml) { "<?xml version='1.0' encoding='ISO-8859-1' ?><PayoneerResponse><Status>000</Status><Description>Echo Ok - All systems are up.</Description></PayoneerResponse>" }
+
+    it 'passes HTTP client options to HTTP client' do
+      expect(RestClient::Request).to receive(:execute).with(hash_including(verify_ssl: true)).and_return(response)
+      client.status
+    end
+  end
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: payoneer-client
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Chris Estreich
+- Todd Eichel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-16 00:00:00.000000000 Z
+date: 2018-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -41,6 +42,7 @@ dependencies:
 description: Payoneer SDK for ruby.
 email:
 - chris@tophatter.com
+- todd@tophatter.com
 executables:
 - payoneer-console
 extensions: []
@@ -86,7 +88,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Payoneer SDK for ruby.