payone_connect 0.1.2 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 1699947db054ca9586dc360c38956b741339e9ef
+  data.tar.gz: 03990fa223508e7f8aca009811c2084bc97f9214
+SHA512:
+  metadata.gz: fe4aff31eac09a35bc0cfd27d19e595c4ba403e5d0bfd6fc7a80bb38c71b0fd9f9bedfcf4a1e63c153bf0bcd9d2c76a784bf1ec184bf8ffa95e2920575ac205f
+  data.tar.gz: ae195a103bbcc840323d422539244a1257da9113dcf9062a1f2838c760ba2f9af1bf3596d0065cc50abcdd086e23fd04bc5d7b608e8e2d0d5e520ab3874e4d0a

data/.gitignore

@@ -4,3 +4,5 @@
 coverage
 rdoc
 pkg
+.ruby-gemset
+.ruby-version

data/.travis.yml

@@ -0,0 +1,6 @@
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - 2.1.2
+script: bundle exec rake

data/CHANGELOG

@@ -0,0 +1,7 @@
+= VERSION 0.2.0
+
+* Fix URI encoding (Jan Raasch)
+* Fixes error when response contains key without value
+* Add to travis (Alexander Lang)
+* Move to bundler (Alexander Lang)
+* Fixes error when response contains multiple consecutive newlines

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gemspec

data/Gemfile.lock

@@ -0,0 +1,42 @@
+PATH
+  remote: .
+  specs:
+    payone_connect (0.1.3)
+      activesupport
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (4.0.4)
+      i18n (~> 0.6, >= 0.6.9)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    atomic (1.1.16)
+    diff-lcs (1.2.5)
+    fakeweb (1.3.0)
+    i18n (0.6.9)
+    minitest (4.7.5)
+    multi_json (1.9.0)
+    rake (10.1.1)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.7)
+    rspec-expectations (2.14.4)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.4)
+    thread_safe (0.2.0)
+      atomic (>= 1.1.7, < 2)
+    tzinfo (0.3.39)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  fakeweb
+  payone_connect!
+  rake
+  rspec (~> 2.1)

data/README.rdoc

@@ -3,22 +3,18 @@
 This is a super simple wrapper around the API for the payment service provider payone (http://www.payone.de)
 
 == Installation
-=== Via github
-  gem install phuesler-payone_connect
-=== Via gem cutter (http://www.gemcutter.org)
-  gem install gemcutter
-  gem tumble
+
   gem install payone_connect
 
 == Usage
 
   require 'payone_connect'
-  
+
   payone = PayoneConnect.new(api_key,params_hash)
   puts payone.request[:status]
 
 == Note on Patches/Pull Requests
- 
+
 * Fork the project.
 * Make your feature addition or bug fix.
 * Add tests for it. This is important so I don't break it in a

data/Rakefile

@@ -1,50 +1,6 @@
-require 'rubygems'
-require 'rake'
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
-begin
-  require 'jeweler'
-  Jeweler::Tasks.new do |gem|
-    gem.name = "payone_connect"
-    gem.summary = %Q{Simple http client for the psp payone api (http://www.payone.de/)}
-    gem.description = %Q{Connects to the payone gateway and passes the parameters}
-    gem.email = "patrick.huesler@gmail.com"
-    gem.homepage = "http://github.com/phuesler/payone_connect"
-    gem.authors = ["Patrick Huesler"]
-    gem.add_development_dependency "rspec"
-    gem.add_development_dependency "fakeweb"
-    # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
-  end
-  Jeweler::GemcutterTasks.new
-rescue LoadError
-  puts "Jeweler (or a dependency) not available. Install it with: sudo gem install jeweler"
-end
+RSpec::Core::RakeTask.new(:spec)
 
-require 'spec/rake/spectask'
-Spec::Rake::SpecTask.new(:spec) do |spec|
-  spec.libs << 'lib' << 'spec'
-  spec.spec_files = FileList['spec/**/*_spec.rb']
-end
-
-Spec::Rake::SpecTask.new(:rcov) do |spec|
-  spec.libs << 'lib' << 'spec'
-  spec.pattern = 'spec/**/*_spec.rb'
-  spec.rcov = true
-end
-
-task :spec => :check_dependencies
-
-task :default => :spec
-
-require 'rake/rdoctask'
-Rake::RDocTask.new do |rdoc|
-  if File.exist?('VERSION')
-    version = File.read('VERSION')
-  else
-    version = ""
-  end
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "payone_connect #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+task default: :spec

data/lib/payone_connect/version.rb

@@ -0,0 +1,3 @@
+class PayoneConnect
+  VERSION = "0.2.0"
+end

data/lib/payone_connect.rb

@@ -1,7 +1,8 @@
 require 'net/http'
 require 'net/https'
 require 'uri'
-require 'payone_connect/core_ext'
+require 'active_support/core_ext/hash/keys'
+require 'active_support/core_ext/object/blank'
 
 class PayoneConnect
   attr_reader :request_data, :request_header
@@ -17,19 +18,19 @@ class PayoneConnect
     http.verify_mode = OpenSSL::SSL::VERIFY_NONE
     handle_response(http.post(@api_url.path, @request_data,@request_header))
   end
-  
+
   protected
-  
+
   def handle_response(http_response)
     return nil if http_response.body.blank?
     response = {}
-    http_response.body.split("\n").each do |param|
-      key,value = param.scan(/([^=]+)=(.+)/).first
+    http_response.body.split(/\n+/).each do |param|
+      key,value = param.scan(/([^=]+)=(.*)/).first
       response[key.to_sym] = value
     end
     response
   end
-  
+
   def process_data(data)
     data.stringify_keys!
     %w(mid portalid key mode).each do |required_field|
@@ -39,12 +40,12 @@ class PayoneConnect
     data.each do |key,value|
       if value.is_a?(Hash)
         value.each do |nested_key, nested_value|
-          post_data << "#{key.to_s}[#{nested_key.to_s}]=#{URI.encode(nested_value.to_s)}"
+          post_data << "#{key.to_s}[#{nested_key.to_s}]=#{URI.encode_www_form_component(nested_value.to_s)}"
         end
       else
-          post_data << "#{key.to_s}=#{URI.encode(value.to_s)}"
+          post_data << "#{key.to_s}=#{URI.encode_www_form_component(value.to_s)}"
       end
     end
     post_data.join("&")
   end
-end
+end

data/payone_connect.gemspec

@@ -1,58 +1,23 @@
-# Generated by jeweler
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
-# -*- encoding: utf-8 -*-
+require File.expand_path('../lib/payone_connect/version', __FILE__)
 
 Gem::Specification.new do |s|
   s.name = %q{payone_connect}
-  s.version = "0.1.2"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Patrick Huesler"]
-  s.date = %q{2010-02-18}
+  s.authors = ["Patrick Huesler", "Alexander Lang", "Jan Raasch", "Christoph Hugo"]
+  s.date = %q{2009-10-04}
   s.description = %q{Connects to the payone gateway and passes the parameters}
   s.email = %q{patrick.huesler@gmail.com}
-  s.extra_rdoc_files = [
-    "LICENSE",
-     "README.rdoc"
-  ]
-  s.files = [
-    ".document",
-     ".gitignore",
-     "LICENSE",
-     "README.rdoc",
-     "Rakefile",
-     "VERSION",
-     "lib/payone_connect.rb",
-     "lib/payone_connect/core_ext.rb",
-     "payone_connect.gemspec",
-     "spec/payone_connect_spec.rb",
-     "spec/spec_helper.rb"
-  ]
+  s.version       = PayoneConnect::VERSION
   s.homepage = %q{http://github.com/phuesler/payone_connect}
-  s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.5}
   s.summary = %q{Simple http client for the psp payone api (http://www.payone.de/)}
-  s.test_files = [
-    "spec/payone_connect_spec.rb",
-     "spec/spec_helper.rb"
-  ]
+  s.files         = `git ls-files`.split($\)
+  s.test_files    = s.files.grep(%r{^spec/})
 
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
-
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rspec>, [">= 0"])
-      s.add_development_dependency(%q<fakeweb>, [">= 0"])
-    else
-      s.add_dependency(%q<rspec>, [">= 0"])
-      s.add_dependency(%q<fakeweb>, [">= 0"])
-    end
-  else
-    s.add_dependency(%q<rspec>, [">= 0"])
-    s.add_dependency(%q<fakeweb>, [">= 0"])
-  end
+  s.add_dependency 'activesupport'
+  s.add_development_dependency(%q<rspec>, ["~> 2.1"])
+  s.add_development_dependency(%q<fakeweb>, [">= 0"])
+  s.add_development_dependency(%q<rake>, [">= 0"])
 end
-

data/spec/payone_connect_spec.rb

@@ -24,65 +24,81 @@ describe PayoneConnect do
     @finance_gate_connection = PayoneConnect.new("https://testapi.pay1.de/post-gateway/",@request_data)
     @uri = URI.parse("https://testapi.pay1.de/post-gateway/")
   end
-  
+
   describe "connection" do
-    it "should connect to the payone gateway" do
+    it "connects to the payone gateway" do
       https_connection = Net::HTTP.new(@uri.host, @uri.port)
-      Net::HTTP.should_receive(:new).with(@uri.host,@uri.port).and_return(https_connection)
+
+      expect(Net::HTTP).to receive(:new).with(@uri.host,@uri.port) { https_connection }
+
       @finance_gate_connection.request
     end
-      
-    it "should set the x form header" do
-      @finance_gate_connection.request_header.should == {'Content-Type'=> 'application/x-www-form-urlencoded'}
+
+    it "sets the x form header" do
+      expect(@finance_gate_connection.request_header).to eql('Content-Type'=> 'application/x-www-form-urlencoded')
     end
   end
-  
+
   describe "general parameter assignment" do
     %w(portalid mid mode key encoding request).each do |parameter|
-      it "should set the #{parameter} parameter" do
-        @finance_gate_connection.request_data.should include("#{parameter}=#{@request_data[parameter]}")
+      it "sets the #{parameter} parameter" do
+        expect(@finance_gate_connection.request_data).to include("#{parameter}=#{@request_data[parameter]}")
       end
     end
   end
-  
+
   describe "successful request" do
     before(:each) do
       FakeWeb.register_uri(:post, "https://testapi.pay1.de/post-gateway/", :body => "status=APPROVED\ntxid=18059493\nuserid=4923401")
     end
-    
-    it "should return the status" do
-      @finance_gate_connection.request[:status].should == "APPROVED"
+
+    it "returns the status" do
+      expect(@finance_gate_connection.request[:status]).to eql("APPROVED")
+    end
+
+    it "returns payone's transaction id" do
+      expect(@finance_gate_connection.request[:txid]).to eql("18059493")
+    end
+
+    it "returns payone's user id" do
+      expect(@finance_gate_connection.request[:userid]).to eql("4923401")
     end
-    
-    it "should return payones transaction id" do
-      @finance_gate_connection.request[:txid].should == "18059493"
+
+    it 'ignores empty lines' do
+      FakeWeb.register_uri(:post, "https://testapi.pay1.de/post-gateway/", :body => "status=APPROVED\n\ntxid=18059493\nuserid=4923401")
+
+      expect(@finance_gate_connection.request[:userid]).to eql("4923401")
     end
-    
-    it "should return payones user id" do
-      @finance_gate_connection.request[:userid].should == "4923401"
+
+    it 'parses empty values' do
+      FakeWeb.register_uri(:post, "https://testapi.pay1.de/post-gateway/", :body => "status=APPROVED\nmandate_identification=PO-11190784\nmandate_status=active\nmandate_text=\ncreditor_identifier=DE16ZZZ00000961533\niban=DE76460500010209043724\nbic=WELADED1SIE\n")
+
+      expect(@finance_gate_connection.request[:mandate_text]).to eql("")
+      expect(@finance_gate_connection.request[:mandate_identification]).to eql("PO-11190784")
     end
   end
-  
+
   describe "response is redirect" do
-    it "should parse the redirect url correctly" do
+    it "parses the redirect url correctly" do
       FakeWeb.register_uri(:post, "https://testapi.pay1.de/post-gateway/", :body => "status=REDIRECT\ntxid=18059493\nuserid=4923401\nredirecturl=https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token=ABC&useraction=commit")
-      @finance_gate_connection.request[:redirecturl].should == "https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token=ABC&useraction=commit"
+
+      expect(@finance_gate_connection.request[:redirecturl]).to eql("https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token=ABC&useraction=commit")
     end
   end
-  
+
   describe "authorization parameter assignment" do
     %w(aid reference currency amount clearingtype).each do |parameter|
-      it "should set the #{parameter} parameter" do
-        @finance_gate_connection.request_data.should include("#{parameter}=#{@request_data[parameter]}")
+      it "sets the #{parameter} parameter" do
+        expect(@finance_gate_connection.request_data).to include("#{parameter}=#{@request_data[parameter]}")
       end
     end
   end
-    
+
   describe "credit card payment parameter assignment" do
     %w(cardpan cardtype cardexpiredate cardcvc2 cardholder).each do |parameter|
-      it "should set the #{parameter} parameter" do
-        @finance_gate_connection.request_data.should include("#{parameter}=#{URI.encode(@request_data[parameter].to_s)}")
+      it "sets the #{parameter} parameter" do
+        expect(@finance_gate_connection.request_data).to include("#{parameter}=#{URI.encode_www_form_component(@request_data[parameter].to_s)}")
       end
     end
-  end  
-end
+  end
+end

data/spec/spec_helper.rb

@@ -1,11 +1,5 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'payone_connect'
-require 'spec'
-require 'spec/autorun'
-require 'rubygems'
+require 'rspec'
 require 'fake_web'
-
-Spec::Runner.configure do |config|
-  
-end

metadata

@@ -1,86 +1,117 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: payone_connect
-version: !ruby/object:Gem::Version 
-  version: 0.1.2
+version: !ruby/object:Gem::Version
+  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Patrick Huesler
+- Alexander Lang
+- Jan Raasch
+- Christoph Hugo
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2010-02-18 00:00:00 +01:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2009-10-04 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
   type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+- !ruby/object:Gem::Dependency
   name: fakeweb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Connects to the payone gateway and passes the parameters
 email: patrick.huesler@gmail.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
-- LICENSE
-- README.rdoc
-files: 
-- .document
-- .gitignore
+extra_rdoc_files: []
+files:
+- ".document"
+- ".gitignore"
+- ".travis.yml"
+- CHANGELOG
+- Gemfile
+- Gemfile.lock
 - LICENSE
 - README.rdoc
 - Rakefile
-- VERSION
 - lib/payone_connect.rb
-- lib/payone_connect/core_ext.rb
+- lib/payone_connect/version.rb
 - payone_connect.gemspec
 - spec/payone_connect_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: http://github.com/phuesler/payone_connect
 licenses: []
-
+metadata: {}
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
-require_paths: 
+rdoc_options: []
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Simple http client for the psp payone api (http://www.payone.de/)
-test_files: 
+test_files:
 - spec/payone_connect_spec.rb
 - spec/spec_helper.rb

data/VERSION

@@ -1 +0,0 @@
-0.1.2

data/lib/payone_connect/core_ext.rb

@@ -1,76 +0,0 @@
-class Hash
-  # Return a new hash with all keys converted to strings.
-  def stringify_keys
-    inject({}) do |options, (key, value)|
-      options[key.to_s] = value
-      options
-    end
-  end
-
-  # Destructively convert all keys to strings.
-  def stringify_keys!
-    keys.each do |key|
-      self[key.to_s] = delete(key)
-    end
-    self
-  end
-end
-
-class Object
-  # An object is blank if it's false, empty, or a whitespace string.
-  # For example, "", "   ", +nil+, [], and {} are blank.
-  #
-  # This simplifies
-  #
-  #   if !address.nil? && !address.empty?
-  #
-  # to
-  #
-  #   if !address.blank?
-  def blank?
-    respond_to?(:empty?) ? empty? : !self
-  end
-    
-  # An object is present if it's not blank.
-  def present?
-    !blank?
-  end
-end
-
-class NilClass #:nodoc:
-  def blank?
-    true
-  end
-end
-
-class FalseClass #:nodoc:
-  def blank?
-    true
-  end
-end
-
-class TrueClass #:nodoc:
-  def blank?
-    false
-  end
-end
-
-class Array #:nodoc:
-  alias_method :blank?, :empty?
-end
-
-class Hash #:nodoc:
-  alias_method :blank?, :empty?
-end
-
-class String #:nodoc:
-  def blank?
-    self !~ /\S/
-  end
-end
-
-class Numeric #:nodoc:
-  def blank?
-    false
-  end
-end