paylane 1.0.2 → 1.1.0

data/.travis.yml

@@ -2,4 +2,4 @@ rvm:
   - 1.9.3
 notifications:
   email:
-    - bkzl@ragnarson.com
+    - devs@shellycloud.com

data/README.md

@@ -14,7 +14,7 @@ or
 
 Start from create a client for API.
 
-    gateway = PayLane::Gateway.new('login, 'password')
+    gateway = PayLane::Gateway.new('login', 'password')
     client = PayLane::API.new(gateway.connect)
 
 Now all methods from [original API](http://devzone.paylane.com/wp-content/uploads/2012/05/paylane_direct_system.pdf) are available in the client object.

data/lib/paylane/api.rb

@@ -8,42 +8,49 @@ module PayLane
     end
 
     def multi_sale(params)
-      request(:multiSale, params, 'multi_sale_params')[:multi_sale_response][:response]
+      response = request(:multiSale, params, 'multi_sale_params')
+      Response.new(response[:multi_sale_response][:response])
     end
 
     def capture_sale(params)
-      request(:captureSale, params)[:capture_sale_response][:response]
+      response = request(:captureSale, params)
+      Response.new(response[:capture_sale_response][:response])
     end
 
     def close_sale_authorization(params)
-      request(:closeSaleAuthorization, params)[:close_sale_authorization_response][:response]
+      response = request(:closeSaleAuthorization, params)
+      Response.new(response[:close_sale_authorization_response][:response])
     end
 
     def refund(params)
-      request(:refund, params)[:refund_response][:response]
+      response = request(:refund, params)
+      Response.new(response[:refund_response][:response])
     end
 
     def resale(params)
-      request(:resale, params)[:resale_response][:response]
+      response = request(:resale, params)
+      Response.new(response[:resale_response][:response])
     end
 
     def get_sale_result(params)
-      request(:getSaleResult, params)[:get_sale_result_response][:response]
+      response = request(:getSaleResult, params)
+      Response.new(response[:get_sale_result_response][:response])
     end
 
     def check_sales(params)
-      request(:checkSales, params, 'check_sales_params')[:check_sales_response][:check_sales_response]
+      response = request(:checkSales, params, 'check_sales_params')
+      Response.new(response[:check_sales_response][:check_sales_response])
     end
 
     private
 
     def request(method, params, params_prefix = nil)
       begin
-        body = params_prefix ? {params_prefix => params} : params
-        soap_response = @client.request(method) { soap.body = body }
-        PayLane::Response.new(soap_response.to_hash)
+        @client.request(method) do
+          soap.body = (params_prefix ? {params_prefix => params} : params)
+        end.to_hash
       rescue Savon::Error => e
-        err = PayLane::ConnectionError.new(e)
+        err = ConnectionError.new(e)
         PayLane.logger.error("[PayLane][Savon] #{err.to_hash}")
         raise err
       end

data/lib/paylane/payment.rb

@@ -1,8 +1,8 @@
 module PayLane
   class Payment
     def initialize(options = {})
-      gateway = PayLane::Gateway.new(PayLane.login, PayLane.password)
-      @api = PayLane::API.new(gateway.connect)
+      gateway = Gateway.new(PayLane.login, PayLane.password)
+      @api = API.new(gateway.connect)
       @options = options
     end
 

data/lib/paylane/recurring_payment.rb

@@ -1,8 +1,8 @@
 module PayLane
   class RecurringPayment
     def initialize(previous_sale_id, options = {})
-      gateway = PayLane::Gateway.new(PayLane.login, PayLane.password)
-      @api = PayLane::API.new(gateway.connect)
+      gateway = Gateway.new(PayLane.login, PayLane.password)
+      @api = API.new(gateway.connect)
       @previous_sale_id = previous_sale_id
       @options = options
     end

data/lib/paylane/response.rb

@@ -1,15 +1,13 @@
 module PayLane
   class Response < Hash
-    def initialize(response)
-      @response = response
-    end
+    attr_reader :body
 
-    def [](key)
-      @response[key]
+    def initialize(body)
+      @body = body
     end
 
     def has_ok?
-      @response.include?(:ok)
+      @body.include?(:ok)
     end
 
     def has_error?
@@ -17,20 +15,16 @@ module PayLane
     end
 
     def has_data?
-      @response.include?(:data)
+      @body.include?(:data)
     end
 
     def error_description
-       @response[:error][:error_description] if has_error?
+       @body[:error][:error_description] if has_error?
     end
 
     def attributes
-      hash = (@response[:ok] || @response[:error])
-      has_data? ? hash.merge(@response[:data]) : hash
-    end
-
-    def to_s
-      @response.to_s
+      hash = (@body[:ok] || @body[:error])
+      has_data? ? hash.merge(@body[:data]) : hash
     end
   end
 end

data/lib/paylane/version.rb

@@ -1,3 +1,3 @@
 module PayLane
-  VERSION = "1.0.2"
+  VERSION = "1.1.0"
 end

data/spec/helpers.rb

@@ -5,7 +5,7 @@ end
 
 module Helpers
   def mock_api_method(connection, method)
-    response = double(to_hash: yield)
+    response = mock(to_hash: yield)
     connection.should_receive(:request).with(method).and_return(response)
   end
 end

data/spec/paylane/api_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe PayLane::API do
-  let(:connection) {
+  let(:connection) do
     gateway = PayLane::Gateway.new(PublicTestAccount::LOGIN, PublicTestAccount::PASSWORD)
     gateway.connect
-  }
+  end
   let(:api) { PayLane::API.new(connection) }
 
   describe '#multi_sale' do
@@ -31,7 +31,8 @@ describe PayLane::API do
 
     it "returns id_sale on successful card charge" do
       mock_api_method(connection, :multiSale) do
-        {multi_sale_response: {response: {ok: {id_sale: "2772323"}, data: {fraud_score: "8.76"}}}}
+        {multi_sale_response: {response: {ok: {id_sale: "2772323"},
+                                          data: {fraud_score: "8.76"}}}}
       end
 
       params.merge({
@@ -44,12 +45,13 @@ describe PayLane::API do
             'name_on_card' => 'John Smith'
       }}})
 
-      api.multi_sale(params).should include({ok: {id_sale: "2772323"}})
+      api.multi_sale(params).body.should include({ok: {id_sale: "2772323"}})
     end
 
     it "returns id_sale on successful direct debit" do
       mock_api_method(connection, :multiSale) do
-        {multi_sale_response: {response: {ok: {id_sale: "2772323"}, data: {fraud_score: "8.76"}}}}
+        {multi_sale_response: {response: {ok: {id_sale: "2772323"},
+                                          data: {fraud_score: "8.76"}}}}
       end
 
       params.merge({
@@ -61,12 +63,13 @@ describe PayLane::API do
             'account_holder' => 'John Smith'
       }}})
 
-      api.multi_sale(params).should include({ok: {id_sale: "2772323"}})
+      api.multi_sale(params).body.should include({ok: {id_sale: "2772323"}})
     end
 
     it "returns id_sale_authorization for sales marked by 'capture_later'" do
       mock_api_method(connection, :multiSale) do
-        {multi_sale_response: {response: {ok: {id_sale_authorization: "2772323"}, data: {fraud_score: "8.76"}}}}
+        {multi_sale_response: {response: {ok: {id_sale_authorization: "2772323"},
+                                          data: {fraud_score: "8.76"}}}}
       end
 
       params.merge({
@@ -82,7 +85,16 @@ describe PayLane::API do
         'capture_later' => true
       })
 
-      api.multi_sale(params).should include({ok: {id_sale_authorization: "2772323"}})
+      api.multi_sale(params).body.should include({ok: {id_sale_authorization: "2772323"}})
+    end
+
+    it "returns instance of PayLane::Response class" do
+      mock_api_method(connection, :multiSale) do
+        {multi_sale_response: {response: {ok: {id_sale: "2772323"},
+                                          data: {fraud_score: "8.76"}}}}
+      end
+
+      api.multi_sale(params).class.should == PayLane::Response
     end
   end
 
@@ -97,7 +109,7 @@ describe PayLane::API do
         'amount' => 9.99
       }
 
-      api.capture_sale(params).should include({ok: {id_sale: "2772323"}})
+      api.capture_sale(params).body.should include({ok: {id_sale: "2772323"}})
     end
   end
 
@@ -109,7 +121,7 @@ describe PayLane::API do
 
       params = {'id_sale_authorization' => '119225'}
 
-      api.close_sale_authorization(params).should include({ok: {is_closed: true}})
+      api.close_sale_authorization(params).body.should include({ok: {is_closed: true}})
     end
   end
 
@@ -125,7 +137,7 @@ describe PayLane::API do
         'reason' => 'test_refund_method'
       }
 
-      api.refund(params).should include({ok: {id_refund: "213871"}})
+      api.refund(params).body.should include({ok: {id_refund: "213871"}})
     end
   end
 
@@ -142,7 +154,7 @@ describe PayLane::API do
         'description' => 'paylane_api_test_resale'
       }
 
-      api.resale(params).should include({ok: {id_sale: "2773239"}})
+      api.resale(params).body.should include({ok: {id_sale: "2773239"}})
     end
   end
 
@@ -157,7 +169,7 @@ describe PayLane::API do
         'description' => 'paylane_api_test'
       }
 
-      api.get_sale_result(params).should include({ok: {id_sale: "2772323"}})
+      api.get_sale_result(params).body.should include({ok: {id_sale: "2772323"}})
     end
 
     it "returns id_sale_error if find processed sale with error" do
@@ -170,21 +182,30 @@ describe PayLane::API do
         'description' => 'paylane_api_test'
       }
 
-      api.get_sale_result(params).should include({ok: {id_sale_error: "831072"}})
+      api.get_sale_result(params).body.should include({ok: {id_sale_error: "831072"}})
     end
   end
 
   describe '#check_sales' do
     it 'returns details for requested sale ids' do
       mock_api_method(connection, :checkSales) do
-        {check_sales_response: {check_sales_response: {ok: {sale_status: [{id_sale: "1", status: "NOT_FOUND", is_refund: false, is_chargeback: false, is_reversal: false}, {id_sale: "2772323", status: "PERFORMED", is_refund: false, is_chargeback: false, is_reversal: false}]}}}}
+        {check_sales_response: {check_sales_response: {ok: {sale_status: [
+          {id_sale: "1", status: "NOT_FOUND", is_refund: false,
+           is_chargeback: false, is_reversal: false}, 
+          {id_sale: "2772323", status: "PERFORMED", is_refund: false,
+           is_chargeback: false, is_reversal: false}
+        ]}}}}
       end
 
       params = {'id_sale_list' => [2772323, 1]}
 
-      sales = api.check_sales(params)[:ok][:sale_status]
-      sales.should include({id_sale: "1", status: "NOT_FOUND", is_refund: false, is_chargeback: false, is_reversal: false})
-      sales.should include({id_sale: "2772323", status: "PERFORMED", is_refund: false, is_chargeback: false, is_reversal: false})
+      sales = api.check_sales(params).body[:ok][:sale_status]
+      sales.should include({id_sale: "1", status: "NOT_FOUND",
+                            is_refund: false, is_chargeback: false,
+                            is_reversal: false})
+      sales.should include({id_sale: "2772323", status: "PERFORMED",
+                            is_refund: false, is_chargeback: false,
+                            is_reversal: false})
     end
   end
 end

metadata

@@ -1,67 +1,76 @@
 --- !ruby/object:Gem::Specification
 name: paylane
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Bartlomiej Kozal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-25 00:00:00.000000000 Z
+date: 2013-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
+  type: :runtime
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.2.0
-  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: rake
+  type: :development
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
+  type: :development
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fakeweb
+  type: :development
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -99,26 +108,27 @@ files:
 - spec/spec_helper.rb
 homepage: ''
 licenses: []
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Ruby client for PayLane service.
 test_files:
 - spec/helpers.rb

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZDQ0NWIxMmQwZmRjMDg5ZjE5ZjhkNzQ0MWFjOWI5OWNjZmI1ZTQ2MA==
-  data.tar.gz: !binary |-
-    MGU2MTFiMzJhOGVhMzhiZmMzZmQ2NWI4ODA2OTE3OTljZjhhYTA2ZA==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    NzY5MTRkNTgzMDBlZTAwNWY0N2YyZWYxNjNhMTEzODFmN2Y2YzgxNmMxZmIz
-    MDBlNTQwODM0Yjg2ZjRlYWU3MGQ5MWVkZGRkMWJiNTU1YTU1Nzk0MTJjYTBk
-    ODgxZmJkNDJmM2FlMzQ0MzA0NWFlYzY0NDIyNGJmMTQ5ZmYxYzk=
-  data.tar.gz: !binary |-
-    ZGY2MWNjMDkyZjBiMjgwZjI2MjkzZDQyYmE0MGJkNGIzMzI4ZjM4M2QwOWEz
-    ZGUyODdkYjI4YzM5OTJkNzE4MjZkMWZjMmMyNDExNzJjNmMyZTkyODIyYTg2
-    ZTYzODVkNWFjMDNhZWM2NTNjNGE5NjNjNjEzZTVlMmVkZGUyOGE=