pavlov 0.1.7.1 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9758ce291059ff9041789760c3859314ca2dfd25
-  data.tar.gz: 74b504eed67d6d0f91811dfe78c88b1142c6dad0
+  metadata.gz: c1b5c84ab82aad4e0ff3231c23c2ecb6c8511165
+  data.tar.gz: b031d26eb86570328beee0ace26d0594cb2bffd2
 SHA512:
-  metadata.gz: 09587b7f4e809ef8050ce7ebac50bd91d557352382f8a648861ab3c65025d8900871e5258db93ed94a4b0a03e7cb33df3e198257f1372f37408ea63f39908158
-  data.tar.gz: 66f927ebc21ce5168f01796d9c4eefa8986a969838d04f24e375726ebd76dbc13bd4ba073f857400875058ad75115f018bc04f95b7b9a75bbcce82d1cf975f2a
+  metadata.gz: 0db1daccbeaac3214a1383fa6efe0e883cd3f32d5c7fd201ffe4903c4889fbbd23e70c0e80988c6c245ea4bc1e985b68e6a20fa26d4bda17b2382ef2f77f15b1
+  data.tar.gz: 4a599d76b32385939a5699a3d6082753436691303d68e894108ada5ab3bd5639b1f4fe1bff6a18f3812643db4000ac4a9a6e67306901e92521de60d8464ee055

data/lib/generators/pavlov/install_generator.rb

@@ -14,4 +14,4 @@ module Pavlov
       application "config.autoload_paths += %W(\#{config.root}/app/backend)"
     end
   end
-end
+end

data/lib/generators/pavlov/templates/backend/backend.rb

@@ -1,3 +1,3 @@
 class Backend
   # This class is a placeholder that will be expanded by a later feature branch
-end
+end

data/lib/pavlov.rb

@@ -1,14 +1,6 @@
-module Pavlov
-  # this method is also available as constantize in Rails,
-  # but we want to be able to write classes and/or tests without Rails
-  def self.get_class_by_string classname
-    classname.constantize
-  end
-
-  def self.string_to_classname string
-    string.to_s.camelize
-  end
+require 'pavlov/support/inflector'
 
+module Pavlov
   def self.command command_name, *args
     klass = class_for_command(command_name)
     klass.new(*args).call
@@ -27,22 +19,20 @@ module Pavlov
   private
 
   def self.class_for_command command_name
-    class_name = 'Commands::' + string_to_classname(command_name)
-    get_class_by_string(class_name)
+    OperationFinder.find(Commands, command_name)
   end
 
   def self.class_for_interactor interactor_name
-    class_name = 'Interactors::' + string_to_classname(interactor_name)
-    get_class_by_string(class_name)
+    OperationFinder.find(Interactors, interactor_name)
   end
 
   def self.class_for_query query_name
-    class_name = 'Queries::' + string_to_classname(query_name)
-    get_class_by_string(class_name)
+    OperationFinder.find(Queries, query_name)
   end
 end
 
 require_relative 'pavlov/engine' if defined?(Rails)
+require_relative 'pavlov/operation_finder'
 require_relative 'pavlov/helpers'
 require_relative 'pavlov/access_denied'
 require_relative 'pavlov/operation'

data/lib/pavlov/alpha_compatibility.rb

@@ -8,50 +8,50 @@ module Pavlov
     def validate_hexadecimal_string param_name, param
       return if param.is_a?(String) && /\A[\da-fA-F]+\Z/.match(param)
 
-      raise Pavlov::ValidationError,  "#{param_name.to_s} should be an hexadecimal string."
+      errors.add param_name, 'should be an hexadecimal string.'
     end
 
     def validate_regex param_name, param, regex, message
       return if regex.match param
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} #{message}"
+      errors.add param_name, "#{message}"
     end
 
     def validate_integer param_name, param, opts = {}
       return if opts[:allow_blank] && param.blank?
       return if param.is_a?(Integer)
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} should be an integer."
+      errors.add param_name, 'should be an integer.'
     end
 
     def validate_in_set param_name, param, set
       return if set.include? param
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} should be on of these values: #{set.inspect}."
+      errors.add param_name, 'should be on of these values: #{set.inspect}.'
     end
 
     def validate_string param_name, param
       return if param.is_a?(String)
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} should be a string."
+      errors.add param_name, 'should be a string.'
     end
 
     def validate_nonempty_string param_name, param
       return if param.is_a?(String) && !param.empty?
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} should be a nonempty string."
+      errors.add param_name, 'should be a nonempty string.'
     end
 
     def validate_integer_string param_name, param
       return if param.is_a?(String) && /\A\d+\Z/.match(param)
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} should be an integer string."
+      errors.add param_name, 'should be an integer string.'
     end
 
     def validate_not_nil param_name, param
       return unless param.nil?
 
-      raise Pavlov::ValidationError, "#{param_name.to_s} should not be nil."
+      errors.add param_name, 'should not be nil.'
     end
   end
 
@@ -63,9 +63,6 @@ module Pavlov
         args.each do |argument|
           attribute argument, Object, default: nil
         end
-
-        # Add attribute for pavlov_options
-        attribute :pavlov_options, Hash, default: {}
       end
     end
   end

data/lib/pavlov/engine.rb

@@ -3,4 +3,4 @@ require 'rails'
 module Pavlov
   class Engine < Rails::Engine
   end
-end
+end

data/lib/pavlov/helpers.rb

@@ -20,7 +20,7 @@ module Pavlov
 
     def with_pavlov_options hash
       if pavlov_options != {}
-        if hash.has_key? 'pavlov_options'
+        if hash.key? 'pavlov_options'
           hash[:pavlov_options] = pavlov_options.merge(hash[:pavlov_options])
         else
           hash[:pavlov_options] = pavlov_options

data/lib/pavlov/operation.rb

@@ -3,6 +3,10 @@ require 'pavlov/helpers'
 require 'virtus'
 require_relative 'access_denied'
 
+require 'active_model'
+require 'active_model/naming'
+require 'active_model/errors'
+
 module Pavlov
   class ValidationError < StandardError
   end
@@ -10,17 +14,28 @@ module Pavlov
   module Operation
     extend Pavlov::Concern
     include Pavlov::Helpers
-    include Virtus
+
+    included do
+      include Virtus
+      extend ActiveModel::Naming
+      extend ActiveModel::Translation
+
+      attribute :pavlov_options, Hash, default: {}
+    end
+
+    def errors
+      @errors ||= ActiveModel::Errors.new(self)
+    end
 
     def valid?
       check_validation
-      true
+      errors.empty?
     rescue Pavlov::ValidationError
       false
     end
 
     def call(*args, &block)
-      check_validation
+      raise Pavlov::ValidationError, 'Some validations fail, cannot execute' unless valid?
       check_authorization
       execute(*args, &block)
     end
@@ -42,7 +57,7 @@ module Pavlov
 
     def missing_arguments
       attribute_set.select do |attribute|
-        !attribute.options.has_key?(:default) && send(attribute.name).nil?
+        !attribute.options.key?(:default) && send(attribute.name).nil?
       end
     end
 

data/lib/pavlov/operation_finder.rb

@@ -0,0 +1,32 @@
+require 'pavlov/support/inflector'
+
+module Pavlov
+  class OperationFinder
+    attr_reader :namespace
+
+    def self.find(namespace, operation_name)
+      operation_lookup_list = Inflector.camelize(operation_name.to_s).split('::')
+      operation_lookup_list.reduce(namespace) do |current_namespace, namespace_or_operation_name|
+        new(current_namespace).send(namespace_or_operation_name)
+      end
+    end
+
+    def initialize(namespace)
+      @namespace = namespace
+    end
+
+    def method_missing(name, attributes = {})
+      find_klass(name)
+    end
+
+    def respond_to_missing?(name, include_private = false)
+      find_klass(name)
+    end
+
+    private
+
+    def find_klass(name)
+      namespace.const_get(Inflector.camelize(name.to_s), false)
+    end
+  end
+end

data/lib/pavlov/support/inflector.rb

@@ -0,0 +1,15 @@
+require 'backports/rails/string'
+
+module Pavlov
+  class Inflector
+    def self.camelize(string, first_letter = :upper)
+      # Feel free to reimplement if you want to get rid of backports dependency.
+      string.camelize
+    end
+
+    def self.constantize(string)
+      # Feel free to reimplement if you want to get rid of backports dependency.
+      string.constantize
+    end
+  end
+end

data/lib/pavlov/version.rb

@@ -2,5 +2,5 @@ module Pavlov
   # We're doing this because we might write tests that deal
   # with other versions of bundler and we are unsure how to
   # handle this better.
-  VERSION = '0.1.7.1'
+  VERSION = '0.1.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pavlov
 version: !ruby/object:Gem::Version
-  version: 0.1.7.1
+  version: 0.1.8
 platform: ruby
 authors:
 - Marten Veldthuis
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-19 00:00:00.000000000 Z
+date: 2013-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -29,6 +29,34 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.5.5
+- !ruby/object:Gem::Dependency
+  name: backports
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 3.2.7
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 3.2.7
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -187,7 +215,9 @@ files:
 - lib/pavlov/helpers.rb
 - lib/pavlov/interactor.rb
 - lib/pavlov/operation.rb
+- lib/pavlov/operation_finder.rb
 - lib/pavlov/query.rb
+- lib/pavlov/support/inflector.rb
 - lib/pavlov/version.rb
 homepage: https://github.com/Factlink/pavlov/
 licenses: