paul_revere 1.3 → 1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0ab658fb765586c440e09c6d2d77eb6fc79e4ae
-  data.tar.gz: e63e7621bd2fde8575a80a0db3c88f604b72d491
+  metadata.gz: 355afacefa6cf9309f77b784430797fa11dcf8d3
+  data.tar.gz: 0b6bf869f4f2004f70dea0e5a708ae2f5878848f
 SHA512:
-  metadata.gz: 7bfb60ac4a86dc3d538770e0319fb338eb937337198b57391f3a262568cf74a080c8d60acc0b4c3c9f594f53ea02c78b4545df2217ca0d4c4d2f92981b83832b
-  data.tar.gz: 8bd4721f70e180cf48c24e2ff49ba8c4bb8707299d0d9c5a457e4ca0c92583201643af0367bbc5ea35ad51e4e478238c58634a11ee37da2a896ffc658017f26f
+  metadata.gz: 6801cbf8cecdb895ff0364d6bd82eb9a97a4c3dec237f4c6eaf8a102768c67e7f3dac968933a42c3480bceba8d757ab2aafc895f40349cff0647dff065852119
+  data.tar.gz: 71100c4a13c779ad10c0a6bffdf022a12ed6d7be502483f26857077cd7b6de1ea289f4b03d3c5ac168f1af9fe09292d17c17d4921449e394236608f506a09ef7

data/.travis.yml

@@ -1,11 +1,12 @@
 language: ruby
 rvm:
-  - 1.9.3
   - 2.0.0
   - 2.1.5
+  - 2.2.0
 gemfile:
-  - gemfiles/rails_4.1.gemfile
-  - gemfiles/rails_4.0.gemfile
-  - gemfiles/rails_3.2.gemfile
-  - gemfiles/rails_3.1.gemfile
-  - gemfiles/rails_3.0.gemfile
+  - gemfiles/rails_4.2.0.gemfile
+  - gemfiles/rails_4.1.0.gemfile
+  - gemfiles/rails_4.0.0.gemfile
+notifications:
+  email: false
+sudo: false

data/Appraisals

@@ -1,4 +1,4 @@
-['4.1', '4.0', '3.2', '3.1', '3.0'].each do |rails_version|
+['4.2.0', '4.1.0', '4.0.0'].each do |rails_version|
   appraise "rails_#{rails_version}" do
     gem "rails", "~> #{rails_version}"
   end

data/Gemfile.lock

@@ -1,80 +1,101 @@
 PATH
   remote: .
   specs:
-    paul_revere (1.3)
-      rails (>= 3.0)
+    paul_revere (1.4)
+      rails (~> 4.0)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    actionmailer (4.1.8)
-      actionpack (= 4.1.8)
-      actionview (= 4.1.8)
+    actionmailer (4.2.0)
+      actionpack (= 4.2.0)
+      actionview (= 4.2.0)
+      activejob (= 4.2.0)
       mail (~> 2.5, >= 2.5.4)
-    actionpack (4.1.8)
-      actionview (= 4.1.8)
-      activesupport (= 4.1.8)
-      rack (~> 1.5.2)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+    actionpack (4.2.0)
+      actionview (= 4.2.0)
+      activesupport (= 4.2.0)
+      rack (~> 1.6.0)
       rack-test (~> 0.6.2)
-    actionview (4.1.8)
-      activesupport (= 4.1.8)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    actionview (4.2.0)
+      activesupport (= 4.2.0)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    activemodel (4.1.8)
-      activesupport (= 4.1.8)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    activejob (4.2.0)
+      activesupport (= 4.2.0)
+      globalid (>= 0.3.0)
+    activemodel (4.2.0)
+      activesupport (= 4.2.0)
       builder (~> 3.1)
-    activerecord (4.1.8)
-      activemodel (= 4.1.8)
-      activesupport (= 4.1.8)
-      arel (~> 5.0.0)
-    activesupport (4.1.8)
-      i18n (~> 0.6, >= 0.6.9)
+    activerecord (4.2.0)
+      activemodel (= 4.2.0)
+      activesupport (= 4.2.0)
+      arel (~> 6.0)
+    activesupport (4.2.0)
+      i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.1)
+      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     appraisal (1.0.2)
       bundler
       rake
       thor (>= 0.14.0)
-    arel (5.0.1.20140414130214)
+    arel (6.0.0)
     builder (3.2.2)
     diff-lcs (1.2.5)
     erubis (2.7.0)
     generator_spec (0.9.3)
       activesupport (>= 3.0.0)
       railties (>= 3.0.0)
+    globalid (0.3.3)
+      activesupport (>= 4.1.0)
     hike (1.2.3)
-    i18n (0.6.11)
-    json (1.8.1)
+    i18n (0.7.0)
+    json (1.8.2)
+    loofah (2.0.1)
+      nokogiri (>= 1.5.9)
     mail (2.6.3)
       mime-types (>= 1.16, < 3)
     mime-types (2.4.3)
-    minitest (5.5.0)
+    mini_portile (0.6.2)
+    minitest (5.5.1)
     multi_json (1.10.1)
-    rack (1.5.2)
-    rack-test (0.6.2)
+    nokogiri (1.6.6.2)
+      mini_portile (~> 0.6.0)
+    rack (1.6.0)
+    rack-test (0.6.3)
       rack (>= 1.0)
-    rails (4.1.8)
-      actionmailer (= 4.1.8)
-      actionpack (= 4.1.8)
-      actionview (= 4.1.8)
-      activemodel (= 4.1.8)
-      activerecord (= 4.1.8)
-      activesupport (= 4.1.8)
+    rails (4.2.0)
+      actionmailer (= 4.2.0)
+      actionpack (= 4.2.0)
+      actionview (= 4.2.0)
+      activejob (= 4.2.0)
+      activemodel (= 4.2.0)
+      activerecord (= 4.2.0)
+      activesupport (= 4.2.0)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.1.8)
-      sprockets-rails (~> 2.0)
-    railties (4.1.8)
-      actionpack (= 4.1.8)
-      activesupport (= 4.1.8)
+      railties (= 4.2.0)
+      sprockets-rails
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.5)
+      activesupport (>= 4.2.0.beta, < 5.0)
+      nokogiri (~> 1.6.0)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.0.1)
+      loofah (~> 2.0)
+    railties (4.2.0)
+      actionpack (= 4.2.0)
+      activesupport (= 4.2.0)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (10.4.2)
-    rspec (3.1.0)
-      rspec-core (~> 3.1.0)
-      rspec-expectations (~> 3.1.0)
-      rspec-mocks (~> 3.1.0)
     rspec-core (3.1.7)
       rspec-support (~> 3.1.0)
     rspec-expectations (3.1.2)
@@ -96,7 +117,7 @@ GEM
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.2)
+    sprockets-rails (2.2.4)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (>= 2.8, < 4.0)
@@ -111,9 +132,8 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  appraisal
-  generator_spec
+  appraisal (~> 1.0)
+  generator_spec (~> 0.9)
   paul_revere!
-  rspec
-  rspec-rails
-  sqlite3
+  rspec-rails (~> 3.1)
+  sqlite3 (~> 1.3)

data/NEWS.md

@@ -1,3 +1,11 @@
+New in 1.4:
+
+* Reference the MIT license from the gemspec
+* Update migration to avoid Rails deprecation warning about timestamps `null :false`
+* Drop support for ruby 1.9.3
+* Remove deprecated Rails method `link_to_function`
+* Use ISO 8601 format when creating the Announcement cookie name
+
 New in 1.3:
 
 * Fix for ActiveRecord migration/generator error on Rails 4+.

data/README.md

@@ -1,7 +1,7 @@
 Paul Revere
 ===========
 
-[![Build Status](https://secure.travis-ci.org/thoughtbot/paul_revere.png?branch=master)](http://travis-ci.org/thoughtbot/paul_revere)
+[![Build Status](https://travis-ci.org/thoughtbot/paul_revere.svg?branch=master)](https://travis-ci.org/thoughtbot/paul_revere)
 
 Simple announcement plugin to include "one off" style announcements in Rails web apps.
 

data/app/models/announcement.rb

@@ -1,8 +1,4 @@
 class Announcement < ActiveRecord::Base
-  if Rails::VERSION::MAJOR < 4
-    attr_accessible(:body)
-  end
-
   def self.current
     order('created_at desc').first || new
   end

data/app/views/announcements/_announcement_for_all.html.erb

@@ -2,7 +2,7 @@
   <div id="announcement">
     <span><%= current_announcement.body.html_safe %></span>
     <span class="hide">
-      <%= link_to_function "hide", "hideAnnouncement('announcement_#{current_announcement.created_at}')" %>
+      <%= link_to "hide", "#", onclick: "hideAnnouncement('announcement_#{current_announcement.created_at.iso8601}')" %>
     </span>
   </div>
 <% end %>

data/gemfiles/{rails_3.0.gemfile → rails_4.0.0.gemfile}

@@ -2,6 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "rails", "~> 3.0"
+gem "rails", "~> 4.0.0"
 
 gemspec :path => "../"

data/gemfiles/{rails_3.1.gemfile → rails_4.1.0.gemfile}

@@ -2,6 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "rails", "~> 3.1"
+gem "rails", "~> 4.1.0"
 
 gemspec :path => "../"

data/gemfiles/{rails_3.2.gemfile → rails_4.2.0.gemfile}

@@ -2,6 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "rails", "~> 3.2"
+gem "rails", "~> 4.2.0"
 
 gemspec :path => "../"

data/lib/generators/paul_revere/paul_revere_generator.rb

@@ -22,7 +22,7 @@ class PaulRevereGenerator < Rails::Generators::Base
   end
 
   def needs_js_copied?
-    ::Rails.version < '3.1' || !::Rails.application.config.assets.enabled
+    !::Rails.application.config.assets.enabled
   end
 
   def js_destination

data/lib/generators/paul_revere/templates/migration.rb

@@ -2,7 +2,7 @@ class CreateAnnouncements < ActiveRecord::Migration
   def self.up
     create_table :announcements do |t|
       t.text :body
-      t.timestamps
+      t.timestamps :null => false
     end
   end
 

data/lib/paul_revere/version.rb

@@ -1,3 +1,3 @@
 module PaulRevere
-  VERSION = '1.3'.freeze
+  VERSION = '1.4'.freeze
 end

data/paul_revere.gemspec

@@ -4,6 +4,7 @@ require 'paul_revere/version'
 Gem::Specification.new do |s|
   s.name        = 'paul_revere'
   s.version     = PaulRevere::VERSION.dup
+  s.licenses    = ['MIT']
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Nick Quaranto', 'Matt Jankowski', 'Joe Ferris', 'Christopher Meiklejohn', 'Tammer Saleh', 'Jason Morrison', 'Gabe Berke-Williams']
   s.email       = 'support@thoughtbot.com'
@@ -16,11 +17,10 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
 
-  s.add_dependency('rails', '>= 3.0')
+  s.add_dependency('rails', '~> 4.0')
 
-  s.add_development_dependency('rspec')
-  s.add_development_dependency('rspec-rails')
-  s.add_development_dependency('sqlite3')
-  s.add_development_dependency('appraisal')
-  s.add_development_dependency('generator_spec')
+  s.add_development_dependency('rspec-rails', '~> 3.1')
+  s.add_development_dependency('sqlite3', '~> 1.3')
+  s.add_development_dependency('appraisal', '~> 1.0')
+  s.add_development_dependency('generator_spec', '~> 0.9')
 end

data/spec/fake_app.rb

@@ -1,23 +1,13 @@
 # Create a rails app
 module PaulRevere
   class Application < Rails::Application
-    config.secret_key_base = 'test'
+    config.secret_key_base = "test"
+    config.paths["config/database"] = ["spec/support/database.yml"]
+    config.eager_load = false
   end
 end
+PaulRevere::Application.initialize!
 
 # Run migrations
-project_root = File.expand_path(File.join(File.dirname(__FILE__), '..'))
-require File.join project_root, 'lib', 'generators', 'paul_revere', 'templates', 'migration'
-
-ActiveRecord::Base.establish_connection(
-  :adapter  => "sqlite3",
-  :database => ":memory:"
-)
-
-if Rails::VERSION::MAJOR < 4
-  ActiveSupport.on_load(:active_record) do
-    attr_accessible(nil)
-  end
-end
-
+require_relative "../lib/generators/paul_revere/templates/migration"
 CreateAnnouncements.suppress_messages { CreateAnnouncements.up }

data/spec/helpers/announcements_helper_spec.rb

@@ -1,8 +1,5 @@
 require 'rails_helper'
 
-require File.join(File.dirname(__FILE__), '..', '..', 'app', 'helpers', 'announcements_helper')
-require File.join(File.dirname(__FILE__), '..', '..', 'app', 'models', 'announcement')
-
 describe AnnouncementsHelper do
 
   it "should return the current announcement when sent current_announcement and cache doesn't exist" do

data/spec/lib/generators/paul_revere/paul_revere_generator_spec.rb

@@ -22,15 +22,6 @@ describe PaulRevereGenerator, type: :generator do
           end
         end
       end
-      if ::Rails.version < '3.1'
-        directory "public" do
-          directory "javascripts" do
-            file "announcements.js" do
-              contains "hideAnnouncement"
-            end
-          end
-        end
-      end
     }
   end
 

data/spec/models/announcement_spec.rb

@@ -1,7 +1,5 @@
 require 'rails_helper'
 
-require File.join(File.dirname(__FILE__), '..', '..', 'app', 'models', 'announcement')
-
 describe Announcement do
   it "should return the latest announcement when there are several" do
     old = create_announcement(:body => 'no fun', :created_at => 2.days.ago)

data/spec/rails_helper.rb

@@ -12,6 +12,7 @@ require "fake_app"
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
+  config.include Rails.application.routes.url_helpers
   config.infer_spec_type_from_file_location!
   config.before(:each) do
     Announcement.delete_all

data/spec/support/database.yml

@@ -0,0 +1,3 @@
+test:
+  adapter: sqlite3
+  database: ":memory:"

data/spec/views/announcements/_announcement.html.erb_spec.rb

@@ -0,0 +1,29 @@
+require "rails_helper"
+
+class User; end
+
+module ApplicationHelper
+  def current_user
+    raise
+  end
+end
+
+describe "announcements/_announcement" do
+  before(:example) do
+    stub_template "announcements/_announcement_for_all.html.erb" => "Partial"
+  end
+
+  it "renders the all partial when there is a user" do
+    allow(view).to receive(:current_user).and_return(User.new)
+    render
+
+    expect(rendered).to match /Partial/
+  end
+
+  it "does not render the all partial when there is not a user" do
+    allow(view).to receive(:current_user).and_return(nil)
+    render
+
+    expect(rendered).to eq "\n"
+  end
+end

data/spec/views/announcements/_announcement_for_all.html.erb_spec.rb

@@ -0,0 +1,26 @@
+require "rails_helper"
+
+describe "announcements/_announcement_for_all" do
+  it "renders nothing when announcement does not exist" do
+    expect(Announcement.count).to eq 0
+    render
+
+    expect(rendered).to eq ""
+  end
+
+  it "renders nothing when an Announcement exists but is hidden" do
+    Announcement.create!(body: "Test")
+    allow(view).to receive(:announcement_hidden?).and_return(true)
+    render
+
+    expect(rendered).to eq ""
+  end
+
+  it "renders the announcement when an Announcement exists and is not hidden" do
+    announcement = Announcement.create!(body: "Test")
+    render
+
+    expect(rendered).to match /Test/
+    expect(rendered).to match /announcement_#{announcement.created_at.iso8601}/
+  end
+end

data/spec/views/announcements/_email_announcement.erb_spec.rb

@@ -0,0 +1,10 @@
+require "rails_helper"
+
+describe "announcements/_email_announcement" do
+  it "renders without error" do
+    Announcement.create!(body: "Test")
+    render
+
+    expect(rendered).to match /Test/
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paul_revere
 version: !ruby/object:Gem::Version
-  version: '1.3'
+  version: '1.4'
 platform: ruby
 authors:
 - Nick Quaranto
@@ -14,92 +14,78 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-17 00:00:00.000000000 Z
+date: 2015-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: generator_spec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 description: Paul Revere provides a model and helper methods to do one-off style announcements.
 email: support@thoughtbot.com
 executables: []
@@ -122,11 +108,9 @@ files:
 - app/views/announcements/_announcement.html.erb
 - app/views/announcements/_announcement_for_all.html.erb
 - app/views/announcements/_email_announcement.erb
-- gemfiles/rails_3.0.gemfile
-- gemfiles/rails_3.1.gemfile
-- gemfiles/rails_3.2.gemfile
-- gemfiles/rails_4.0.gemfile
-- gemfiles/rails_4.1.gemfile
+- gemfiles/rails_4.0.0.gemfile
+- gemfiles/rails_4.1.0.gemfile
+- gemfiles/rails_4.2.0.gemfile
 - lib/generators/paul_revere/USAGE
 - lib/generators/paul_revere/paul_revere_generator.rb
 - lib/generators/paul_revere/templates/migration.rb
@@ -141,8 +125,13 @@ files:
 - spec/paul_revere_spec.rb
 - spec/rails_helper.rb
 - spec/spec_helper.rb
+- spec/support/database.yml
+- spec/views/announcements/_announcement.html.erb_spec.rb
+- spec/views/announcements/_announcement_for_all.html.erb_spec.rb
+- spec/views/announcements/_email_announcement.erb_spec.rb
 homepage: https://github.com/thoughtbot/paul_revere
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -160,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Simple announcement plugin to include `one off` style announcements in Rails
@@ -173,3 +162,7 @@ test_files:
 - spec/paul_revere_spec.rb
 - spec/rails_helper.rb
 - spec/spec_helper.rb
+- spec/support/database.yml
+- spec/views/announcements/_announcement.html.erb_spec.rb
+- spec/views/announcements/_announcement_for_all.html.erb_spec.rb
+- spec/views/announcements/_email_announcement.erb_spec.rb

data/gemfiles/rails_4.0.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "~> 4.0"
-
-gemspec :path => "../"

data/gemfiles/rails_4.1.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "~> 4.1"
-
-gemspec :path => "../"