paul_revere 1.0 → 1.1

data/Appraisals

@@ -1,4 +1,4 @@
-['3.2.3', '3.1.4', '3.0.12'].each do |rails_version|
+['3.2.6', '3.1.6', '3.0.15'].each do |rails_version|
   appraise "rails-#{rails_version}" do
     gem "rails", rails_version
   end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    paul_revere (1.0)
+    paul_revere (1.1)
       rails (~> 3.0)
 
 GEM
@@ -50,7 +50,7 @@ GEM
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.18)
+    mime-types (1.19)
     mocha (0.9.12)
     multi_json (1.0.3)
     polyglot (0.3.3)

data/NEWS.md

@@ -1,3 +1,9 @@
+New in 1.1:
+
+* Support for the asset pipeline.
+* More clear installation instructions for both newer and older Rails.
+* The Announcement body is attr_accessible.
+
 New in 1.0:
 
 * Support for Rails 3.2.3, 3.1.4, and 3.0.12.

data/README.md

@@ -6,17 +6,44 @@ Paul Revere
 
 Simple announcement plugin to include "one off" style announcements in Rails web apps.
 
-Install
--------
+Install with the asset pipeline (Rails 3.1+, asset pipeline enabled)
+--------------------------------------------------------------------
 
 Install as normal in your Gemfile:
 
     gem 'paul_revere'
 
-Run the generator to create the migration and copy the javascript file into public:
+Run the generator to create the migration:
 
     rails generate paul_revere
 
+Add the announcement JS to `app/assets/javascripts/application.js`:
+
+    //= require announcements
+
+Run the migration:
+
+    rake db:migrate && rake db:migrate:redo
+
+Install without the asset pipeline (Rails 3.0 or asset pipeline disabled)
+---------------------------------------------------------------------------
+
+Install as normal in your Gemfile:
+
+    gem 'paul_revere'
+
+Run the generator to create the migration and copy the JavaScript file into public:
+
+    rails generate paul_revere
+
+Add the announcement JS to your layout, such as `app/views/layouts/application.html.erb`:
+
+    <%= javascript_include_tag 'announcements' %>
+
+Run the migration:
+
+    rake db:migrate && rake db:migrate:redo
+
 Usage
 -----
 
@@ -31,9 +58,13 @@ Paul Revere provides...
 So the flow would be...
 
 * Install the gem
-* Add `helper :announcements` either to application_controller.rb or to the specific controllers where you want to make the announcement helpers available
-* Use those partials in the correct places in your view code and mailer view code where you want announcements to show up
-* When you want to make an announcement, use the rails console to create a new Announcement record
+* Use those partials in the correct places in your view code and mailer view code where you want announcements to show up:
+
+    <%= render 'announcements/announcement_for_all' %>
+
+* When you want to make an announcement, use the Rails console to create a new `Announcement` record:
+
+    Announcement.create!(body: 'This Web site is shutting down because you refuse to pay')
 
 Beastie Boys Lyrics
 -------------------
@@ -104,7 +135,6 @@ His boy had beef and he got dropped
 Mike D. grabbed the money M.C.A. snatched the gold  
 I grabbed two girlies and a beer that's cold.
 
-
 Credits
 -------
 

data/app/models/announcement.rb

@@ -1,4 +1,6 @@
 class Announcement < ActiveRecord::Base
+  attr_accessible :body
+
   def self.current
     first(:order => 'created_at DESC') || new
   end

data/gemfiles/{3.0.12.gemfile → rails-3.0.15.gemfile}

@@ -2,6 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "rails", "3.0.12"
+gem "rails", "3.0.15"
 
 gemspec :path=>"../"

data/gemfiles/{rails-3.2.3.gemfile → rails-3.1.6.gemfile}

@@ -2,6 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "rails", "3.2.3"
+gem "rails", "3.1.6"
 
 gemspec :path=>"../"

data/gemfiles/{rails-3.1.4.gemfile → rails-3.2.6.gemfile}

@@ -2,6 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "rails", "3.1.4"
+gem "rails", "3.2.6"
 
 gemspec :path=>"../"

data/lib/generators/paul_revere/paul_revere_generator.rb

@@ -4,11 +4,29 @@ class PaulRevereGenerator < Rails::Generators::Base
   include Rails::Generators::Migration
   extend ActiveRecord::Generators::Migration
 
-  desc "Put the javascript and migration in place"
+  desc "Put the JavaScript and migration in place"
   source_root File.join(File.dirname(__FILE__), "templates")
 
   def install
-    copy_file "announcements.js", "public/javascripts/announcements.js"
+    copy_javascript if needs_js_copied?
     migration_template "migration.rb", "db/migrate/create_announcements.rb"
   end
+
+  private
+
+  def copy_javascript
+    copy_file File.join(javascript_path, 'announcements.js'), js_destination
+  end
+
+  def javascript_path
+    File.join(%w(.. .. .. .. app assets javascripts))
+  end
+
+  def needs_js_copied?
+    ::Rails.version < '3.1' || !::Rails.application.config.assets.enabled
+  end
+
+  def js_destination
+    'public/javascripts/announcements.js'
+  end
 end

data/lib/paul_revere/version.rb

@@ -1,3 +1,3 @@
 module PaulRevere
-  VERSION = '1.0'.freeze
+  VERSION = '1.1'.freeze
 end

data/spec/fake_app.rb

@@ -13,4 +13,8 @@ ActiveRecord::Base.establish_connection(
   :database => ":memory:"
 )
 
+ActiveSupport.on_load(:active_record) do
+  attr_accessible(nil)
+end
+
 CreateAnnouncements.suppress_messages { CreateAnnouncements.up }

data/spec/models/announcement_spec.rb

@@ -4,19 +4,32 @@ require File.join(File.dirname(__FILE__), '..', '..', 'app', 'models', 'announce
 
 describe Announcement do
   it "should return the latest announcement when there are several" do
-    old = Announcement.create!(:body => 'no fun', :created_at => 2.days.ago)
-    latest = Announcement.create!(:body => 'fun', :created_at => 1.day.ago)
-    older = Announcement.create!(:body => 'less fun', :created_at => 3.days.ago)
+    old = create_announcement(:body => 'no fun', :created_at => 2.days.ago)
+    latest = create_announcement(:body => 'fun', :created_at => 1.day.ago)
+    older = create_announcement(:body => 'less fun', :created_at => 3.days.ago)
 
     Announcement.current.should == latest
   end
 
   it "should return an existent announcement where there is no announcement" do
-    Announcement.create!(:body => 'body')
+    create_announcement(:body => 'body')
     Announcement.current.exists?.should == true
   end
 
   it "should return a non-existent announcement where there is no announcement" do
     Announcement.current.exists?.should be_false
   end
+
+  it 'can always assign straight to the body' do
+    Announcement.create!(:body => 'hello').body.should == 'hello'
+  end
+
+  def create_announcement(attributes)
+    announcement = Announcement.new
+    attributes.each do |key, value|
+      announcement.send("#{key}=", value)
+    end
+    announcement.save!
+    announcement
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paul_revere
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: '1.1'
   prerelease: 
 platform: ruby
 authors:
@@ -15,11 +15,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-11 00:00:00.000000000Z
+date: 2012-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &22372400 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -27,10 +27,15 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *22372400
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &22371980 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -38,10 +43,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *22371980
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &22371520 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -49,10 +59,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *22371520
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &22371100 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -60,10 +75,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *22371100
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &22370680 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -71,10 +91,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *22370680
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
-  requirement: &22370260 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -82,7 +107,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *22370260
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Paul Revere provides a model and helper methods to do one-off style announcements.
 email: support@thoughtbot.com
 executables: []
@@ -98,21 +128,18 @@ files:
 - NEWS.md
 - README.md
 - Rakefile
+- app/assets/javascripts/announcements.js
 - app/helpers/announcements_helper.rb
 - app/models/announcement.rb
 - app/views/announcements/_announcement.html.erb
 - app/views/announcements/_announcement_for_all.html.erb
 - app/views/announcements/_email_announcement.erb
-- gemfiles/3.0.12.gemfile
-- gemfiles/3.1.4.gemfile
-- gemfiles/3.2.3.gemfile
-- gemfiles/rails-3.0.12.gemfile
-- gemfiles/rails-3.1.4.gemfile
-- gemfiles/rails-3.2.3.gemfile
+- gemfiles/rails-3.0.15.gemfile
+- gemfiles/rails-3.1.6.gemfile
+- gemfiles/rails-3.2.6.gemfile
 - init.rb
 - lib/generators/paul_revere/USAGE
 - lib/generators/paul_revere/paul_revere_generator.rb
-- lib/generators/paul_revere/templates/announcements.js
 - lib/generators/paul_revere/templates/migration.rb
 - lib/paul_revere.rb
 - lib/paul_revere/version.rb
@@ -137,7 +164,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3043656868834385100
+      hash: -1368084792273439523
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -146,10 +173,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3043656868834385100
+      hash: -1368084792273439523
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Simple announcement plugin to include 'one off' style announcements in Rails

data/gemfiles/3.1.4.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "3.1.4"
-gem "sass-rails"
-gem "coffee-script"
-gem "uglifier"
-gem "jquery-rails"
-
-gemspec :path=>"../"

data/gemfiles/3.2.3.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "3.2.3"
-
-gemspec :path=>"../"

data/gemfiles/rails-3.0.12.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "3.0.12"
-
-gemspec :path=>"../"